redmine_airbrake_backend 0.3.2 → 0.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8185afe3bc7ac030e618be306c9be7880c0ffa21
-  data.tar.gz: 07c55aff9ccea9736ee713a4a163c705f2abd2ba
+  metadata.gz: 618ee3d3d8ec581efd20a70331dcf0c95fc35f07
+  data.tar.gz: 387de8062df6128c399eb18431bf66b2c610ee39
 SHA512:
-  metadata.gz: 3c137cba430f392e3f5253538027e7bf83702b1e6692f97f60f6d4c1f6a8c436ccd7fd94f1e5ff204cc8ce287bc5175f99a9fbda5f358d26efda2d7594ecfa14
-  data.tar.gz: ee61e400218e713a558989a22127c43fb06f7730d4164be7612c793bdbab4106aa359ab5f3f5e655e802dd7b79e1ba1b40fdba305f4f831cbb12aae3be27ab4b
+  metadata.gz: e234cb1fd3984a9dc85465466efc9cc806572b8dbce306531e59825b4e97e5aaf63469844ada49c584ff4da1a5870472f4bc67221c5efaf665b9a0658301a318
+  data.tar.gz: f4e8f815ad22df7e3060df447af795c6d20619ac96c8f48a653d32403cdd4909ade75b26c80251f62daabfa5465e0686608fca8d820a5f53a932b11ebaf12c88

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    redmine_airbrake_backend (0.3.2)
+    redmine_airbrake_backend (0.3.3)
       hpricot
       htmlentities
       rails
@@ -34,7 +34,7 @@ GEM
       thread_safe (~> 0.1)
       tzinfo (~> 0.3.37)
     arel (4.0.0)
-    atomic (1.1.13)
+    atomic (1.1.14)
     builder (3.1.4)
     erubis (2.7.0)
     hike (1.2.3)
@@ -46,7 +46,7 @@ GEM
       treetop (~> 1.4.8)
     mime-types (1.25)
     minitest (4.7.5)
-    multi_json (1.7.9)
+    multi_json (1.8.0)
     polyglot (0.3.3)
     rack (1.5.2)
     rack-test (0.6.2)
@@ -75,7 +75,7 @@ GEM
       activesupport (>= 3.0)
       sprockets (~> 2.8)
     thor (0.18.1)
-    thread_safe (0.1.2)
+    thread_safe (0.1.3)
       atomic
     tilt (1.4.1)
     treetop (1.4.15)

data/app/models/airbrake_project_setting.rb

@@ -1,17 +1,12 @@
+require 'redmine/safe_attributes'
+
 class AirbrakeProjectSetting < ActiveRecord::Base
   include Redmine::SafeAttributes
 
   belongs_to :project
-  Project.has_one :airbrake_settings, class_name: AirbrakeProjectSetting.name, dependent: :destroy
-
   belongs_to :tracker
-  Tracker.has_many :airbrake_project_settings, dependent: :nullify
-
   belongs_to :category, class_name: IssueCategory.name
-  IssueCategory.has_many :airbrake_project_settings, dependent: :nullify
-
   belongs_to :priority, class_name: IssuePriority.name
-  IssuePriority.has_many :airbrake_project_settings, dependent: :nullify
 
   validates_presence_of :project_id
 

data/lib/redmine_airbrake_backend.rb

@@ -1,4 +1,9 @@
 require 'redmine_airbrake_backend/engine'
 
 module RedmineAirbrakeBackend
+
+  def self.directory
+    File.expand_path(File.join(File.dirname(__FILE__), '..'))
+  end
+
 end

data/lib/redmine_airbrake_backend/engine.rb

@@ -2,16 +2,33 @@ require 'redmine_airbrake_backend/version'
 
 module RedmineAirbrakeBackend
   class Engine < ::Rails::Engine
-    initializer 'redmine_airbrake_backend.register_redmine_plugin', after: :load_config_initializers do |app|
-      register_plugin
+    initializer 'redmine_airbrake_backend.register_redmine_plugin', after: 'load_config_initializers' do |app|
+      register_redmine_plugin
+    end
+
+    initializer 'redmine_airbrake_backend.apply_patches', after: 'redmine_airbrake_backend.register_redmine_plugin' do |app|
+      ActionDispatch::Callbacks.to_prepare do
+        require_dependency 'redmine_airbrake_backend/patches/project'
+        require_dependency 'redmine_airbrake_backend/patches/tracker'
+        require_dependency 'redmine_airbrake_backend/patches/issue_category'
+        require_dependency 'redmine_airbrake_backend/patches/issue_priority'
+        require_dependency 'redmine_airbrake_backend/patches/projects_helper'
+
+        RedmineAirbrakeBackend::Engine.apply_patch(Project, RedmineAirbrakeBackend::Patches::Project)
+        RedmineAirbrakeBackend::Engine.apply_patch(Tracker, RedmineAirbrakeBackend::Patches::Tracker)
+        RedmineAirbrakeBackend::Engine.apply_patch(IssueCategory, RedmineAirbrakeBackend::Patches::IssueCategory)
+        RedmineAirbrakeBackend::Engine.apply_patch(IssuePriority, RedmineAirbrakeBackend::Patches::IssuePriority)
+        RedmineAirbrakeBackend::Engine.apply_patch(ProjectsHelper, RedmineAirbrakeBackend::Patches::ProjectsHelper)
+      end
+    end
 
-      require_dependency 'airbrake_project_setting'
-      require_dependency 'redmine_airbrake_backend/project_helper_patch'
+    def apply_patch(clazz, patch)
+      clazz.send(:include, patch) unless clazz.included_modules.include?(patch)
     end
 
     private
 
-    def register_plugin
+    def register_redmine_plugin
       Redmine::Plugin.register :redmine_airbrake_backend do
         name 'Airbrake Backend'
         author 'Florian Schwab'
@@ -20,7 +37,7 @@ module RedmineAirbrakeBackend
         url 'https://github.com/ydkn/redmine_airbrake_backend'
         version ::RedmineAirbrakeBackend::VERSION
         requires_redmine :version_or_higher => '2.3.2'
-        directory File.expand_path(File.join(File.dirname(__FILE__), '..', '..'))
+        directory RedmineAirbrakeBackend.directory
 
         project_module :airbrake do
           permission :manage_airbrake, {airbrake: [:update]}

data/lib/redmine_airbrake_backend/notice.rb

@@ -25,16 +25,16 @@ module RedmineAirbrakeBackend
       doc = Hpricot::XML(xml_data)
 
       raise NoticeInvalid if (notice = doc.at('notice')).blank?
-      raise NoticeInvalid if (version = notice.attributes['version']).blank?
-      raise UnsupportedVersion unless SUPPORTED_API_VERSIONS.include?(version)
+      raise NoticeInvalid.new('no version') if (version = notice.attributes['version']).blank?
+      raise UnsupportedVersion.new(version) unless SUPPORTED_API_VERSIONS.include?(version)
 
       params = JSON.parse(notice.at('api-key').inner_text).symbolize_keys rescue nil
-      raise NoticeInvalid if params.blank?
+      raise NoticeInvalid.new('no or invalid api-key') if params.blank?
 
-      raise NoticeInvalid if (notifier = convert_element(notice.at('notifier'))).blank?
+      raise NoticeInvalid.new('no notifier') if (notifier = convert_element(notice.at('notifier'))).blank?
 
-      raise NoticeInvalid if (error = convert_element(notice.at('error'))).blank?
-      raise NoticeInvalid if error[:message].blank?
+      raise NoticeInvalid.new('no error') if (error = convert_element(notice.at('error'))).blank?
+      raise NoticeInvalid.new('no message') if error[:message].blank?
 
       error[:backtrace] = format_backtrace(error[:backtrace])
 

data/lib/redmine_airbrake_backend/patches/issue_category.rb

@@ -0,0 +1,11 @@
+require 'active_support/concern'
+
+module RedmineAirbrakeBackend::Patches
+  module IssueCategory
+    extend ActiveSupport::Concern
+
+    included do
+      has_many :airbrake_project_settings, dependent: :nullify
+    end
+  end
+end

data/lib/redmine_airbrake_backend/patches/issue_priority.rb

@@ -0,0 +1,11 @@
+require 'active_support/concern'
+
+module RedmineAirbrakeBackend::Patches
+  module IssuePriority
+    extend ActiveSupport::Concern
+
+    included do
+      has_many :airbrake_project_settings, dependent: :nullify
+    end
+  end
+end

data/lib/redmine_airbrake_backend/patches/project.rb

@@ -0,0 +1,11 @@
+require 'active_support/concern'
+
+module RedmineAirbrakeBackend::Patches
+  module Project
+    extend ActiveSupport::Concern
+
+    included do
+      has_one :airbrake_settings, class_name: AirbrakeProjectSetting.name, dependent: :destroy
+    end
+  end
+end

data/lib/redmine_airbrake_backend/patches/projects_helper.rb

@@ -0,0 +1,24 @@
+require 'active_support/concern'
+
+module RedmineAirbrakeBackend::Patches
+  module ProjectsHelper
+    extend ActiveSupport::Concern
+
+    included do
+      alias_method_chain :project_settings_tabs, :airbrake_backend_tab
+    end
+
+    def project_settings_tabs_with_airbrake_backend_tab
+      tabs = project_settings_tabs_without_airbrake_backend_tab
+
+      tabs.push({
+          :name => 'airbrake',
+          :action => :manage_airbrake,
+          :partial => 'projects/settings/airbrake',
+          :label => :project_module_airbrake
+        })
+
+      tabs.select{|tab| User.current.allowed_to?(tab[:action], @project)}
+    end
+  end
+end

data/lib/redmine_airbrake_backend/patches/tracker.rb

@@ -0,0 +1,11 @@
+require 'active_support/concern'
+
+module RedmineAirbrakeBackend::Patches
+  module Tracker
+    extend ActiveSupport::Concern
+
+    included do
+      has_many :airbrake_project_settings, dependent: :nullify
+    end
+  end
+end

data/lib/redmine_airbrake_backend/version.rb

@@ -1,3 +1,3 @@
 module RedmineAirbrakeBackend
-  VERSION = '0.3.2'
+  VERSION = '0.3.3'
 end

data/lib/tasks/test.rake

@@ -0,0 +1,33 @@
+namespace :redmine do
+  namespace :airbrake_backend do
+    desc 'Runs the plugin tests.'
+    task :test do
+      Rake::Task["redmine:airbrake_backend:test:units"].invoke
+      Rake::Task["redmine:airbrake_backend:test:functionals"].invoke
+      Rake::Task["redmine:airbrake_backend:test:integration"].invoke
+    end
+
+    namespace :test do
+      desc 'Runs the plugin unit tests.'
+      Rake::TestTask.new :units => "db:test:prepare" do |t|
+        t.libs << "test"
+        t.verbose = true
+        t.pattern = "#{RedmineAirbrakeBackend.directory}/test/unit/**/*_test.rb"
+      end
+
+      desc 'Runs the plugin functional tests.'
+      Rake::TestTask.new :functionals => "db:test:prepare" do |t|
+        t.libs << "test"
+        t.verbose = true
+        t.pattern = "#{RedmineAirbrakeBackend.directory}/test/functional/**/*_test.rb"
+      end
+
+      desc 'Runs the plugin integration tests.'
+      Rake::TestTask.new :integration => "db:test:prepare" do |t|
+        t.libs << "test"
+        t.verbose = true
+        t.pattern = "#{RedmineAirbrakeBackend.directory}/test/integration/**/*_test.rb"
+      end
+    end
+  end
+end

data/test/test_helper.rb

@@ -0,0 +1 @@
+require File.expand_path('./test/test_helper')

data/test/unit/notice_test.rb

@@ -0,0 +1,54 @@
+require File.expand_path('../../test_helper', __FILE__)
+
+class NoticeTest < ActiveSupport::TestCase
+
+  test 'parse' do
+    api_key = {
+      api_key: 'foobar',
+      project: 'foo'
+    }.to_json
+    xml_data = <<-EOS
+      <?xml version="1.0" encoding="UTF-8"?>
+      <notice version="2.4">
+        <api-key>#{api_key}</api-key>
+        <notifier>
+          <name>Airbrake Notifier</name>
+          <version>3.1.6</version>
+          <url>http://api.airbrake.io</url>
+        </notifier>
+        <error>
+          <class>RuntimeError</class>
+          <message>RuntimeError: I've made a huge mistake</message>
+          <backtrace>
+            <line method="public" file="/testapp/app/models/user.rb" number="53"/>
+            <line method="index" file="/testapp/app/controllers/users_controller.rb" number="14"/>
+          </backtrace>
+        </error>
+        <request>
+          <url>http://example.com</url>
+          <component/>
+          <action/>
+          <cgi-data>
+            <var key="SERVER_NAME">example.org</var>
+            <var key="HTTP_USER_AGENT">Mozilla</var>
+          </cgi-data>
+        </request>
+        <server-environment>
+          <project-root>/testapp</project-root>
+          <environment-name>production</environment-name>
+          <app-version>1.0.0</app-version>
+        </server-environment>
+      </notice>
+    EOS
+
+    notice = RedmineAirbrakeBackend::Notice.parse(prepare_xml(xml_data))
+    assert notice
+  end
+
+  private
+
+  def prepare_xml(xml_data)
+    xml_data.split("\n").map{|l| l.strip}.join('')
+  end
+
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: redmine_airbrake_backend
 version: !ruby/object:Gem::Version
-  version: 0.3.2
+  version: 0.3.3
 platform: ruby
 authors:
 - Florian Schwab
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-09-05 00:00:00.000000000 Z
+date: 2013-09-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -108,9 +108,16 @@ files:
 - lib/redmine_airbrake_backend.rb
 - lib/redmine_airbrake_backend/engine.rb
 - lib/redmine_airbrake_backend/notice.rb
-- lib/redmine_airbrake_backend/project_helper_patch.rb
+- lib/redmine_airbrake_backend/patches/issue_category.rb
+- lib/redmine_airbrake_backend/patches/issue_priority.rb
+- lib/redmine_airbrake_backend/patches/project.rb
+- lib/redmine_airbrake_backend/patches/projects_helper.rb
+- lib/redmine_airbrake_backend/patches/tracker.rb
 - lib/redmine_airbrake_backend/version.rb
+- lib/tasks/test.rake
 - redmine_airbrake_backend.gemspec
+- test/test_helper.rb
+- test/unit/notice_test.rb
 homepage: https://github.com/ydkn/redmine_airbrake_backend
 licenses:
 - MIT
@@ -135,4 +142,6 @@ rubygems_version: 2.0.3
 signing_key: 
 specification_version: 4
 summary: This plugin provides the necessary API to use Redmine as a Airbrake backend
-test_files: []
+test_files:
+- test/test_helper.rb
+- test/unit/notice_test.rb

data/lib/redmine_airbrake_backend/project_helper_patch.rb

@@ -1,16 +0,0 @@
-::ProjectsHelper.module_eval %Q{
-  alias_method :project_settings_tabs_original_airbrake, :project_settings_tabs
-
-  def project_settings_tabs
-    tabs = project_settings_tabs_original_airbrake
-
-    tabs.push({
-        :name => 'airbrake',
-        :action => :manage_airbrake,
-        :partial => 'projects/settings/airbrake',
-        :label => :project_module_airbrake
-      })
-
-    tabs.select{|tab| User.current.allowed_to?(tab[:action], @project)}
-  end
-}