redlock 1.3.0 → 1.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 91ee96071b53b7710c8268b7146c1c44f77a50b1b38267ccc9c088ad2ce8ca0c
-  data.tar.gz: 3d5adc81e331d1f971b440c14c9c8418257c7c499c8cc40a515dbc80c564dda5
+  metadata.gz: 7de9b6b9d70bce2578e474bdfe8dfa15c22bb57e0c876ac7127d826a5b6ba9b4
+  data.tar.gz: c294d219107aa4a8682ba4ff303e150497ea61b2dd4abb71d3cac15e78c218bd
 SHA512:
-  metadata.gz: 5753c8c53fee8599cf22869200bed307d27eff4c0aeb8e5235e96dfd46fe201283cb122d9298f7cc113396a5fa141ecb6d69f2f90bb80a4e0aff4bd1ae89fa50
-  data.tar.gz: 2fe0eb860c936c84bf37e3f77a6e8f3b83d003e30121c964d2a1a816894b48a3ce69c874982bb8973d626cab95f508a752da157def815e69133cf0a17c57dc63
+  metadata.gz: b0eeead2b1307f12487603d72a7a5e00d6aba1d697a5327ac484a4fa4cc00575e0fcedd43a38aa34ee93da7322550630ad3cec158a5ef0fcf98849033c90ec85
+  data.tar.gz: 712d3c40ab8c4278f4649f373bfcb6ca4eeb2361461a48ad42d17f44a9d1becba460b82ed99f6b035232698267ad5046831230960b47171d9fa09d9ba0d4b692

data/Gemfile.lock

@@ -1,13 +1,13 @@
 PATH
   remote: .
   specs:
-    redlock (1.2.2)
+    redlock (1.3.2)
       redis (>= 3.0.0, < 6.0)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    connection_pool (2.2.5)
+    connection_pool (2.3.0)
     coveralls (0.8.23)
       json (>= 1.8, < 3)
       simplecov (~> 0.16.1)
@@ -18,9 +18,9 @@ GEM
     docile (1.4.0)
     json (2.3.1)
     rake (13.0.6)
-    redis (5.0.1)
-      redis-client (~> 0.7)
-    redis-client (0.7.1)
+    redis (5.0.5)
+      redis-client (>= 0.9.0)
+    redis-client (0.10.0)
       connection_pool
     rspec (3.11.0)
       rspec-core (~> 3.11.0)
@@ -28,13 +28,13 @@ GEM
       rspec-mocks (~> 3.11.0)
     rspec-core (3.11.0)
       rspec-support (~> 3.11.0)
-    rspec-expectations (3.11.0)
+    rspec-expectations (3.11.1)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.11.0)
     rspec-mocks (3.11.1)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.11.0)
-    rspec-support (3.11.0)
+    rspec-support (3.11.1)
     simplecov (0.16.1)
       docile (~> 1.1)
       json (>= 1.8, < 3)

data/lib/redlock/client.rb

@@ -170,8 +170,6 @@ module Redlock
         recover_from_script_flush do
           @redis.with { |conn| conn.evalsha Scripts::LOCK_SCRIPT_SHA, keys: [resource], argv: [val, ttl, allow_new_lock] }
         end
-      rescue Redis::BaseConnectionError
-        false
       end
 
       def unlock(resource, val)

data/lib/redlock/version.rb

@@ -1,3 +1,3 @@
 module Redlock
-  VERSION = '1.3.0'
+  VERSION = '1.3.2'
 end

data/spec/client_spec.rb

@@ -242,14 +242,14 @@ RSpec.describe Redlock::Client do
     end
 
     context 'when a server goes away' do
-      it 'does not raise an error on connection issues' do
-        # We re-route the lock manager to a (hopefully) non-existent Redis URL.
+      it 'raises an error on connection issues' do
+        # Set lock manager to a (hopefully) non-existent Redis URL to test error
         redis_instance = lock_manager.instance_variable_get(:@servers).first
         redis_instance.instance_variable_set(:@redis, unreachable_redis)
 
         expect {
-          expect(lock_manager.lock(resource_key, ttl)).to be_falsey
-        }.to_not raise_error
+          lock_manager.lock(resource_key, ttl)
+        }.to raise_error(Redis::CannotConnectError)
       end
     end
 
@@ -259,7 +259,9 @@ RSpec.describe Redlock::Client do
         redis_instance = lock_manager.instance_variable_get(:@servers).first
         old_redis = redis_instance.instance_variable_get(:@redis)
         redis_instance.instance_variable_set(:@redis, unreachable_redis)
-        expect(lock_manager.lock(resource_key, ttl)).to be_falsey
+        expect {
+          lock_manager.lock(resource_key, ttl)
+        }.to raise_error(Redis::CannotConnectError)
         redis_instance.instance_variable_set(:@redis, old_redis)
         expect(lock_manager.lock(resource_key, ttl)).to be_truthy
       end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: redlock
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.3.2
 platform: ruby
 authors:
 - Leandro Moreira
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-09-05 00:00:00.000000000 Z
+date: 2022-10-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: redis