redis_voteable 0.1.0 → 0.1.1

data/lib/redis_voteable/version.rb

@@ -1,3 +1,3 @@
 module RedisVoteable
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end

data/lib/redis_voteable/voteable.rb

@@ -38,12 +38,12 @@ module RedisVoteable
       end
       
       def up_percentage
-        return (up_votes.to_f * 100 / total_votes) unless votes == 0
+        return (up_votes.to_f * 100 / total_votes) unless total_votes == 0
         nil
       end
       
       def down_percentage
-        return (down_votes.to_f * 100 / total_votes) unless votes == 0
+        return (down_votes.to_f * 100 / total_votes) unless total_votes == 0
         nil
       end
       

data/lib/redis_voteable/voter.rb

@@ -113,17 +113,17 @@ module RedisVoteable
       end
       
       # Return the total number of votes a voter has cast.
-      def vote_count()
-        up_vote_count + down_vote_count
+      def total_votes()
+        up_votes + down_votes
       end
       
       # Returns the number of upvotes a voter has cast.
-      def up_vote_count()
+      def up_votes()
         redis.scard prefixed("#{class_key(self)}:#{UP_VOTES}")
       end
       
       # Returns the number of downvotes a voter has cast.
-      def down_vote_count()
+      def down_votes()
         redis.scard prefixed("#{class_key(self)}:#{DOWN_VOTES}")
       end
       

data/redis_voteable.gemspec

@@ -20,7 +20,7 @@ Gem::Specification.new do |s|
   
   # Dependencies
   s.add_dependency "redis", "~> 2.2.0"
-  s.add_dependency "activesupport"
+  s.add_dependency "activesupport", ">= 3.0.0"
   
   # For development only
   s.add_development_dependency "activerecord", "~> 3.0.0"

data/spec/lib/redis_voteable_spec.rb

@@ -37,9 +37,9 @@ describe "Redis Voteable" do
   end
 
   it "voter should have up vote votings" do
-    @voter.up_vote_count == 0
+    @voter.up_votes == 0
     @voter.up_vote(@voteable)
-    @voter.up_vote_count == 1
+    @voter.up_votes == 1
     @voter.votings[0].should == @voteable
   end
 
@@ -52,12 +52,38 @@ describe "Redis Voteable" do
   end
 
   it "voter should have down vote votings" do
-    @voter.down_vote_count.should == 0
+    @voter.down_votes.should == 0
     @voter.down_vote(@voteable)
-    @voter.down_vote_count.should == 1
+    @voter.down_votes.should == 1
     @voter.votings[0].should == @voteable
   end
 
+  it "voteable should calculate correct percentages" do
+    @voter.up_vote(@voteable)
+    @voteable.up_percentage.should == 100.0
+    @voteable.down_percentage.should == 0.0
+    @voter2 = VoterModel.create(:name => "Voter 2")
+    @voter2.down_vote(@voteable)
+    @voteable.up_percentage.should == 50.0
+    @voteable.down_percentage.should == 50.0
+  end
+  
+  it "voteable should calculate lower Wilson confidence bound" do
+    @voter2 = VoterModel.create(:name => "Voter 2")
+    @voter3 = VoterModel.create(:name => "Voter 3")
+    @voter4 = VoterModel.create(:name => "Voter 4")
+    @voter.up_vote(@voteable)
+    score1 = @voteable.confidence
+    @voter2.down_vote(@voteable)
+    score2 = @voteable.confidence
+    @voter3.down_vote(@voteable)
+    score3 = @voteable.confidence
+    @voter3.up_vote(@voteable)
+    score4 = @voteable.confidence
+    @voter4.up_vote(@voteable)
+    score5 = @voteable.confidence
+  end
+
   describe "up vote" do
     it "should increase up votes of voteable by one" do
       @voteable.up_votes.should == 0
@@ -66,9 +92,9 @@ describe "Redis Voteable" do
     end
 
     it "should increase up votes of voter by one" do
-      @voter.up_vote_count.should == 0
+      @voter.up_votes.should == 0
       @voter.up_vote(@voteable)
-      @voter.up_vote_count.should == 1
+      @voter.up_votes.should == 1
     end
 
     it "should only allow a voter to up vote a voteable once" do
@@ -93,15 +119,15 @@ describe "Redis Voteable" do
       @voteable.up_votes.should == 0
       @voteable.down_votes.should == 1
       @voteable.tally.should == -1
-      @voter.up_vote_count.should == 0
-      @voter.down_vote_count.should == 1
+      @voter.up_votes.should == 0
+      @voter.down_votes.should == 1
       
       @voter.up_vote(@voteable)
       @voteable.up_votes.should == 1
       @voteable.down_votes.should == 0
       @voteable.tally.should == 1
-      @voter.up_vote_count.should == 1
-      @voter.down_vote_count.should == 0
+      @voter.up_votes.should == 1
+      @voter.down_votes.should == 0
     end
 
     it "should allow up votes from different voters" do
@@ -133,9 +159,9 @@ describe "Redis Voteable" do
     end
 
     it "should decrease down votes of voter by one" do
-      @voter.down_vote_count.should == 0
+      @voter.down_votes.should == 0
       @voter.down_vote(@voteable)
-      @voter.down_vote_count.should == 1
+      @voter.down_votes.should == 1
     end
 
     it "should only allow a voter to down vote a voteable once" do
@@ -160,15 +186,15 @@ describe "Redis Voteable" do
       @voteable.up_votes.should == 1
       @voteable.down_votes.should == 0
       @voteable.tally.should == 1
-      @voter.up_vote_count.should == 1
-      @voter.down_vote_count.should == 0
+      @voter.up_votes.should == 1
+      @voter.down_votes.should == 0
       
       @voter.down_vote(@voteable)
       @voteable.up_votes.should == 0
       @voteable.down_votes.should == 1
       @voteable.tally.should == -1
-      @voter.up_vote_count.should == 0
-      @voter.down_vote_count.should == 1
+      @voter.up_votes.should == 0
+      @voter.down_votes.should == 1
     end
 
     it "should allow down votes from different voters" do
@@ -196,10 +222,10 @@ describe "Redis Voteable" do
     it "should decrease the up votes if up voted before" do
       @voter.up_vote(@voteable)
       @voteable.up_votes.should == 1
-      @voter.up_vote_count.should == 1
+      @voter.up_votes.should == 1
       @voter.clear_vote(@voteable)
       @voteable.up_votes.should == 0
-      @voter.up_vote_count.should == 0
+      @voter.up_votes.should == 0
     end
 
     it "should raise an error if voter didn't vote for the voteable" do

data/spec/spec_helper.rb

@@ -34,7 +34,7 @@ RSpec.configure do |config|
 
   config.after(:each) do
     DatabaseCleaner.clean
-    #redis = Redis.new
-    #redis.flushdb
+    redis = Redis.new
+    redis.flushdb
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: redis_voteable
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
   prerelease: 
 platform: ruby
 authors:
@@ -13,7 +13,7 @@ date: 2011-09-30 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: redis
-  requirement: &70161134771100 !ruby/object:Gem::Requirement
+  requirement: &70115573519260 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -21,21 +21,21 @@ dependencies:
         version: 2.2.0
   type: :runtime
   prerelease: false
-  version_requirements: *70161134771100
+  version_requirements: *70115573519260
 - !ruby/object:Gem::Dependency
   name: activesupport
-  requirement: &70161134770360 !ruby/object:Gem::Requirement
+  requirement: &70115573518580 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 3.0.0
   type: :runtime
   prerelease: false
-  version_requirements: *70161134770360
+  version_requirements: *70115573518580
 - !ruby/object:Gem::Dependency
   name: activerecord
-  requirement: &70161134769280 !ruby/object:Gem::Requirement
+  requirement: &70115573517840 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -43,10 +43,10 @@ dependencies:
         version: 3.0.0
   type: :development
   prerelease: false
-  version_requirements: *70161134769280
+  version_requirements: *70115573517840
 - !ruby/object:Gem::Dependency
   name: sqlite3-ruby
-  requirement: &70161134768500 !ruby/object:Gem::Requirement
+  requirement: &70115573510500 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -54,10 +54,10 @@ dependencies:
         version: 1.3.0
   type: :development
   prerelease: false
-  version_requirements: *70161134768500
+  version_requirements: *70115573510500
 - !ruby/object:Gem::Dependency
   name: bundler
-  requirement: &70161134763980 !ruby/object:Gem::Requirement
+  requirement: &70115573509880 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -65,10 +65,10 @@ dependencies:
         version: 1.0.0
   type: :development
   prerelease: false
-  version_requirements: *70161134763980
+  version_requirements: *70115573509880
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &70161134763320 !ruby/object:Gem::Requirement
+  requirement: &70115573508880 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -76,10 +76,10 @@ dependencies:
         version: 2.0.0
   type: :development
   prerelease: false
-  version_requirements: *70161134763320
+  version_requirements: *70115573508880
 - !ruby/object:Gem::Dependency
   name: database_cleaner
-  requirement: &70161134762000 !ruby/object:Gem::Requirement
+  requirement: &70115573508360 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -87,7 +87,7 @@ dependencies:
         version: 0.6.7
   type: :development
   prerelease: false
-  version_requirements: *70161134762000
+  version_requirements: *70115573508360
 description: ! 'A Redis-backed voting extension for Rails applications. '
 email:
 - cbrauchli@gmail.com