redis_dashboard 0.1.4 → 0.1.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b7368d883f06fd1e645b36e38eda3265344e4e79
-  data.tar.gz: fd50890c3609ce804ff203eea14a0ebc85455572
+  metadata.gz: 77f7bba022a91fd2ecc4e3a04bc6e681941ae6e6
+  data.tar.gz: 9c8356bfc9dc1ed4f1c86f7d538062bfd0a3474e
 SHA512:
-  metadata.gz: 35aaf7042c058433465f2aa74615bec63c44d08e66906da4fef874522dd106bddea978ec68f24c779f15b88b6825667777b0d33ff058f81008e42f8d187a7415
-  data.tar.gz: f6a728c21d83ca3f6cb31fde65b49ae0da1371a2a0db0c1416e0db8522f77d66be6feecb769aaedcf022b364c300ec002eff992fd95a0b4b9be7c588bc94f1cf
+  metadata.gz: 519dcddb89f59ac645ab7f194cdc7f31564d40bf69879a4fda2d955a608ecf3a15d21307d046827c5a47e8cea57b047eb95e033a6bdf005d0822bdb6a0f69cbd
+  data.tar.gz: 46b0949f00f5dcf0cf192b44b3efd1ddd59fa78720f099a2eb469244ec746b3073018119f322ecba4ca412e445bf7dc6c223ef4badf9efd8135855cb10bf8767

data/lib/redis_dashboard/application.rb

@@ -3,6 +3,9 @@ require "redis"
 require "uri"
 
 class RedisDashboard::Application < Sinatra::Base
+  require "erubis"
+  set :erb, escape_html: true
+
   after { close_clients }
 
   get "/" do
@@ -74,8 +77,10 @@ class RedisDashboard::Application < Sinatra::Base
     end
 
     def compute_cache_hit_ratio(info)
-      if (total = info["keyspace_hits"].to_i + info["keyspace_misses"].to_i) > 0
-        info["keyspace_hits"].to_f * 100
+      hits = info["keyspace_hits"].to_i
+      misses = info["keyspace_misses"].to_i
+      if (total = hits + misses) > 0
+        hits * 100.0 / total
       else
         0
       end
@@ -83,7 +88,7 @@ class RedisDashboard::Application < Sinatra::Base
 
     def clients_column_description(col)
       # https://redis.io/commands/client-list
-      {
+      @clients_column_description ||= {
         id: "an unique 64-bit client ID (introduced in Redis 2.8.12).",
         addr: "address/port of the client",
         fd: "file descriptor corresponding to the socket",
@@ -101,12 +106,13 @@ class RedisDashboard::Application < Sinatra::Base
         omem: "output buffer memory usage",
         events: "file descriptor events (see below)",
         cmd: "last command played",
-      }[col.to_sym]
+      }
+      @clients_column_description[col.to_sym]
     end
 
     def client_event_description(event)
       # https://redis.io/commands/client-list
-      {
+      @client_event_description ||= {
         O: "the client is a slave in MONITOR mode",
         S: "the client is a normal slave server",
         M: "the client is a master",
@@ -120,7 +126,8 @@ class RedisDashboard::Application < Sinatra::Base
         r: "the client is in readonly mode against a cluster node",
         A: "connection to be closed ASAP",
         N: "no specific flag set",
-      }[event.to_sym]
+      }
+      @client_event_description[event.to_sym]
     end
   end
 end

data/lib/redis_dashboard/views/index.erb

@@ -20,7 +20,7 @@
         </div>
         <div>
           <span class="label">Cache hit ratio</span>
-          <span><%= format_impact_percentage compute_cache_hit_ratio(info) %></span>
+          <span><%== format_impact_percentage compute_cache_hit_ratio(info) %></span>
         </div>
       </div>
     </div>

data/lib/redis_dashboard/views/layout.erb

@@ -24,7 +24,7 @@
           </div>
         <% end %>
       </div>
-      <%= yield %>
+      <%== yield %>
       <div class="page-footer">
         Made by <a href="https://basesecrete.com/en/">Base Secrète</a>.  MIT License. <a href="https://github.com/BaseSecrete/redis_dashboard">Fork on GitHub</a>.
         <div class="rorvswild">

data/lib/redis_dashboard/views/slowlog.erb

@@ -1,5 +1,5 @@
 <p>
-  List up to <%= client.config["slowlog-max-len"] %> commands slower than <%= format_usec client.config["slowlog-log-slower-than"] %>.
+  List up to <%= client.config["slowlog-max-len"] %> commands slower than <%== format_usec client.config["slowlog-log-slower-than"] %>.
   It is defined in your config by <em>slowlog-max-len</em> and <em>slowlog-log-slower-than</em>.
 </p>
 
@@ -16,7 +16,7 @@
       <tr>
         <td><%= cmd.id %></td>
         <td class="date"><%= epoch_to_short_date_time cmd.timestamp %></td>
-        <td class="number"><%= format_usec cmd.microseconds %></td>
+        <td class="number"><%== format_usec cmd.microseconds %></td>
         <td><%= cmd.command.join(" ") %></td>
       </tr>
     <% end %>

data/lib/redis_dashboard/views/stats.erb

@@ -10,10 +10,10 @@
     <% for (key,hash) in stats %>
       <tr>
         <td class="key"><%= key %></td>
-        <td class="number"><%= format_usec hash["usec"] %></td>
+        <td class="number"><%== format_usec hash["usec"] %></td>
         <td class="number"><%= hash["calls"] %></td>
-        <td class="number"><%= format_usec hash["usec_per_call"] %></td>
-        <td class="number"><%= format_impact_percentage hash["impact"] %></td>
+        <td class="number"><%== format_usec hash["usec_per_call"] %></td>
+        <td class="number"><%== format_impact_percentage hash["impact"] %></td>
       </tr>
     <% end %>
   </table>

data/redis_dashboard.gemspec

@@ -3,7 +3,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
   spec.name          = "redis_dashboard"
-  spec.version       = "0.1.4"
+  spec.version       = "0.1.5"
   spec.authors       = ["Alexis Bernard"]
   spec.email         = ["alexis@bernard.io"]
   spec.summary       = "Sinatra app to monitor Redis servers."

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: redis_dashboard
 version: !ruby/object:Gem::Version
-  version: 0.1.4
+  version: 0.1.5
 platform: ruby
 authors:
 - Alexis Bernard
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-07-01 00:00:00.000000000 Z
+date: 2019-07-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sinatra