redis_cache_mailer_delivery 0.0.5 → 0.0.6

data/CHANGELOG

@@ -1,2 +1,7 @@
-- 0.0.4
+v0.0.6
+  * BUG fix: One has to set the whole settings in the client or CacheDelivery will 
+    not work properly since some settings could be missing
+v0.0.5
+  * Generalize how the marshallable converters are working. Make it a setting that can be configured by the clients
+v0.0.4
   * Add the ability to marshal a unmarshalable object, given the object provides marshallable method that make the object to be marshallable.

data/lib/redis_cache_mailer_delivery.rb

@@ -1,5 +1,6 @@
 require 'action_mailer'
 require 'redis_cache_mailer_delivery/version'
+require 'redis_cache_mailer_delivery/settings'
 require 'redis_cache_mailer_delivery/marshallable_converter_setting'
 require 'redis_cache_mailer_delivery/cache_delivery'
 require 'redis_cache_mailer_delivery/converters/sequel_marshallable_mail_message'
@@ -9,10 +10,8 @@ module RedisCacheMailerDelivery
   class << self
     def install
       ActionMailer::Base.add_delivery_method :redis_cache, RedisCacheMailerDelivery::CacheDelivery,
-        :redis_key_name => "redis_cache_mailer_delivery:mail_messages",
-        :marshallable_converters => []
+        Settings.default_values
     end
-
   end # << self
 end # RedisCacheMailerDelivery
 require 'redis_cache_mailer_delivery/railtie'

data/lib/redis_cache_mailer_delivery/cache_delivery.rb

@@ -6,18 +6,18 @@ module RedisCacheMailerDelivery
   #
   class CacheDelivery
 
-    # @attr [Hash] settings Settings for CacheDelivery
-    attr_accessor :settings
+    attr_reader :settings
+    private :settings
 
     # @api private
     def initialize(settings)
-      @settings = settings
+      @settings = Settings.new(settings)
     end
 
     # @api private
     def deliver!(mail)
-      list = Redis::List.new settings[:redis_key_name], :marshal => true
-      settings[:marshallable_converters].each do |setting|
+      list = Redis::List.new settings.redis_key_name, :marshal => true
+      settings.marshallable_converters.each do |setting|
         mail = MarshallableConverterSetting.new(setting).marshallable_class.marshallable(mail)
       end
       list << mail

data/lib/redis_cache_mailer_delivery/deliveries.rb

@@ -11,7 +11,8 @@ module RedisCacheMailerDelivery
       # @return [Array] array of mails (each mail is an instance of Mail.)
       #
       def all
-        list = Redis::List.new ActionMailer::Base.redis_cache_settings[:redis_key_name], :marshal => true
+        settings = Settings.new ActionMailer::Base.redis_cache_settings
+        list = Redis::List.new settings.redis_key_name, :marshal => true
         list.values
       end
     end 

data/lib/redis_cache_mailer_delivery/settings.rb

@@ -0,0 +1,15 @@
+module RedisCacheMailerDelivery
+  class Settings
+    class << self
+      def default_values
+      {:redis_key_name => "redis_cache_mailer_delivery:mail_messages",
+        :marshallable_converters => []}
+      end
+    end
+    def initialize(settings)
+      self.class.default_values.merge(settings).each do |key, value|
+        self.class.send(:define_method, key) {value}
+      end
+    end
+  end
+end

data/lib/redis_cache_mailer_delivery/version.rb

@@ -1,3 +1,3 @@
 module RedisCacheMailerDelivery
-  VERSION = "0.0.5"
+  VERSION = "0.0.6"
 end

data/spec/redis_cache_mailer_delivery/cache_delivery_spec.rb

@@ -2,8 +2,8 @@ require File.expand_path(File.join(File.dirname(__FILE__), "..", "spec_helper"))
 
 module RedisCacheMailerDelivery
   describe CacheDelivery do
-    subject {described_class.new :redis_key_name => "a-name", :marshallable_converters => []}
     describe "#deliver!" do
+      subject {described_class.new :redis_key_name => "a-name", :marshallable_converters => []}
       let(:object) {Mail::Message.new}
 
       after(:each) do

data/spec/redis_cache_mailer_delivery/settings_spec.rb

@@ -0,0 +1,37 @@
+require File.expand_path(File.join(File.dirname(__FILE__), "..", "spec_helper"))
+
+module RedisCacheMailerDelivery
+  describe Settings do
+    describe ".default_values" do
+      {:redis_key_name => "redis_cache_mailer_delivery:mail_messages",
+        :marshallable_converters => []}.each do |key, value|
+        it "includes #{key} and its default value to #{value}" do
+          described_class.default_values.should include(key => value)
+        end
+      end
+    end
+
+    describe ".new" do
+      context "when a value that is a key in default_values hash being passed in" do
+        subject {described_class.new :redis_key_name => "a-new-name"}
+        it "generates a method and return the value being passed in" do
+          subject.redis_key_name.should eq("a-new-name")
+        end
+      end
+      context "when a value that is not a key in default_values hash being passed in" do
+        subject {described_class.new :something_else => "a-new-name"}
+        it "generates a method and return the value being passed in" do
+          subject.something_else.should eq("a-new-name")
+        end
+      end
+      Settings.default_values.each do |key, value|
+        context "when #{key} is not passed in" do
+          subject {described_class.new({})}
+          it "generates a method #{key} and return the value defined in the default_values array" do
+            subject.send(key).should eq(value)
+          end
+        end
+      end
+    end
+  end
+end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: redis_cache_mailer_delivery
 version: !ruby/object:Gem::Version 
-  hash: 21
+  hash: 19
   prerelease: 
   segments: 
   - 0
   - 0
-  - 5
-  version: 0.0.5
+  - 6
+  version: 0.0.6
 platform: ruby
 authors: 
 - Yi Wen
@@ -155,12 +155,14 @@ files:
 - lib/redis_cache_mailer_delivery/deliveries.rb
 - lib/redis_cache_mailer_delivery/marshallable_converter_setting.rb
 - lib/redis_cache_mailer_delivery/railtie.rb
+- lib/redis_cache_mailer_delivery/settings.rb
 - lib/redis_cache_mailer_delivery/version.rb
 - redis_cache_mailer_delivery.gemspec
 - spec/redis_cache_mailer_delivery/cache_delivery_spec.rb
 - spec/redis_cache_mailer_delivery/converters/sequel_marshallable_mail_message_spec.rb
 - spec/redis_cache_mailer_delivery/deliveries_spec.rb
 - spec/redis_cache_mailer_delivery/marshallable_converter_setting_spec.rb
+- spec/redis_cache_mailer_delivery/settings_spec.rb
 - spec/redis_cache_mailer_delivery_spec.rb
 - spec/spec_helper.rb
 - spec/support/faked_rails.rb
@@ -203,6 +205,7 @@ test_files:
 - spec/redis_cache_mailer_delivery/converters/sequel_marshallable_mail_message_spec.rb
 - spec/redis_cache_mailer_delivery/deliveries_spec.rb
 - spec/redis_cache_mailer_delivery/marshallable_converter_setting_spec.rb
+- spec/redis_cache_mailer_delivery/settings_spec.rb
 - spec/redis_cache_mailer_delivery_spec.rb
 - spec/spec_helper.rb
 - spec/support/faked_rails.rb