redis_cache_mailer_delivery 0.0.3 → 0.0.4

data/CHANGELOG

@@ -0,0 +1,2 @@
+- 0.0.4
+  * Add the ability to marshal a unmarshalable object, given the object provides marshallable method that make the object to be marshallable.

data/README.md

@@ -48,6 +48,14 @@ RedisCacheMailerDelivery::Deliveries.all
 
 to access all the mails
 
+## Sequel
+
+If you use Sequel and you set a sequel record into the Mail::Message (```mail.record = record```), the chances are you will encounter an error where you cannot serialize the message since the record might be a singleton. The gem has a builtin fix for this by using marshallable! method provied by Sequel since 3.6.0
+
+## Other unmarshallable objects
+
+The code will find if the mail being passed in responds to ```marshallable``` method, if it does, the code will call ```marshallable``` method before send it to the redis store
+
 ## Contributing
 
 1. Fork it

data/lib/redis_cache_mailer_delivery/mail/cache_delivery.rb

@@ -17,7 +17,9 @@ module Mail
     # @api private
     def deliver!(mail)
       list = Redis::List.new settings[:redis_key_name], :marshal => true
-      list << mail
+      mail = SequelMarshallableMailMessage.marshallable mail
+      object = mail.respond_to?(:marshallable) ? mail.marshallable : mail
+      list << object
     end
 
   end # CacheDelivery

data/lib/redis_cache_mailer_delivery/mail/sequel_marshallable_mail_message.rb

@@ -0,0 +1,11 @@
+module Mail
+  module SequelMarshallableMailMessage
+    class << self
+      def marshallable(object)
+        return object unless object.respond_to?(:record)
+        object.record.marshallable! if object.record.respond_to?(:marshallable!)
+        object
+      end
+    end
+  end
+end

data/lib/redis_cache_mailer_delivery/version.rb

@@ -1,3 +1,3 @@
 module RedisCacheMailerDelivery
-  VERSION = "0.0.3"
+  VERSION = "0.0.4"
 end

data/lib/redis_cache_mailer_delivery.rb

@@ -1,6 +1,7 @@
 require 'action_mailer'
 require 'redis_cache_mailer_delivery/version'
 require 'redis_cache_mailer_delivery/mail/cache_delivery'
+require 'redis_cache_mailer_delivery/mail/sequel_marshallable_mail_message'
 require 'redis_cache_mailer_delivery/deliveries'
 
 module RedisCacheMailerDelivery

data/spec/redis_cache_mailer_delivery/mail/cache_delivery_spec.rb

@@ -13,6 +13,24 @@ module Mail
         subject.deliver!(object)
         Redis::List.new("a-name", :marshal => true).values[0].should eq(object)
       end
+
+      it "tries to make it marshallable first by passing it through SequelMarshallableMailMessage" do
+        SequelMarshallableMailMessage.should_receive(:marshallable).with(object).and_return object
+        subject.deliver!(object)
+      end
+
+      context "when the object respond to marshallable" do
+        before(:each) do
+          def object.marshallable
+            Mail::Message.new
+          end
+        end
+        
+        it "calls the method before send to redis" do
+          object.should_receive(:marshallable).and_return Mail::Message.new
+          subject.deliver!(object)
+        end
+      end
     end
   end
 end

data/spec/redis_cache_mailer_delivery/mail/sequel_marshallable_mail_message_spec.rb

@@ -0,0 +1,38 @@
+require 'spec_helper'
+
+describe Mail::SequelMarshallableMailMessage do
+  let(:object) {Class.new.new}
+  describe "#marshallable" do
+    context "when the message responds to the record message" do
+      let(:record) {double :sequel_record, :marshallable! => nil}
+      before(:each) do
+        object.stub(:record).and_return record
+      end
+
+      it "calls the record's marshallable! method" do
+        record.should_receive(:marshallable!).and_return record
+        described_class.marshallable object
+      end
+
+      it "returns the mail" do
+        described_class.marshallable(object).should eq(object)
+      end
+
+      context "and the record is nil" do
+        before(:each) do
+          object.stub(:record).and_return nil
+        end
+
+        it "returns itself" do
+          described_class.marshallable(object).should eq(object)
+        end
+      end
+    end
+
+    context "when the message does not respond to the record message" do
+      it "returns itself" do
+        described_class.marshallable(object).should eq(object)
+      end
+    end
+  end
+end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: redis_cache_mailer_delivery
 version: !ruby/object:Gem::Version 
-  hash: 25
+  hash: 23
   prerelease: 
   segments: 
   - 0
   - 0
-  - 3
-  version: 0.0.3
+  - 4
+  version: 0.0.4
 platform: ruby
 authors: 
 - Yi Wen
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2012-03-23 00:00:00 Z
+date: 2012-03-25 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: redis
@@ -143,6 +143,7 @@ files:
 - .rspec
 - .rvmrc
 - .travis.yml
+- CHANGELOG
 - Gemfile
 - Guardfile
 - LICENSE
@@ -151,11 +152,13 @@ files:
 - lib/redis_cache_mailer_delivery.rb
 - lib/redis_cache_mailer_delivery/deliveries.rb
 - lib/redis_cache_mailer_delivery/mail/cache_delivery.rb
+- lib/redis_cache_mailer_delivery/mail/sequel_marshallable_mail_message.rb
 - lib/redis_cache_mailer_delivery/railtie.rb
 - lib/redis_cache_mailer_delivery/version.rb
 - redis_cache_mailer_delivery.gemspec
 - spec/redis_cache_mailer_delivery/deliveries_spec.rb
 - spec/redis_cache_mailer_delivery/mail/cache_delivery_spec.rb
+- spec/redis_cache_mailer_delivery/mail/sequel_marshallable_mail_message_spec.rb
 - spec/redis_cache_mailer_delivery_spec.rb
 - spec/spec_helper.rb
 - spec/support/faked_rails.rb
@@ -196,6 +199,7 @@ summary: Use Redis to store the Mail::Message when using in Rails
 test_files: 
 - spec/redis_cache_mailer_delivery/deliveries_spec.rb
 - spec/redis_cache_mailer_delivery/mail/cache_delivery_spec.rb
+- spec/redis_cache_mailer_delivery/mail/sequel_marshallable_mail_message_spec.rb
 - spec/redis_cache_mailer_delivery_spec.rb
 - spec/spec_helper.rb
 - spec/support/faked_rails.rb