redis-rails-instrumentation 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f77ad22f3ab95a646a40999de5e772ac9eca1107
-  data.tar.gz: 0ae988ec9866cb2443aee39a0c2d4d046fa0c499
+  metadata.gz: 1d418b58a6ea59c34e95c91b1d87d46b25a9f866
+  data.tar.gz: e48976db5221830f7662151ec552b5e78d0b9a16
 SHA512:
-  metadata.gz: bb535484b3e4870dc4ed2f784fc443264924df4a324dceedf2a888b4d8ff436357f2da65af48a605032fa8671877672f12c10d276669acc8df8b1b4c7ffafc94
-  data.tar.gz: 7511ba14bc0345597d7da545e84dbad4bc895ea16595c362b8788cccb5cd5d03218c48bf87518a7f19760a8ff42c6c9a320d09ce8710f040a05838bbffc5b055
+  metadata.gz: bf2f31155b84b0ddf1c1a73c004e516fe592be8b4fe4eaf18a8f862ed2126bbf0260fc2f91059514f760f14d2f0ca8858cf281af34b32d55c8d766f5d88cc224
+  data.tar.gz: 32aec6f8232e929462dd043a0d0da301a2a2d7103787f19ea33b2453c60cb73f2dd7af5f991256305ebf6c8125eb400c937e24e5231a55fcb6f412e120855769

data/.travis.yml

@@ -5,7 +5,7 @@ rvm:
   - 2.1.10
   - 2.2.6
   - 2.3.3
-  - 2.4.0
-  - jruby-9.1.7.0
+  - 2.4.1
+  - jruby-9.1.8.0
 services:
   - redis-server

data/lib/redis/rails/instrumentation.rb

@@ -17,7 +17,7 @@ class Redis
 
           output = cmds.map do |name, *args|
             if !args.empty?
-              "[ #{name.to_s.upcase} #{args.join(' ')} ]"
+              "[ #{name.to_s.upcase} #{format_arguments(args)} ]"
             else
               "[ #{name.to_s.upcase} ]"
             end
@@ -25,6 +25,18 @@ class Redis
 
           debug message(event, 'Redis', output)
         end
+
+        private
+
+        def format_arguments(args)
+          args.map do |arg|
+            if arg.respond_to?(:encoding) && arg.encoding == Encoding::ASCII_8BIT
+              '<BINARY DATA>'
+            else
+              arg
+            end
+          end.join(' ')
+        end
       end
     end
   end

data/lib/redis/rails/instrumentation/version.rb

@@ -1,7 +1,7 @@
 class Redis
   module Rails
     module Instrumentation
-      VERSION = "1.0.0".freeze
+      VERSION = "1.0.1".freeze
     end
   end
 end

data/spec/redis/rails/instrumentation_spec.rb

@@ -1,5 +1,6 @@
 require 'spec_helper'
 require 'redis'
+require 'base64'
 
 class Redis
   module Rails
@@ -42,6 +43,14 @@ class Redis
           .to match(/Redis \(\d+\.\d+ms\)  \[ GET test \]/)
       end
 
+      it 'truncates binary data' do
+        @logger.level = Logger::DEBUG
+        Instrumentation::Railtie.run_initializers
+        redis.set('test', Base64.decode64("R0lGODlhAQABAPAAAAAAAAAAACH5BAEAAAAALAAAAAABAAEAAAICRAEAOw=="))
+        expect(@logger.logged(:debug)[0])
+          .to match(/Redis \(\d+\.\d+ms\)  \[ SET test <BINARY DATA> \]/)
+      end
+
       it 'omits debug logging in production' do
         @logger.level = Logger::ERROR
         Instrumentation::Railtie.run_initializers

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: redis-rails-instrumentation
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Ville Lautanala
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-01-18 00:00:00.000000000 Z
+date: 2017-03-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: redis