redis-rack 2.1.0 → 2.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bd358598a3b5173b0af0e6af5a0eb8544d33beb746a24c0d4ae01cb01e5e82c1
-  data.tar.gz: 9afa606f06fc3a5b6812ac5d5a961bc440df74b2ac27160a03536fa0f69d7474
+  metadata.gz: e8fe2b21455a3af95982db86314846abed8b97be35712009a6c720b1fe8a0e3f
+  data.tar.gz: 99c15862e3d1e7c1d16d460da299fcc0dc551a606ce9731710f153f51f3b6196
 SHA512:
-  metadata.gz: a88c2a36dca22320e1e8d015fbfd0ece8b71f814c60e7a90cb1036ae8cee9f713f3321389f286c707b982a5a82c8b5078ffe93b58c37e17367fec6aa8544e209
-  data.tar.gz: 41722398d1973c7390155fb71c9fe17e3e99e1b0093db1b7d588c77dec01487390b4208a8e04ff0a8050d0f03029c606d619e68da7cbfed9e3bdf397159c0502
+  metadata.gz: ef8ef0c5c0286d5df01ee90df055e19ef90969f11b0568a681e64f1955558837584504c5a1b62c8cfc5e7b6fead33cdfa39741f8048ecf787457cb85c7910e6d
+  data.tar.gz: e3f5a9642b8f50e9da6cc05f9387d7acca8245bd702e8f795690b383b6fe253ec037ab930e68a282c37e32f139956e00e6a9a5137dae5957cb03e332cfe057a4

data/.ruby-version

@@ -1 +1 @@
-2.6.2
+2.7.1

data/CHANGELOG.md

@@ -0,0 +1,246 @@
+v2.1.0 (2020-01-13)
+--------------------------------------------------------------------------------
+
+*   Update version to v2.1.0 final
+    Tom Scott
+
+*   Test against most recent versions of Ruby
+    Tom Scott
+
+*   Update gemspec to remove rubyforge_project
+
+    It is deprecated or removed already
+
+    Original warning message:
+    Gem::Specification#rubyforge_project= is deprecated with no replacement. It will be removed on or after 2019-12-01.
+    PikachuEXE
+
+*   back tests to original state
+    Alexey Vasiliev
+
+*   Fix redis-rack for rack 2.0.8, small improvements
+    Alexey Vasiliev
+
+*   Fix redis-rack for rack 2.0.8, fix generate_unique_sid
+    Alexey Vasiliev
+
+*   Fix redis-rack for rack 2.0.8
+    Alexey Vasiliev
+
+*   v2.1.0.pre: Update Rack Session API, drop support for Rack 1.0
+    Tom Scott
+
+v2.0.6
+--------------------------------------------------------------------------------
+
+*   v2.0.6: Prevent Connection Pool from passing nil options
+    Tom Scott
+
+*   Make bundler dependency more permissive to support future ruby versions
+    Tom Scott
+
+*   Drop support for Rack v1
+    Tom Scott
+
+*   Update Rack::Session API Compatibility
+
+    The latest version of Rack [deprecated subclassing Rack::Session::ID](https://github.com/rack/rack/blob/master/lib/rack/session/abstract/id.rb#L412-L419),
+    replacing it instead with `Rack::Session::Persisted`. Update the method
+    implementations in this gem to support the new API. Shoutouts to @onk
+    for actually writing this code, we're pulling it in from his fork.
+    Tom Scott
+
+*   Automatically assign issues to @tubbo when they are created
+    Tom Scott
+
+*   Automatically release to RubyGems when new tags are pushed to GitHub
+    Tom Scott
+
+*   Raise Error when `:redis_store` is Incorrect Type
+
+    Passing an object that isn't a `Redis::Store` into the session storage
+    configuration can cause errors when methods are called with more
+    arguments than the default Redis client can handle. These additional
+    arguments are used by `Rack::Session::Redis` to configure the key
+    namespace and TTL globally in the main configuration, and pass them down
+    to `Redis::Store` to be appended to the key. An `ArgumentError` will now
+    be thrown when a `:redis_store` is of a type that isn't a `Redis::Store`
+    (or a subclass thereof).
+
+    Resolves #46
+    Tom Scott
+
+*   Add code owners
+    Tom Scott
+
+*   Do not provide nil values for missing connection pool options
+
+    Fixes #44
+    Jake Goulding
+
+v2.0.5
+--------------------------------------------------------------------------------
+
+*   v2.0.5 release
+    Tom Scott
+
+*   add spec to validate blank sessions are not stored in redis
+    mstruve
+
+*   dont store a blank session in redis
+    mstruve
+
+*   Add documentation for options
+    Daniel M Barlow
+
+v2.0.4
+--------------------------------------------------------------------------------
+
+*   Release 2.0.4
+    Tom Scott
+
+*   Remove .ruby-version
+    Tom Scott
+
+*   Remove rake, appraisal from gemspec executables
+
+    The contents of the bin directory are binstubs to assist development.
+    They are not intended to be shipped with the gem itself. This commit
+    updates the gemspec to ensure that they are not exposed to rubygems as
+    executables for redis-rack, which will fix conflicts with the legitimate
+    rake and appraisal executables provided by those other gems.
+    Matt Brictson
+
+v2.0.3
+--------------------------------------------------------------------------------
+
+*   v2.0.3: Avoid mutex locking with global option
+    Tom Scott
+
+*   Restore default_options in #generate_unique_sid
+    Tom Scott
+
+*   Refactor connection_pool code
+
+    Adds a `Redis::Rack::Connection` object for handling the instantiation
+    of a `Redis::Store` or a `ConnectionPool` if pool configuration is
+    given. Restores the purpose of `Rack::Session::Redis` to only implement
+    the session ID abstract API provided by Rack.
+    Tom Scott
+
+*   Rename :use_global_lock option to :threadsafe to match Rails
+    Garrett Thornburg
+
+*   Use mocha mocks to assert the mutex is never locked
+    Garrett Thornburg
+
+*   Allow redis-store v1.4
+    Shane O'Grady
+
+*   Create a :use_global_lock option that avoids the global lock
+    Garrett Thornburg
+
+*   Rake task for running all tests on all gem versions
+    Tom Scott
+
+*   Install Appraisal so we can test against multiple versions of Rack
+    Tom Scott
+
+v2.0.2
+--------------------------------------------------------------------------------
+
+*   v2.0.2: Resolve regression forcing Rack 2.x and above
+    Tom Scott
+
+v2.0.1
+--------------------------------------------------------------------------------
+
+*   v2.0.1: Relax gem dependencies
+    Tom Scott
+
+*   smoothen redis-store dependency
+    Mathieu Jobin
+
+*   Drop support for Rubinius 1.9 mode
+
+    1.9.x is EOL in MRI Ruby Land, and Rubinius 1.9 mode isn't really used
+    much anymore. This should make the builds pass again.
+    Tom Scott
+
+*   Update README.md (#20)
+    Nicolas
+
+*   Remove jruby 1.9 mode from the build matrix
+    Tom Scott
+
+*   Remove test because why
+    Tom Scott
+
+v2.0.0
+--------------------------------------------------------------------------------
+
+*   v2.0: Drop support for Ruby below 2.2 (thanks @connorshea)
+
+    Fixes #17, major shoutouts to @connorshea for getting this off the
+    ground. This also edits the CI config to drop support for older Ruby
+    versions.
+    Tom Scott
+
+*   Fix gem dependency versions
+    Tom Scott
+
+*   v2.0.0.pre Add support for Rails 5 and Rack 2.
+    Tom Scott
+
+*   v2.0.0: Upgrade to Rack 2.0
+
+    This release includes some backwards-incompatible changes that pertain
+    to Rails' upgrade to Rack 2.x.
+    Tom Scott
+
+*   Update README
+    Tom Scott
+
+*   Fix readme
+    Tom Scott
+
+*   travis.yml add Ruby 2.3.0
+    shiro16
+
+*   add 2.1 and 2.2 rubies to travis
+    Marc Roberts
+
+*   Remove support for Ruby 1.9
+    Marc Roberts
+
+*   Loosen dependancy on Rack to allow 1.5 and 2.x
+
+    Rails 5 beta requires Rack 2.x and this gem is unusable unless can use Rack 2.x
+    Marc Roberts
+
+*   Update README.md
+    Ryan Bigg
+
+*   add support for ConnectionPool
+    Roman Usherenko
+
+*   Introduce redis_store option (closes #1)
+    Kurakin Alexander
+
+*   Atomically lock session id and implement skip support.
+    W. Andrew Loe III
+
+v1.5.0
+------
+
+*   Enable CI
+    Luca Guidi
+
+*   Update README.md
+    Luca Guidi
+
+*   Moved back from jodosha/redis-store
+    Luca Guidi
+
+*   Moved
+    Luca Guidi

data/Gemfile

@@ -1,2 +1,6 @@
 source 'https://rubygems.org'
+
 gemspec
+
+gem 'redis-store-testing', github: 'redis-store/testing'
+gem 'appraisal', '~> 2.2'

data/lib/rack/session/redis.rb

@@ -24,7 +24,7 @@ module Rack
         loop do
           sid = generate_sid
           first = with do |c|
-            [*c.setnx(sid.private_id, session, @default_options)].first
+            [*c.setnx(sid.private_id, session, @default_options.to_hash)].first
           end
           break sid if [1, true].include?(first)
         end
@@ -44,9 +44,9 @@ module Rack
         end
       end
 
-      def write_session(req, sid, new_session, options)
+      def write_session(req, sid, new_session, options = {})
         with_lock(req, false) do
-          with { |c| c.set sid.private_id, new_session, options }
+          with { |c| c.set(sid.private_id, new_session, options.to_hash) }
           sid
         end
       end
@@ -65,7 +65,7 @@ module Rack
         @default_options.fetch(:threadsafe, true)
       end
 
-      def with_lock(req, default=nil)
+      def with_lock(req, default = nil)
         @mutex.lock if req.multithread? && threadsafe?
         yield
       rescue Errno::ECONNREFUSED

data/lib/redis/rack/connection.rb

@@ -1,6 +1,8 @@
 class Redis
   module Rack
     class Connection
+      POOL_KEYS = %i[pool pool_size pool_timeout].freeze
+
       def initialize(options = {})
         @options = options
         @store = options[:redis_store]
@@ -24,7 +26,9 @@ class Redis
       end
 
       def pooled?
-        [:pool, :pool_size, :pool_timeout].any? { |key| @options.key?(key) }
+        return @pooled if defined?(@pooled)
+
+        @pooled = POOL_KEYS.any? { |key| @options.key?(key) }
       end
 
       def pool

data/lib/redis/rack/version.rb

@@ -1,5 +1,5 @@
 class Redis
   module Rack
-    VERSION = '2.1.0'
+    VERSION = '2.1.4'
   end
 end

data/redis-rack.gemspec

@@ -20,12 +20,10 @@ Gem::Specification.new do |s|
   s.add_runtime_dependency 'redis-store',   ['< 2', '>= 1.2']
   s.add_runtime_dependency 'rack',          '>= 2.0.8', '< 3'
 
-  s.add_development_dependency 'rake',     '~> 10'
+  s.add_development_dependency 'rake',     '>= 12.3.3'
   s.add_development_dependency 'bundler',  '> 1', '< 3'
   s.add_development_dependency 'mocha',    '~> 0.14.0'
   s.add_development_dependency 'minitest', '~> 5'
-  s.add_development_dependency 'redis-store-testing'
   s.add_development_dependency 'connection_pool',     '~> 1.2.0'
-  s.add_development_dependency 'appraisal'
 end
 

metadata

@@ -1,35 +1,35 @@
 --- !ruby/object:Gem::Specification
 name: redis-rack
 version: !ruby/object:Gem::Version
-  version: 2.1.0
+  version: 2.1.4
 platform: ruby
 authors:
 - Luca Guidi
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-01-13 00:00:00.000000000 Z
+date: 2022-01-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: redis-store
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '1.2'
     - - "<"
       - !ruby/object:Gem::Version
         version: '2'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '1.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '1.2'
     - - "<"
       - !ruby/object:Gem::Version
         version: '2'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '1.2'
 - !ruby/object:Gem::Dependency
   name: rack
   requirement: !ruby/object:Gem::Requirement
@@ -54,16 +54,16 @@ dependencies:
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '10'
+        version: 12.3.3
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '10'
+        version: 12.3.3
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -112,20 +112,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '5'
-- !ruby/object:Gem::Dependency
-  name: redis-store-testing
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: connection_pool
   requirement: !ruby/object:Gem::Requirement
@@ -140,20 +126,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 1.2.0
-- !ruby/object:Gem::Dependency
-  name: appraisal
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 description: Redis Store for Rack applications
 email:
 - me@lucaguidi.com
@@ -165,6 +137,7 @@ files:
 - ".gitignore"
 - ".ruby-version"
 - ".travis.yml"
+- CHANGELOG.md
 - CODEOWNERS
 - Gemfile
 - MIT-LICENSE
@@ -184,7 +157,7 @@ homepage: http://redis-store.org/redis-rack
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -199,8 +172,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
-signing_key: 
+rubygems_version: 3.1.2
+signing_key:
 specification_version: 4
 summary: Redis Store for Rack
 test_files: