redis-rack 2.0.5 → 2.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 66572ef2577985ef4e66d8eff099b41cd2522452
-  data.tar.gz: 021ff43d18f10505f52187456132922eddea15b8
+SHA256:
+  metadata.gz: 68b8d92fa59d3d7167cf87bd16e1e62ca34ba905a901964a6d386b47155f8da0
+  data.tar.gz: 3c8b27ef07b66c2050d053287c03eb3aee64860fda3e4ff806200d9cc663f7ec
 SHA512:
-  metadata.gz: dd6ac3b843ebadac7e56d802680badd2163ac0320a90377e94f730465c739ee74738e5c2b347a34c4fae1b6d94160a8f988c8e748ab540c820750ed7792b2ae0
-  data.tar.gz: b26ae6bfb3306d19260454d41ce2559e88997365bfc713c10fd33168b8e70ea052b45be7fed5e5370a8c36b0b66c5415935df19d77ae2a6cef1db64fd925e36c
+  metadata.gz: 351e468a771f67ed2e05c3620735636f23f7ad40e338d420c3662a2f7bfc1abdf82e3cf30c1e9a8268452ed1451e87740cc7fabb110b5c60251717a84b2c70f4
+  data.tar.gz: b93772d79076558bf42e60effd452a47699e215538e73435ec70f500ee8e2902b65b7c1f2eb40d4019884c12fbf81ab57b940702657b4295581abe820483631d

data/.github/auto-assign-issues.yml

@@ -0,0 +1,2 @@
+assignees:
+  - tubbo

data/.travis.yml

@@ -1,16 +1,22 @@
 language: ruby
-script: 'bundle exec rake'
+script: bundle exec rake
 rvm:
-  - 2.2.3
-  - 2.3.1
-  - ruby-head
-  - jruby-head
-
+- 2.2.3
+- 2.3.1
+- ruby-head
+- jruby-head
 matrix:
   allow_failures:
-    - rvm: jruby-head
-    - rvm: ruby-head
-# Put this in your .travis.yml
+  - rvm: jruby-head
+  - rvm: ruby-head
 gemfile:
-  - gemfiles/rack_2.gemfile
-  - gemfiles/rack_1.gemfile
+- gemfiles/rack_2.gemfile
+- gemfiles/rack_1.gemfile
+deploy:
+  provider: rubygems
+  api_key:
+    secure: VTosVmCdLWUGK8KyzovYri7ySfd7fACtfL8MClEBBHnI+m2cLCpmtCJ7Z1X7z9BXlj974EDaF8V9iRKzfksXIf8aaPfVQw9AW94fLJZbfSB8YGOGyNbPu9YECoZQB1aZ2lw9s/aEdfwCbmqizO/fYpG3YoPKJdm1ZJpNOFR37Xk=
+  gem: redis-rack
+  on:
+    tags: true
+    repo: redis-store/redis-rack

data/CODEOWNERS

@@ -0,0 +1 @@
+* @tubbo

data/lib/redis/rack/connection.rb

@@ -9,6 +9,10 @@ class Redis
         if @pool && !@pool.is_a?(ConnectionPool)
           raise ArgumentError, "pool must be an instance of ConnectionPool"
         end
+
+        if @store && !@store.is_a?(Redis::Store)
+          raise ArgumentError, "redis_store must be an instance of Redis::Store (currently #{@store.class.name})"
+        end
       end
 
       def with(&block)
@@ -35,7 +39,7 @@ class Redis
         {
           size: @options[:pool_size],
           timeout: @options[:pool_timeout]
-        }
+        }.reject { |key, value| value.nil? }.to_h
       end
     end
   end

data/lib/redis/rack/version.rb

@@ -1,6 +1,6 @@
 class Redis
   module Rack
-    VERSION = '2.0.5'
+    VERSION = '2.0.6'
   end
 end
 

data/test/redis/rack/connection_test.rb

@@ -56,12 +56,29 @@ class Redis
         conn.store.must_equal(store)
       end
 
+      it "throws an error when provided Redis store is not the expected type" do
+        assert_raises ArgumentError do
+          Connection.new(redis_store: ::Redis.new)
+        end
+      end
+
       it "uses the specified Redis server when provided" do
         conn = Connection.new(redis_server: 'redis://127.0.0.1:6380/1')
 
         conn.pooled?.must_equal false
         conn.store.to_s.must_match(/127\.0\.0\.1:6380 against DB 1$/)
       end
+
+      it "does not include nil options for the connection pool" do
+        conn = Connection.new
+        conn.pool_options.must_be_empty
+
+        conn = Connection.new(pool_size: nil)
+        conn.pool_options.must_be_empty
+
+        conn = Connection.new(pool_timeout: nil)
+        conn.pool_options.must_be_empty
+      end
     end
   end
 end

metadata

@@ -1,35 +1,35 @@
 --- !ruby/object:Gem::Specification
 name: redis-rack
 version: !ruby/object:Gem::Version
-  version: 2.0.5
+  version: 2.0.6
 platform: ruby
 authors:
 - Luca Guidi
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-11-09 00:00:00.000000000 Z
+date: 2019-09-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: redis-store
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '2'
     - - ">="
       - !ruby/object:Gem::Version
         version: '1.2'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '2'
     - - ">="
       - !ruby/object:Gem::Version
         version: '1.2'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '2'
 - !ruby/object:Gem::Dependency
   name: rack
   requirement: !ruby/object:Gem::Requirement
@@ -155,9 +155,11 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/auto-assign-issues.yml"
 - ".gitignore"
 - ".travis.yml"
 - Appraisals
+- CODEOWNERS
 - Gemfile
 - MIT-LICENSE
 - README.md
@@ -193,8 +195,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: redis-rack
-rubygems_version: 2.6.14
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Redis Store for Rack