redis-em-mutex 0.2.2 → 0.2.3

data/HISTORY.rdoc

@@ -1,3 +1,7 @@
+0.2.3
+- fixed: rare but possible race condition in unlock!
+  manifesting as deadlock exception when no deadlock should occur
+
 0.2.2
 - fixed: uuid must be set only once
 - fixed: forking process or setup before reactor is running would hang

data/README.md

@@ -53,7 +53,7 @@ $ [sudo] gem install redis-em-mutex
 #### Gemfile
 
 ```ruby
-gem "redis-em-mutex", "~> 0.2.2"
+gem "redis-em-mutex", "~> 0.2.3"
 ```
 
 #### Github

data/lib/redis/em-mutex.rb

@@ -215,6 +215,7 @@ class Redis
       def unlock!
         sem_left = @ns_names.length
         if @locked_id && owner_ident(@locked_id) == (lock_full_ident = @locked_owner_id)
+          @locked_owner_id = @locked_id = nil
           @@redis_pool.execute(false) do |r|
             @ns_names.each do |name|
               r.watch(name) do
@@ -231,7 +232,6 @@ class Redis
               end
             end
           end
-          @locked_owner_id = @locked_id = nil
         end
         sem_left.zero? && self
       end

data/lib/redis/em-mutex/version.rb

@@ -1,7 +1,7 @@
 class Redis
   module EM
     class Mutex
-      VERSION = '0.2.2'
+      VERSION = '0.2.3'
     end
   end
 end

data/spec/redis-em-mutex-semaphores.rb

@@ -418,6 +418,31 @@ describe Redis::EM::Mutex do
     end
   end
 
+  it "should not raise deadlock exception when none is expected" do
+    mutex = described_class.new(*@lock_names, expire: 10000)
+    f = Fiber.current
+    count = 0
+    200.times do
+      EM::Synchrony.next_tick do
+        begin
+          count+=1
+          5.times do
+            mutex.synchronize do
+              EM::Synchrony.sleep(0.0001)
+            end
+          end
+          count-=1
+          f.resume if count.zero? && f
+        rescue Exception => e
+          f.resume e
+        end
+      end
+    end
+    e = Fiber.yield
+    f = nil
+    raise e if e
+  end
+
   around(:each) do |testcase|
     @after_em_stop = nil
     @exception = nil

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: redis-em-mutex
 version: !ruby/object:Gem::Version
-  version: 0.2.2
+  version: 0.2.3
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-02-06 00:00:00.000000000 Z
+date: 2013-02-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: redis