redis-elasticache 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2b7bd6bcce6dd8e60cfb6713b12e266d19ea1d89daa620a3cf0cfc0a8132c733
-  data.tar.gz: 44ed6e3acae5636421987cc2dd7d6aeafd2f607f26606a0a3f30c2b330379e79
+  metadata.gz: 7c74a2742340fc6f0ff10c669b43b2d0f7c1a300f49d77500361659fbba49de0
+  data.tar.gz: 908669948d0ae1b9b8e04719c4dd97665271da8cb3e3aaaf9d9e7e6a00daa063
 SHA512:
-  metadata.gz: 64160ba02b483c108b07b9f15c92d16f9b63e57db83e8b4bb65abf3fee7ea3ae9a3689aa0471b9bb67a691d45be72c6437552b9e2a905368f17a8644b4e1e526
-  data.tar.gz: 14ebb85c2b8c3a2dabe6865e12f0acd43228d1e3c450cc8a874cbbdc97c0334121bccf7000c9fa9b91c495af9510eda6311a34492e3752ae8a018a267a1c2641
+  metadata.gz: 2f9bd873418ddf35846ab8b005bdc327cd4c092bba06d8ebef14c1425b34257a149e181755f522a41bec394ca2cd381a9770443616c44e00dea72c48c77bf781
+  data.tar.gz: fdfdc13e8d6d93243cf92c1699bb9bdc0583a117c73461089b23e3f282db95565f5b3f5cb0f2132b56da7fb6c8a0f7d341942710be88ca125d880265064c6fe3

data/lib/redis/elasticache/failover.rb

@@ -4,30 +4,33 @@ class Redis
 
   module Connection
     class Ruby
-
-      ELASTICACHE_READONLY_ERROR = "READONLY You can't write against a read only replica.".freeze
-      ELASTICACHE_LOADING_ERROR = "LOADING Redis is loading the dataset in memory".freeze
+      ELASTICACHE_READONLY_ERROR_PREFIX = "READONLY".freeze
+      ELASTICACHE_LOADING_ERROR_PREFIX = "LOADING".freeze
       ELASTICACHE_READONLY_MESSAGE = "A write operation was issued to an ELASTICACHE replica node that is READONLY.".freeze
       ELASTICACHE_LOADING_MESSAGE = "A write operation was issued to an ELASTICACHE node that was previously READONLY and is now LOADING.".freeze
 
-      # Amazon RDS supports failover, but because it uses DNS magic to point to
-      # the master node, TCP connections are not disconnected and we can issue
-      # write operations to a node that is no longer the master. Under normal 
-      # conditions this should be interpreted as a `CommandError`, but with RDS
-      # replication groups, we should consider this a `BaseConnectionError` so we
-      # terminate the connection, reconnect and retry the operation with the
+      # Amazon Elasticache supports failover, but because it uses DNS magic to
+      # point to the master node, TCP connections are not disconnected and we
+      # can issue write operations to a node that is no longer the master. Under
+      # normal conditions this should be interpreted as a `CommandError`, but with
+      # Elasticache replication groups, we should consider this a `BaseConnectionError`
+      # so we terminate the connection, reconnect and retry the operation with the
       # correct node as the master accepting writes.
       def format_error_reply(line)
         error_message = line.strip
-        if error_message == ELASTICACHE_READONLY_ERROR
+        if error_message_has_prefix?(ELASTICACHE_READONLY_ERROR_PREFIX, error_message)
           raise BaseConnectionError, ELASTICACHE_READONLY_MESSAGE
-        elsif error_message == ELASTICACHE_LOADING_ERROR
+        elsif error_message_has_prefix?(ELASTICACHE_LOADING_ERROR_PREFIX, error_message)
           raise BaseConnectionError, ELASTICACHE_LOADING_MESSAGE
         else
           CommandError.new(error_message)
         end
       end
 
+      private
+      def error_message_has_prefix?(prefix, error_message)
+        (error_message.slice(0, prefix.length) === prefix)
+      end
     end
   end
 end

data/lib/redis/elasticache/version.rb

@@ -1,5 +1,5 @@
 class Redis
   module Elasticache
-    VERSION = "0.1.2"
+    VERSION = "0.1.3"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: redis-elasticache
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Craig McNamara
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-03-22 00:00:00.000000000 Z
+date: 2019-10-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: redis