redis-cluster-client 0.4.5 → 0.4.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: be67f7c4a1a9e75573c957233bc9381745fc143b483583a4abb02b6b794bf49a
-  data.tar.gz: b12b518ba293af7e8f84e9a8c4770c5d5e8d776e213af30db94bcba753612802
+  metadata.gz: b894248e71e984932e9d2f177640c86a7f7d08cb57d3bf43bb91603ffe737003
+  data.tar.gz: e1ca295dc2a19a4c16ecb2b69ef3ad28cd353c5f5b17db90749d29c8b9eb3f79
 SHA512:
-  metadata.gz: fa19e009a6af98f69b797a88fd0ce3e09c9cd74d0bed99fdcabf4c15e78435179736e66d5d18e0e2c66c44d6343ab75e443b3d8577b37beb91ed13065f00bf4c
-  data.tar.gz: e055226106abe328b92d84da1f63e2d3e3ef22168cf3716837e96a7491249862894d98fa49edd92681083d6617787701411e51dab391322f1259af86a730149f
+  metadata.gz: 88f12ba8750400ac78ae399d0b1f1301a7d12626286d780a04268af16bc1fab58f2da168b8802766f631fb09327518ca0f6927e2b57f6c03a79b3ec4439b9033
+  data.tar.gz: f721594b1cf537dc05f7d999f99626814f88f3488bf8f2c3c67fa197214f24a1b5513a25e616666c2c8a840cd3b33c616517e8eb35eee9c169a21a3e63ad86ea

data/lib/redis_client/cluster/pub_sub.rb

@@ -3,12 +3,45 @@
 class RedisClient
   class Cluster
     class PubSub
-      MAX_THREADS = Integer(ENV.fetch('REDIS_CLIENT_MAX_THREADS', 5))
+      class State
+        def initialize(client)
+          @client = client
+          @worker = nil
+        end
+
+        def call(command)
+          @client.call_v(command)
+        end
+
+        def close
+          @worker.exit if @worker&.alive?
+          @client.close
+        end
+
+        def take_message(timeout)
+          @worker = subscribe(@client, timeout) if @worker.nil?
+          return if @worker.join(0.01).nil?
+
+          message = @worker[:reply]
+          @worker = nil
+          message
+        end
+
+        private
+
+        def subscribe(client, timeout)
+          Thread.new(client, timeout) do |pubsub, to|
+            Thread.current[:reply] = pubsub.next_event(to)
+          rescue StandardError => e
+            Thread.current[:reply] = e
+          end
+        end
+      end
 
       def initialize(router, command_builder)
         @router = router
         @command_builder = command_builder
-        @pubsub_states = {}
+        @states = {}
       end
 
       def call(*args, **kwargs)
@@ -20,46 +53,39 @@ class RedisClient
       end
 
       def close
-        @pubsub_states.each_value(&:close)
-        @pubsub_states.clear
+        @states.each_value(&:close)
+        @states.clear
       end
 
       def next_event(timeout = nil)
-        return if @pubsub_states.empty?
+        return if @states.empty?
 
-        msgs = collect_messages(timeout).compact
-        return msgs.first if msgs.size < 2
+        max_duration = calc_max_duration(timeout)
+        starting = obtain_current_time
+        loop do
+          break if max_duration > 0 && obtain_current_time - starting > max_duration
 
-        msgs
+          @states.each_value do |pubsub|
+            message = pubsub.take_message(timeout)
+            return message if message
+          end
+        end
       end
 
       private
 
       def _call(command)
         node_key = @router.find_node_key(command)
-        pubsub = if @pubsub_states.key?(node_key)
-                   @pubsub_states[node_key]
-                 else
-                   @pubsub_states[node_key] = @router.find_node(node_key).pubsub
-                 end
-        pubsub.call_v(command)
+        @states[node_key] = State.new(@router.find_node(node_key).pubsub) unless @states.key?(node_key)
+        @states[node_key].call(command)
       end
 
-      def collect_messages(timeout) # rubocop:disable Metrics/AbcSize
-        @pubsub_states.each_slice(MAX_THREADS).each_with_object([]) do |chuncked_pubsub_states, acc|
-          threads = chuncked_pubsub_states.map do |_, v|
-            Thread.new(v) do |pubsub|
-              Thread.current[:reply] = pubsub.next_event(timeout)
-            rescue StandardError => e
-              Thread.current[:reply] = e
-            end
-          end
+      def obtain_current_time
+        Process.clock_gettime(Process::CLOCK_MONOTONIC, :microsecond)
+      end
 
-          threads.each do |t|
-            t.join
-            acc << t[:reply] unless t[:reply].nil?
-          end
-        end
+      def calc_max_duration(timeout)
+        timeout.nil? || timeout < 0 ? 0 : timeout * 1_000_000
       end
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: redis-cluster-client
 version: !ruby/object:Gem::Version
-  version: 0.4.5
+  version: 0.4.7
 platform: ruby
 authors:
 - Taishi Kasuga
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-08-09 00:00:00.000000000 Z
+date: 2023-08-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: redis-client