redis-cluster-client 0.3.8 → 0.3.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 18f675a5c604e59eed84fc2b90de0b42ddfbddfe947ccdee442fdf39f379270a
-  data.tar.gz: bf3962c29e9df010c2ef25ea226c5e041bf120ca65ae2392ab0a251a21276b44
+  metadata.gz: 2e617645bfcf37192c1c665ceaee819439ee26821688906d311dd3792fc6c7d5
+  data.tar.gz: c9a3125c8d012dfc937464aa37751c26e35fa8a7696a3b418a87f7019b263a06
 SHA512:
-  metadata.gz: 1a8894042ac085a832548195a519095c73036d0da1ce4f3f543d675f272751fb46af42defe9a83f5dc0aea1681c1abc6b82a98c44d9b855ddbe7005a04b8cfa8
-  data.tar.gz: ef2f92ee572dae262b3eb4e94c198e5618ad013343636fd5442d3da46b0ec48f433fd977a723d624d8a14e93a5315631ad8cb72a16ad3d46ad918186197a0070
+  metadata.gz: b2a815abb356acc39f0e842b5ecef6dd3d997b7554db351f7804289d386d8178221cab843e2144affceb55e849e52c672a99c49e51ef12d54000d0ee2b754f91
+  data.tar.gz: f19f384f8928b1487d45fb7171b4af70becc6b34a5da9a7e9dc15050d88035123f9b8e08c979c01a59fce6581337a9155d4ba1a221397a4948b1aeadceee5957

data/lib/redis_client/cluster/node/latency_replica.rb

@@ -21,7 +21,7 @@ class RedisClient
           @replications.each_value { |keys| keys.sort_by! { |k| latencies.fetch(k) } }
           @replica_clients = select_replica_clients(@replications, @clients)
           @clients_for_scanning = select_clients_for_scanning(@replications, @clients)
-          @existed_replicas = @replications.reject { |_, v| v.empty? }.values
+          @existed_replicas = @replications.values.reject(&:empty?)
         end
 
         def clients_for_scanning(seed: nil) # rubocop:disable Lint/UnusedMethodArgument

data/lib/redis_client/cluster/node.rb

@@ -18,10 +18,12 @@ class RedisClient
       MAX_STARTUP_SAMPLE = 37
       MAX_THREADS = Integer(ENV.fetch('REDIS_CLIENT_MAX_THREADS', 5))
       IGNORE_GENERIC_CONFIG_KEYS = %i[url host port path].freeze
+      SLOT_OPTIMIZATION_STRING = '0' * SLOT_SIZE
 
       ReloadNeeded = Class.new(::RedisClient::Error)
+
       Info = Struct.new(
-        'RedisNode',
+        'RedisClusterNode',
         :id, :node_key, :role, :primary_id, :ping_sent,
         :pong_recv, :config_epoch, :link_state, :slots,
         keyword_init: true
@@ -35,23 +37,27 @@ class RedisClient
         end
       end
 
-      SLOT_OPTIMIZATION_MAX_SHARD_SIZE = 256
-      SLOT_OPTIMIZATION_STRING = '0' * SLOT_SIZE
-      Slot = Struct.new('RedisSlot', :slots, :primary_node_keys, keyword_init: true) do
-        def [](slot)
-          primary_node_keys[slots.getbyte(slot)]
+      Slot = Struct.new('StringArray', :string, :elements, keyword_init: true) do
+        def [](index)
+          raise IndexError if index < 0
+          return if index >= string.bytesize
+
+          elements[string.getbyte(index)]
         end
 
-        def []=(slot, primary_node_key)
-          index = primary_node_keys.find_index(primary_node_key)
-          if index.nil?
-            raise(::RedisClient::Cluster::Node::ReloadNeeded, primary_node_key) if primary_node_keys.size >= SLOT_OPTIMIZATION_MAX_SHARD_SIZE
+        def []=(index, element)
+          raise IndexError if index < 0
+          return if index >= string.bytesize
+
+          pos = elements.find_index(element) # O(N)
+          if pos.nil?
+            raise(RangeError, 'full of elements') if elements.size >= 256
 
-            index = primary_node_keys.size
-            primary_node_keys << primary_node_key
+            pos = elements.size
+            elements << element
           end
 
-          slots.setbyte(slot, index)
+          string.setbyte(index, pos)
         end
       end
 
@@ -229,7 +235,12 @@ class RedisClient
       def update_slot(slot, node_key)
         return if @mutex.locked?
 
-        @mutex.synchronize { @slots[slot] = node_key }
+        @mutex.synchronize do
+          @slots[slot] = node_key
+        rescue RangeError
+          @slots = Array.new(SLOT_SIZE) { |i| @slots[i] }
+          @slots[slot] = node_key
+        end
       end
 
       private
@@ -256,11 +267,11 @@ class RedisClient
       end
 
       def make_array_for_slot_node_mappings(node_info_list)
-        return Array.new(SLOT_SIZE) if node_info_list.count(&:primary?) > SLOT_OPTIMIZATION_MAX_SHARD_SIZE
+        return Array.new(SLOT_SIZE) if node_info_list.count(&:primary?) > 256
 
         ::RedisClient::Cluster::Node::Slot.new(
-          slots: String.new(SLOT_OPTIMIZATION_STRING, encoding: Encoding::BINARY, capacity: SLOT_SIZE),
-          primary_node_keys: node_info_list.select(&:primary?).map(&:node_key)
+          string: String.new(SLOT_OPTIMIZATION_STRING, encoding: Encoding::BINARY, capacity: SLOT_SIZE),
+          elements: node_info_list.select(&:primary?).map(&:node_key)
         )
       end
 

data/lib/redis_client/cluster/normalized_cmd_name.rb

@@ -57,11 +57,12 @@ class RedisClient
       end
 
       def normalize(name)
-        return @cache[name] if @cache.key?(name)
+        return @cache[name] || name.to_s.downcase if @cache.key?(name)
         return name.to_s.downcase if @mutex.locked?
 
-        @mutex.synchronize { @cache[name] = name.to_s.downcase }
-        @cache[name]
+        str = name.to_s.downcase
+        @mutex.synchronize { @cache[name] = str }
+        str
       end
     end
   end

data/lib/redis_client/cluster/router.rb

@@ -12,6 +12,7 @@ class RedisClient
   class Cluster
     class Router
       ZERO_CURSOR_FOR_SCAN = '0'
+      METHODS_FOR_BLOCKING_CMD = %i[blocking_call_v blocking_call].freeze
 
       attr_reader :node
 
@@ -91,7 +92,7 @@ class RedisClient
           raise
         end
       rescue ::RedisClient::ConnectionError => e
-        raise if method == :blocking_call_v || (method == :blocking_call && e.is_a?(RedisClient::ReadTimeoutError))
+        raise if METHODS_FOR_BLOCKING_CMD.include?(method) && e.is_a?(RedisClient::ReadTimeoutError)
         raise if retry_count <= 0
 
         update_cluster_info!

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: redis-cluster-client
 version: !ruby/object:Gem::Version
-  version: 0.3.8
+  version: 0.3.10
 platform: ruby
 authors:
 - Taishi Kasuga
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-09-24 00:00:00.000000000 Z
+date: 2022-09-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: redis-client