redis-cluster-client 0.3.3 → 0.3.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1eaec04db89e1afa8a1d0a27688194d5941a94edb00aef979b1f368d01b4dd41
-  data.tar.gz: 36571e86def197fc3633d4c026958fbe635576d5f9aec3ab19b32759957a8f14
+  metadata.gz: a697c2bd33f615cb435ee48c11c301bba56cad4eac139f30db70a183d888d891
+  data.tar.gz: 52200e9400bd7bd7fde2019c52b6cf1e26c6c019cbf1ed12a25c2167cd7ac129
 SHA512:
-  metadata.gz: 2da9f21f30cc49f9df64cf11ed5ee3c0385bc6310bbb7e8cf3478552272f716ab68928aee05bb90b24d39253040f170fd38df78687afb78ea612f310f6a96b2e
-  data.tar.gz: 4f7828b8072f01aaa5aa56264d7fda6f8d4ff17bce7a88a5adb2c05bd5eab8a74fe137b3c59ce1bba086a9793a05d490252d0df94228e35c6c10a2b0d869d797
+  metadata.gz: 05dc86fd1aa3cbf3cd3f0fa43d9d1c8463fcbe9e0ce1bcfe094f6095fd92d878a4bb21e6d6fa62203e91f3dc642e5869552f0b83d579cfa158b791501e1cb600
+  data.tar.gz: 8f80c5072d4d1bdbeb3e2cb4c9f92493537a6d9002edd71426598844ba28a497171c055135bb19a1d89a325c194026195100f9a0aea89c0beac3d8e9424f7f58

data/lib/redis_client/cluster/command.rb

@@ -2,10 +2,13 @@
 
 require 'redis_client'
 require 'redis_client/cluster/errors'
+require 'redis_client/cluster/normalized_cmd_name'
 
 class RedisClient
   class Cluster
     class Command
+      EMPTY_STRING = ''
+
       class << self
         def load(nodes) # rubocop:disable Metrics/MethodLength
           errors = []
@@ -29,7 +32,10 @@ class RedisClient
 
         def parse_command_details(rows)
           rows&.reject { |row| row[0].nil? }.to_h do |row|
-            [row[0].downcase, { arity: row[1], flags: row[2], first: row[3], last: row[4], step: row[5] }]
+            [
+              ::RedisClient::Cluster::NormalizedCmdName.instance.get_by_name(row[0]),
+              { arity: row[1], flags: row[2], first: row[3], last: row[4], step: row[5] }
+            ]
           end
         end
       end
@@ -40,7 +46,7 @@ class RedisClient
 
       def extract_first_key(command)
         i = determine_first_key_position(command)
-        return '' if i == 0
+        return EMPTY_STRING if i == 0
 
         key = (command[i].is_a?(Array) ? command[i].flatten.first : command[i]).to_s
         hash_tag = extract_hash_tag(key)
@@ -56,7 +62,8 @@ class RedisClient
       end
 
       def exists?(name)
-        @details.key?(name.to_s.downcase)
+        key = ::RedisClient::Cluster::NormalizedCmdName.instance.get_by_name(name)
+        @details.key?(key)
       end
 
       private
@@ -72,14 +79,14 @@ class RedisClient
       end
 
       def dig_details(command, key)
-        name = command&.flatten&.first.to_s.downcase # OPTIMIZE: prevent allocation for string
+        name = ::RedisClient::Cluster::NormalizedCmdName.instance.get_by_command(command)
         return if name.empty? || !@details.key?(name)
 
         @details.fetch(name).fetch(key)
       end
 
       def determine_first_key_position(command) # rubocop:disable Metrics/CyclomaticComplexity, Metrics/MethodLength
-        case command&.flatten&.first.to_s.downcase # OPTIMIZE: prevent allocation for string
+        case ::RedisClient::Cluster::NormalizedCmdName.instance.get_by_command(command)
         when 'eval', 'evalsha', 'zinterstore', 'zunionstore' then 3
         when 'object' then 2
         when 'memory'
@@ -104,7 +111,7 @@ class RedisClient
         s = key.index('{')
         e = key.index('}', s.to_i + 1)
 
-        return '' if s.nil? || e.nil?
+        return EMPTY_STRING if s.nil? || e.nil?
 
         key[s + 1..e - 1]
       end

data/lib/redis_client/cluster/node/latency_replica.rb

@@ -40,12 +40,12 @@ class RedisClient
         private
 
         def measure_latencies(clients) # rubocop:disable Metrics/MethodLength, Metrics/AbcSize
-          latencies = {}
-
+          latencies = nil
           clients.each_slice(::RedisClient::Cluster::Node::MAX_THREADS) do |chuncked_clients|
             threads = chuncked_clients.map do |k, v|
               Thread.new(k, v) do |node_key, client|
                 Thread.pass
+                Thread.current.thread_variable_set(:node_key, node_key)
 
                 min = DUMMY_LATENCY_NSEC
                 MEASURE_ATTEMPT_COUNT.times do
@@ -55,13 +55,17 @@ class RedisClient
                   min = duration if duration < min
                 end
 
-                latencies[node_key] = min
+                Thread.current.thread_variable_set(:latency, min)
               rescue StandardError
-                latencies[node_key] = DUMMY_LATENCY_NSEC
+                Thread.current.thread_variable_set(:latency, DUMMY_LATENCY_NSEC)
               end
             end
 
-            threads.each(&:join)
+            threads.each do |t|
+              t.join
+              latencies ||= {}
+              latencies[t.thread_variable_get(:node_key)] = t.thread_variable_get(:latency)
+            end
           end
 
           latencies

data/lib/redis_client/cluster/node.rb

@@ -39,27 +39,36 @@ class RedisClient
       class << self
         def load_info(options, **kwargs) # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/MethodLength, Metrics/PerceivedComplexity
           startup_size = options.size > MAX_STARTUP_SAMPLE ? MAX_STARTUP_SAMPLE : options.size
-          node_info_list = Array.new(startup_size)
-          errors = Array.new(startup_size)
+          node_info_list = errors = nil
           startup_options = options.to_a.sample(MAX_STARTUP_SAMPLE).to_h
           startup_nodes = ::RedisClient::Cluster::Node.new(startup_options, **kwargs)
           startup_nodes.each_slice(MAX_THREADS).with_index do |chuncked_startup_nodes, chuncked_idx|
             threads = chuncked_startup_nodes.each_with_index.map do |raw_client, idx|
               Thread.new(raw_client, (MAX_THREADS * chuncked_idx) + idx) do |cli, i|
                 Thread.pass
+                Thread.current.thread_variable_set(:index, i)
                 reply = cli.call('CLUSTER', 'NODES')
-                node_info_list[i] = parse_node_info(reply)
+                Thread.current.thread_variable_set(:info, parse_node_info(reply))
               rescue StandardError => e
-                errors[i] = e
+                Thread.current.thread_variable_set(:error, e)
               ensure
                 cli&.close
               end
             end
 
-            threads.each(&:join)
+            threads.each do |t|
+              t.join
+              if t.thread_variable?(:info)
+                node_info_list ||= Array.new(startup_size)
+                node_info_list[t.thread_variable_get(:index)] = t.thread_variable_get(:info)
+              elsif t.thread_variable?(:error)
+                errors ||= Array.new(startup_size)
+                errors[t.thread_variable_get(:index)] = t.thread_variable_get(:error)
+              end
+            end
           end
 
-          raise ::RedisClient::Cluster::InitialSetupError, errors if node_info_list.all?(&:nil?)
+          raise ::RedisClient::Cluster::InitialSetupError, errors if node_info_list.nil?
 
           grouped = node_info_list.compact.group_by do |rows|
             rows.sort_by { |row| row[:id] }
@@ -147,7 +156,7 @@ class RedisClient
 
       def send_ping(method, command, args, &block)
         result_values, errors = call_multiple_nodes(@topology.clients, method, command, args, &block)
-        return result_values if errors.empty?
+        return result_values if errors.nil? || errors.empty?
 
         raise ReloadNeeded if errors.values.any?(::RedisClient::ConnectionError)
 
@@ -228,26 +237,35 @@ class RedisClient
 
       def call_multiple_nodes!(clients, method, command, args, &block)
         result_values, errors = call_multiple_nodes(clients, method, command, args, &block)
-        return result_values if errors.empty?
+        return result_values if errors.nil? || errors.empty?
 
         raise ::RedisClient::Cluster::ErrorCollection, errors
       end
 
-      def try_map(clients) # rubocop:disable Metrics/MethodLength
-        results = {}
-        errors = {}
+      def try_map(clients) # rubocop:disable Metrics/MethodLength, Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
+        results = errors = nil
         clients.each_slice(MAX_THREADS) do |chuncked_clients|
           threads = chuncked_clients.map do |k, v|
             Thread.new(k, v) do |node_key, client|
               Thread.pass
+              Thread.current.thread_variable_set(:node_key, node_key)
               reply = yield(node_key, client)
-              results[node_key] = reply unless reply.nil?
+              Thread.current.thread_variable_set(:result, reply)
             rescue StandardError => e
-              errors[node_key] = e
+              Thread.current.thread_variable_set(:error, e)
             end
           end
 
-          threads.each(&:join)
+          threads.each do |t|
+            t.join
+            if t.thread_variable?(:result)
+              results ||= {}
+              results[t.thread_variable_get(:node_key)] = t.thread_variable_get(:result)
+            elsif t.thread_variable?(:error)
+              errors ||= {}
+              errors[t.thread_variable_get(:node_key)] = t.thread_variable_get(:error)
+            end
+          end
         end
 
         [results, errors]

data/lib/redis_client/cluster/normalized_cmd_name.rb

@@ -0,0 +1,67 @@
+# frozen_string_literal: true
+
+require 'singleton'
+
+class RedisClient
+  class Cluster
+    class NormalizedCmdName
+      include Singleton
+
+      EMPTY_STRING = ''
+
+      def initialize
+        @cache = {}
+        @mutex = Mutex.new
+      end
+
+      def get_by_command(command)
+        get(command, index: 0)
+      end
+
+      def get_by_subcommand(command)
+        get(command, index: 1)
+      end
+
+      def get_by_name(name)
+        get(name, index: 0)
+      end
+
+      def clear
+        @mutex.synchronize { @cache.clear }
+      end
+
+      private
+
+      def get(command, index:)
+        name = extract_name(command, index: index)
+        return EMPTY_STRING if name.nil? || name.empty?
+
+        normalize(name)
+      end
+
+      def extract_name(command, index:)
+        case command
+        when String, Symbol then index.zero? ? command : nil
+        when Array then extract_name_from_array(command, index: index)
+        end
+      end
+
+      def extract_name_from_array(command, index:)
+        return if command.size - 1 < index
+
+        case e = command[index]
+        when String, Symbol then e
+        when Array then e[index]
+        end
+      end
+
+      def normalize(name)
+        return @cache[name] if @cache.key?(name)
+        return name.to_s.downcase if @mutex.locked?
+
+        @mutex.synchronize { @cache[name] = name.to_s.downcase }
+        @cache[name]
+      end
+    end
+  end
+end

data/lib/redis_client/cluster/pipeline.rb

@@ -20,37 +20,37 @@ class RedisClient
       def call(*args, **kwargs, &block)
         command = @command_builder.generate(args, kwargs)
         node_key = @router.find_node_key(command, seed: @seed)
-        add_line(node_key, [@size, :call_v, command, block])
+        add_row(node_key, [@size, :call_v, command, block])
       end
 
       def call_v(args, &block)
         command = @command_builder.generate(args)
         node_key = @router.find_node_key(command, seed: @seed)
-        add_line(node_key, [@size, :call_v, command, block])
+        add_row(node_key, [@size, :call_v, command, block])
       end
 
       def call_once(*args, **kwargs, &block)
         command = @command_builder.generate(args, kwargs)
         node_key = @router.find_node_key(command, seed: @seed)
-        add_line(node_key, [@size, :call_once_v, command, block])
+        add_row(node_key, [@size, :call_once_v, command, block])
       end
 
       def call_once_v(args, &block)
         command = @command_builder.generate(args)
         node_key = @router.find_node_key(command, seed: @seed)
-        add_line(node_key, [@size, :call_once_v, command, block])
+        add_row(node_key, [@size, :call_once_v, command, block])
       end
 
       def blocking_call(timeout, *args, **kwargs, &block)
         command = @command_builder.generate(args, kwargs)
         node_key = @router.find_node_key(command, seed: @seed)
-        add_line(node_key, [@size, :blocking_call_v, timeout, command, block])
+        add_row(node_key, [@size, :blocking_call_v, timeout, command, block])
       end
 
       def blocking_call_v(timeout, args, &block)
         command = @command_builder.generate(args)
         node_key = @router.find_node_key(command, seed: @seed)
-        add_line(node_key, [@size, :blocking_call_v, timeout, command, block])
+        add_row(node_key, [@size, :blocking_call_v, timeout, command, block])
       end
 
       def empty?
@@ -59,41 +59,57 @@ class RedisClient
 
       # TODO: https://github.com/redis-rb/redis-cluster-client/issues/37 handle redirections
       def execute # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/MethodLength, Metrics/PerceivedComplexity
-        all_replies = Array.new(@size)
-        errors = {}
+        all_replies = errors = nil
         @grouped.each_slice(MAX_THREADS) do |chuncked_grouped|
           threads = chuncked_grouped.map do |k, v|
             Thread.new(@router, k, v) do |router, node_key, rows|
               Thread.pass
-              replies = router.find_node(node_key).pipelined do |pipeline|
-                rows.each do |(_size, *row, block)|
-                  pipeline.send(*row, &block)
-                end
-              end
-
+              replies = do_pipelining(router.find_node(node_key), rows)
               raise ReplySizeError, "commands: #{rows.size}, replies: #{replies.size}" if rows.size != replies.size
 
-              rows.each_with_index { |row, idx| all_replies[row.first] = replies[idx] }
+              Thread.current.thread_variable_set(:rows, rows)
+              Thread.current.thread_variable_set(:replies, replies)
             rescue StandardError => e
-              errors[node_key] = e
+              Thread.current.thread_variable_set(:node_key, node_key)
+              Thread.current.thread_variable_set(:error, e)
             end
           end
 
-          threads.each(&:join)
+          threads.each do |t|
+            t.join
+            if t.thread_variable?(:replies)
+              all_replies ||= Array.new(@size)
+              t.thread_variable_get(:rows).each_with_index { |r, i| all_replies[r.first] = t.thread_variable_get(:replies)[i] }
+            elsif t.thread_variable?(:error)
+              errors ||= {}
+              errors[t.thread_variable_get(:node_key)] = t.thread_variable_get(:error)
+            end
+          end
         end
 
-        return all_replies if errors.empty?
+        return all_replies if errors.nil?
 
         raise ::RedisClient::Cluster::ErrorCollection, errors
       end
 
       private
 
-      def add_line(node_key, line)
+      def add_row(node_key, row)
         @grouped[node_key] = [] unless @grouped.key?(node_key)
-        @grouped[node_key] << line
+        @grouped[node_key] << row
         @size += 1
       end
+
+      def do_pipelining(node, rows)
+        node.pipelined do |pipeline|
+          rows.each do |row|
+            case row.size
+            when 4 then pipeline.send(row[1], row[2], &row[3])
+            when 5 then pipeline.send(row[1], row[2], row[3], &row[4])
+            end
+          end
+        end
+      end
     end
   end
 end

data/lib/redis_client/cluster/router.rb

@@ -6,6 +6,7 @@ require 'redis_client/cluster/errors'
 require 'redis_client/cluster/key_slot_converter'
 require 'redis_client/cluster/node'
 require 'redis_client/cluster/node_key'
+require 'redis_client/cluster/normalized_cmd_name'
 
 class RedisClient
   class Cluster
@@ -25,7 +26,7 @@ class RedisClient
       end
 
       def send_command(method, command, *args, &block) # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/MethodLength, Metrics/PerceivedComplexity
-        cmd = command.first.to_s.downcase
+        cmd = ::RedisClient::Cluster::NormalizedCmdName.instance.get_by_command(command)
         case cmd
         when 'acl', 'auth', 'bgrewriteaof', 'bgsave', 'quit', 'save'
           @node.call_all(method, command, args, &block).first
@@ -65,7 +66,12 @@ class RedisClient
       # @see https://redis.io/topics/cluster-spec#redirection-and-resharding
       #   Redirection and resharding
       def try_send(node, method, command, args, retry_count: 3, &block) # rubocop:disable Metrics/MethodLength, Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
-        node.send(method, *args, command, &block)
+        if args.empty?
+          # prevent memory allocation for variable-length args
+          node.send(method, command, &block)
+        else
+          node.send(method, *args, command, &block)
+        end
       rescue ::RedisClient::CommandError => e
         raise if retry_count <= 0
 
@@ -193,7 +199,7 @@ class RedisClient
       end
 
       def send_config_command(method, command, args, &block)
-        case command[1].to_s.downcase
+        case ::RedisClient::Cluster::NormalizedCmdName.instance.get_by_subcommand(command)
         when 'resetstat', 'rewrite', 'set'
           @node.call_all(method, command, args, &block).first
         else assign_node(command).send(method, *args, command, &block)
@@ -201,7 +207,7 @@ class RedisClient
       end
 
       def send_memory_command(method, command, args, &block)
-        case command[1].to_s.downcase
+        case ::RedisClient::Cluster::NormalizedCmdName.instance.get_by_subcommand(command)
         when 'stats' then @node.call_all(method, command, args, &block)
         when 'purge' then @node.call_all(method, command, args, &block).first
         else assign_node(command).send(method, *args, command, &block)
@@ -209,7 +215,7 @@ class RedisClient
       end
 
       def send_client_command(method, command, args, &block)
-        case command[1].to_s.downcase
+        case ::RedisClient::Cluster::NormalizedCmdName.instance.get_by_subcommand(command)
         when 'list' then @node.call_all(method, command, args, &block).flatten
         when 'pause', 'reply', 'setname'
           @node.call_all(method, command, args, &block).first
@@ -217,10 +223,8 @@ class RedisClient
         end
       end
 
-      def send_cluster_command(method, command, args, &block) # rubocop:disable Metrics/MethodLength
-        subcommand = command[1].to_s.downcase
-
-        case subcommand
+      def send_cluster_command(method, command, args, &block)
+        case subcommand = ::RedisClient::Cluster::NormalizedCmdName.instance.get_by_subcommand(command)
         when 'addslots', 'delslots', 'failover', 'forget', 'meet', 'replicate',
              'reset', 'set-config-epoch', 'setslot'
           raise ::RedisClient::Cluster::OrchestrationCommandNotSupported, ['cluster', subcommand]
@@ -234,7 +238,7 @@ class RedisClient
       end
 
       def send_script_command(method, command, args, &block)
-        case command[1].to_s.downcase
+        case ::RedisClient::Cluster::NormalizedCmdName.instance.get_by_subcommand(command)
         when 'debug', 'kill'
           @node.call_all(method, command, args, &block).first
         when 'flush', 'load'
@@ -244,7 +248,7 @@ class RedisClient
       end
 
       def send_pubsub_command(method, command, args, &block) # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
-        case command[1].to_s.downcase
+        case ::RedisClient::Cluster::NormalizedCmdName.instance.get_by_subcommand(command)
         when 'channels' then @node.call_all(method, command, args, &block).flatten.uniq.sort_by(&:to_s)
         when 'numsub'
           @node.call_all(method, command, args, &block).reject(&:empty?).map { |e| Hash[*e] }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: redis-cluster-client
 version: !ruby/object:Gem::Version
-  version: 0.3.3
+  version: 0.3.5
 platform: ruby
 authors:
 - Taishi Kasuga
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-09-18 00:00:00.000000000 Z
+date: 2022-09-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: redis-client
@@ -42,6 +42,7 @@ files:
 - lib/redis_client/cluster/node/random_replica.rb
 - lib/redis_client/cluster/node/replica_mixin.rb
 - lib/redis_client/cluster/node_key.rb
+- lib/redis_client/cluster/normalized_cmd_name.rb
 - lib/redis_client/cluster/pipeline.rb
 - lib/redis_client/cluster/pub_sub.rb
 - lib/redis_client/cluster/router.rb