redis-client 0.7.2 → 0.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 81e19420827bc96f40097f45a68660c9158a72de1bf181a4a1713d12630964f0
-  data.tar.gz: ea48a355e633b2b54415e06b1fdff363879296ffb67085b97ee67ee52ec0e4dd
+  metadata.gz: e7e7b7923ecb86353521db31036b3c5678683fcb6ed8ec5799c1ca6c6b5fcd44
+  data.tar.gz: 9e782f9884b2f12eb0c58ca701da62e8945a14a1eca27c3052adbb0a1e4fe428
 SHA512:
-  metadata.gz: a01f575d01adb1260d01be754ccbd3e39d03415ed4ce4f28998bfe081b298eff041a39acefbc594a058647968e6d9e5ae245f58dc05889243428abd731fc01e8
-  data.tar.gz: '099a087f0f32deb096302080128b817f0472be41bdce36e4df05d0d3404b2329661aa353491a388a671765349bf170c76c1284d84ffa24981ef3e46647225770'
+  metadata.gz: c77d09a8330bbcc4e8b2329a1ff9e660bb2c5ddf35cccafcf89f0b37ef9d89f579fa32b9ec7a7f64eecff12941ac835e4424dcf7ab9fdef12fc01ae73250959f
+  data.tar.gz: 4c16639282ca539e04d07d363c28e663a5e409f6c6d9deef856158fe8d46a1e20669b44c025e978dc04965106148e1fd7fcd82cc1d50abc8c27fb4694b825e2e

data/CHANGELOG.md

@@ -1,5 +1,17 @@
 # Unreleased
 
+# 0.8.0
+
+- Add a `connect` interface to the instrumentation API.
+
+# 0.7.4
+
+- Properly parse script errors on pre 7.0 redis server.
+
+# 0.7.3
+
+- Fix a bug in `url` parsing conflicting with the `path` option.
+
 # 0.7.2
 
 - Raise a distinct `RedisClient::OutOfMemoryError`, for Redis `OOM` errors.

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    redis-client (0.7.2)
+    redis-client (0.8.0)
       connection_pool
 
 GEM
@@ -38,7 +38,7 @@ GEM
     rubocop-minitest (0.19.1)
       rubocop (>= 0.90, < 2.0)
     ruby-progressbar (1.11.0)
-    stackprof (0.2.19)
+    stackprof (0.2.21)
     toxiproxy (2.0.2)
     unicode-display_width (2.2.0)
 

data/README.md

@@ -349,6 +349,10 @@ end
 
 ```ruby
 module MyRedisInstrumentation
+  def connect(redis_config)
+    MyMonitoringService.instrument("redis.connect") { super }
+  end
+
   def call(command, redis_config)
     MyMonitoringService.instrument("redis.query") { super }
   end

data/lib/redis_client/config.rb

@@ -149,8 +149,8 @@ class RedisClient
           URI.decode_www_form_component(uri.password)
         end
 
-        path = uri.path&.delete_prefix("/")
-        kwargs[:db] ||= Integer(path) if path && !path.empty?
+        db_path = uri.path&.delete_prefix("/")
+        kwargs[:db] ||= Integer(db_path) if db_path && !db_path.empty?
       end
 
       super(**kwargs)

data/lib/redis_client/middlewares.rb

@@ -4,6 +4,10 @@ class RedisClient
   module Middlewares
     extend self
 
+    def connect(_config)
+      yield
+    end
+
     def call(command, _config)
       yield command
     end

data/lib/redis_client/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 class RedisClient
-  VERSION = "0.7.2"
+  VERSION = "0.8.0"
 end

data/lib/redis_client.rb

@@ -94,7 +94,14 @@ class RedisClient
 
     class << self
       def parse(error_message)
-        code = error_message.split(' ', 2).first
+        code = if error_message.start_with?("ERR Error running script")
+          # On older redis servers script errors are nested.
+          # So we need to parse some more.
+          if (match = error_message.match(/:\s-([A-Z]+) /))
+            match[1]
+          end
+        end
+        code ||= error_message.split(' ', 2).first
         klass = ERRORS.fetch(code, self)
         klass.new(error_message)
       end
@@ -638,12 +645,14 @@ class RedisClient
   end
 
   def connect
-    connection = config.driver.new(
-      config,
-      connect_timeout: connect_timeout,
-      read_timeout: read_timeout,
-      write_timeout: write_timeout,
-    )
+    connection = Middlewares.connect(config) do
+      config.driver.new(
+        config,
+        connect_timeout: connect_timeout,
+        read_timeout: read_timeout,
+        write_timeout: write_timeout,
+      )
+    end
 
     prelude = config.connection_prelude.dup
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: redis-client
 version: !ruby/object:Gem::Version
-  version: 0.7.2
+  version: 0.8.0
 platform: ruby
 authors:
 - Jean Boussier
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-09-05 00:00:00.000000000 Z
+date: 2022-09-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: connection_pool