redis-client 0.23.0 → 0.24.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 588c7b4963a757c4d297236e15e0fd2b84d1137f42f14ca26dcfdf3349588126
-  data.tar.gz: cc68ebf122ca5c9044c9c0e08713071e60b151c526f37699d7fa5d28c2e52e5f
+  metadata.gz: 7c3cb528ecb15130b80ce97d00a5e0e45c31edfc6147068516e1a52295a94045
+  data.tar.gz: b4517fbd99d0f3997e510b6d0d56c345c1fceb1ad44fcac59cceb28faf4326b5
 SHA512:
-  metadata.gz: 3a23804a8dbf13a35f8dae709586c44b3b81bd4d6d671ed79890b734b9e722f996c6d514bc609da511a0695deeefbfdfafcf8545fd6a0f7d8144d1936f72f417
-  data.tar.gz: 1be3aff9e63209a7424c0078f1fe26d8f45212034f0a8d18fa8cb778f7bdb12200effa4796082dd7a1096f18f840cdf84ddff8a9ab3ff2ad6a552db9db595484
+  metadata.gz: dbc7fcacc084fcd9d765337ad48a2a8ee413eecfec48f1a166fbd58510299cf92b3e058ce08620055deadeca86464c2c25fe6cddcccab532ab3d2cd741f9cef0
+  data.tar.gz: '09164c4ea9f7021d58df97690f78e7940821a44eb7e12cc4c25324bd17e0e784f447443accedbe2299e6d8c0a0a6f15391491465c4c32baaa56286501b77b693'

data/CHANGELOG.md

@@ -1,5 +1,18 @@
 # Unreleased
 
+# 0.24.0
+
+- Allow `sentinel_password` to be provided as a `Proc`.
+- Ensure `Config#inspect` and `Config#to_s` do not display stored passwords.
+
+# 0.23.2
+
+- Fix retry logic not to attempt to retry on an open circuit breaker. Fix #227.
+
+# 0.23.1
+
+- Fix a potential crash in `hiredis-client` when using subcriptions (`next_event`). See #221.
+
 # 0.23.0
 
 - Allow `password` to be a callable. Makes it easy to implement short lived password authentication strategies.
@@ -67,6 +80,7 @@
 - Discard sockets rather than explictly close them when a fork is detected. #126.
 - Allow to configure sentinel client via url. #117.
 - Fix sentinel to preverse the auth/password when refreshing the sentinel list. #107.
+- Added `RedisClient#measure_round_trip_delay` method. #113.
 
 # 0.14.1
 

data/lib/redis_client/config.rb

@@ -40,7 +40,7 @@ class RedisClient
         circuit_breaker: nil
       )
         @username = username
-        @password = password
+        @password = password && !password.respond_to?(:call) ? ->(_) { password } : password
         @db = begin
           Integer(db || DEFAULT_DB)
         rescue ArgumentError
@@ -70,7 +70,6 @@ class RedisClient
 
         reconnect_attempts = Array.new(reconnect_attempts, 0).freeze if reconnect_attempts.is_a?(Integer)
         @reconnect_attempts = reconnect_attempts
-        @connection_prelude = (build_connection_prelude unless @password.respond_to?(:call))
 
         circuit_breaker = CircuitBreaker.new(**circuit_breaker) if circuit_breaker.is_a?(Hash)
         if @circuit_breaker = circuit_breaker
@@ -88,19 +87,36 @@ class RedisClient
       end
 
       def connection_prelude
-        if @password.respond_to?(:call)
-          build_connection_prelude
-        else
-          @connection_prelude
+        prelude = []
+        pass = password
+        if protocol == 3
+          prelude << if pass
+            ["HELLO", "3", "AUTH", username, pass]
+          else
+            ["HELLO", "3"]
+          end
+        elsif pass
+          prelude << if @username && !@username.empty?
+            ["AUTH", @username, pass]
+          else
+            ["AUTH", pass]
+          end
         end
+
+        if @db && @db != 0
+          prelude << ["SELECT", @db.to_s]
+        end
+
+        # Deep freeze all the strings and commands
+        prelude.map! do |commands|
+          commands = commands.map { |str| str.frozen? ? str : str.dup.freeze }
+          commands.freeze
+        end
+        prelude.freeze
       end
 
       def password
-        if @password.respond_to?(:call)
-          @password.call(username)
-        else
-          @password
-        end
+        @password&.call(username)
       end
 
       def username
@@ -162,37 +178,6 @@ class RedisClient
         end
         url
       end
-
-      private
-
-      def build_connection_prelude
-        prelude = []
-        pass = password
-        if protocol == 3
-          prelude << if pass
-            ["HELLO", "3", "AUTH", username, pass]
-          else
-            ["HELLO", "3"]
-          end
-        elsif pass
-          prelude << if @username && !@username.empty?
-            ["AUTH", @username, pass]
-          else
-            ["AUTH", pass]
-          end
-        end
-
-        if @db && @db != 0
-          prelude << ["SELECT", @db.to_s]
-        end
-
-        # Deep freeze all the strings and commands
-        prelude.map! do |commands|
-          commands = commands.map { |str| str.frozen? ? str : str.dup.freeze }
-          commands.freeze
-        end
-        prelude.freeze
-      end
     end
 
     include Common

data/lib/redis_client/sentinel_config.rb

@@ -38,9 +38,14 @@ class RedisClient
       end
 
       @to_list_of_hash = @to_hash = nil
+      password = if sentinel_password && !sentinel_password.respond_to?(:call)
+        ->(_) { sentinel_password }
+      else
+        sentinel_password
+      end
       @extra_config = {
         username: sentinel_username,
-        password: sentinel_password,
+        password: password,
         db: nil,
       }
       if client_config[:protocol] == 2

data/lib/redis_client/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 class RedisClient
-  VERSION = "0.23.0"
+  VERSION = "0.24.0"
 end

data/lib/redis_client.rb

@@ -710,9 +710,14 @@ class RedisClient
         end
       rescue ConnectionError, ProtocolError => error
         preferred_error ||= error
-        preferred_error = error unless error.is_a?(CircuitBreaker::OpenCircuitError)
         close
 
+        if error.is_a?(CircuitBreaker::OpenCircuitError)
+          raise preferred_error
+        else
+          preferred_error = error
+        end
+
         if !@disable_reconnection && config.retry_connecting?(tries, error)
           tries += 1
           retry

metadata

@@ -1,14 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: redis-client
 version: !ruby/object:Gem::Version
-  version: 0.23.0
+  version: 0.24.0
 platform: ruby
 authors:
 - Jean Boussier
-autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-12-10 00:00:00.000000000 Z
+date: 2025-03-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: connection_pool
@@ -24,7 +23,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description:
 email:
 - jean.boussier@gmail.com
 executables: []
@@ -58,7 +56,6 @@ metadata:
   homepage_uri: https://github.com/redis-rb/redis-client
   source_code_uri: https://github.com/redis-rb/redis-client
   changelog_uri: https://github.com/redis-rb/redis-client/blob/master/CHANGELOG.md
-post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -73,8 +70,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3.1
-signing_key:
+rubygems_version: 3.6.2
 specification_version: 4
 summary: Simple low-level client for Redis 6+
 test_files: []