redis-client 0.17.1 → 0.19.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3e73c2e13870d3adcb345e544fe99bbffa6ad1bf5f7267203e49f838c56a7492
-  data.tar.gz: d090544eb97a93ad0d21d5a6c14c40ffb3ca384425ccf27d82c797f0f7e2d35a
+  metadata.gz: 920d97dcf258796ba88bb2f087fa89c1595dd245f67292c7432893848baacd0b
+  data.tar.gz: 07151d3aa036f7c513e7baa2cc94c22a7f9b4af8a09e132b1943716cd458c408
 SHA512:
-  metadata.gz: 60e0fbf2c30888ac05855af2ba6b145ac96e0e011cc58d989f66e9379baa549c9af1ad2f7077ce431b334d6b1318b83463eac7bcb7a323752c79644e0dbce495
-  data.tar.gz: 1e3e10ef87472a412239261c0642e134f9521e83e49def834bb76b1aa6481c8e8fc9b13cfe1916c0f0ed43af8799a331e9649caa61155ce9eeb8391b0c15c98a
+  metadata.gz: a6f664cf2c5fe77115606dc15e031e6bccc55c440b55d521ef5429653acb89bf55597dd4e5cd4892fb61f9452790a2ca41e32e72c6f824c7da9609987b14ff42
+  data.tar.gz: c6a34fe93aac6d5ae5c8995881e17581e64a762d0fdc3d3fe1772b07b1759196b2ca5a27e14e00c826399d03a1259f799c816ac1ca1ee001314d9b32f341ecb8

data/CHANGELOG.md

@@ -1,5 +1,19 @@
 # Unreleased
 
+# 0.19.1
+
+- Fixed a bug in `hiredis-client` that could cause a crash if interrupted by `Timeout.timeout` or other `Thread#raise` based mecanism.
+- Fixed a GC bug that could cause crashes in `hiredis-client`.
+
+# 0.19.0
+
+- Revalidate connection in `RedisClient#connected?`
+- Eagerly fail if `db:` isn't an Integer. #151.
+
+# 0.18.0
+
+- Expose more connection details such as `host`, `db`, etc on `RedisClient`.
+
 # 0.17.1
 
 - Add support for `NaN` in RESP3 protocol doubles.

data/Gemfile

@@ -6,7 +6,7 @@ source "https://rubygems.org"
 gemspec name: "redis-client"
 
 gem "minitest"
-gem "rake", "~> 13.0"
+gem "rake", "~> 13.1"
 gem "rake-compiler"
 gem "rubocop"
 gem "rubocop-minitest"

data/Gemfile.lock

@@ -1,14 +1,14 @@
 PATH
   remote: .
   specs:
-    redis-client (0.17.1)
+    redis-client (0.19.1)
       connection_pool
 
 GEM
   remote: https://rubygems.org/
   specs:
     ast (2.4.2)
-    benchmark-ips (2.12.0)
+    benchmark-ips (2.13.0)
     byebug (11.1.3)
     connection_pool (2.4.1)
     hiredis (0.6.3)
@@ -18,7 +18,7 @@ GEM
     parser (3.1.2.1)
       ast (~> 2.4.1)
     rainbow (3.1.1)
-    rake (13.0.6)
+    rake (13.1.0)
     rake-compiler (1.2.5)
       rake
     redis (4.6.0)
@@ -53,7 +53,7 @@ DEPENDENCIES
   byebug
   hiredis
   minitest
-  rake (~> 13.0)
+  rake (~> 13.1)
   rake-compiler
   redis (~> 4.6)
   redis-client!

data/lib/redis_client/config.rb

@@ -41,7 +41,12 @@ class RedisClient
       )
         @username = username
         @password = password
-        @db = db || DEFAULT_DB
+        @db = begin
+          Integer(db || DEFAULT_DB)
+        rescue ArgumentError
+          raise ArgumentError, "db: must be an Integer, got: #{db.inspect}"
+        end
+
         @id = id
         @ssl = ssl || false
 

data/lib/redis_client/ruby_connection.rb

@@ -148,6 +148,7 @@ class RedisClient
       )
       true
     rescue SystemCallError, OpenSSL::SSL::SSLError, SocketError => error
+      socket&.close
       raise CannotConnectError, error.message, error.backtrace
     end
 

data/lib/redis_client/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 class RedisClient
-  VERSION = "0.17.1"
+  VERSION = "0.19.1"
 end

data/lib/redis_client.rb

@@ -179,6 +179,38 @@ class RedisClient
     config.server_url
   end
 
+  def id
+    config.id
+  end
+
+  def timeout
+    config.read_timeout
+  end
+
+  def db
+    config.db
+  end
+
+  def host
+    config.host unless config.path
+  end
+
+  def port
+    config.port unless config.path
+  end
+
+  def path
+    config.path
+  end
+
+  def username
+    config.username
+  end
+
+  def password
+    config.password
+  end
+
   def size
     1
   end
@@ -190,17 +222,18 @@ class RedisClient
 
   def timeout=(timeout)
     super
-    raw_connection.read_timeout = raw_connection.write_timeout = timeout if connected?
+    @raw_connection&.read_timeout = timeout
+    @raw_connection&.write_timeout = timeout
   end
 
   def read_timeout=(timeout)
     super
-    raw_connection.read_timeout = timeout if connected?
+    @raw_connection&.read_timeout = timeout
   end
 
   def write_timeout=(timeout)
     super
-    raw_connection.write_timeout = timeout if connected?
+    @raw_connection&.write_timeout = timeout
   end
 
   def pubsub
@@ -354,7 +387,7 @@ class RedisClient
   end
 
   def connected?
-    @raw_connection&.connected?
+    @raw_connection&.revalidate
   end
 
   def close
@@ -637,6 +670,7 @@ class RedisClient
     elsif retryable
       tries = 0
       connection = nil
+      preferred_error = nil
       begin
         connection = raw_connection
         if block_given?
@@ -645,13 +679,15 @@ class RedisClient
           connection
         end
       rescue ConnectionError, ProtocolError => error
+        preferred_error ||= error
+        preferred_error = error unless error.is_a?(CircuitBreaker::OpenCircuitError)
         close
 
         if !@disable_reconnection && config.retry_connecting?(tries, error)
           tries += 1
           retry
         else
-          raise
+          raise preferred_error
         end
       end
     else

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: redis-client
 version: !ruby/object:Gem::Version
-  version: 0.17.1
+  version: 0.19.1
 platform: ruby
 authors:
 - Jean Boussier
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-10-22 00:00:00.000000000 Z
+date: 2023-12-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: connection_pool
@@ -77,7 +77,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.7
+rubygems_version: 3.4.10
 signing_key:
 specification_version: 4
 summary: Simple low-level client for Redis 6+