redirector 1.0.1 → 1.0.2

data/spec/features/middleware_spec.rb

@@ -33,9 +33,9 @@ describe 'Redirector middleware', :type => :feature do
   it 'should preserve the query string if the Redirector.preserve_query is true' do
     original_option = Redirector.preserve_query
     Redirector.preserve_query = true
-    visit '/my_custom_url/20?categoryID=12345'
+    visit '/my_custom_url/20?categoryID=43257'
     uri = URI.parse(current_url)
-    uri.query.should == 'categoryID=12345'
+    uri.query.should == 'categoryID=43257'
     current_path.should == '/news/20'
     Redirector.preserve_query = original_option
   end
@@ -60,13 +60,25 @@ describe 'Redirector middleware', :type => :feature do
     current_url.should == 'http://example.com:3000/news/5'
   end
 
-  it 'handles invalid URIs properly' do
-    bad_rule = create(:redirect_rule_regex, :destination => 'http://www.example.com$1', :source => '^/custom(.*)$')
+  it 'foregoes search if ignored path pattern is detected' do
+    original_option = Redirector.ignored_patterns
+    Redirector.ignored_patterns = [/^\/my_custom_url\/.+/]
 
-    begin
-      visit '/custom)e2'
-    rescue Redirector::RuleError => e
-      e.message.should == "RedirectRule #{bad_rule.id} generated the bad destination: http://www.example.com)e2"
+    visit '/my_custom_url/20'
+    current_path.should == '/my_custom_url/20'
+
+    Redirector.ignored_patterns = original_option
+  end
+
+  unless Rails.version =~ /\A4\.2\.\d\z/
+    it 'handles invalid URIs properly' do
+      bad_rule = create(:redirect_rule_regex, :destination => 'http://www.example.com$1', :source => '^/custom(.*)$')
+
+      begin
+        visit '/custom)e2'
+      rescue Redirector::RuleError => e
+        e.message.should == "RedirectRule #{bad_rule.id} generated the bad destination: http://www.example.com)e2"
+      end
     end
   end
 end

data/spec/models/redirect_rule_spec.rb

@@ -32,6 +32,15 @@ describe RedirectRule do
     new_rule.errors_on(:source).should == ['is an invalid regular expression']
   end
 
+  describe 'strip_source_whitespace before_save callback' do
+    it 'strips leading and trailing whitespace when saved' do
+      subject = FactoryGirl.build(:redirect_rule, :source => ' /needs-stripping ')
+
+      subject.save
+      subject.reload.source.should == '/needs-stripping'
+    end
+  end
+
   describe '.match_for' do
     it 'returns nil if there is no matching rule' do
       RedirectRule.match_for('/someplace', {}).should be_nil

metadata

@@ -1,35 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: redirector
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
 platform: ruby
 authors:
 - Brian Landau
 autorequire: 
 bindir: bin
-cert_chain:
-- |
-  -----BEGIN CERTIFICATE-----
-  MIIDOjCCAiKgAwIBAgIBADANBgkqhkiG9w0BAQUFADBDMRUwEwYDVQQDDAxicmlh
-  bmpsYW5kYXUxFTATBgoJkiaJk/IsZAEZFgVnbWFpbDETMBEGCgmSJomT8ixkARkW
-  A2NvbTAeFw0wNzEyMDUwMzA5NTBaFw0wODEyMDQwMzA5NTBaMEMxFTATBgNVBAMM
-  DGJyaWFuamxhbmRhdTEVMBMGCgmSJomT8ixkARkWBWdtYWlsMRMwEQYKCZImiZPy
-  LGQBGRYDY29tMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAvizK5bV4
-  NQARcbPgZpLkSaashTY2JgLqQbxw9en6F4JFQsAlalWvmPqaC65NUxpV+Yb7mK1e
-  Rx/6HBln8QeywVMwYTRvqYXXVn1MTLxnYLpLjQQrsM0vZIxwNsmQzrNqvvdGJRok
-  gSrJx8lnb3LkmO68N6mG1lETaviaPwWhlB8mu3kcDG9dDXLWbPLDO4wHIIMl+0Nb
-  wpyl7d4vteRAXOHmA+Ir5KkWloEhpPJ/WzUL4kxmvcqVSo04aEGsGecgkgSWfyID
-  7Z4KcE1dqjA1RjmeRHwxQilW49GkthB3CQhfhsjYJ3IYvUfiQIzDdrWLbJpxzShk
-  E1IpSLMiP4svBQIDAQABozkwNzAJBgNVHRMEAjAAMAsGA1UdDwQEAwIEsDAdBgNV
-  HQ4EFgQU00bxUNAS/W5tSWPDvnSlm3Tf9VYwDQYJKoZIhvcNAQEFBQADggEBAKUC
-  669HsZByRjaana3sE5Tyo59/Cb8LxphAS0s9rMtiQyh2sPIno02/pAKrC7S2qnwZ
-  8W71VKqROGnBhaSjWshwU0BjbcCpNDAE4YPLP3lUlP69FuGXbsqv9sYH1GKjgFHi
-  OCM/uh9PLtUOQ0gRKixi8/edn11sUxYLMjpThagIU/kzw2J/xQoUpOgzHzrDnN00
-  8VWE27Mw4BMckRzTjgyEbGB6+j1NYaaQ76a1q1yFc3XiR9crZhyTmXT887lPCe3B
-  QHjym4e4y/FmXBJjpO/TtRoYd8a5YTCaOsML7M/nb/XrArvE3l5JaNEXkhH/nGs7
-  wR9huisTMlESX3ReGKU=
-  -----END CERTIFICATE-----
-date: 2014-09-26 00:00:00.000000000 Z
+cert_chain: []
+date: 2017-10-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -266,7 +245,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: A Rails engine that adds a piece of middleware to the top of your middleware