redi_search 4.1.0 → 6.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5ae66b8370802c6acf6c50487cc751e526bd7afa69be14bf56e0e5b8db416511
-  data.tar.gz: ccffbbb3db86598eb132225091cf3cfae3bfac692bca430d2484e7c97f0ab81c
+  metadata.gz: 7bb651cd81b7d83eb69c31a88bc6680c47083c324bd0a7e2670081fa479b12fa
+  data.tar.gz: '037638518a882a238acf3f81c08e2598733ecfc3b8571a9e93e37c894f8b73aa'
 SHA512:
-  metadata.gz: 037fd2b21e9e296e3b143f4d878a9e9cb37406f99c66b22f54a218d1a3d12c046034b19d011b875b2cd5ab3d9a1bb81c4f10b4c862196d01e8a408a2d6436156
-  data.tar.gz: 17e0f4dccd59d130c3d76314cff4b2a94da725b1b5bdc2478aaf39dde5c3a34d178cbafb04db45bf5488a8a7006bb043ed14247e46a47a64d362cc94b6fe52f1
+  metadata.gz: 3c3ddf47605dee892bdf811d2bcab81ce503431532ae481e1c1a49f611061c5b43a01d2d45325901c658e14a4ceb706b743411439f14bd235ed44fddecaf6716
+  data.tar.gz: 1879a477cae2f84072f28d20d88ce4d6e61b1b28ea4e2966cec01ebc14e9fed61b45b43a3688eacb0979f31647b5c66ff55c460f852a68b8154348effd0c8ee0

data/.github/workflows/lint.yml

@@ -4,17 +4,17 @@ on:
   pull_request:
   push:
     branches:
-      - master
+      - main
 
 jobs:
   lint:
     runs-on: ubuntu-latest
     steps:
     - uses: actions/checkout@v2
-    - name: Set up Ruby 3.0
+    - name: Set up Ruby 3.1
       uses: ruby/setup-ruby@v1
       with:
-        ruby-version: 3.0
+        ruby-version: 3.1
     - name: Install rubocop
       run: |
         gem install rubocop rubocop-performance rubocop-minitest rubocop-rake

data/.github/workflows/tests.yml

@@ -4,15 +4,15 @@ on:
   pull_request:
   push:
     branches:
-      - master
+      - main
 
 jobs:
   unit:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        ruby: [ '2.5', '2.6', '2.7', '3.0' ]
-        gemfile: [ 'Gemfile', 'gemfiles/activerecord_60.gemfile'  ]
+        ruby: [ '2.7', '3.0', '3.1' ]
+        gemfile: [ 'Gemfile', 'gemfiles/activerecord_60.gemfile', 'gemfiles/activerecord_61.gemfile', 'gemfiles/activerecord_70.gemfile'  ]
     steps:
     - uses: actions/checkout@v2
     - name: Set up Ruby ${{ matrix.ruby }}
@@ -29,17 +29,20 @@ jobs:
       run: BUNDLE_GEMFILE=${{ matrix.gemfile }} bundle exec rake test:unit
   integration:
     runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        redisearch: [ '2.4.7' ]
     services:
       redisearch:
-        image: redislabs/redisearch:2.0.6
+        image: redislabs/redisearch:${{ matrix.redisearch }}
         ports:
           - 6379:6379
     steps:
     - uses: actions/checkout@v2
-    - name: Set up Ruby 3.0
+    - name: Set up Ruby 3.1
       uses: ruby/setup-ruby@v1
       with:
-        ruby-version: 3.0
+        ruby-version: 3.1
     - name: Install dependencies
       run: |
         sudo apt-get install libsqlite3-dev -y

data/.rubocop.yml

@@ -13,7 +13,7 @@ AllCops:
     - test/dummy/db/schema.rb
     - gemfiles/**/*
     - bin/**/*
-  TargetRubyVersion: 2.5
+  TargetRubyVersion: 2.7
 
 # Department Bundler
 Bundler/DuplicatedGem:
@@ -619,10 +619,6 @@ Lint/BinaryOperatorWithIdenticalOperands:
   Description: Checks for comparison of something with itself.
   Enabled: true
 
-Lint/UselessElseWithoutRescue:
-  Description: Checks for useless `else` in `begin..end` without `rescue`.
-  Enabled: true
-
 Lint/ReturnInVoidContext:
   Description: Checks for return in void context.
   Enabled: true

data/Appraisals

@@ -7,3 +7,7 @@ end
 appraise "activerecord-61" do
   gem "activerecord", "< 6.2", ">= 6.1"
 end
+
+appraise "activerecord-70" do
+  gem "activerecord", "~> 7.0.0.alpha1"
+end

data/Gemfile

@@ -7,6 +7,7 @@ git_source(:github) { |repo_name| "https://github.com/#{repo_name}" }
 gemspec
 
 gem "appraisal", "~> 2.2"
+gem "debug"
 gem "faker"
 gem "mocha"
 gem "rubocop"
@@ -16,4 +17,4 @@ gem "rubocop-rake"
 gem "simplecov"
 gem "sqlite3"
 
-gem "activerecord", "~> 6.1"
+gem "activerecord", "~> 7.0"

data/README.md

@@ -1,14 +1,11 @@
 <p align="center">
   <a href="https://github.com/npezza93/redi_search">
-    <img src="https://raw.githubusercontent.com/npezza93/redi_search/master/.github/logo.svg?sanitize=true" width="350">
+    <img src="https://raw.githubusercontent.com/npezza93/redi_search/main/.github/logo.svg?sanitize=true" width="350">
   </a>
 </p>
 
 # RediSearch
 
-![Build Status](https://github.com/npezza93/redi_search/workflows/tests/badge.svg)
-[![Maintainability](https://api.codeclimate.com/v1/badges/c6437acac5684de2549d/maintainability)](https://codeclimate.com/github/npezza93/redi_search/maintainability)
-
 A simple, but powerful, Ruby wrapper around RediSearch, a search engine on top of
 Redis.
 
@@ -103,17 +100,19 @@ defining what a search index is. According to [Swiftype](https://swiftype.com):
 ## Schema
 
 This defines the fields and the properties of those fields in the index. A
-schema is a hash, with field names as the keys, and the field type(and options)
-as the value. Each field can be one of four types: geo, numeric, tag, or text
-and can have many options. A simple example of a schema is:
+schema is a simple DSL. Each field can be one of four types: geo, numeric, tag,
+or text and can have many options. A simple example of a schema is:
 ```ruby
-{ first_name: :text, last_name: :text }
+RediSearch::Schema.new do
+  text_field :first_name
+  text_field :last_name
+end
 ```
 
 The supported options for each type are as follows:
 
 ##### Text field
-With no options: `{ name: :text }`
+With no options: `text_field :name`
 
 <details>
   <summary>Options</summary>
@@ -122,7 +121,7 @@ With no options: `{ name: :text }`
       <b>weight</b> (default: 1.0)
       <ul>
         <li>Declares the importance of this field when calculating result accuracy. This is a multiplication factor.</li>
-        <li>Ex: <code>{ name: { text: { weight: 2 } } }</code></li>
+        <li>Ex: <code>text_field :name, weight: 2</code></li>
       </ul>
     </li>
     <li>
@@ -137,7 +136,7 @@ With no options: `{ name: :text }`
           </ul>
         </li>
         <li>
-          Ex: <code>{ name: { text: { phonetic: 'dm:en' } } }</code>
+          Ex: <code>text_field :name, phonetic: 'dm:en'</code>
         </li>
       </ul>
     </li>
@@ -145,28 +144,28 @@ With no options: `{ name: :text }`
       <b>sortable</b> (default: false)
       <ul>
         <li>Allows the user to later sort the results by the value of this field (this adds memory overhead so do not declare it on large text fields).</li>
-        <li>Ex: <code>{ name: { text: { sortable: true } } }</code></li>
+        <li>Ex: <code>text_field :name, sortable: true</code></li>
       </ul>
     </li>
     <li>
       <b>no_index</b> (default: false)
       <ul>
         <li>Field will not be indexed. This is useful in conjunction with <code>sortable</code>, to create fields whose update using PARTIAL will not cause full reindexing of the document. If a field has <code>no_index</code> and doesn't have <code>sortable</code>, it will just be ignored by the index.</li>
-        <li>Ex: <code>{ name: { text: { no_index: true } } }</code></li>
+        <li>Ex: <code>text_field :name, no_index: true</code></li>
       </ul>
     </li>
     <li>
       <b>no_stem</b> (default: false)
       <ul>
         <li>Disable stemming when indexing its values. This may be ideal for things like proper names.</li>
-        <li>Ex: <code>{ name: { text: { no_stem: true } } }</code></li>
+        <li>Ex: <code>text_feidl :name, no_stem: true</code></li>
       </ul>
     </li>
   </ul>
 </details>
 
 ##### Numeric field
-With no options: `{ price: :numeric }`
+With no options: `numeric_field :price`
 
 <details>
   <summary>Options</summary>
@@ -175,21 +174,21 @@ With no options: `{ price: :numeric }`
       <b>sortable</b> (default: false)
       <ul>
         <li>Allows the user to later sort the results by the value of this field (this adds memory overhead so do not declare it on large text fields).</li>
-        <li>Ex: <code>{ id: { numeric: { sortable: true } } }</code></li>
+        <li>Ex: <code>numeric_field :id, sortable: true</code></li>
       </ul>
     </li>
     <li>
       <b>no_index</b> (default: false)
       <ul>
         <li>Field will not be indexed. This is useful in conjunction with <code>sortable</code>, to create fields whose update using PARTIAL will not cause full reindexing of the document. If a field has <code>no_index</code> and doesn't have <code>sortable</code>, it will just be ignored by the index.</li>
-        <li>Ex: <code>{ id: { numeric: { no_index: true } } }</code></li>
+        <li>Ex: <code>numeric_field :id, no_index: true</code></li>
       </ul>
     </li>
   </ul>
 </details>
 
 ##### Tag field
-With no options: `{ tag: :tag }`
+With no options: `tag_field :tag`
 
 <details>
   <summary>Options</summary>
@@ -198,28 +197,28 @@ With no options: `{ tag: :tag }`
       <b>sortable</b> (default: false)
       <ul>
         <li>Allows the user to later sort the results by the value of this field (this adds memory overhead so do not declare it on large text fields).</li>
-        <li>Ex: <code>{ tag: { tag: { sortable: true } } }</code></li>
+        <li>Ex: <code>tag_field :tag, sortable: true</code></li>
       </ul>
     </li>
     <li>
       <b>no_index</b> (default: false)
       <ul>
         <li>Field will not be indexed. This is useful in conjunction with <code>sortable</code>, to create fields whose update using PARTIAL will not cause full reindexing of the document. If a field has <code>no_index</code> and doesn't have <code>sortable</code>, it will just be ignored by the index.</li>
-        <li>Ex: <code>{ tag: { tag: { no_index: true } } }</code></li>
+        <li>Ex: <code>tag_field :tag, no_index: true</code></li>
       </ul>
     </li>
     <li>
       <b>separator</b> (default: ",")
       <ul>
         <li>Indicates how the text contained in the field is to be split into individual tags. The default is ,. The value must be a single character.</li>
-        <li>Ex: <code>{ tag: { tag: { separator: ',' } } }</code></li>
+        <li>Ex: <code>tag_field :tag, separator: ','</code></li>
       </ul>
     </li>
   </ul>
 </details>
 
 ##### Geo field
-With no options: `{ place: :geo }`
+With no options: `geo_field :place`
 
 <details>
   <summary>Options</summary>
@@ -228,14 +227,14 @@ With no options: `{ place: :geo }`
       <b>sortable</b> (default: false)
       <ul>
         <li>Allows the user to later sort the results by the value of this field (this adds memory overhead so do not declare it on large text fields).</li>
-        <li>Ex: <code>{ place: { geo: { sortable: true } } }</code></li>
+        <li>Ex: <code>geo_field :place, sortable: true</code></li>
       </ul>
     </li>
     <li>
       <b>no_index</b> (default: false)
       <ul>
         <li>Field will not be indexed. This is useful in conjunction with <code>sortable</code>, to create fields whose update using PARTIAL will not cause full reindexing of the document. If a field has <code>no_index</code> and doesn't have <code>sortable</code>, it will just be ignored by the index.</li>
-        <li>Ex: <code>{ place: { geo: { no_index: true } } }</code></li>
+        <li>Ex: <code>geo_field :place, no_index: true</code></li>
       </ul>
     </li>
   </ul>
@@ -250,12 +249,10 @@ You can fetch a `Document` using `.get` class methods.
 given `document_id`.
 
 You can also make a `Document` instance using the
-`.for_object(index, record, serializer: nil, only: [])` class method. It takes
+`.for_object(index, record, only: [])` class method. It takes
 an `Index` instance and a Ruby object. That object must respond to all the
-fields specified in the `Index`'s `Schema` or pass a serializer class that
-accepts the object and responds to all the fields specified in the `Index`'s
-`Schema`. `only` accepts an array of fields from the schema and limits the
-fields that are passed to the `Document`.
+fields specified in the `Index`'s `Schema`. `only` accepts an array of fields
+from the schema and limits the fields that are passed to the `Document`.
 
 Once you have an instance of a `Document`, it responds to all the fields
 specified in the `Index`'s `Schema` as methods and `document_id`. `document_id`
@@ -271,10 +268,12 @@ Finally there is a `#del` method that will remove the `Document` from the
 ## Index
 
 To initialize an `Index`, pass the name of the `Index` as a string or symbol
-and the `Schema`.
+and the `Schema` block.
 
 ```ruby
-RediSearch::Index.new(name_of_index, schema)
+RediSearch::Index.new(name_of_index) do
+  text_field :foobar
+end
 ```
 
 #### Available Commands
@@ -330,8 +329,10 @@ RediSearch::Index.new(name_of_index, schema)
   - Removes a `Document` from the `Index`.
 - `document_count`
   - Returns the number of `Document`s in the `Index`
-- `add_field(field_name, schema)`
-  - Adds a new field to the `Index`. Ex: `index.add_field(:first_name, text: { phonetic: "dm:en" })`
+- `add_field(name, type, **options, &block)`
+  - Adds a new field to the `Index`.
+  - The block and options are optional.
+  - Ex: `index.add_field(:first_name, :text, phonetic: "dm:en")`
 - `reindex(documents, recreate: false)`
    - If `recreate` is `true` the `Index` will be dropped and recreated
 
@@ -343,7 +344,7 @@ be chained together. When searching, an array of `Document`s is returned
 which has public reader methods for all the schema fields.
 
 ```ruby
-main ❯ index = RediSearch::Index.new("user_idx", name: { text: { phonetic: "dm:en" } })
+main ❯ index = RediSearch::Index.new("user_idx") { text_field :name, phonetic: "dm:en" }
 main ❯ index.add RediSearch::Document.for_object(index, User.new("10039", "Gene", "Volkman"))
 main ❯ index.add RediSearch::Document.for_object(index, User.new("9998", "Jeannie", "Ledner"))
 main ❯ index.search("john")
@@ -473,7 +474,7 @@ returns an array where each element contains suggestions for each search term
 and a normalized score based on its occurrences in the index.
 
 ```ruby
-main ❯ index = RediSearch::Index.new("user_idx", name: { text: { phonetic: "dm:en" } })
+main ❯ index = RediSearch::Index.new("user_idx") { text_field :name, phonetic: "dm:en" }
 main ❯ index.spellcheck("jimy")
   RediSearch (1.1ms)  FT.SPELLCHECK user_idx jimy DISTANCE 1
   => [#<RediSearch::Spellcheck::Result:0x00007f805591c670
@@ -495,10 +496,10 @@ keyword argument from inside your model. Ex:
 
 ```ruby
 class User < ApplicationRecord
-  redi_search schema: {
-    first: { text: { phonetic: "dm:en" } },
-    last: { text: { phonetic: "dm:en" } }
-  }
+  redi_search do
+    text_field :first, phonetic: "dm:en"
+    text_field :last, phonetic: "dm:en"
+  end
 end
 ```
 
@@ -515,21 +516,16 @@ similarly to `RediSearch::Index#reindex`. Some of the differences include:
     particular field.
 
 
-The `redi_search` class method also takes an optional `serializer` argument
-which takes the class name of a serializer. The serializer must respond to all
-the fields in a schema as methods. We don't serialize to a JSON object since
-RediSearch doesn't serialize documents that way.
+While defining the schema you can optionally pass it a block. If no block is
+passed the `name` will called on the model to get the value. If a block is
+passed the value for the field is obtained through calling the block.
 
 ```ruby
 class User < ApplicationRecord
-  redi_search schema: {
-    name: { text: { phonetic: "dm:en" } }
-  }, serializer: UserSerializer
-end
-
-class UserSerializer < SimpleDelegator
-  def name
-    "#{first_name} #{last_name}"
+  redi_search do
+    text_field :name do
+      "#{first_name} #{last_name}"
+    end
   end
 end
 ```
@@ -553,13 +549,13 @@ optional `index_prefix` argument which gets prepended to the index name:
 
 ```ruby
 class User < ApplicationRecord
-  redi_search schema: {
-    first: { text: { phonetic: "dm:en" } },
-    last: { text: { phonetic: "dm:en" } }
-  }, index_prefix: 'prefix'
+  redi_search index_prefix: 'prefix' do
+    text_field :first, phonetic: "dm:en"
+    text_field :last, phonetic: "dm:en"
+  end
 end
 
-User.redi_search_index.name
+User.search_index.name
 # => prefix_users_development
 ```
 
@@ -568,13 +564,13 @@ after creating and updating and will be removed from the `Index` upon
 destruction.
 
 There are a few more convenience methods that are publicly available:
-- `redi_search_document`
+- `search_document`
   - Returns the record as a `RediSearch::Document` instance
-- `redi_search_delete_document`
+- `remove_from_index`
   - Removes the record from the `Index`
-- `redi_search_add_document`
+- `add_to_index`
   - Adds the record to the `Index`
-- `redi_search_index`
+- `search_index`
   - Returns the `RediSearch::Index` instance
 
 
@@ -608,4 +604,4 @@ The gem is available as open source under the terms of the
 
 Everyone interacting in the RediSearch project’s codebases, issue trackers, chat
 rooms and mailing lists is expected to follow the [code of
-conduct](https://github.com/npezza93/redi_search/blob/master/CODE_OF_CONDUCT.md).
+conduct](https://github.com/npezza93/redi_search/blob/main/CODE_OF_CONDUCT.md).

data/bin/console

@@ -19,10 +19,14 @@ ActiveRecord::Migration.create_table :users do |t|
 end
 
 class User < ActiveRecord::Base
-  redi_search schema: {
-    first: { text: { phonetic: "dm:en" } },
-    last: { text: { phonetic: "dm:en" } }
-  }
+  redi_search do
+    text_field :first, phonetic: "dm:en"
+    text_field :last, phonetic: "dm:en"
+    tag_field :tags
+    text_field :name, phonetic: "dm:en" do
+      "#{first} #{last}"
+    end
+  end
 end
 
 def seed_users(count = 10_000)

data/bin/publish

@@ -8,7 +8,7 @@ require_relative "../lib/redi_search/version"
 # path to your application root.
 APP_ROOT = Pathname.new File.expand_path("..", __dir__)
 MASTER_CHECK = <<~MASTER_CHECK
-  if [ $(git symbolic-ref --short -q HEAD) != 'master' ];
+  if [ $(git symbolic-ref --short -q HEAD) != 'main' ];
     then exit 1;
   fi
 MASTER_CHECK
@@ -20,7 +20,7 @@ end
 
 abort("\n== Version Type incorrect ==") unless VERSION_TYPES.include?(ARGV[0])
 
-abort("\n== Not on master") unless system(MASTER_CHECK)
+abort("\n== Not on main") unless system(MASTER_CHECK)
 
 current_version = RediSearch::VERSION.split(".").map(&:to_i)
 

data/gemfiles/activerecord_60.gemfile

@@ -3,6 +3,7 @@
 source "https://rubygems.org"
 
 gem "appraisal", "~> 2.2"
+gem "debug"
 gem "faker"
 gem "mocha"
 gem "rubocop"

data/gemfiles/activerecord_61.gemfile

@@ -3,6 +3,7 @@
 source "https://rubygems.org"
 
 gem "appraisal", "~> 2.2"
+gem "debug"
 gem "faker"
 gem "mocha"
 gem "rubocop"

data/gemfiles/activerecord_70.gemfile

@@ -0,0 +1,16 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "appraisal", "~> 2.2"
+gem "debug"
+gem "faker"
+gem "mocha"
+gem "rubocop"
+gem "rubocop-minitest"
+gem "rubocop-performance"
+gem "simplecov"
+gem "sqlite3"
+gem "activerecord", "~> 7.0.1"
+
+gemspec path: "../"

data/lib/redi_search/add_field.rb

@@ -2,16 +2,18 @@
 
 module RediSearch
   class AddField
-    def initialize(index, field_name, schema)
-      @index = index
-      @field_name = field_name
-      @raw_schema = schema
+    def initialize(index, name, type, **options, &block)
+      @index   = index
+      @name    = name
+      @type    = type
+      @options = options
+      @block   = block
     end
 
     def call!
-      index.schema.add_field(field_name, raw_schema)
+      field = index.schema.add_field(name, type, **options, &block)
 
-      RediSearch.client.call!(*command).ok?
+      RediSearch.client.call!("ALTER", index.name, "SCHEMA", "ADD", *field).ok?
     end
 
     def call
@@ -22,14 +24,6 @@ module RediSearch
 
     private
 
-    attr_reader :index, :field_name, :raw_schema
-
-    def command
-      ["ALTER", index.name, "SCHEMA", "ADD", *field_schema]
-    end
-
-    def field_schema
-      @field_schema ||= Schema.make_field(field_name, raw_schema).to_a
-    end
+    attr_reader :index, :name, :type, :options, :block
   end
 end

data/lib/redi_search/client.rb

@@ -3,8 +3,6 @@
 require "redis"
 require "active_support/notifications"
 
-require "redi_search/client/response"
-
 module RediSearch
   class Client
     def initialize(redis = Redis.new)
@@ -20,9 +18,9 @@ module RediSearch
     end
 
     def multi
-      Response.new(redis.multi do
+      Response.new(redis.multi do |pipeline|
         instrument("pipeline", query: ["begin pipeline"])
-        capture_pipeline { yield }
+        capture_pipeline(pipeline) { yield }
         instrument("pipeline", query: ["finish pipeline"])
       end)
     end
@@ -32,14 +30,18 @@ module RediSearch
     attr_reader   :redis
     attr_accessor :pipeline
 
-    def capture_pipeline
-      self.pipeline = true
+    def capture_pipeline(pipeline)
+      self.pipeline = pipeline
       yield
       self.pipeline = false
     end
 
     def send_command(command, *params)
-      Response.new(redis.call(command, *params))
+      if pipeline
+        Response.new(pipeline.call(command, *params))
+      else
+        Response.new(redis.call(command, *params))
+      end
     end
 
     def instrument(action, payload, &block)
@@ -47,7 +49,7 @@ module RediSearch
         "action.redi_search",
         { name: "RediSearch", action: action, inside_pipeline: pipeline }.
           merge(payload),
-        &Proc.new(&(block || proc {})) # rubocop:disable Lint/EmptyBlock
+        &Proc.new(&(block || proc {}))
       )
     end
   end

data/lib/redi_search/document/display.rb

@@ -4,9 +4,9 @@ module RediSearch
   class Document
     module Display
       def inspect
-        inspection = pretty_print_attributes.map do |field_name|
+        inspection = pretty_print_attributes.filter_map do |field_name|
           "#{field_name}: #{public_send(field_name)}"
-        end.compact.join(", ")
+        end.join(", ")
 
         "#<#{self.class} #{inspection}>"
       end
@@ -19,7 +19,7 @@ module RediSearch
         pp_attrs.compact
       end
 
-      #:nocov:
+      # :nocov:
       def pretty_print(printer) # rubocop:disable Metrics/MethodLength
         printer.object_address_group(self) do
           printer.seplist(
@@ -35,7 +35,7 @@ module RediSearch
           end
         end
       end
-      #:nocov:
+      # :nocov:
     end
   end
 end