redditkit 1.0.0 → 1.0.1

data/spec/redditkit/base_spec.rb

@@ -22,7 +22,7 @@ describe RedditKit::Base do
 
     context "predicate method" do
       it "can access predicate methods" do
-        expect(@thing.id?).to be_true
+        expect(@thing.id?).to be true
       end
     end
 

data/spec/redditkit/client/account_spec.rb

@@ -6,14 +6,14 @@ describe RedditKit::Client::Account, :vcr do
     it "signs the user in" do
       client = RedditKit::Client.new redditkit_username, redditkit_password
 
-      expect(client.signed_in?).to be_true
+      expect(client.signed_in?).to be true
       expect(client.user).to_not be_nil
     end
   end
 
   describe "#signed_in?" do
     it "determines whether there is a user signed in" do
-      expect(authenticated_client.signed_in?).to be_true
+      expect(authenticated_client.signed_in?).to be true
     end
   end
 
@@ -22,7 +22,7 @@ describe RedditKit::Client::Account, :vcr do
       client = RedditKit::Client.new :username => redditkit_username, :password => redditkit_password
       client.sign_out
 
-      expect(client.signed_in?).to_not be_true
+      expect(client.signed_in?).to be false
     end
   end
 

data/spec/redditkit/client/links_spec.rb

@@ -55,7 +55,7 @@ describe RedditKit::Client::Links, :vcr do
       links = RedditKit.links_with_domain "github.com"
       result = links.all? { |link| link.domain == 'github.com' }
 
-      expect(result).to be_true
+      expect(result).to be true
     end
   end
 

data/spec/redditkit/client/moderation_spec.rb

@@ -62,7 +62,7 @@ describe RedditKit::Client::Moderation, :vcr do
     end
 
     it "requests the correct resource" do
-      authenticated_client.distinguish :comment => '12345'
+      authenticated_client.distinguish '12345'
       expect(a_post('api/distinguish/yes')).to have_been_made
     end
   end

data/spec/redditkit/client/multireddits_spec.rb

@@ -95,7 +95,7 @@ describe RedditKit::Client::Multireddits, :vcr do
       multireddits = authenticated_client.my_multireddits
       multireddit = multireddits.find { |multi| multi.name == multireddit_name }
 
-      expect(multireddit.subreddits.include? 'haskell').to be_true
+      expect(multireddit.subreddits.include? 'haskell').to be true
 
       authenticated_client.delete_multireddit multireddit_name
     end
@@ -136,7 +136,7 @@ describe RedditKit::Client::Multireddits, :vcr do
       authenticated_client.add_subreddit_to_multireddit 'addsubreddit', 'haskell'
       multireddit = authenticated_client.multireddit redditkit_username, 'addsubreddit'
 
-      expect(multireddit.subreddits.include? 'haskell').to be_true
+      expect(multireddit.subreddits.include? 'haskell').to be true
 
       authenticated_client.delete_multireddit 'addsubreddit'
     end
@@ -149,7 +149,7 @@ describe RedditKit::Client::Multireddits, :vcr do
       authenticated_client.remove_subreddit_from_multireddit 'removesubreddit', 'haskell'
       multireddit = authenticated_client.multireddit redditkit_username, 'removesubreddit'
 
-      expect(multireddit.subreddits.include? 'haskell').to be_false
+      expect(multireddit.subreddits.include? 'haskell').to be false
 
       authenticated_client.delete_multireddit 'removesubreddit'
     end

data/spec/redditkit/client/users_spec.rb

@@ -67,14 +67,14 @@ describe RedditKit::Client::Users, :vcr do
       client = RedditKit::Client.new
       available = client.username_available? 'samsymons' 
 
-      expect(available).to_not be_true
+      expect(available).to be false
     end
 
     it "returns true for an available username" do
       client = RedditKit::Client.new
       available = client.username_available? 'available_user' 
 
-      expect(available).to be_true
+      expect(available).to be true
     end
   end
 

data/spec/redditkit/client/voting_spec.rb

@@ -6,28 +6,28 @@ describe RedditKit::Client::Voting do
     context "with a comment full name passed" do
       it "upvotes the comment" do
         authenticated_client.upvote test_comment_full_name
-        expect(test_comment.upvoted?).to be_true
+        expect(test_comment.upvoted?).to be true
       end
     end
     
     context "with a link full name passed" do
       it "upvotes the link" do
         authenticated_client.upvote test_link_full_name
-        expect(test_link.upvoted?).to be_true
+        expect(test_link.upvoted?).to be true
       end
     end
 
     context "with a comment passed" do
       it "upvotes the comment" do
         authenticated_client.upvote test_comment
-        expect(test_comment.upvoted?).to be_true
+        expect(test_comment.upvoted?).to be true
       end
     end
 
     context "with a link passed" do
       it "upvotes the link" do
         authenticated_client.upvote test_link
-        expect(test_link.upvoted?).to be_true
+        expect(test_link.upvoted?).to be true
       end
     end
   end
@@ -36,28 +36,28 @@ describe RedditKit::Client::Voting do
     context "with a comment full name passed" do
       it "downvotes the comment" do
         authenticated_client.downvote test_comment_full_name
-        expect(test_comment.downvoted?).to be_true
+        expect(test_comment.downvoted?).to be true
       end
     end
     
     context "with a link full name passed" do
       it "downvotes the link" do
         authenticated_client.downvote test_link_full_name
-        expect(test_link.downvoted?).to be_true
+        expect(test_link.downvoted?).to be true
       end
     end
 
     context "with a comment passed" do
       it "downvotes the comment" do
         authenticated_client.downvote test_comment
-        expect(test_comment.downvoted?).to be_true
+        expect(test_comment.downvoted?).to be true
       end
     end
 
     context "with a link passed" do
       it "downvotes the link" do
         authenticated_client.downvote test_link
-        expect(test_link.downvoted?).to be_true
+        expect(test_link.downvoted?).to be true
       end
     end
   end
@@ -66,32 +66,32 @@ describe RedditKit::Client::Voting do
     context "with a comment full name passed" do
       it "withdraws the vote on the comment" do
         authenticated_client.withdraw_vote test_comment_full_name
-        expect(test_comment.upvoted?).to_not be_true
-        expect(test_comment.downvoted?).to_not be_true
+        expect(test_comment.upvoted?).to be false
+        expect(test_comment.downvoted?).to be false
       end
     end
     
     context "with a link full name passed" do
       it "withdraws the vote on the link" do
         authenticated_client.withdraw_vote test_link_full_name
-        expect(test_link.upvoted?).to_not be_true
-        expect(test_link.downvoted?).to_not be_true
+        expect(test_link.upvoted?).to be false
+        expect(test_link.downvoted?).to be false
       end
     end
 
     context "with a comment passed" do
       it "withdraws the vote on the comment" do
         authenticated_client.withdraw_vote test_comment
-        expect(test_comment.upvoted?).to_not be_true
-        expect(test_comment.downvoted?).to_not be_true
+        expect(test_comment.upvoted?).to be false
+        expect(test_comment.downvoted?).to be false
       end
     end
 
     context "with a link passed" do
       it "withdraws the vote on the link" do
         authenticated_client.withdraw_vote test_link
-        expect(test_link.upvoted?).to_not be_true
-        expect(test_link.downvoted?).to_not be_true
+        expect(test_link.upvoted?).to be false
+        expect(test_link.downvoted?).to be false
       end
     end
   end

data/spec/redditkit/client_spec.rb

@@ -27,9 +27,9 @@ describe RedditKit::Client, :vcr do
   it "should tell us whether it is signed in", :authenticated do
     client = authenticated_client
 
-    expect(client.signed_in?).to be_true
+    expect(client.signed_in?).to be true
     client.sign_out
-    expect(client.signed_in?).to_not be_true
+    expect(client.signed_in?).to be false
   end
 
   it "should be able to sign out", :authenticated do

data/spec/redditkit/comment_spec.rb

@@ -6,21 +6,21 @@ describe RedditKit::Comment, :vcr do
     comments = RedditKit.comments '1n002d'
     comment = comments.first
 
-    expect(comment.replies?).to be_true
+    expect(comment.replies?).to be true
   end
 
   it "should be deleted if both author and comment attributes are set to '[deleted]'" do
     attributes = { :data => { :author => '[deleted]', :body => '[deleted]' } }
     deleted_comment = RedditKit::Comment.new attributes
 
-    expect(deleted_comment.deleted?).to be_true
+    expect(deleted_comment.deleted?).to be true
   end
 
   it "should not be deleted if neither author and comment attributes are set to '[deleted]'" do
     comments = RedditKit.comments '1n002d'
     comment = comments.first
 
-    expect(comment.deleted?).to_not be_true
+    expect(comment.deleted?).to be false
   end
 
 end

data/spec/redditkit/link_spec.rb

@@ -3,23 +3,34 @@ require 'spec_helper'
 describe RedditKit::Link do
 
   before :all do
-    attributes = { :data => { :id => '12345', :url => 'http://example.com/test.png', :permalink => 'permalink', :created_utc => Time.now.to_i } }
+    attributes = { :data => { :id => '12345', :title => "&", :url => 'http://example.com/test.png', :permalink => 'permalink', :created_utc => Time.now.to_i } }
     @link = RedditKit::Link.new attributes
 
     old_link_attributes = { :data => { :id => '12345', :url => 'http://example.com/test.png', :created_utc => Time.new(2000, 1, 1).to_i } }
     @old_link = RedditKit::Link.new old_link_attributes
+
+    parameter_link_attributes = { :data => { :id => '12345', :url => 'http://example.com/test?param=something&whatever=test', :created_utc => Time.new(2000, 1, 1).to_i } }
+    @link_with_parameters = RedditKit::Link.new parameter_link_attributes
+  end
+
+  it "decodes HTML entities in link titles" do
+    expect(@link.title).to eq '&' 
+  end
+
+  it "decodes HTML entities in link URLs" do
+    expect(@link_with_parameters.url).to eq 'http://example.com/test?param=something&whatever=test'
   end
 
   it "does not show the score for new links" do
-    expect(@link.showing_link_score?).to be_false
+    expect(@link.showing_link_score?).to be false
   end
 
   it "shows the score for old links" do
-    expect(@old_link.showing_link_score?).to be_true
+    expect(@old_link.showing_link_score?).to be true
   end
 
   it "determines whether the link has an image extension" do
-    expect(@link.image_link?).to be_true
+    expect(@link.image_link?).to be true
   end
 
   it "returns the link's permalink" do

data/spec/redditkit/multireddit_spec.rb

@@ -17,7 +17,7 @@ describe RedditKit::Multireddit do
     result = subreddits.all? { |subreddit| subreddit.is_a? String }
 
     expect(subreddits.length).to eq 3
-    expect(result).to be_true
+    expect(result).to be true
   end
 
   it "returns the username of the multireddit's owner" do

data/spec/redditkit/thing_spec.rb

@@ -12,7 +12,7 @@ describe RedditKit::Thing do
 
   it "is equal to another thing with the same full name" do
     second_thing = RedditKit::Thing.new({ :kind => 't1', :data => { :id => '12345' } })
-    expect(@thing == second_thing).to be_true
+    expect(@thing == second_thing).to be true
   end
 
 end

data/spec/redditkit/votable_spec.rb

@@ -33,19 +33,19 @@ describe RedditKit::Votable do
 
   describe "#upvoted?" do
     it "determines whether the object is upvoted" do
-      expect(@votable.upvoted?).to be_true
+      expect(@votable.upvoted?).to be true
     end
   end
 
   describe "#downvoted?" do
     it "determines whether the object is downvoted" do
-      expect(@votable.downvoted?).to_not be_true
+      expect(@votable.downvoted?).to be false
     end
   end
 
   describe "#voted?" do
     it "determines whether the object has been voted on" do
-      expect(@votable.voted?).to be_true
+      expect(@votable.voted?).to be true
     end
   end
 

data/spec/redditkit_spec.rb

@@ -11,7 +11,7 @@ describe RedditKit do
   end
 
   it "responds to methods on its client" do
-    expect(RedditKit.respond_to?(:username)).to be_true
+    expect(RedditKit.respond_to?(:username)).to be true
   end
 
   it "forwards methods to its client" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: redditkit
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Sam Symons
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-11-11 00:00:00.000000000 Z
+date: 2014-01-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -24,20 +24,54 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.8'
+- !ruby/object:Gem::Dependency
+  name: htmlentities
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '4.3'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '4.3'
+- !ruby/object:Gem::Dependency
+  name: multi_json
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.8'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.8'
 - !ruby/object:Gem::Dependency
   name: dotenv
   requirement: !ruby/object:Gem::Requirement
     requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.9'
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.9.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.9'
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.9.0
 description: A simple reddit API library, covering 100% of the reddit API.
 email:
 - samsymons@me.com
@@ -48,8 +82,9 @@ files:
 - LICENSE.md
 - README.md
 - Rakefile
-- redditkit.gemspec
+- lib/redditkit.rb
 - lib/redditkit/base.rb
+- lib/redditkit/client.rb
 - lib/redditkit/client/account.rb
 - lib/redditkit/client/apps.rb
 - lib/redditkit/client/captcha.rb
@@ -66,7 +101,6 @@ files:
 - lib/redditkit/client/utilities.rb
 - lib/redditkit/client/voting.rb
 - lib/redditkit/client/wiki.rb
-- lib/redditkit/client.rb
 - lib/redditkit/comment.rb
 - lib/redditkit/creatable.rb
 - lib/redditkit/error.rb
@@ -83,8 +117,7 @@ files:
 - lib/redditkit/user.rb
 - lib/redditkit/version.rb
 - lib/redditkit/votable.rb
-- lib/redditkit.rb
-- spec/cassettes/authenticated_client.yml
+- redditkit.gemspec
 - spec/cassettes/RedditKit_Client/should_raise_an_error_with_invalid_credentials.yml
 - spec/cassettes/RedditKit_Client_Account/_sign_in/signs_the_user_in.yml
 - spec/cassettes/RedditKit_Client_Account/_update_session/updates_the_current_session.yml
@@ -92,8 +125,8 @@ files:
 - spec/cassettes/RedditKit_Client_Captcha/_needs_captcha_/checks_if_the_current_account_needs_a_CAPTCHA.yml
 - spec/cassettes/RedditKit_Client_Captcha/_new_captcha_identifier/returns_a_new_CAPTCHA_identifier.yml
 - spec/cassettes/RedditKit_Client_Comments/_comment/requests_the_correct_resource.yml
-- spec/cassettes/RedditKit_Client_Comments/_comments/with_a_link_identifier/returns_comments_on_a_link.yml
 - spec/cassettes/RedditKit_Client_Comments/_comments/with_a_RedditKit_Link/returns_comments_on_a_link.yml
+- spec/cassettes/RedditKit_Client_Comments/_comments/with_a_link_identifier/returns_comments_on_a_link.yml
 - spec/cassettes/RedditKit_Client_Comments/_submit_comment/requests_the_correct_resource.yml
 - spec/cassettes/RedditKit_Client_Flair/_apply_flair_template/clears_flair_templates.yml
 - spec/cassettes/RedditKit_Client_Flair/_clear_flair_templates/clears_flair_templates.yml
@@ -196,6 +229,7 @@ files:
 - spec/cassettes/RedditKit_Client_Wiki/_revert_to_revision/requests_the_correct_resource.yml
 - spec/cassettes/RedditKit_Comment/should_not_be_deleted_if_neither_author_and_comment_attributes_are_set_to_deleted_.yml
 - spec/cassettes/RedditKit_Comment/should_return_replies.yml
+- spec/cassettes/authenticated_client.yml
 - spec/redditkit/base_spec.rb
 - spec/redditkit/client/account_spec.rb
 - spec/redditkit/client/apps_spec.rb
@@ -243,12 +277,11 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.1.10
+rubygems_version: 2.2.0
 signing_key: 
 specification_version: 4
 summary: A simple reddit API library.
 test_files:
-- spec/cassettes/authenticated_client.yml
 - spec/cassettes/RedditKit_Client/should_raise_an_error_with_invalid_credentials.yml
 - spec/cassettes/RedditKit_Client_Account/_sign_in/signs_the_user_in.yml
 - spec/cassettes/RedditKit_Client_Account/_update_session/updates_the_current_session.yml
@@ -256,8 +289,8 @@ test_files:
 - spec/cassettes/RedditKit_Client_Captcha/_needs_captcha_/checks_if_the_current_account_needs_a_CAPTCHA.yml
 - spec/cassettes/RedditKit_Client_Captcha/_new_captcha_identifier/returns_a_new_CAPTCHA_identifier.yml
 - spec/cassettes/RedditKit_Client_Comments/_comment/requests_the_correct_resource.yml
-- spec/cassettes/RedditKit_Client_Comments/_comments/with_a_link_identifier/returns_comments_on_a_link.yml
 - spec/cassettes/RedditKit_Client_Comments/_comments/with_a_RedditKit_Link/returns_comments_on_a_link.yml
+- spec/cassettes/RedditKit_Client_Comments/_comments/with_a_link_identifier/returns_comments_on_a_link.yml
 - spec/cassettes/RedditKit_Client_Comments/_submit_comment/requests_the_correct_resource.yml
 - spec/cassettes/RedditKit_Client_Flair/_apply_flair_template/clears_flair_templates.yml
 - spec/cassettes/RedditKit_Client_Flair/_clear_flair_templates/clears_flair_templates.yml
@@ -360,6 +393,7 @@ test_files:
 - spec/cassettes/RedditKit_Client_Wiki/_revert_to_revision/requests_the_correct_resource.yml
 - spec/cassettes/RedditKit_Comment/should_not_be_deleted_if_neither_author_and_comment_attributes_are_set_to_deleted_.yml
 - spec/cassettes/RedditKit_Comment/should_return_replies.yml
+- spec/cassettes/authenticated_client.yml
 - spec/redditkit/base_spec.rb
 - spec/redditkit/client/account_spec.rb
 - spec/redditkit/client/apps_spec.rb