red-black-tree 0.1.8 → 0.1.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e7cc7e3138c1b0ceea2d6b5a2f91620323f75ebe346288bc69761d77d95eb5c4
-  data.tar.gz: 057d9d283d5312f6c5f8e155e3c039c342d036b779d115738c7afbc57ca419f4
+  metadata.gz: ef532dd5b5da89ad3dbf780bba52824ecdece998306dc89d4742ddd7b9444a1b
+  data.tar.gz: dee8cd6cb0ebf9b837519d9131790590e6fcab86c5fe45af0d28cb603d53f224
 SHA512:
-  metadata.gz: 61f4a9a44d3949b3c2072de4fbca1507cf78306adc32dae8bad26ec5a71171ae952cb81effddf41990a8e2b6dc0e06d39a121389e5bc4c3438eca981dc2a0b59
-  data.tar.gz: c9bced3565a3ec9439c1c08dca09676d1c3966cb18a97507c1f815e938b73419f9f3bce0e4d13d06e97dc59a92f845a3b9b4f094841aa900bde3b004959baeca
+  metadata.gz: 75b0530cb685fb3cfcd1fa8435a8329e97df9fbd49e5e7063b5de0c34cbef24c453dc5d22481c8ba4cafe475f48ea3ccafa37788ef92b066c667882ce860130c
+  data.tar.gz: 8fdf009768bfb1551f2f4954ddab323c12b1d76d438c0be8b2bbb4ffe10816de58513e2642649ad78b25b1ea931a03a29a82b3d2df6a3dfeae70997158fe9183

data/CHANGELOG.md

@@ -1,5 +1,15 @@
 ## [Unreleased]
 
+## [0.1.10] - 2026-05-17
+
+- Fix `RedBlackTree#delete!` orphaning predecessor's child when deleting a node with two valid children
+
+## [0.1.9] - 2026-05-10
+
+- Add `Enumerable` to `RedBlackTree`
+- Fix `RedBlackTree#clear!` not detaching nodes
+- Fix `LeafNodeComparable` being prepended to `LeafNode`
+
 ## [0.1.8] - 2025-07-26
 
 - Refactor to slim down and de-duplicate some methods

data/README.md

@@ -1,7 +1,7 @@
 # RedBlackTree
 
 ![Version](https://img.shields.io/gem/v/red-black-tree)
-![Build](https://img.shields.io/github/actions/workflow/status/joshuay03/red-black-tree/.github/workflows/tests.yml?branch=main)
+![Build](https://badge.buildkite.com/6ccbd68c23960899d1deafdb4cfaa96f1e8c04ad6e198e193b.svg)
 
 [Red-black tree](https://en.wikipedia.org/wiki/Red%E2%80%93black_tree) data structure for Ruby.
 
@@ -86,20 +86,20 @@ Benchmark.ips do |x|
   x.compare!
 end
 
-#=> ruby 3.4.1 (2024-12-25 revision 48d4efcb85) +YJIT +PRISM [arm64-darwin24]
+#=> ruby 4.0.3 (2026-04-21 revision 85ddef263a) +YJIT +PRISM [arm64-darwin23]
 #=> Warming up --------------------------------------
 #=>         RedBlackTree     1.000 i/100ms
 #=> Array (gradual sort)     1.000 i/100ms
-#=>  Array (single sort)   100.000 i/100ms
+#=>  Array (single sort)    81.000 i/100ms
 #=> Calculating -------------------------------------
-#=>         RedBlackTree     16.684 (± 6.0%) i/s   (59.94 ms/i) -     84.000 in   5.053688s
-#=> Array (gradual sort)      0.270 (± 0.0%) i/s     (3.71 s/i) -      2.000 in   7.418650s
-#=>  Array (single sort)     1.006k (± 2.4%) i/s  (994.28 μs/i) -      5.100k in   5.073834s
-#=>
+#=>         RedBlackTree     12.170 (± 8.2%) i/s   (82.17 ms/i) -     61.000 in   5.023274s
+#=> Array (gradual sort)      0.208 (± 0.0%) i/s     (4.82 s/i) -      2.000 in   9.632733s
+#=>  Array (single sort)    815.762 (± 1.2%) i/s    (1.23 ms/i) -      4.131k in   5.064788s
+#=> 
 #=> Comparison:
-#=>  Array (single sort):     1005.8 i/s
-#=>         RedBlackTree:       16.7 i/s - 60.28x  slower
-#=> Array (gradual sort):        0.3 i/s - 3729.44x  slower
+#=>  Array (single sort):      815.8 i/s
+#=>         RedBlackTree:       12.2 i/s - 67.03x  slower
+#=> Array (gradual sort):        0.2 i/s - 3928.64x  slower
 ```
 
 ### Sort and search 10,000 elements
@@ -122,7 +122,7 @@ Benchmark.ips do |x|
   x.report("RedBlackTree#search") do
     tree = RedBlackTree.new
     sample_data.each { |work| tree << WorkNode.new(work); }
-    raise unless tree.search search_sample
+    raise unless tree.search { |node| node.data == search_sample }
   end
 
   # 1:1 comparison
@@ -156,34 +156,34 @@ Benchmark.ips do |x|
   x.compare!
 end
 
-#=> ruby 3.4.1 (2024-12-25 revision 48d4efcb85) +YJIT +PRISM [arm64-darwin24]
+#=> ruby 4.0.3 (2026-04-21 revision 85ddef263a) +YJIT +PRISM [arm64-darwin23]
 #=> Warming up --------------------------------------
 #=>  RedBlackTree#search     3.000 i/100ms
 #=> Array#find (gradual sort)
 #=>                          1.000 i/100ms
 #=> Array#find (single sort)
-#=>                         95.000 i/100ms
+#=>                         79.000 i/100ms
 #=> Array#bsearch (gradual sort)
 #=>                          1.000 i/100ms
 #=> Array#bsearch (single sort)
-#=>                        108.000 i/100ms
+#=>                         87.000 i/100ms
 #=> Calculating -------------------------------------
-#=>  RedBlackTree#search     42.850 (± 4.7%) i/s   (23.34 ms/i) -    216.000 in   5.049896s
+#=>  RedBlackTree#search     32.188 (± 6.2%) i/s   (31.07 ms/i) -    162.000 in   5.051229s
 #=> Array#find (gradual sort)
-#=>                           0.274 (± 0.0%) i/s     (3.65 s/i) -      2.000 in   7.302412s
+#=>                           0.207 (± 0.0%) i/s     (4.83 s/i) -      2.000 in   9.651532s
 #=> Array#find (single sort)
-#=>                         935.492 (± 2.7%) i/s    (1.07 ms/i) -      4.750k in   5.081415s
+#=>                         809.310 (± 3.8%) i/s    (1.24 ms/i) -      4.108k in   5.084020s
 #=> Array#bsearch (gradual sort)
-#=>                           0.275 (± 0.0%) i/s     (3.63 s/i) -      2.000 in   7.269027s
+#=>                           0.205 (± 0.0%) i/s     (4.88 s/i) -      2.000 in   9.753754s
 #=> Array#bsearch (single sort)
-#=>                          1.104k (± 2.0%) i/s  (905.52 μs/i) -      5.616k in   5.087395s
-#=>
+#=>                         857.497 (± 1.0%) i/s    (1.17 ms/i) -      4.350k in   5.073414s
+#=> 
 #=> Comparison:
-#=>  Array#bsearch (single sort):     1104.3 i/s
-#=>     Array#find (single sort):      935.5 i/s - 1.18x  slower
-#=>          RedBlackTree#search:       42.9 i/s - 25.77x  slower
-#=> Array#bsearch (gradual sort):        0.3 i/s - 4013.67x  slower
-#=>    Array#find (gradual sort):        0.3 i/s - 4031.85x  slower
+#=> Array#bsearch (single sort):      857.5 i/s
+#=> Array#find (single sort):      809.3 i/s - 1.06x  slower
+#=>  RedBlackTree#search:       32.2 i/s - 26.64x  slower
+#=> Array#find (gradual sort):        0.2 i/s - 4138.00x  slower
+#=> Array#bsearch (gradual sort):        0.2 i/s - 4181.79x  slower
 ```
 
 ## WIP Features

data/lib/red-black-tree.rb

@@ -6,6 +6,7 @@ require_relative "red_black_tree/node/leaf_node"
 
 class RedBlackTree
   include Utils
+  include Enumerable
 
   # @return [Integer] the number of valid/non-leaf nodes
   attr_reader :size
@@ -134,7 +135,9 @@ class RedBlackTree
 
     if node.children_are_valid?
       delete_node_with_two_children! node
-    elsif node.single_child_is_valid?
+    end
+
+    if node.single_child_is_valid?
       delete_node_with_one_child! node
     elsif node.children_are_leaves?
       delete_leaf_node! node, original_node
@@ -153,6 +156,11 @@ class RedBlackTree
   #
   # @return [RedBlackTree] self
   def clear!
+    traverse_post_order do |node|
+      node.tree = nil
+      node.colour = node.parent = node.left = node.right = nil
+    end
+
     @root = nil
     @size = 0
     @left_most_node = nil
@@ -179,7 +187,7 @@ class RedBlackTree
   alias_method :find, :search
 
   def select &block
-    raise ArgumentError, "block must be provided for select" unless block
+    raise ArgumentError, "block must be provided for select" unless block_given?
 
     _select_by_block block, @root
   end
@@ -193,6 +201,17 @@ class RedBlackTree
     !search(data).nil?
   end
 
+  # Traverses the tree in in-order and yields each node.
+  # When called without a block, returns an {Enumerator}.
+  #
+  # @yield [RedBlackTree::Node] the block to be executed for each node
+  # @return [void, Enumerator]
+  def each &block
+    return enum_for(:each) unless block_given?
+
+    traverse_in_order(&block)
+  end
+
   # Traverses the tree in pre-order and yields each node.
   #
   # @param node [RedBlackTree::Node] the node to start the traversal from
@@ -243,11 +262,9 @@ class RedBlackTree
     queue = [@root]
     until queue.empty?
       node = queue.shift
-      next if node.nil? || node.leaf?
-
       block.call node
-      queue << node.left
-      queue << node.right
+      queue << node.left unless node.left.leaf?
+      queue << node.right unless node.right.leaf?
     end
   end
 
@@ -329,13 +346,12 @@ class RedBlackTree
   def delete_node_with_two_children! node
     is_root = is_root? node
 
-    successor = node.left
-    successor = successor.right until successor.right.leaf?
-    node.swap_colour_with! successor
-    node.swap_position_with! successor
-    node.swap_position_with! LeafNode.new
+    predecessor = node.left
+    predecessor = predecessor.right until predecessor.right.leaf?
+    node.swap_colour_with! predecessor
+    node.swap_position_with! predecessor
 
-    @root = successor if is_root
+    @root = predecessor if is_root
   end
 
   def delete_node_with_one_child! node

data/lib/red_black_tree/node.rb

@@ -9,7 +9,7 @@ class RedBlackTree
   class Node
     class << self
       def inherited subclass
-        subclass.prepend LeafNodeComparable
+        subclass.prepend LeafNodeComparable unless subclass == ::RedBlackTree::LeafNode
       end
     end
 

data/lib/red_black_tree/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 class RedBlackTree
-  VERSION = "0.1.8"
+  VERSION = "0.1.10"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: red-black-tree
 version: !ruby/object:Gem::Version
-  version: 0.1.8
+  version: 0.1.10
 platform: ruby
 authors:
 - Joshua Young
@@ -49,7 +49,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.9
+rubygems_version: 4.0.10
 specification_version: 4
 summary: Red-Black Tree Data Structure for Ruby
 test_files: []