red-arrow-activerecord 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 5ac5974438fd59eeab35b60221680f207c80acfc
-  data.tar.gz: 3bac786c5c9058ad3fcac6bbdaff8e6b3f2ff731
+SHA256:
+  metadata.gz: 6e3ce2d50d09a561409312f1a6d46b9be1764028c7502b036147f8be00c1b5ce
+  data.tar.gz: e4a5aa2ccbcf04142b9e798e5363813476b42982154dfcc5b1ca259d975de5ab
 SHA512:
-  metadata.gz: c5c20bb8254c395ea9eafafcf9996e7dac7df8110c49685211fec1edecd82299f2de96c20d67f0f62c339e5e153c255be8e1e09349413891f0fc327422c2bb5d
-  data.tar.gz: e39eb1ea4ec0914dc0360b81c81b0b89ec9c848b2eafd3151574bf442795c24c138387fc91248c3df68ebdff823cd4504bb4165ac98b9ee203dfd2a10701094b
+  metadata.gz: b345fbf7fa5523565b991570bf09ea174be478e4b47644e0377c767380c6c27532ae4e2ad85e9587dccb7bbf48ad1eadd2b11e2c093e14ad81d91cb54300adbe
+  data.tar.gz: 752ec4e82b12c9f599fd02a1ea6b58204a4d7de22b7cf09b502bf7c183e3a55ddeaa74db73d02d3d07e49f6d02cf50fb4fe7f7c93f4835cba0ab8284f2bb8d5f

data/doc/text/news.md

@@ -1,5 +1,18 @@
 # News
 
+## 0.1.1 - 2019-02-02
+
+### Improvements
+
+  * Suppressed a warning.
+    [GitHub#3][Patch by Yasuo Honda]
+
+  * Changed to use Red Arrow 0.12.0 or later.
+
+### Thanks
+
+  * Yasuo Honda
+
 ## 0.1.0 - 2018-02-05
 
 Initial release!!!

data/lib/arrow-activerecord/arrowable.rb

@@ -7,34 +7,23 @@ module ArrowActiveRecord
       target_column_names = column_names if select_values.empty?
 
       fields = []
-      data_types = []
       target_column_names.each do |name|
         name = name.to_s
         target_column = columns.find do |column|
           column.name == name
         end
-        arrow_data_type = extract_arrow_data_type(target_column)
-        fields << Arrow::Field.new(name, arrow_data_type)
-        data_types << arrow_data_type
+        fields << {name: name, data_type: extract_arrow_data_type(target_column)}
       end
       schema = Arrow::Schema.new(fields)
 
-      arrow_array_batches = data_types.collect do
-        []
-      end
+      record_batches = []
+      record_batch_builder = Arrow::RecordBatchBuilder.new(schema)
       in_batches(of: batch_size).each do |relation|
-        column_values_set = relation.pluck(*target_column_names).transpose
-        data_types.each_with_index do |data_type, i|
-          column_values = column_values_set[i]
-          arrow_array_batches[i] << build_arrow_array(column_values, data_type)
-        end
-      end
-      columns = fields.collect.with_index do |field, i|
-        chunked_array = Arrow::ChunkedArray.new(arrow_array_batches[i])
-        Arrow::Column.new(field, chunked_array)
+        records = relation.pluck(*target_column_names)
+        record_batch_builder.append(records)
+        record_batches << record_batch_builder.flush
       end
-
-      Arrow::Table.new(schema, columns)
+      Arrow::Table.new(schema, record_batches)
     end
 
     private
@@ -49,56 +38,30 @@ module ArrowActiveRecord
       end
       case type
       when :bigint
-        Arrow::Int64DataType.new
+        :int64
       when :binary
-        Arrow::BinaryDataType.new
+        :binary
       when :boolean
-        Arrow::BooleanDataType.new
+        :boolean
       when :date
-        Arrow::Date32DataType.new
+        :date32
       when :datetime
-        Arrow::TimestampDataType.new(:nano)
-      # when :decimal
+        [:timestamp, :nano]
+      when :decimal
+        [:decimal128, type.precision, type.scale]
       when :float
-        Arrow::FloatDataType.new
+        :float
       when :integer
-        Arrow::Int32DataType.new
+        :int32
       # when :json
       when :string, :text
-        Arrow::StringDataType.new
+        :string
       when :time, :timestamp
-        Arrow::TimestampDataType.new(:nano)
-      when :timestamp
-        Arrow::TimestampDataType.new(:nano)
+        [:timestamp, :nano]
       else
         message = "unsupported data type: #{type}: #{column.inspect}"
         raise NotImplementedError, message
       end
     end
-
-    def build_arrow_array(column_values, data_type)
-      case data_type
-      when Arrow::Int64DataType
-        Arrow::Int64Array.new(column_values)
-      when Arrow::BinaryDataType
-        Arrow::BinaryArray.new(column_values)
-      when Arrow::BooleanDataType
-        Arrow::BooleanArray.new(column_values)
-      when Arrow::Date32DataType
-        Arrow::Date32Array.new(column_values)
-      when Arrow::TimestampDataType
-        builder = Arrow::TimestampArrayBuilder.new(data_type)
-        builder.build(column_values)
-      when Arrow::FloatDataType
-        Arrow::FloatArray.new(column_values)
-      when Arrow::Int32DataType
-        Arrow::Int32Array.new(column_values)
-      when Arrow::StringDataType
-        Arrow::StringArray.new(column_values)
-      else
-        message = "unsupported data type: #{data_type.inspect}"
-        raise NotImplementedError, message
-      end
-    end
   end
 end

data/lib/arrow-activerecord/version.rb

@@ -1,3 +1,3 @@
 module ArrowActiverecord
-  VERSION = '0.1.0'
+  VERSION = '0.1.1'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: red-arrow-activerecord
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - hatappi
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-02-04 00:00:00.000000000 Z
+date: 2019-02-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -31,14 +31,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.12.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.12.0
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -129,7 +129,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.2.2
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: A library that provides conversion method between Apache Arrow and ActiveRecord