recursive-open-struct 1.0.4 → 1.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c20dbcb5ce4e4805d18e6c7ea454ef2357dbc224
-  data.tar.gz: d9a112d4e90c9355c3f7356e88b16f81fe8da7f7
+  metadata.gz: 1ce4a65c03dbe16514c0c612776ec39b9a2c311b
+  data.tar.gz: 3ff3fa9d5f9ebb3f9d51dd682102a1b78e1b426e
 SHA512:
-  metadata.gz: 7379ae006edd0cea0f1b052098042a6333cc8ed3509fa1742f77b54aa73d135eb483e41bfa7eb00e39b29fb2c7c5cc808cd788f4af0cb3ff0fdb11a77a4d2f77
-  data.tar.gz: ac6f2be126563fa292e523f2e463fa1a8f520f8d5e6b45c134e6d196a4bc50de4d1bcf144448cf8da7b5b862615cf400efaf094efd1c11c9b55e7f5e96fa7175
+  metadata.gz: a3d79ba1465c421d5d0b0364b28b6bcc1b49d62e766e1aa7d2c5a1670a561e079808e32a2664bf055e654cf94bdb8fd53fe6a3c3087a4078c35c484d7b92d2d7
+  data.tar.gz: 5fded05b30f636676539de9aaed356c735e9adb43fedc020691494ace3330eccb9ad78349646511a0a5b3164dabe91452e1e95d7263191ffdd12baa721ecc23e

data/AUTHORS.txt

@@ -1,5 +1,6 @@
 Recursive-open-struct was written by these fine people:
 
+* Beni Cherniavsky-Paskin <cben@redhat.com>
 * Cédric Felizard <cedric@felizard.fr>
 * Federico Aloi <federico.aloi@gmail.com>
 * fervic <roberto@runawaybit.com>

data/CHANGELOG.md

@@ -1,8 +1,14 @@
+1.0.5 / 2017-06-21
+==================
+
+* FIX [#54](https://github.com/aetherknight/recursive-open-struct/pull/54):
+  Beni Cherniavsky-Paskin: Improve performance of `new_ostruct_member` by using
+  `self.singleton_class.method_defined?` instead of `self.methods.include?`
+
 1.0.4 / 2017-04-29
 ==================
 
-* FIX
-  [#52](https://github.com/aetherknight/recursive-open-struct/pull/52): Joe
+* FIX [#52](https://github.com/aetherknight/recursive-open-struct/pull/52): Joe
   Rafaniello: Improve performance of DeepDup by using Set instead of an Array
   to track visited nodes.
 

data/LICENSE.txt

@@ -1,4 +1,4 @@
-Copyright (c) 2009-2016, The Recursive-open-struct developers (given in the
+Copyright (c) 2009-2017, The Recursive-open-struct developers (given in the
 file AUTHORS.txt).
 
 Permission is hereby granted, free of charge, to any person obtaining

data/README.md

@@ -47,14 +47,22 @@ You may also install the gem manually :
     gem install recursive-open-struct
 
 ## Contributing
- 
-* Fork the project.
-* Make your feature addition or bug fix.
-* Add tests for your new or changed functionality. Make sure the tests you add
-  provide clean and clear explanation of the feature.
-* Send me a pull request. Bonus points for topic branches.
+
+For simple bug fixes, feel free to provide a pull request.
+
+For anything else (new features, bugs that you want to report, and bugs that
+are difficult to fix), I recommend opening an issue first to discuss the
+feature or bug. I am fairly cautious about adding new features that might cause
+RecursiveOpenStruct's API to deviate radically from OpenStruct's (since it
+might introduce new reserved method names), and it is useful to discuss the
+best way to solve a problem when there are tradeoffs or imperfect solutions.
+
+When contributing code that changes behavior or fixes bugs, please include unit
+tests to cover the new behavior or to provide regression testing for bugs.
+Also, treat the unit tests as documentation --- make sure they are clean,
+clear, and concise, and well organized.
 
 ## Copyright
 
-Copyright (c) 2009-2016, The Recursive-open-struct developers (given in the
+Copyright (c) 2009-2017, The Recursive-open-struct developers (given in the
 file AUTHORS.txt). See LICENSE.txt for details.

data/lib/recursive_open_struct.rb

@@ -95,7 +95,7 @@ class RecursiveOpenStruct < OpenStruct
   # 2.4.0.
   def new_ostruct_member(name)
     key_name = _get_key_from_table_(name)
-    unless self.methods.include?(name.to_sym)
+    unless self.singleton_class.method_defined?(name.to_sym)
       class << self; self; end.class_eval do
         define_method(name) do
           self[key_name]

data/lib/recursive_open_struct/version.rb

@@ -3,5 +3,5 @@
 require 'ostruct'
 
 class RecursiveOpenStruct < OpenStruct
-  VERSION = "1.0.4"
+  VERSION = "1.0.5"
 end

data/spec/recursive_open_struct/ostruct_2_0_0_spec.rb

@@ -96,7 +96,13 @@ describe RecursiveOpenStruct do
 
     context "each_pair" do
       it "iterates over hash keys, with keys as symbol" do
-        expect(ros.each_pair).to match ({:foo => 'foo', :bar => :bar}.each_pair)
+        ros_pairs = []
+        ros.each_pair {|k,v| ros_pairs << [k,v]}
+
+        hash_pairs = []
+        {:foo => 'foo', :bar => :bar}.each_pair {|k,v| hash_pairs << [k,v]}
+
+        expect(ros_pairs).to match (hash_pairs)
       end
     end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: recursive-open-struct
 version: !ruby/object:Gem::Version
-  version: 1.0.4
+  version: 1.0.5
 platform: ruby
 authors:
 - William (B.J.) Snow Orvis
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-04-29 00:00:00.000000000 Z
+date: 2017-06-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler