recurly 3.0.0.beta.4 → 3.0.0.beta.5

data/lib/recurly/resources/user.rb

@@ -6,13 +6,13 @@ module Recurly
   module Resources
     class User < Resource
 
-      # @!attribute [r] created_at
+      # @!attribute created_at
       #   @return [DateTime]
-      define_attribute :created_at, DateTime, { :read_only => true }
+      define_attribute :created_at, DateTime
 
-      # @!attribute [r] deleted_at
+      # @!attribute deleted_at
       #   @return [DateTime]
-      define_attribute :deleted_at, DateTime, { :read_only => true }
+      define_attribute :deleted_at, DateTime
 
       # @!attribute email
       #   @return [String]
@@ -22,17 +22,17 @@ module Recurly
       #   @return [String]
       define_attribute :first_name, String
 
-      # @!attribute [r] id
+      # @!attribute id
       #   @return [String]
-      define_attribute :id, String, { :read_only => true }
+      define_attribute :id, String
 
       # @!attribute last_name
       #   @return [String]
       define_attribute :last_name, String
 
-      # @!attribute [r] object
+      # @!attribute object
       #   @return [String] Object type
-      define_attribute :object, String, { :read_only => true }
+      define_attribute :object, String
 
       # @!attribute time_zone
       #   @return [String]

data/lib/recurly/schema.rb

@@ -88,7 +88,7 @@ module Recurly
       # @return [String]
       attr_accessor :description
 
-      def initialize(name, type, options={}, description=nil)
+      def initialize(name, type, options = {}, description = nil)
         @name = name
         @type = type
         @options = options
@@ -113,9 +113,8 @@ module Recurly
     private_constant :Attribute
   end
 
-
-  require_relative './schema/schema_factory'
-  require_relative './schema/schema_validator'
-  require_relative './schema/json_deserializer'
-  require_relative './schema/request_caster'
+  require_relative "./schema/schema_factory"
+  require_relative "./schema/schema_validator"
+  require_relative "./schema/json_deserializer"
+  require_relative "./schema/request_caster"
 end

data/lib/recurly/schema/json_deserializer.rb

@@ -1,4 +1,4 @@
-require 'date'
+require "date"
 
 module Recurly
   class Schema
@@ -18,7 +18,7 @@ module Recurly
       def from_json(attributes = {})
         resource = new()
         attributes.each do |attr_name, val|
-          next if attr_name == 'object'
+          next if attr_name == "object"
 
           schema_attr = self.schema.get_attribute(attr_name)
 
@@ -44,8 +44,9 @@ module Recurly
 
             resource.send(writer, val)
           else
-            # TODO ignoring these missing fields for now
-            puts "Missing #{attr_name}"
+            if Recurly::STRICT_MODE
+              raise ArgumentError, "#{resource.class.name} encountered json attribute #{attr_name.inspect}: #{val.inspect} but it's unknown to it's schema"
+            end
           end
         end
         resource

data/lib/recurly/schema/json_parser.rb

@@ -1,4 +1,4 @@
-require 'json'
+require "json"
 
 module Recurly
   # This is a wrapper class to help parse responses into Recurly objects.
@@ -23,7 +23,7 @@ module Recurly
       type = if data.has_key?("error")
                "error"
              else
-               data.delete('object')
+               data.delete("object")
              end
       klazz = self.recurly_class(type)
 
@@ -52,10 +52,10 @@ module Recurly
       case type
       when nil
         nil
-      when 'list'
+      when "list"
         Pager
       else
-        type_camelized = type.split('_').map(&:capitalize).join
+        type_camelized = type.split("_").map(&:capitalize).join
         if Resources.const_defined?(type_camelized)
           klazz = Resources.const_get(type_camelized)
           if klazz.ancestors.include?(Resource)

data/lib/recurly/schema/request_caster.rb

@@ -1,4 +1,4 @@
-require 'date'
+require "date"
 
 module Recurly
   class Schema
@@ -25,13 +25,13 @@ module Recurly
       # @param data [Hash,Resource,Request] The data to transform into a JSON Hash.
       # @param schema [Schema] The schema to use to transform the data into a JSON Hash.
       # @return [Hash] The pure Hash ready to be serialized into JSON.
-      def cast(data, schema=self.schema)
+      def cast(data, schema = self.schema)
         casted = {}
         if data.is_a?(Resource) || data.is_a?(Request)
           data = as_json(data, schema)
         end
 
-        data.each do |k,v|
+        data.each do |k, v|
           schema_attr = schema.get_attribute(k)
           norm_val = if v.respond_to?(:attributes)
                        cast(v, schema_attr.recurly_class.schema)
@@ -59,7 +59,7 @@ module Recurly
 
       def as_json(resource, schema)
         writeable_attributes = schema.attributes.reject(&:read_only?).map(&:name)
-        resource.attributes.select { |k,_| writeable_attributes.include?(k) }
+        resource.attributes.select { |k, _| writeable_attributes.include?(k) }
       end
     end
   end

data/lib/recurly/schema/schema_factory.rb

@@ -28,7 +28,7 @@ module Recurly
       #   acount.code = "newcode" # this method protected since read_only = true
       #   account.code
       #   #=> "mycode"
-      def define_attribute(name, type, options={})
+      def define_attribute(name, type, options = {})
         attribute = schema.add_attribute(name, type, options)
 
         # Define the reader

data/lib/recurly/schema/schema_validator.rb

@@ -118,7 +118,7 @@ module Recurly
           while j < m
             cost = (char1 == str2_codepoints[j]) ? 0 : 1
             x = min3(
-              d[j+1] + 1, # insertion
+              d[j + 1] + 1, # insertion
               i + 1,      # deletion
               d[j] + cost # substitution
             )
@@ -145,4 +145,3 @@ module Recurly
     end
   end
 end
-

data/lib/recurly/version.rb

@@ -1,3 +1,3 @@
 module Recurly
-  VERSION = "3.0.0.beta.4"
+  VERSION = "3.0.0.beta.5"
 end

data/recurly.gemspec

@@ -1,20 +1,20 @@
 # coding: utf-8
-lib = File.expand_path('../lib', __FILE__)
+lib = File.expand_path("../lib", __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require 'recurly/version'
+require "recurly/version"
 
 Gem::Specification.new do |spec|
-  spec.name          = "recurly"
-  spec.version       = Recurly::VERSION
-  spec.authors       = ["Recurly"]
-  spec.email         = ["support@recurly.com"]
+  spec.name = "recurly"
+  spec.version = Recurly::VERSION
+  spec.authors = ["Recurly"]
+  spec.email = ["support@recurly.com"]
 
-  spec.summary       = "The ruby client for Recurly's Partner API"
-  spec.description   = "The ruby client for Recurly's Partner API"
-  spec.homepage      = "https://partner-docs.recurly.com"
-  spec.license       = "MIT"
+  spec.summary = "The ruby client for Recurly's Partner API"
+  spec.description = "The ruby client for Recurly's Partner API"
+  spec.homepage = "https://partner-docs.recurly.com"
+  spec.license = "MIT"
 
-  spec.files         = `git ls-files -z`.split("\x0").reject do |f|
+  spec.files = `git ls-files -z`.split("\x0").reject do |f|
     f.match(%r{^(test|spec|features)/})
   end
   # spec.bindir        = "exe"
@@ -30,4 +30,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "yard", "~> 0.9"
   spec.add_development_dependency "pry", "~> 0.10"
   spec.add_development_dependency "simplecov", "~> 0.16"
+  spec.add_development_dependency "rufo", "~> 0.7"
 end

data/scripts/format

@@ -0,0 +1,6 @@
+#!/usr/bin/env bash
+if [ "$1" == "--check" ]; then
+  ./bin/rufo . --check
+else
+  ./bin/rufo . -x
+fi

data/scripts/test

@@ -1,3 +1,14 @@
 #!/usr/bin/env bash
 
-./bin/rspec
+# First check formatting
+echo "Checking style..."
+./scripts/format --check
+if [ $? -ne 0 ]; then
+  echo "Code does not conform to style guide. To autoformat, run './scripts/format'."
+  exit 1
+else
+  echo "Style check passed"
+fi
+
+# Run tests
+rake spec

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: recurly
 version: !ruby/object:Gem::Version
-  version: 3.0.0.beta.4
+  version: 3.0.0.beta.5
 platform: ruby
 authors:
 - Recurly
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-04-04 00:00:00.000000000 Z
+date: 2019-06-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -128,6 +128,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.16'
+- !ruby/object:Gem::Dependency
+  name: rufo
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.7'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.7'
 description: The ruby client for Recurly's Partner API
 email:
 - support@recurly.com
@@ -156,6 +170,7 @@ files:
 - lib/recurly/requests/account_acquisition_cost.rb
 - lib/recurly/requests/account_acquisition_updatable.rb
 - lib/recurly/requests/account_create.rb
+- lib/recurly/requests/account_purchase.rb
 - lib/recurly/requests/account_update.rb
 - lib/recurly/requests/add_on_create.rb
 - lib/recurly/requests/add_on_pricing.rb
@@ -178,12 +193,15 @@ files:
 - lib/recurly/requests/plan_hosted_pages.rb
 - lib/recurly/requests/plan_pricing.rb
 - lib/recurly/requests/plan_update.rb
+- lib/recurly/requests/purchase_create.rb
 - lib/recurly/requests/shipping_address_create.rb
 - lib/recurly/requests/shipping_address_update.rb
 - lib/recurly/requests/subscription_add_on_create.rb
 - lib/recurly/requests/subscription_change_create.rb
 - lib/recurly/requests/subscription_create.rb
 - lib/recurly/requests/subscription_pause.rb
+- lib/recurly/requests/subscription_purchase.rb
+- lib/recurly/requests/subscription_shipping_purchase.rb
 - lib/recurly/requests/subscription_update.rb
 - lib/recurly/resource.rb
 - lib/recurly/resources/account.rb
@@ -244,9 +262,8 @@ files:
 - lib/recurly/version.rb
 - recurly.gemspec
 - scripts/build
-- scripts/check-deps
 - scripts/clean
-- scripts/install-deps
+- scripts/format
 - scripts/test
 homepage: https://partner-docs.recurly.com
 licenses:
@@ -268,7 +285,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 1.3.1
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.14.1
+rubygems_version: 2.6.14.3
 signing_key: 
 specification_version: 4
 summary: The ruby client for Recurly's Partner API

data/scripts/check-deps

@@ -1,28 +0,0 @@
-#!/usr/bin/env bash
-set -e
-
-function check_for_command {
-  if ! hash eval "$1" 2>/dev/null; then
-    echo "✖ Could not find '$1'" 
-    exit 1
-  fi
-  echo "✓ Found $1"
-}
-
-check_for_command "ruby"
-check_for_command "bundle"
-
-RUBY_VERSION=$(ruby --version)
-RUBY_MAJOR=$(ruby --version | cut -d' ' -f2 | cut -d'.' -f1)
-RUBY_MINOR=$(ruby --version | cut -d' ' -f2 | cut -d'.' -f2)
-
-function unsupported_ruby_version {
-  echo "✖ Unsupported ruby version is ${RUBY_VERSION}"
-  exit 1
-}
-
-if [ "$RUBY_MAJOR" -lt "2" ] || [ "$RUBY_MINOR" -lt "3" ]; then
-  unsupported_ruby_version
-else
-  echo "✓ Version ${RUBY_VERSION} is compatible"
-fi

data/scripts/install-deps

@@ -1,44 +0,0 @@
-#!/usr/bin/env bash
-set -e
-
-if ! hash brew 2>/dev/null; then
-  echo "✖ Homebrew not found. Please install: https://brew.sh/"
-  exit 1
-else
-  echo "✓ Found homebrew"
-fi
-
-if ! hash rbenv 2>/dev/null; then
-  read -p "✖ 'rbenv' not found. Would you like to install it? [Y/n] " -n 1 -r
-  echo
-  if [[ $REPLY =~ ^[Yy\n]$ ]]
-  then
-    brew install rbenv ruby-build && true
-    echo
-    echo "Please follow the rbenv instructions below before continuing:"
-    eval "$(rbenv init -)"
-    echo $(rbenv init)
-    read -p "Press enter to continue"
-    # Installs latest stable version
-    VERSION=$(rbenv install -l | grep -v - | tail -1)
-    rbenv install $VERSION
-    rbenv global $VERSION
-  else
-    exit 1
-  fi
-else
-  echo "✓ Found rbenv"
-fi
-
-if ! hash bundle 2>/dev/null; then
-  read -p "✖ 'bundle' not found. Would you like to install it? [Y/n] " -n 1 -r
-  echo
-  if [[ $REPLY =~ ^[Yy]$ ]]
-  then
-    gem install bundler
-  else
-    exit 1
-  fi
-else
-  echo "✓ Found bundle"
-fi