recurly 2.2.3 → 2.2.4

checksums.yaml

@@ -1,15 +1,7 @@
 ---
-!binary "U0hBMQ==":
-  metadata.gz: !binary |-
-    NjhkNmMyMGU5YjU3YWFhNTI4MjU1NGU1YzRjZjJiYzJmMzdkNTA5ZA==
-  data.tar.gz: !binary |-
-    MjdjMmM5OGU4MGE0NjFlMmIzMDkxZTAxYTlmNjE4ODc5NTAzYmY3OQ==
+SHA1:
+  metadata.gz: ab34994a1c9c447dfadd88e6a57ca425ea9e260e
+  data.tar.gz: 1dad0cdd579adde8eeba75f613b9393e578e7609
 SHA512:
-  metadata.gz: !binary |-
-    NGVlOTllNWEwZjdmZjI4OWY0MmExYjc3YWY3NzVkNDRjNjY4YzdlNmQzOTVm
-    ZWIzYzk0ZTA4OWM4ZDVmODIyYTM1NTVjNDA0NmQyZWU4ZThlNDViNjdhZjQ2
-    NzFkZDE0OTFkMWY2MmExYzgyNTk5NGUwMDM4ZTg1MmYzNWI1NDU=
-  data.tar.gz: !binary |-
-    NDJiNzlkNTYxMTc2YmViOWJhNGNmNjI0MGQyY2QxZjQxNmJmM2M2Yjk5ZDgx
-    NDE0Y2FmMzIzZGFkZTdiYzUzYzJkNGYyMGI0M2I3OGIxZGYxMzc1MDZlMjYx
-    ZThhOGQ0OWNiMTI0NzA0ZTQ0MjY5OTJlYmRjZWU4MmI0ZDNiZWI=
+  metadata.gz: 2b8e90a4bb40f8ae9b90bf64ff8d905eed197ef9c06b4e38b5c5fa74cdb63f1732f3e0e70c25c66389569852dc952efaf395ff95496d93fa3873fa4b6fcb019d
+  data.tar.gz: 1f989840edba57d172d368766b35d51cd5979da1b3475d924d73d408c60ed3d605ab2c04a11175710159676b48dc1c1312f021ddf5fc9ebe19913cde378d2413

data/README.md

@@ -12,7 +12,7 @@ Recurly is packaged as a Ruby gem. We recommend you install it with
 [Bundler](http://gembundler.com/) by adding the following line to your Gemfile:
 
 ``` ruby
-gem 'recurly', '~> 2.2.3'
+gem 'recurly', '~> 2.2.4'
 ```
 
 Recurly will automatically use [Nokogiri](http://nokogiri.org/) (for a nice

data/lib/recurly/api.rb

@@ -15,6 +15,7 @@ module Recurly
     require 'recurly/api/errors'
 
     @@base_uri = "https://api.recurly.com/v2/"
+    @@valid_domains = [".recurly.com"]
 
     FORMATS = Helper.hash_with_indifferent_read_access(
       'pdf' => 'application/pdf',
@@ -73,6 +74,13 @@ module Recurly
         URI.parse @@base_uri.sub('api', Recurly.subdomain)
       end
 
+      def validate_uri!(uri)
+        domain = @@valid_domains.detect { |d| uri.host.end_with?(d) }
+        unless domain
+          raise ArgumentError, "URI #{uri} is invalid. You may only make requests to a Recurly domain."
+        end
+      end
+
       # @return [String]
       def user_agent
         "Recurly/#{Version}; #{RUBY_DESCRIPTION}"

data/lib/recurly/api/net_http_adapter.rb

@@ -36,13 +36,14 @@ module Recurly
           head = headers.dup
           head.update options[:head] if options[:head]
           head.delete_if { |_, value| value.nil? }
-          uri = base_uri + URI.escape(uri)
+          uri = base_uri + uri
           if options[:params] && !options[:params].empty?
             pairs = options[:params].map { |key, value|
               "#{CGI.escape key.to_s}=#{CGI.escape value.to_s}"
             }
             uri += "?#{pairs.join '&'}"
           end
+          self.validate_uri!(uri)
           request = METHODS[method].new uri.request_uri, head
           request.basic_auth(*[Recurly.api_key, nil].flatten[0, 2])
           if options[:body]

data/lib/recurly/resource.rb

@@ -1,4 +1,5 @@
 require 'date'
+require 'erb'
 
 module Recurly
   # The base class for all Recurly resources (e.g. {Account}, {Subscription},
@@ -184,6 +185,7 @@ module Recurly
       #   Recurly::Account.member_path "code" # => "accounts/code"
       #   Recurly::Account.member_path nil    # => "accounts"
       def member_path uuid
+        uuid = ERB::Util.url_encode(uuid) if uuid
         [collection_path, uuid].compact.join '/'
       end
 
@@ -319,9 +321,8 @@ module Recurly
           raise NotFound, "can't find a record with nil identifier"
         end
 
-        uri = uuid =~ /^http/ ? uuid : member_path(uuid)
         begin
-          from_response API.get(uri, {}, options)
+          from_response API.get(member_path(uuid), {}, options)
         rescue API::NotFound => e
           raise NotFound, e.description
         end

data/lib/recurly/version.rb

@@ -2,7 +2,7 @@ module Recurly
   module Version
     MAJOR   = 2
     MINOR   = 2
-    PATCH   = 3
+    PATCH   = 4
     PRE     = nil
 
     VERSION = [MAJOR, MINOR, PATCH, PRE].compact.join('.').freeze

metadata

@@ -1,58 +1,58 @@
 --- !ruby/object:Gem::Specification
 name: recurly
 version: !ruby/object:Gem::Version
-  version: 2.2.3
+  version: 2.2.4
 platform: ruby
 authors:
 - Recurly
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-05-09 00:00:00.000000000 Z
+date: 2017-11-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 0.9.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 0.9.2
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 2.6.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 2.6.1
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 1.7.6
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 1.7.6
-description: ! 'An API client library for Recurly: http://recurly.com'
+description: 'An API client library for Recurly: http://recurly.com'
 email: support@recurly.com
 executables:
 - recurly
@@ -100,25 +100,24 @@ licenses:
 metadata: {}
 post_install_message: 
 rdoc_options:
-- --main
+- "--main"
 - README.md
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: 1.9.3
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.6.13
 signing_key: 
 specification_version: 4
 summary: Recurly API Client
 test_files: []
-has_rdoc: true