rectify 0.12.0 → 0.13.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 2917c203f981798ec8aece021edc988fa3401407
-  data.tar.gz: d8e3dd7970418ebf72d27d21c64e458e58eed93f
+SHA256:
+  metadata.gz: 746036ed910a8095cff3044cbda94ee43a8879f9387e2d34e9020651ceff587f
+  data.tar.gz: 9b3883bf9a2af976f15edfc678d032b3c878ac3a5b11ca95eab2b853d38fe1ea
 SHA512:
-  metadata.gz: 0a2e6048a2d9489e94c2420d924fd9f1b5d0450684d9970f99a22ddd7523a1a5260307b7ba93079a94682a7a42debbdbe585011400f59a79e617512445512746
-  data.tar.gz: 6ef948555bf0bb6a7f20c114e860cad00036987a5879a877d2bf22bcd14e4b744eed19a445da307bc2bab7546427a38337a2780e7634afd9e299043b12221a98
+  metadata.gz: 2edb94003a8a75bdb2d050e8e78167f1cd021300f9daed422a93b9b10afc4667024508ae818cde5363722d5f9f8f69d6cbf47864bae06ee60020facfe2bcb496
+  data.tar.gz: 6002583baf035ed5011f152429f984c4e07b2da47833b4b3eb889b9732fb3e4d8bb3a03c90f8e2df1a4196c82b21e6a0a1a15603cbcedade620a5c3dc2af29fc

data/lib/rectify/form.rb

@@ -9,10 +9,10 @@ module Rectify
 
     def self.from_params(params, additional_params = {})
       params_hash = hash_from(params)
+      mimicked_params = ensure_hash(params_hash[mimicked_model_name])
 
       attributes_hash = params_hash
-        .fetch(mimicked_model_name, {})
-        .merge(params_hash)
+        .merge(mimicked_params)
         .merge(additional_params)
 
       formatted_attributes = FormatAttributesHash
@@ -54,6 +54,14 @@ module Rectify
       params.with_indifferent_access
     end
 
+    def self.ensure_hash(object)
+      if object.is_a?(Hash)
+        object
+      else
+        {}
+      end
+    end
+
     def persisted?
       id.present? && id.to_i > 0
     end

data/lib/rectify/format_attributes_hash.rb

@@ -16,16 +16,28 @@ module Rectify
     attr_reader :attribute_set
 
     def convert_indexed_hashes_to_arrays(attributes_hash)
-      array_attribute_names.each do |name|
+      array_attributes.each do |array_attribute|
+        name = array_attribute.name
         attribute = attributes_hash[name]
         next unless attribute.is_a?(Hash)
 
-        attributes_hash[name] = attribute.values
+        attributes_hash[name] = transform_values_for_type(
+          attribute.values,
+          array_attribute.member_type.primitive
+        )
       end
     end
 
-    def array_attribute_names
-      attribute_set.select { |a| a.primitive == Array }.map { |a| a.name.to_s }
+    def transform_values_for_type(values, element_type)
+      return values unless element_type < Rectify::Form
+
+      values.map do |value|
+        self.class.new(element_type.attribute_set).format(value)
+      end
+    end
+
+    def array_attributes
+      attribute_set.select { |attribute| attribute.primitive == Array }
     end
 
     def convert_hash_keys(value)

data/lib/rectify/version.rb

@@ -1,3 +1,3 @@
 module Rectify
-  VERSION = "0.12.0".freeze
+  VERSION = "0.13.0".freeze
 end

data/readme.md

@@ -473,6 +473,27 @@ other data in your params hash is ignored.
 Take a look at [Virtus](https://github.com/solnic/virtus) for more information
 about how to build a form object.
 
+### I18n
+
+Regarding internationalization, the main affected classes when coercing are `Date` and `Time` classes. This is coercing Strings into `Date`, `DateTime` and `Time`. Texts don't usually need to be coerced as they are simple String attributes with nothing special in them.
+
+When coercing dates and times in a multi-language application, each locale will have its own date and time formats, and these formats should be taken into account when coercing strings (inputs entered by the user, or comming form external sources).
+
+So for `Date`, `DateTime` and `Time` classes, Rectify does not support I18n by default. But there are some ways to achieve it indirectly.
+
+Probably the best is to define custom `Virtus::Attribute`s for each kind of temporal class. For exmaple:
+
+```ruby
+class LocalizedDate < Virtus::Attribute
+  def coerce(value)
+    return value unless value.is_a?(String)
+    Date.strptime(value, I18n.t("date.formats.short"))
+  rescue ArgumentError
+    nil
+  end
+end
+```
+
 ## Commands
 
 Commands (also known as Service Objects) are the home of your business logic.

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rectify
 version: !ruby/object:Gem::Version
-  version: 0.12.0
+  version: 0.13.0
 platform: ruby
 authors:
 - Andy Pike
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-05-22 00:00:00.000000000 Z
+date: 2018-10-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -142,14 +142,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.4'
+        version: '3.8'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.4'
+        version: '3.8'
 - !ruby/object:Gem::Dependency
   name: rspec-collection_matchers
   requirement: !ruby/object:Gem::Requirement
@@ -242,7 +242,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5.1
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: Improvements for building Rails apps