recourse 7.1.0 → 7.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 80390029ce0bfed87fcf8247faceb992a392422044f0b0641bbfadb9bd3660f0
-  data.tar.gz: 81f226e7f69b2fa9846e2bc80e610d227e182d680b8c1d563b095a26f26fee1c
+  metadata.gz: b5902f16def7afce17cc0aec2d67eb1255ffc504af58cbd766146a4f3e7f3077
+  data.tar.gz: 3e917516c8a76bdc0fe30497e02d7181a886d96f500cd765dfbe6202f4785452
 SHA512:
-  metadata.gz: f87b1572b17070744c3c03c2f64b6d699e53a738270b4bf2d88f0040264992a050709e891fde967e2c21f64508e41191a56cab0ba3b7e3dda1fa04bb3b25f9dd
-  data.tar.gz: bcf92ebc75b14486038c81b558580ff958e49d28a17259d895a97888e5a350dd3afe610f72b959b343a9a47b9c41a09b203518b1f28532d61fada8df683b5f2c
+  metadata.gz: d1a6d35fa1bd005290644f5f8981ac7a7837fda2f6bb9919b3225518ab41bacdf497d261827116b43928b1cf1f918eea3b5030de38faed3bd195aa257db6f798
+  data.tar.gz: e242d7c656755f01f53c1e2f3c1f9b75c89bbc5654b50a3dc44e6bb7f768c64321572c024e7d52fe036dcfc9c65bed2eaee7464815617e2294bfcbecc64350dc

data/CHANGELOG.md

@@ -7,6 +7,22 @@ For more information about changelogs, check [Keep a Changelog](http://keepachan
 
 ## [Unreleased]
 
+## 7.2.1 - 2026-09-20
+
+* [FIX] A refused change keeps the card it was made in
+
+  The card is drawn around a record's own pages, worked out from the action: `show` and
+  `edit`. A write a validation turns down draws `edit` again under the name `update`, so
+  the tabs went with it and the reader was left with a form and no way back.
+
+## 7.2.0 - 2026-09-20
+
+* [CHANGE] A row a model will not give up says so, rather than raising
+
+  `destroy` was `destroy!`, so a `before_destroy` that threw `:abort` answered a reader
+  with a 500. The page keeps the row and says `Specialty could not be deleted.`, the way
+  an update that a validation turned down says what it says.
+
 ## 7.1.0 - 2026-09-20
 
 * [CHANGE] The card draws the button that deletes what the page is about

data/app/controllers/concerns/recourse/attachment_writing.rb

@@ -23,7 +23,7 @@ module Recourse
     def destroy_resource(record)
       return super unless attachment_reflection
 
-      attachment_of(record).destroy!
+      attachment_of(record).destroy
     end
 
     # Attached rather than assigned, which is the whole reason this exists. Rails'

data/app/controllers/concerns/recourse/reference_resolution.rb

@@ -24,7 +24,7 @@ module Recourse
 
     # And the record gone. `destroy!`, so a callback that stops one says so rather than
     # leaving the page claiming it worked.
-    def destroy_resource(record) = record.destroy!
+    def destroy_resource(record) = record.destroy
 
     # A foreign key whose label is typed arrives as that label, so it is looked up
     # here. Nothing found leaves the key nil, and `belongs_to` reports it missing.

data/app/controllers/recourse/base_controller.rb

@@ -65,11 +65,14 @@ module Recourse
       end
     end
 
-    # Deletes the record and shows the index without it. `destroy!`, so a callback that
-    # stops one says so rather than leaving the page claiming it worked.
+    # Deletes the record and shows the index without it. A callback that stops one is
+    # answered where the record still is, rather than left to raise or to let the page
+    # claim it worked: a row a model refuses to give up is a page's business, not a 500.
     def destroy
-      destroy_resource @recourse
-      wrote t('recourse.deleted', model: human_name)
+      return wrote t('recourse.deleted', model: human_name) if destroy_resource @recourse
+
+      flash.alert = t 'recourse.deleted_error', model: human_name
+      redirect_back fallback_location: url_for(action: :index), status: :see_other
     end
 
   private

data/config/locales/recourse.en.yml

@@ -50,6 +50,7 @@ en:
     darken: Dark
     delete: Delete %{model}
     deleted: "%{model} was deleted."
+    deleted_error: "%{model} could not be deleted."
     destroy: Delete
     exit: Exit
     displaying:

data/lib/recourse/helpers/cards.rb

@@ -3,13 +3,18 @@ module Recourse
     # The tabs on the card a record's pages share: a look, a change, and each
     # nested index under the record — counted where the record keeps a count.
     module Cards
+      # The pages a record's card is drawn around. `update` is the change page too: a
+      # write a validation turns down draws the form again, and the tabs a reader came
+      # in by are still the record's.
+      CARDED = %w[show edit update].freeze
+
     private
 
       # The record whose card this page is drawn in: the parent, on a page nested under
       # one, and the record itself where the page is its look or its change. An index of
       # its own, and a form for a record that is not there yet, stand outside a card.
       def card_record
-        resource_parent || (resource_record if controller.action_name.in? %w[show edit])
+        resource_parent || (resource_record if controller.action_name.in? CARDED)
       end
 
       # The pages of the record the card is about, as `[label, path, current]` — a

data/lib/recourse/version.rb

@@ -1,4 +1,4 @@
 module Recourse
   # Version of the gem, read by the gemspec and by hosts checking compatibility.
-  VERSION = '7.1.0'
+  VERSION = '7.2.1'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: recourse
 version: !ruby/object:Gem::Version
-  version: 7.1.0
+  version: 7.2.1
 platform: ruby
 authors:
 - claudiob