recourse 7.1.0 → 7.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 80390029ce0bfed87fcf8247faceb992a392422044f0b0641bbfadb9bd3660f0
-  data.tar.gz: 81f226e7f69b2fa9846e2bc80e610d227e182d680b8c1d563b095a26f26fee1c
+  metadata.gz: 95ef379a34df3d662d855df04690b3627584af8e5340d3bc7f9fd451569d6828
+  data.tar.gz: 6429eefa62d743af7e1071cac2bed85618fc36dba623551d14d01f62129b2ded
 SHA512:
-  metadata.gz: f87b1572b17070744c3c03c2f64b6d699e53a738270b4bf2d88f0040264992a050709e891fde967e2c21f64508e41191a56cab0ba3b7e3dda1fa04bb3b25f9dd
-  data.tar.gz: bcf92ebc75b14486038c81b558580ff958e49d28a17259d895a97888e5a350dd3afe610f72b959b343a9a47b9c41a09b203518b1f28532d61fada8df683b5f2c
+  metadata.gz: 487d50ea3bf02897f91807512d4624dd768b41483ccd5b4a4da74f4d3aa8e460c3491e3abe1739d13ca55480a985b9c93485112352c28bae5729c0969316f92b
+  data.tar.gz: 29540aff5c10c30fca2a7c79ac0fe6ad4f572d505be2a085dfc7f3675539941c0a67358a328a431a0d39974410665a5e7891c3511e88b93cb26926ba916d707e

data/CHANGELOG.md

@@ -7,6 +7,14 @@ For more information about changelogs, check [Keep a Changelog](http://keepachan
 
 ## [Unreleased]
 
+## 7.2.0 - 2026-09-20
+
+* [CHANGE] A row a model will not give up says so, rather than raising
+
+  `destroy` was `destroy!`, so a `before_destroy` that threw `:abort` answered a reader
+  with a 500. The page keeps the row and says `Specialty could not be deleted.`, the way
+  an update that a validation turned down says what it says.
+
 ## 7.1.0 - 2026-09-20
 
 * [CHANGE] The card draws the button that deletes what the page is about

data/app/controllers/concerns/recourse/attachment_writing.rb

@@ -23,7 +23,7 @@ module Recourse
     def destroy_resource(record)
       return super unless attachment_reflection
 
-      attachment_of(record).destroy!
+      attachment_of(record).destroy
     end
 
     # Attached rather than assigned, which is the whole reason this exists. Rails'

data/app/controllers/concerns/recourse/reference_resolution.rb

@@ -24,7 +24,7 @@ module Recourse
 
     # And the record gone. `destroy!`, so a callback that stops one says so rather than
     # leaving the page claiming it worked.
-    def destroy_resource(record) = record.destroy!
+    def destroy_resource(record) = record.destroy
 
     # A foreign key whose label is typed arrives as that label, so it is looked up
     # here. Nothing found leaves the key nil, and `belongs_to` reports it missing.

data/app/controllers/recourse/base_controller.rb

@@ -65,11 +65,14 @@ module Recourse
       end
     end
 
-    # Deletes the record and shows the index without it. `destroy!`, so a callback that
-    # stops one says so rather than leaving the page claiming it worked.
+    # Deletes the record and shows the index without it. A callback that stops one is
+    # answered where the record still is, rather than left to raise or to let the page
+    # claim it worked: a row a model refuses to give up is a page's business, not a 500.
     def destroy
-      destroy_resource @recourse
-      wrote t('recourse.deleted', model: human_name)
+      return wrote t('recourse.deleted', model: human_name) if destroy_resource @recourse
+
+      flash.alert = t('recourse.deleted_error', model: human_name)
+      redirect_back fallback_location: url_for(action: :index), status: :see_other
     end
 
   private

data/config/locales/recourse.en.yml

@@ -50,6 +50,7 @@ en:
     darken: Dark
     delete: Delete %{model}
     deleted: "%{model} was deleted."
+    deleted_error: "%{model} could not be deleted."
     destroy: Delete
     exit: Exit
     displaying:

data/lib/recourse/version.rb

@@ -1,4 +1,4 @@
 module Recourse
   # Version of the gem, read by the gemspec and by hosts checking compatibility.
-  VERSION = '7.1.0'
+  VERSION = '7.2.0'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: recourse
 version: !ruby/object:Gem::Version
-  version: 7.1.0
+  version: 7.2.0
 platform: ruby
 authors:
 - claudiob