recourse 7.0.0 → 7.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d4c5d237ba9ace6d0bde291127548ea5202ea729de90541d11240a5d2db0dae3
-  data.tar.gz: 7f266eaa7ba56f045c692702fa94c4163d09621bedfd3eb963ab025af5efba39
+  metadata.gz: 95ef379a34df3d662d855df04690b3627584af8e5340d3bc7f9fd451569d6828
+  data.tar.gz: 6429eefa62d743af7e1071cac2bed85618fc36dba623551d14d01f62129b2ded
 SHA512:
-  metadata.gz: c03bfff3a9f95fa135fd7aaf1b5b16e8c905dab9431d13bdc139aaf58cf5188d36164e1921260b6ba21fe3829bdea087bcefbf9f2082ddc73e06d6201ccee885
-  data.tar.gz: c79417ff860145a2da9a5e987d842f9d7351e1a92c91916a65714ae83b68786f4f6c557d6e60cdd35dbed670d24974831490235a5127cb4f8437962576e7dd7d
+  metadata.gz: 487d50ea3bf02897f91807512d4624dd768b41483ccd5b4a4da74f4d3aa8e460c3491e3abe1739d13ca55480a985b9c93485112352c28bae5729c0969316f92b
+  data.tar.gz: 29540aff5c10c30fca2a7c79ac0fe6ad4f572d505be2a085dfc7f3675539941c0a67358a328a431a0d39974410665a5e7891c3511e88b93cb26926ba916d707e

data/CHANGELOG.md

@@ -7,6 +7,32 @@ For more information about changelogs, check [Keep a Changelog](http://keepachan
 
 ## [Unreleased]
 
+## 7.2.0 - 2026-09-20
+
+* [CHANGE] A row a model will not give up says so, rather than raising
+
+  `destroy` was `destroy!`, so a `before_destroy` that threw `:abort` answered a reader
+  with a 500. The page keeps the row and says `Specialty could not be deleted.`, the way
+  an update that a validation turned down says what it says.
+
+## 7.1.0 - 2026-09-20
+
+* [CHANGE] The card draws the button that deletes what the page is about
+
+  It was drawn by the gem's own `edit` template, so a host writing a template of its own
+  lost it and wrote `destroy_resource_button` back by hand. The card draws it now, the way
+  it draws the tabs and the buttons beside the trail, and a host's page is its body alone.
+
+  A record's own page carries it, whichever of the two is open, so a resource routed to be
+  read and deleted but never changed is deleted from the page that reads it. Nothing gains
+  the ability to delete what it could not: a route without `destroy` draws no button.
+
+* [CHANGE] A column the database generates is never offered on a form
+
+  Postgres writes a stored generated column out of the others and takes no value for one,
+  so a field for it would be refused whatever was typed. Such a column is read on every
+  other screen as before.
+
 ## 7.0.0 - 2026-09-19
 
 * [BREAKING] What a page counts is the gem's to work out

data/app/controllers/concerns/recourse/attachment_writing.rb

@@ -23,7 +23,7 @@ module Recourse
     def destroy_resource(record)
       return super unless attachment_reflection
 
-      attachment_of(record).destroy!
+      attachment_of(record).destroy
     end
 
     # Attached rather than assigned, which is the whole reason this exists. Rails'

data/app/controllers/concerns/recourse/reference_resolution.rb

@@ -24,7 +24,7 @@ module Recourse
 
     # And the record gone. `destroy!`, so a callback that stops one says so rather than
     # leaving the page claiming it worked.
-    def destroy_resource(record) = record.destroy!
+    def destroy_resource(record) = record.destroy
 
     # A foreign key whose label is typed arrives as that label, so it is looked up
     # here. Nothing found leaves the key nil, and `belongs_to` reports it missing.

data/app/controllers/recourse/base_controller.rb

@@ -65,11 +65,14 @@ module Recourse
       end
     end
 
-    # Deletes the record and shows the index without it. `destroy!`, so a callback that
-    # stops one says so rather than leaving the page claiming it worked.
+    # Deletes the record and shows the index without it. A callback that stops one is
+    # answered where the record still is, rather than left to raise or to let the page
+    # claim it worked: a row a model refuses to give up is a page's business, not a 500.
     def destroy
-      destroy_resource @recourse
-      wrote t('recourse.deleted', model: human_name)
+      return wrote t('recourse.deleted', model: human_name) if destroy_resource @recourse
+
+      flash.alert = t('recourse.deleted_error', model: human_name)
+      redirect_back fallback_location: url_for(action: :index), status: :see_other
     end
 
   private

data/app/views/recourses/_card.html.erb

@@ -4,7 +4,10 @@
 <%# Every bare action the routes drew under this record: a nested resource with no
     index of its own is reached from nowhere, so its button sits beside the
     breadcrumbs wherever the record is shown, on whichever of its pages that is. -%>
+<%# The button that deletes what the page is about, drawn here rather than in a template
+    so a host writing its own show or edit keeps it without asking. -%>
 <% content_for :actions do %>
+  <%= destroy_resource_button destroyable_record %>
   <% bare_action_buttons(record).each do |label, path, method| %>
     <%= button_to label, path, method:, form_class: 'ms-3',
                                class: 'btn theme-primary btn-sm btn-solid' %>

data/app/views/recourses/edit.html.erb

@@ -1,7 +1,3 @@
 <% content_for :title, resource_record_label %>
 
-<% content_for :actions do %>
-  <%= destroy_resource_button resource_record %>
-<% end %>
-
 <%= render 'form', resource_key => resource_record %>

data/config/locales/recourse.en.yml

@@ -50,6 +50,7 @@ en:
     darken: Dark
     delete: Delete %{model}
     deleted: "%{model} was deleted."
+    deleted_error: "%{model} could not be deleted."
     destroy: Delete
     exit: Exit
     displaying:

data/lib/recourse/columns.rb

@@ -1,6 +1,14 @@
 # Reopened for the order a row reads in, which a table, a show page and a form all ask
 # for the same way.
 module Recourse
+  # Columns the database writes itself out of the others, which a form never offers: a
+  # stored generated column takes no value, and Postgres refuses the one a form would send.
+  # @param model [Class] the model the page is about.
+  # @return [Array<String>] the names of its generated columns.
+  def self.virtual_columns(model)
+    model.columns.select(&:virtual?).map(&:name)
+  end
+
   # Which part of a row a column belongs to. What a column holds is the gem's to know
   # and where the schema put it is the host's, so both have a say: the kind picks the
   # band, and the order inside the band is the one the table already has. Extended onto

data/lib/recourse/helpers/cards.rb

@@ -7,11 +7,8 @@ module Recourse
 
       # The record whose card this page is drawn in: the parent, on a page nested under
       # one, and the record itself where the page is its look or its change. An index of
-      # its own, and a form for a record that is not there yet, stand outside a card. A
-      # host drawing a page whole says so by assigning `@recourse_card = false`.
+      # its own, and a form for a record that is not there yet, stand outside a card.
       def card_record
-        return if controller_assign('recourse_card') == false
-
         resource_parent || (resource_record if controller.action_name.in? %w[show edit])
       end
 

data/lib/recourse/helpers/deletions.rb

@@ -12,10 +12,18 @@ module Recourse
 
     private
 
+      # The record a page may delete: the one it is about, on its own look or its own
+      # change page. A nested index wears the parent's card and deletes nothing from it.
+      # @api private
+      def destroyable_record
+        resource_record if controller.action_name.in? %w[show edit]
+      end
+
       # Deletes the record on the page, or nothing at all where no action is routed
       # to delete it with — the same two guards the edit link answers to.
+      # @api private
       def destroy_resource_button(record)
-        path = destroy_resource_path record
+        path = record && destroy_resource_path(record)
         return unless path
 
         confirm_button_to t('recourse.delete', model: resource_name), path,
@@ -24,6 +32,7 @@ module Recourse
                           form_class: 'd-inline-block'
       end
 
+      # @api private
       # What deleting this record takes with it, counted a level down and no further:
       # a state reaches counties, then ZIPs, then locations, and counting that far
       # would join 40,965 rows to draw one page.

data/lib/recourse/recoursive.rb

@@ -25,10 +25,12 @@ module Recourse
     # `%i[created_at updated_at]` asks for the two Rails keeps rather than the two
     # a record is about. A timestamp named here still lands last, and in that order,
     # whichever way round it was written.
+    # @api private
     def recourse_displayed = []
 
     # `ZIP code`: what to call a foreign key pointing here. A form's label, a table's
     # heading and a search prompt all name the same thing, so they name it once.
+    # @api private
     def recourse_reference_name
       attribute = Recourse.downcase human_attribute_name(recourse_label)
 
@@ -37,6 +39,7 @@ module Recourse
 
     # True when the label has a length, so it is short enough to be typed and a
     # form can ask for the value instead of listing every record to pick from.
+    # @api private
     def recourse_typed_label?
       validators_on(recourse_label).any? ActiveModel::Validations::LengthValidator
     end

data/lib/recourse/searchable/columns.rb

@@ -2,6 +2,7 @@ module Recourse
   module Searchable
     # What a model's own schema offers a search: which of its columns are worth
     # looking through, and which of its foreign keys are worth looking past.
+    # @api private
     module Columns
       # Column types a search box can match on containment. An enum is a Postgres
       # type of its own, and what it holds is a word, so it reads as a string too.

data/lib/recourse/searchable/terms.rb

@@ -15,6 +15,7 @@ module Recourse
       # and the labels behind foreign keys — less the one `except:` names — on
       # containment; or, for a model that keeps nothing in plaintext worth
       # searching, its encrypted columns, whole.
+      # @api private
       def recourse_search_terms(except: nil)
         plain = recourse_searchable_columns + recourse_searchable_references(except:)
         return [plain, 'cont'] if plain.any?
@@ -23,6 +24,7 @@ module Recourse
       end
 
       # Those same terms as words, lower case but for the acronyms among them.
+      # @api private
       def recourse_search_names(except: nil)
         fields, = recourse_search_terms(except:)
 
@@ -33,6 +35,7 @@ module Recourse
 
       # A term is a column of this model, or a `zip_code` reaching through one of its
       # foreign keys — which a form and a table already have a name for.
+      # @api private
       def recourse_term_name(field)
         reached = recourse_searchable_associations.find { |one| field.start_with? "#{one.name}_" }
         return reached.klass.recourse_reference_name if reached

data/lib/recourse/searchable.rb

@@ -47,11 +47,13 @@ module Recourse
     # True where a foreign key pointing here is typed rather than picked, which a
     # form and the controller reading its parameters back have to agree on: the label
     # is bounded, or the table is too long to list.
+    # @api private
     def recourse_typed_reference? = recourse_typed_label? || !recourse_listable?
 
     # True where every row of this model could be listed in one menu. The count is
     # bounded, so the question costs the same on ten rows as on ten million, and it
     # is asked once per class — a table that crosses the line is noticed at boot.
+    # @api private
     def recourse_listable?
       return @recourse_listable unless @recourse_listable.nil?
 

data/lib/recourse/version.rb

@@ -1,4 +1,4 @@
 module Recourse
   # Version of the gem, read by the gemspec and by hosts checking compatibility.
-  VERSION = '7.0.0'
+  VERSION = '7.2.0'
 end

data/lib/recourse.rb

@@ -59,10 +59,11 @@ module Recourse
 
   # Columns a user may set: the form offers these, the show page reads these out, and
   # `create` permits these. A counter cache is none of a user's business — Rails keeps
-  # it, so a form that offered one would let it be typed over.
+  # it, so a form that offered one would let it be typed over, and neither is a column
+  # the database generates: it takes no value at all.
   def self.editable_columns(model)
     ordered model, model.column_names - ['id', *TIMESTAMPS] - counters(model).keys -
-                   hidden_columns(model)
+                   hidden_columns(model) - virtual_columns(model)
   end
 
   # Columns no screen shows: whatever the model asked to hide through `recourse_hidden`

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: recourse
 version: !ruby/object:Gem::Version
-  version: 7.0.0
+  version: 7.2.0
 platform: ruby
 authors:
 - claudiob