recourse 5.6.2 → 5.6.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 064c3ed09111afd19f1d3e11c5a612cd89fa791ed1af947e443bb15b4af7b331
-  data.tar.gz: d93cb6f3a73e164ebba8a2aebad883f3bbf8caf5bc30d5b314b454f130013c1c
+  metadata.gz: 83d3a5ce095d609bf7da53c08839eab3bc4924c6e6150f9675d79725c4c9f53f
+  data.tar.gz: d2325213f4e461394adb107d3a3834f6ef668159ce6e90e7fa77aa09d09a8389
 SHA512:
-  metadata.gz: 158d0cfe8800d1b44812f358d6033ffcb00da7adbbe2e52c2264d97e18115cfc7e96c70e38b7e7c9eb40c8ed9b9658095b49314497e31459d7a62e21b011e127
-  data.tar.gz: f573d4015aa37561ea7be6272120394aeeb96d9a7c55a0732680f6a135769b96361529da4a1d6a69767fd542bbb6457a8ae3dda1be99f9105568936d371af182
+  metadata.gz: 54d4c8b8075fc497c45caf991fe7f8e5ea04cacb30bf619a12682e137cf962072140b1ff69eaff9ad881658adb018a440bc344fd3bfb3859ec776bdd077ae87b
+  data.tar.gz: 9d8a3e17c0cdb3e05f57381beda1c68b31b5b6924d7104717622c29d5658f6faa198ab33d1c576a81ea8e7adf4ccdee3b9be885c248421302229381536dc7445

data/lib/recourse/helpers/resources.rb

@@ -3,6 +3,10 @@ module Recourse
     # What the page is about and what it is called: the model behind it, the record
     # on it, and the words both are read out under.
     module Resources
+      # Where Ruby's own `to_s` lives: a record whose model never wrote one prints the
+      # object's address, which is no name for a page.
+      DEFAULT_PRINTERS = [Kernel, Object].freeze
+
       # Human, plural name of the resource on the page, e.g. `Contacts`. A page of
       # attachments is named after what the record calls them rather than after Active
       # Storage's own word for the row: `Photos`, never `Blobs`. `known_title`, since a
@@ -42,11 +46,26 @@ module Recourse
       # What the record on the page is called, by whatever its model labels it with —
       # and nothing where there is no record to name.
       def resource_record_label
-        resource_record&.attributes&.dig resource_model.recourse_label.to_s
+        return unless resource_record
+
+        labelled_record.presence || printed_record
       end
 
     private
 
+      # The column the model labels itself by, which most models keep.
+      def labelled_record
+        resource_record.attributes[resource_model.recourse_label.to_s]
+      end
+
+      # And what the record prints itself as, for the models that keep no such column:
+      # a chat is called by the first thing asked in it, which no column holds. Only
+      # where the model wrote a `to_s` of its own — the one Ruby supplies prints the
+      # object's address, which names nothing and is worse than an unnamed crumb.
+      def printed_record
+        resource_record.to_s unless DEFAULT_PRINTERS.include? resource_record.method(:to_s).owner
+      end
+
       # Resolved by the controller, which is the one that knows whether the name is a
       # model of this app's, something a record has attached, or a model a host named.
       def resource_model

data/lib/recourse/icons.rb

@@ -3,11 +3,14 @@
 module Recourse
   # What a resource is drawn with, by the name of the class a route resolves to, and
   # nil where there is no such class -- a bare action is drawn under a word this app
-  # has no class for, and an icon is not worth raising over.
+  # has no class for, and an icon is not worth raising over. A word that does resolve
+  # is not a drawn model either where what it found never heard of `recourse_icon`:
+  # `Message` may be a host's own class for gathering rows rather than a table of them,
+  # and asking it would raise rather than draw nothing.
   def self.known_icon(name)
     model = name.to_s.split('/').last.classify.safe_constantize
 
-    known_model_icon model if model
+    known_model_icon model if model.respond_to? :recourse_icon
   end
 
   # And for a model in hand. Nil rather than Unicon's circle where it has never heard

data/lib/recourse/version.rb

@@ -1,4 +1,4 @@
 module Recourse
   # Version of the gem, read by the gemspec and by hosts checking compatibility.
-  VERSION = '5.6.2'
+  VERSION = '5.6.3'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: recourse
 version: !ruby/object:Gem::Version
-  version: 5.6.2
+  version: 5.6.3
 platform: ruby
 authors:
 - claudiob