recourse 5.6.1 → 5.6.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 35965cb0f94b2d2fca0366cea985b802e99b777307c665028a112cab73bd37e4
-  data.tar.gz: 3ba554f83c3f8a9525482ea3df5a5d8c41356fc00897a25d5bce865c36f90792
+  metadata.gz: 064c3ed09111afd19f1d3e11c5a612cd89fa791ed1af947e443bb15b4af7b331
+  data.tar.gz: d93cb6f3a73e164ebba8a2aebad883f3bbf8caf5bc30d5b314b454f130013c1c
 SHA512:
-  metadata.gz: a562bc4ad1b45cb1f29a82fe2bb81a69d85d59771becf9761da3cc4ef34dbbd14f6e251f5904fa0b0a42104cfdbe295bbdfdc191704284eb6f069bed5574daf2
-  data.tar.gz: d71660925c2cf5cc173240c7404254e1f0a5ff3bf1a9c75d8dc7a9a5856266fa21f2622cd0f1fb9fd1e65afccbf2472b5c8627bb89582e4656ca0072db18aea3
+  metadata.gz: 158d0cfe8800d1b44812f358d6033ffcb00da7adbbe2e52c2264d97e18115cfc7e96c70e38b7e7c9eb40c8ed9b9658095b49314497e31459d7a62e21b011e127
+  data.tar.gz: f573d4015aa37561ea7be6272120394aeeb96d9a7c55a0732680f6a135769b96361529da4a1d6a69767fd542bbb6457a8ae3dda1be99f9105568936d371af182

data/CHANGELOG.md

@@ -7,6 +7,19 @@ For more information about changelogs, check [Keep a Changelog](http://keepachan
 
 ## [Unreleased]
 
+## 5.6.2 - 2026-09-18
+
+* [Fix] A kept table notices a count that changed
+
+  The key a table is cached under carried the rows, the newest `updated_at` among them and
+  everything they reach along `includes` — but not the counts they draw. A counter cache is
+  written by `update_counters`, which moves no timestamp, so a row whose children changed is
+  one `MAX(updated_at)` still calls unchanged: an agent who claimed two contacts went on
+  reading `0 contacts` until something else wrote to the agent.
+
+  The counts go in the key beside the version. They are read off the rows already in memory,
+  so this costs no query, the way reading that version costs none.
+
 ## 5.6.1 - 2026-09-18
 
 * [Change] The pinned bundle is `houseaccount@0.14.2`

data/app/views/recourses/_table.html.erb

@@ -4,6 +4,9 @@
 <%# The key carries what the rows draw besides their own columns: `MAX(updated_at)`
     over the relation sees only the rows themselves, so a name or a ZIP read off the
     record a row points at would keep whatever it said when the fragment was written.
+    And the counts they draw, which no timestamp moves: a counter cache is written by
+    `update_counters`, so a row whose children changed is one `MAX(updated_at)` still
+    calls unchanged.
     And the row partial's digest: a host's `_row` is resolved at render, which the
     fragment's own template digest never follows.
     And the column list: which columns a table shows is decided in Ruby —
@@ -13,8 +16,8 @@
     the fragment when a square is clicked. And the zone, for the same reason again:
     a timestamp is drawn against the reader's own clock, so without it the first
     person to load a table would settle what hour everybody else read. -%>
-<% key = [recourses, rows_version(recourses), row_digest, resource_columns,
-          bookmark_digest, Time.zone.name] -%>
+<% key = [recourses, rows_version(recourses), counters_version(recourses), row_digest,
+          resource_columns, bookmark_digest, Time.zone.name] -%>
 <% cache_if cacheable_table?, key do %>
   <% actions = resource_actions %>
   <%# Read once for the whole table: every row of it is positioned or none is. -%>

data/lib/recourse/helpers/rows.rb

@@ -33,6 +33,18 @@ module Recourse
         drawn.filter_map { |one| one.try :updated_at }.max&.utc&.to_fs :usec
       end
 
+      # The counts the rows draw, which the version above cannot see. A counter cache is
+      # written by `update_counters`, which moves no timestamp, so a row whose children
+      # changed is a row `MAX(updated_at)` still calls unchanged -- and the table went on
+      # showing the count it was cached with. Read off the rows in memory like the
+      # version is, so this costs no query either.
+      def counters_version(rows)
+        columns = resource_model.recourse_counters.keys
+        return if columns.empty?
+
+        rows.map { |row| row.attributes.values_at(*columns) }
+      end
+
       # Every record the rows reach along `includes`, in any shape `includes` accepts:
       # a name, a list of them, or a hash naming what to follow from there.
       def reached(rows, names)

data/lib/recourse/version.rb

@@ -1,4 +1,4 @@
 module Recourse
   # Version of the gem, read by the gemspec and by hosts checking compatibility.
-  VERSION = '5.6.1'
+  VERSION = '5.6.2'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: recourse
 version: !ruby/object:Gem::Version
-  version: 5.6.1
+  version: 5.6.2
 platform: ruby
 authors:
 - claudiob