recourse 4.8.0 → 5.0.0

data/app/views/recourses/_combobox.html.erb

@@ -1,38 +1,20 @@
 <%# locals: (name:, id:, placeholder:, invalid: false, feedback: nil, described: nil, required: false, label: nil, counter: nil, recourses: nil, values: [], multiple: false, selected: [], aria_label: nil, small: false, all: nil, none: nil, shown: nil) -%>
-<button class='form-control<%= ' form-control-sm' if small %><%= ' is-invalid' if invalid %> combobox-toggle' type='button' id='<%= id %>'
-        data-bs-toggle='combobox' data-bs-name='<%= name %>' data-controller='combobox'
-        data-combobox-more-value='<%= t 'recourse.more' %>'
-        data-bs-placeholder='<%= placeholder %>' data-bs-search='true'
-        aria-required='<%= required %>' <%= tag.attributes 'data-bs-multiple': ('true' if multiple), 'aria-label': aria_label, 'aria-describedby': described %>>
-  <span class='combobox-value'><%= placeholder %></span>
-  <i class='bi bi-chevron-down combobox-caret'></i>
-</button>
-<div class='menu'>
-  <div class='combobox-search' data-controller='clear'>
-    <input type='text' class='form-control combobox-search-input'
-           placeholder='<%= t 'recourse.search' %>'
-           autocomplete='off' aria-label='<%= t 'recourse.search' %>'
-           data-clear-target='input' data-action='input->clear#toggle'>
-    <button type='button' class='combobox-search-clear d-none' aria-label='<%= t 'recourse.clear' %>'
-            data-clear-target='button' data-action='clear#clear'>
-      <i class='bi bi-x-lg'></i>
-    </button>
-  </div>
-  <%# No `data-bs-value`, so the plugin's own click handler passes it by and this one
-      is ours; and never `.selected`, which it counts whatever the element is. -%>
-  <% if all -%>
-    <button type='button' class='menu-item' data-controller='deselect' data-action='deselect#all'
-            data-deselect-multiple-value='<%= multiple %>'><%= all %></button>
-    <div class='menu-divider'></div>
-  <% end -%>
-  <%# A value of its own, and an empty one: the plugin builds its hidden input from
-      whichever item is selected, so this is what sets an optional key back to
-      nothing. `deselect` cannot serve here — in a single menu the plugin selects
-      whatever is clicked rather than toggling it, so re-clicking the chosen item
-      would change nothing at all. -%>
+<%# A plain <select>, which the design bundle dresses as Bootstrap's combobox: this is
+    the whole contract, and a page without the script has a working select. The words
+    the menu needs travel on it, since a script has no locale of its own; a multiple
+    select is named with `[]`, so the browser submits every pick the way Ransack reads a
+    list predicate. -%>
+<%= tag.select name: (multiple ? "#{name}[]" : name), id: id, multiple: multiple, required: required,
+               class: class_names('form-select', 'form-select-sm': small, 'is-invalid': invalid),
+               aria: { label: aria_label, describedby: described },
+               data: { controller: 'combobox', combobox_placeholder_value: placeholder,
+                       combobox_more_value: t('recourse.more'), combobox_all_value: all,
+                       search: t('recourse.search'), clear: t('recourse.clear'),
+                       no_results: t('recourse.no_results') } do %>
+  <%# An empty option is what sets an optional key back to nothing; a required one
+      offers no way to leave itself empty. -%>
   <% if none -%>
-    <button type='button' class='menu-item' data-bs-value='' aria-selected='false'><span class='menu-item-content'><span><%= none %></span></span></button>
-    <div class='menu-divider'></div>
+    <%= tag.option none, value: '' %>
   <% end -%>
   <%# Records are cached on the relation, and a list of words is not worth caching:
       an enum has a dozen of them and they are already in memory. Nor is a table with
@@ -42,27 +24,27 @@
       <% recourses.each do |recourse| %>
         <% chosen = selected.include? recourse.id.to_s -%>
         <%# In the menu but not on it: an option accounting for none of the rows being
-            filtered is `d-none` until `All` asks for it. One already ticked stays put,
+            filtered is held back until `All` asks for it. One already ticked stays put,
             or the box would name a filter its own menu does not offer. -%>
         <% empty = counter && !chosen && recourse.attributes[counter].to_i.zero? -%>
-        <%# The name in a `.menu-item-content > span`, which is what the plugin copies into
-            the closed box: a count belongs in the menu and not on the box. Its wrapper
-            is `flex: 1`, so the count needs no margin of its own to sit at the right. -%>
-        <button class='menu-item<%= ' selected' if chosen %><%= ' d-none' if empty %>' type='button' data-bs-value='<%= recourse.id %>' aria-selected='<%= chosen %>'><span class='menu-item-content'><span><%= recourse.attributes[label] %></span></span><% if counter %><span class='recourse-count fg-2'><%= number_with_delimiter recourse.attributes[counter] %></span><% end %><% if multiple %><i class='bi bi-check menu-item-check'></i><% end %></button>
+        <%= tag.option recourse.attributes[label], value: recourse.id, selected: chosen,
+                       data: { count: (number_with_delimiter recourse.attributes[counter] if counter),
+                               hidden: ('' if empty) } %>
       <% end %>
     <% end %>
   <% else -%>
     <% values.each do |option| %>
-      <%# Compared as text, because that is what a request carries it back as. -%>
+      <%# A value on its own, or a `[label, value]` pair for where what the menu reads
+          is not what it submits: a CRM is picked by its own name and carried back as
+          the class the column holds. Compared as text, since that is what a request
+          carries it back as. -%>
+      <% shown_as, option = option.is_a?(Array) ? option : [option, option] -%>
       <% chosen = selected.include? option.to_s -%>
-      <%# In the menu but not on it, the way an unused filter option is: a list too long
-          to read opens on the few worth reading, and `All` asks for the rest. -%>
       <% waiting = shown && !chosen && shown.exclude?(option.to_s) -%>
-      <button class='menu-item<%= ' selected' if chosen %><%= ' d-none' if waiting %>' type='button' data-bs-value='<%= option %>' aria-selected='<%= chosen %>'><span class='menu-item-content'><span><%= option %></span></span><% if multiple %><i class='bi bi-check menu-item-check'></i><% end %></button>
+      <%= tag.option shown_as, value: option, selected: chosen, data: { hidden: ('' if waiting) } %>
     <% end %>
   <% end -%>
-  <div class='combobox-no-results d-none'><%= t 'recourse.no_results' %></div>
-</div>
+<% end %>
 <% if feedback -%>
   <small class='invalid-feedback' id='<%= id %>_error'><%= feedback %></small>
 <% end -%>

data/lib/recourse/engine.rb

@@ -10,47 +10,9 @@ require_relative 'routes'
 module Recourse
   # Hooks the gem into a host app's boot so its controllers and views are found.
   class Engine < ::Rails::Engine
-    # Prefix the gem answers for with a file. `Rack::Static` matches on
-    # `start_with?`, so dropping the slash would swallow `/recourses` itself.
-    STATIC_URLS = %w[/recourse/].freeze
-
-    # Every file is asked for again on every full load, and answered `304 Not Modified`
-    # while it stands. The URL of a file never changes between versions of the gem, so
-    # a browser told to keep one for hours ran the previous version's script — with the
-    # tooltip a release had just taken away — until the hours were up.
-    STATIC_HEADERS = [[:all, { 'cache-control' => 'no-cache' }]].freeze
-
     # Initializers all run before routes are drawn, so `recourses` exists in time.
     initializer 'recourse.routes' do
       ActionDispatch::Routing::Mapper.include Scopes, Routes
     end
-
-    # Serves what a page needs, since a host may run no asset pipeline at all. The
-    # prefix keeps its slash: without it `/recourses` would be served as a file.
-    # Turbo answers first, by exact path — matched on the prefix alone, the statics
-    # below would swallow it with a 404 instead of passing it on. Then vendored
-    # files, then our own JavaScript, each cascading so the next shares the URL, and
-    # finally our own stylesheets — the palettes. All of it sits before
-    # `Rails::Rack::Logger`, so fetching a stylesheet writes no `Started GET` line:
-    # a file is not what a log is about, and placement says so without the gem
-    # touching a host's logging.
-    initializer 'recourse.assets' do |app|
-      # turbo-rails' own bundle: the same Turbo plus the cable element, in the
-      # version that gem signs its streams for. A dependency rather than something
-      # to find, since a page here cannot do without it.
-      app.middleware.insert_before Rails::Rack::Logger, Rack::Static,
-                                   urls: { '/recourse/turbo.min.js' => 'turbo.min.js' },
-                                   root: Turbo::Engine.root.join('app/assets/javascripts').to_s,
-                                   header_rules: STATIC_HEADERS
-      app.middleware.insert_before Rails::Rack::Logger, Rack::Static,
-                                   urls: STATIC_URLS, root: Engine.root.join('vendor'),
-                                   header_rules: STATIC_HEADERS, cascade: true
-      app.middleware.insert_before Rails::Rack::Logger, Rack::Static,
-                                   urls: STATIC_URLS, root: Engine.root.join('app/javascript'),
-                                   header_rules: STATIC_HEADERS, cascade: true
-      app.middleware.insert_before Rails::Rack::Logger, Rack::Static,
-                                   urls: STATIC_URLS, root: Engine.root.join('app/stylesheets'),
-                                   header_rules: STATIC_HEADERS
-    end
   end
 end

data/lib/recourse/helpers/constraints.rb

@@ -3,13 +3,10 @@ module Recourse
     # Turns a model's validators into the HTML that constrains a form field.
     module Constraints
       # Shown for a field whose shape has one canonical example.
-      SAMPLE_PLACEHOLDERS = { 'phone' => '555-555-5555', 'email' => 'michael@example.com' }.freeze
+      SAMPLE_PLACEHOLDERS = { 'email' => 'michael@example.com' }.freeze
 
-      # What the browser checks where the typed shape differs from the stored one: a
-      # phone is ten digits in the database but is typed with its separators.
-      DISPLAY_PATTERNS = { 'phone' => '[2-9]\d{2}-[2-9]\d{2}-\d{4}' }.freeze
-
-      # Hands a phone field to the Stimulus controller that types its separators.
+      # Hands a phone field to the controller that decides its shape: the separators as it
+      # is typed, and the pattern, placeholder and title the field is left without here.
       PHONE_CONTROLLER = {
         controller: 'phone', action: 'keydown->phone#down input->phone#input',
       }.freeze
@@ -20,7 +17,7 @@ module Recourse
       # which is the page's model unless a field asks about another one's attribute.
       def field_html(column, type = nil, model = resource_model)
         key = (type || column).to_s
-        pattern = DISPLAY_PATTERNS[key] || column_pattern(model, column)
+        pattern = column_pattern(model, column) unless key == 'phone'
 
         {
           maxlength: length_option(model, column, :maximum),

data/lib/recourse/helpers/filters.rb

@@ -85,9 +85,9 @@ module Recourse
                                      all: all, values: Array(values), **)
       end
 
-      # A multiple combobox submits one comma-joined input, read back out the same way.
+      # A multiple select submits one value per pick, and a link carries them the same way.
       def filter_values(predicate)
-        query_params[predicate].to_s.split ','
+        Array(query_params[predicate]).map(&:to_s).compact_blank
       end
     end
   end

data/lib/recourse/helpers/formats.rb

@@ -34,7 +34,7 @@ module Recourse
 
         case kind
         when :integer then number_with_delimiter value
-        when :phone then number_to_phone value
+        when :phone then phone_span value
         when :monetary then number_to_currency value, **precision_option(column)
         when :percentage then number_to_percentage value, **precision_option(column)
         when :decimal then number_with_precision value, **precision_option(column)
@@ -71,13 +71,12 @@ module Recourse
         tag.pre JSON.pretty_generate(value), class: 'recourse-payload'
       end
 
-      def enum_badge(value)
-        tag.span value, class: 'badge'
-      end
+      # Ten digits and a controller: how a phone reads is the design bundle's to decide.
+      def phone_span(value) = value && tag.span(value, data: { controller: 'phone' })
 
-      def web_url?(value)
-        value.is_a?(String) && value.match?(WEB_URL)
-      end
+      def enum_badge(value) = tag.span(value, class: 'badge')
+
+      def web_url?(value) = value.is_a?(String) && value.match?(WEB_URL)
 
       # The words lead where the value points, in this tab, the way any link does; the
       # arrow after them — Bootstrap's icon link, stepping under the cursor — opens the

data/lib/recourse/helpers/refreshes.rb

@@ -4,24 +4,14 @@ module Recourse
     module Refreshes
     private
 
-      # The subscription tag, after asking the head for the two metas that make a
-      # refresh morph in place and keep the scroll — and nothing at all when the
-      # model broadcasts nothing, so a host without turbo-rails is untouched.
+      # The subscription tag, and nothing at all when the model broadcasts nothing, so a page
+      # never listens for what will not come. The layout's head has the two metas that make
+      # a refresh morph in place and keep the scroll.
       def refresh_subscription
         return unless resource_model.recourse_broadcasting?
 
-        content_for :head, refresh_metas
         turbo_stream_from resource_model.model_name.plural
       end
-
-      # Without these Turbo answers a refresh by replacing the whole body, which
-      # drops the caret, the scroll and any menu that was open.
-      def refresh_metas
-        safe_join [
-          tag.meta(name: 'turbo-refresh-method', content: 'morph'),
-          tag.meta(name: 'turbo-refresh-scroll', content: 'preserve'),
-        ]
-      end
     end
   end
 end

data/lib/recourse/themes.rb

@@ -24,7 +24,8 @@ module Recourse
 
   # Where the palettes are served from, named once: the layout links one, the layout's
   # own script puts back the one a reader chose, and the sidebar's controller swaps it.
-  THEMES_PATH = '/recourse/themes'
+  # The version is the one the layout links its stylesheet and script at.
+  THEMES_PATH = 'https://design.houseaccount.com/v0.3.1/theme'
 
   # Where a reader's chosen palette and mode are kept in their browser. Named once for
   # the same reason: the sidebar's controller writes it and the layout reads it back.

data/lib/recourse/version.rb

@@ -1,4 +1,4 @@
 module Recourse
   # Version of the gem, read by the gemspec and by hosts checking compatibility.
-  VERSION = '4.8.0'
+  VERSION = '5.0.0'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: recourse
 version: !ruby/object:Gem::Version
-  version: 4.8.0
+  version: 5.0.0
 platform: ruby
 authors:
 - claudiob
@@ -132,40 +132,11 @@ files:
 - app/controllers/recourse/base_controller.rb
 - app/controllers/recourse/bookmarks_controller.rb
 - app/controllers/recourses_controller.rb
-- app/javascript/recourse/bookmark_controller.js
-- app/javascript/recourse/clear_controller.js
-- app/javascript/recourse/combobox_controller.js
-- app/javascript/recourse/confirm.js
-- app/javascript/recourse/density_controller.js
-- app/javascript/recourse/deselect_controller.js
-- app/javascript/recourse/flash.js
-- app/javascript/recourse/limit_controller.js
-- app/javascript/recourse/phone_controller.js
-- app/javascript/recourse/relative_time_controller.js
-- app/javascript/recourse/reveal_controller.js
-- app/javascript/recourse/scheme_controller.js
-- app/javascript/recourse/search_controller.js
-- app/javascript/recourse/shortcuts_controller.js
-- app/javascript/recourse/timezone_controller.js
-- app/javascript/recourse/toast_controller.js
-- app/javascript/recourse/tooltip_controller.js
-- app/javascript/recourse/written.js
-- app/javascript/recourse/written_controller.js
-- app/stylesheets/recourse/themes/bootstrap.css
-- app/stylesheets/recourse/themes/dawn.css
-- app/stylesheets/recourse/themes/dracula.css
-- app/stylesheets/recourse/themes/gruvbox.css
-- app/stylesheets/recourse/themes/monokai.css
-- app/stylesheets/recourse/themes/nord.css
-- app/stylesheets/recourse/themes/one_dark.css
-- app/stylesheets/recourse/themes/solarized.css
-- app/stylesheets/recourse/themes/tokyo_night.css
 - app/views/layouts/recourses.html.erb
 - app/views/recourses/_breadcrumb.html.erb
 - app/views/recourses/_card.html.erb
 - app/views/recourses/_color.html.erb
 - app/views/recourses/_combobox.html.erb
-- app/views/recourses/_confirm.html.erb
 - app/views/recourses/_fields.html.erb
 - app/views/recourses/_flash.html.erb
 - app/views/recourses/_footer.html.erb
@@ -250,12 +221,6 @@ files:
 - lib/recourse/version.rb
 - lib/recourse/writes.rb
 - lib/recourse/zones.rb
-- vendor/recourse/bootstrap-icons.min.css
-- vendor/recourse/bootstrap.bundle.min.js
-- vendor/recourse/bootstrap.min.css
-- vendor/recourse/fonts/bootstrap-icons.woff
-- vendor/recourse/fonts/bootstrap-icons.woff2
-- vendor/recourse/stimulus.js
 homepage: https://github.com/claudiob/recourse
 licenses:
 - MIT

data/app/javascript/recourse/bookmark_controller.js

@@ -1,97 +0,0 @@
-import { Controller } from '/recourse/stimulus.js'
-import { flash } from '/recourse/flash.js'
-
-// The square that keeps a row, answered before the server does. The icon flips under
-// the cursor and the request goes in the background, so the table is never redrawn and
-// the row stays where the eye left it — until the next load, where kept-first belongs.
-//
-// The form is still a real one. Without this controller it submits, redirects and
-// reloads, which is the same floor every other button here degrades to.
-export default class extends Controller {
-  static values = { kept: Boolean, error: String }
-
-  connect() {
-    this.form = this.element.closest('form')
-    this.row = this.element.closest('tr')
-    this.icon = this.element.querySelector('i')
-    this.form.addEventListener('submit', this.submit)
-  }
-
-  disconnect() {
-    this.form.removeEventListener('submit', this.submit)
-  }
-
-  // An arrow so `this` survives being handed to the listener, and so the same
-  // function object is the one removed again.
-  submit = (event) => {
-    event.preventDefault()
-    const kept = !this.keptValue
-    // Read the form before flipping it. The verb it is still wearing is the one this
-    // click means — `post` to keep the row, `delete` to drop it — while `render`
-    // dresses it for the click after this one, which is the opposite.
-    const body = new FormData(this.form)
-    this.render(kept)
-    this.send(body, kept)
-  }
-
-  // What the eye reads, what a screen reader reads, and what the next click will do:
-  // the path never changes, only the verb Rails wrote into the form.
-  render(kept) {
-    this.keptValue = kept
-    this.icon.className = kept ? 'bi bi-bookmark-fill' : 'bi bi-bookmark'
-    this.element.setAttribute('aria-pressed', kept)
-    this.method.value = kept ? 'delete' : 'post'
-  }
-
-  // The token in the head, not the one in the form. Rails scopes a form's own token
-  // to the method it was drawn with and this square flips that method; the form's is
-  // inside a cached fragment besides, so it belongs to whichever session drew the
-  // table. The head's is global to the session and fresh per request, and Rails takes
-  // whichever of the two is valid.
-  get token() {
-    return document.querySelector('meta[name="csrf-token"]')?.content
-  }
-
-  // Rails' own override field, which `button_to` writes only for a delete — so a
-  // square that started hollow has none until the first click makes one.
-  get method() {
-    let field = this.form.querySelector('input[name="_method"]')
-    if (!field) {
-      field = document.createElement('input')
-      field.type = 'hidden'
-      field.name = '_method'
-      this.form.prepend(field)
-    }
-    return field
-  }
-
-  // The response is never rendered, but it is read: a 500, a dropped connection or
-  // an expired session would otherwise leave a filled square that was never saved.
-  // `Accept` is what tells the server this one wants no flash and no redirect.
-  async send(body, kept) {
-    try {
-      const response = await fetch(this.form.action, {
-        method: 'post',
-        body,
-        headers: { Accept: 'application/json', 'X-CSRF-Token': this.token },
-      })
-      if (!response.ok) return this.revert(kept)
-
-      // The report, and the reason there is no toast: the row takes or loses its tint,
-      // which says which rows are kept. The icon flipped on the click and would have
-      // flipped under a request that never landed, so this is the half only the server
-      // can give.
-      this.row?.classList.toggle('recourse-kept', kept)
-    } catch {
-      this.revert(kept)
-    }
-  }
-
-  // Put the square back, and say why — the one time this column speaks, since a click
-  // that worked is reported by the row taking color. Nothing to put back but the
-  // square: the tint is never laid on until the row is written.
-  revert(kept) {
-    this.render(!kept)
-    flash(this.errorValue)
-  }
-}

data/app/javascript/recourse/clear_controller.js

@@ -1,22 +0,0 @@
-import { Controller } from '/recourse/stimulus.js'
-
-export default class extends Controller {
-  static targets = ['input', 'button']
-
-  connect() {
-    this.toggle()
-  }
-
-  toggle() {
-    this.buttonTarget.classList.toggle('d-none', !this.inputTarget.value)
-  }
-
-  clear() {
-    this.inputTarget.value = ''
-    // The combobox filters its menu on `input`, so it has to hear one to put every
-    // row back. Bootstrap listens on the field itself, and the event bubbles anyway.
-    this.inputTarget.dispatchEvent(new Event('input', { bubbles: true }))
-    this.inputTarget.focus()
-    this.toggle()
-  }
-}

data/app/javascript/recourse/combobox_controller.js

@@ -1,68 +0,0 @@
-import { Controller } from '/recourse/stimulus.js'
-import { Combobox } from '/recourse/bootstrap.bundle.min.js'
-
-// The plugin keeps a menu's value in a hidden input it creates itself, which
-// Turbo's DOM surgery knows nothing about: a morphing refresh deletes the input
-// while the instance keeps writing to the detached node, and a snapshot restore
-// resurrects an old input beside the one a new instance makes — either way the
-// next click submits a filter that is stale, doubled or missing. Owning the
-// lifecycle here keeps the input and the instance one thing.
-//
-// And what a menu with several picks reads as. The plugin writes `2 selected`, which
-// says how many and not which; the first pick named and the rest counted says both,
-// in the words the locale gives `more`. Written after the plugin writes its own — on
-// every change, and once the instance is made — so the plugin's text never shows.
-export default class extends Controller {
-  static values = { more: String }
-
-  connect() {
-    // A restored snapshot arrives with the last visit's input baked in. The
-    // instance it belonged to is gone, so it is only a second submission.
-    if (!Combobox.getInstance(this.element)) { this.#clearStaleInputs() }
-
-    this.combobox = Combobox.getOrCreateInstance(this.element)
-    this.#name()
-    this.named = () => this.#name()
-    this.element.addEventListener('change.bs.combobox', this.named)
-    this.morphed = () => this.#remake()
-    document.addEventListener('turbo:morph', this.morphed)
-  }
-
-  disconnect() {
-    document.removeEventListener('turbo:morph', this.morphed)
-    this.element.removeEventListener('change.bs.combobox', this.named)
-    this.combobox.dispose()
-  }
-
-  // Remade whole rather than repaired: the constructor reads the `.selected`
-  // items the morph just made truthful, so disposing and starting over syncs the
-  // input, the toggle's text and the listeners in one move.
-  #remake() {
-    if (!this.element.isConnected) { return }
-
-    this.combobox.dispose()
-    this.combobox = Combobox.getOrCreateInstance(this.element)
-    this.#name()
-  }
-
-  // `California + 1 more` over the plugin's `2 selected`. Only a multiple menu with
-  // more than one pick: with one, the plugin already names it, and with none it
-  // shows the placeholder.
-  #name() {
-    const picked = this.element.nextElementSibling.querySelectorAll('.menu-item.selected')
-    if (!this.element.dataset.bsMultiple || picked.length < 2) { return }
-
-    const first = picked[0].querySelector('.menu-item-content > span:first-child')
-    this.element.querySelector('.combobox-value').textContent = this.moreValue
-      .replace('%{first}', first.textContent)
-      .replace('%{count}', picked.length - 1)
-  }
-
-  #clearStaleInputs() {
-    const name = this.element.dataset.bsName
-
-    for (const input of this.element.parentNode.querySelectorAll('input[type="hidden"]')) {
-      if (input.name === name) { input.remove() }
-    }
-  }
-}

data/app/javascript/recourse/confirm.js

@@ -1,46 +0,0 @@
-import { Dialog } from '/recourse/bootstrap.bundle.min.js'
-
-// Turbo hands over the whole warning as one string. The first line is the question
-// and each remaining line a paragraph — real paragraphs here, where a confirm() box
-// had newlines. Always textContent, never innerHTML: the title carries a record's
-// own name, and a name is data.
-export default function confirm(message) {
-  const dialog = document.querySelector('#recourse-confirm')
-  const [title, ...lines] = message.split('\n')
-  dialog.querySelector('.dialog-title').textContent = title
-  dialog.querySelector('.dialog-body').replaceChildren(...paragraphs(lines))
-
-  return new Promise(resolve => {
-    // `onclick` rather than addEventListener: reassigning replaces the previous
-    // answer's handler, so asking twice on one page never wires the button twice.
-    dialog.querySelector('.recourse-confirm-delete').onclick = () => {
-      resolve(true)
-      Dialog.getOrCreateInstance(dialog).hide()
-    }
-    // Cancel, Esc and a click on the backdrop all close through here. After a
-    // Delete the promise is settled, and settling it again is a no-op.
-    dialog.addEventListener('hidden.bs.dialog', () => resolve(false), { once: true })
-    Dialog.getOrCreateInstance(dialog).show()
-  })
-}
-
-function paragraphs(lines) {
-  return lines.filter(line => line).map(line => {
-    const paragraph = document.createElement('p')
-    paragraph.textContent = line
-    return paragraph
-  })
-}
-
-// Three things outlive a Turbo visit that starts mid-close: the snapshot, which would
-// restore an open dialog; `dialog-open` on <html>, which is the scroll lock; and
-// `hiding` on the dialog, the class its closing animation runs under. dispose() closes
-// instantly and lifts the lock, but cuts the animation short of the end that would
-// have taken `hiding` off — and a dialog still wearing it opens invisible the next
-// time it is asked, which on a table of Remove buttons is the very next click. In the
-// module, so it registers once.
-document.addEventListener('turbo:before-cache', () => {
-  const dialog = document.querySelector('#recourse-confirm')
-  if (dialog?.open) Dialog.getOrCreateInstance(dialog).dispose()
-  dialog?.classList.remove('hiding')
-})

data/app/javascript/recourse/density_controller.js

@@ -1,21 +0,0 @@
-import { Controller } from '/recourse/stimulus.js'
-
-// The arrows at the foot of the sidebar, drawn on a phone alone: a tap puts the words
-// back beside every icon the chrome shows — the sidebar's entries, the crumbs, the tabs,
-// the foot's own controls — and the next tap takes them away again. The choice goes to
-// the server in a cookie, the way the zone does, and the page is loaded again outright
-// rather than reshaped in place: Safari left the row of entries where it was when the
-// words came out of hiding, one link over the next, until a reload laid it out afresh.
-// A Turbo visit to the same address is no better — an index carries the metas that make
-// a refresh morph, so the visit reshaped the body it had rather than drawing a new one.
-export default class extends Controller {
-  static values = { storage: String }
-
-  toggle() {
-    const expanded = document.body.classList.contains('recourse-expanded')
-    const density = expanded ? 'compact' : 'expanded'
-
-    document.cookie = `${this.storageValue}=${density}; path=/; max-age=31536000; samesite=lax`
-    window.location.reload()
-  }
-}

data/app/javascript/recourse/deselect_controller.js

@@ -1,37 +0,0 @@
-import { Controller } from '/recourse/stimulus.js'
-
-export default class extends Controller {
-  static values = { multiple: Boolean }
-
-  // `All` asks for the options the menu is holding back — they are in it already, and
-  // this is what puts them on it.
-  all(event) {
-    // A menu that sets a value is configured to close on any click inside it, this
-    // button included — which would shut it over the options it was clicked to see. The
-    // listener doing that is on the document, so stopping the click here is what keeps
-    // them in view. A menu that narrows a table closes on outside clicks only, and is
-    // unaffected either way.
-    event.stopPropagation()
-
-    const menu = this.element.closest('.menu')
-
-    for (const waiting of menu.querySelectorAll('.menu-item.d-none')) {
-      waiting.classList.remove('d-none')
-    }
-
-    // And, on a menu that narrows a table, it means every row as well as every option,
-    // which is what nothing being ticked says. Clicking each chosen item is what the
-    // plugin is already listening for, so the hidden input, the toggle's text and the
-    // events stay its business rather than ours — it has no method for this, and
-    // reaching into its state would be guessing.
-    //
-    // Only there. A menu that sets a value cannot mean none of them, and a click on the
-    // one already chosen is the plugin being told to choose it again — which closes the
-    // menu over the options this button was clicked to see.
-    if (!this.multipleValue) return
-
-    for (const item of menu.querySelectorAll('.menu-item.selected')) {
-      item.click()
-    }
-  }
-}