recourse 4.4.4 → 4.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9a2407f2f271c099137cb116f77873a8e498e106f32ebe70e6b4ad20c789a987
-  data.tar.gz: bc9c0f80bf263983fc51f4af82eb17675564b9f17eccb794284fec10f7ee59eb
+  metadata.gz: 10cc1a031240c0430a970cea2dc0c79460e3b6dfe131ce6e8a854aed364a485c
+  data.tar.gz: 631f40d0bc652b90cdaf960864ea5c47f7baa55ea1808b4a366a3d26ff021220
 SHA512:
-  metadata.gz: b9f10651a71c2e65a15c8f6a1f5c7d33b5ff67b516e9a528b3220ffa9e273cb88423afdda64d6301a9a09ab97614a0c7dfa701f15d1ea4bb1bc11b2a2bcedf25
-  data.tar.gz: fd3b958dfeddf61fc1d368435e6675d9103d102d367ada4309f89c0b135a3c5da26e3069a7ba4ceb998881e6cd9a04bdb2041f6004e1729124a54b5290d49a44
+  metadata.gz: 43892125e4332125787621108a81ccea1de70de89c66c6cdf686d68f54d7d8eda0c7251e964e2a74df8c5a9492ec8d26b8cf99c5443fa246bc91aebe0de8b13d
+  data.tar.gz: be7fa5f7c3853ba0ccecb21f5b290ab0ac38f00f1165d541ab670ff35decd71f9df154cc09836ecc7432153d3035dad9ccd290e449cba08d36976fbd579c9965

data/CHANGELOG.md

@@ -5,6 +5,21 @@ All notable changes to this project will be documented in this file.
 For more information about changelogs, check [Keep a Changelog](http://keepachangelog.com) and
 [Vandamme](http://tech-angels.github.io/vandamme).
 
+## 4.5.0 - 2026-09-08
+
+* [Fix] A row with a bookmark square is as tall as a row without one: the square no longer claims a button's minimum height
+
+* [Feature] The arrow after a web address opens it in a new tab, while the words still open it in this one
+
+* [Fix] A production rake task boots without Rails 8.2 warning that Action Controller and Active Record were loaded early
+
+  `recourses` defined each missing controller as the routes drew, which loaded the host's
+  `RecoursesController` and everything above it, and asked a nested name for its model the
+  same way. A boot that will not eager load — a `db:migrate` on release — draws its routes
+  before it is done, and Rails 8.2 logs a warning for every component loaded then. The
+  controller now waits for the app's first request or job, and the model is looked up as a
+  constant, without loading it.
+
 ## 4.4.4 - 2026-09-08
 
 * [Fix] On a phone the search form keeps its place beside the breadcrumb once a filter is picked

data/app/views/layouts/recourses.html.erb

@@ -265,6 +265,10 @@
          next to one, so it takes the line's height and not `.btn`'s own minimum —
          which would leave the row under every table taller than the words in it. */
       .recourse-limit { min-height: 0; }
+      /* The bookmark square is an icon in a row of text, not a control in a form, so it
+         takes the line's height too: `.btn`'s minimum made every row with one taller
+         than the rows without. */
+      .recourse-bookmark { min-height: 0; }
       /* Stacked, each control is a row of its own rather than a fragment of one:
          there is no second control beside it to share the line with. */
       @media (width < 768px) {

data/config/locales/recourse.en.yml

@@ -45,6 +45,7 @@ en:
     # What a menu with several picks reads as, the first named and the rest counted.
     more: "%{first} + %{count} more"
     new: New %{model}
+    new_tab: Open in a new tab
     no_results: No results found
     none: "No %{models}."
     optional: Optional

data/lib/recourse/controllers.rb

@@ -1,16 +1,43 @@
 module Recourse
   # Defines the controller classes a host app has not written for itself.
   module Controllers
+    @held = []
+    @lock = Mutex.new
+
     # Creates a controller for the named resource unless the host app has one. The
     # name arrives with whatever namespace it was drawn in — `admin/contacts` — so
-    # the constant lands where Rails will look for it.
-    def self.define_missing(path, base = nil)
+    # the constant lands where Rails will look for it. A block names the superclass,
+    # `RecoursesController` by default, and is called only once the class is made.
+    def self.define_missing(path, &base)
       class_name = "#{path.camelize}Controller"
       # const_defined? is true for a Zeitwerk autoload, so files on disk count too.
       return if Object.const_defined? class_name
 
-      namespace(class_name.deconstantize).const_set class_name.demodulize,
-                                                    Class.new(base || RecoursesController)
+      booting? ? hold(class_name, base) : define(class_name, base)
+    end
+
+    # Makes the controllers held back while the app booted. The executor runs this
+    # ahead of the app's first request or job, once every class may be loaded.
+    def self.define_held
+      @lock.synchronize { define(*@held.shift) until @held.empty? }
+    end
+
+    private_class_method def self.define(class_name, base)
+      superclass = base ? base.call : RecoursesController
+      namespace(class_name.deconstantize).const_set class_name.demodulize, Class.new(superclass)
+    end
+
+    # Rails 8.2 warns when Action Controller is loaded during the boot of an app that
+    # will not eager load — a rake task's, which draws its routes before it is done
+    # and never dispatches to a controller — so the class waits for the first run.
+    private_class_method def self.booting?
+      app = Rails.application
+      app.present? && !app.config.eager_load && !app.initialized?
+    end
+
+    private_class_method def self.hold(class_name, base)
+      Rails.application.executor.to_run { Controllers.define_held } if @held.empty?
+      @held << [class_name, base]
     end
 
     # The module a namespaced controller belongs in, made where the host has none of

data/lib/recourse/helpers/bookmarks.rb

@@ -50,13 +50,15 @@ module Recourse
 
       # Kept or not, one square either way: the same path with the verb reversed, so
       # the button toggles by flipping the method Rails already wrote into the form.
+      # `recourse-bookmark` takes back the height `.btn` claims, so the row stays as
+      # tall as one with no square in it.
       def bookmark_button(record)
         kept = bookmarked_ids.include? record.id
         label = t "recourse.#{kept ? 'unbookmark' : 'bookmark'}"
 
         button_to bookmark_icon(kept, label), bookmark_url(record),
                   method: kept ? :delete : :post, form_class: 'd-inline-block',
-                  class: 'btn btn-sm btn-link p-0 border-0 lh-1',
+                  class: 'btn btn-sm btn-link p-0 border-0 lh-1 recourse-bookmark',
                   **bookmark_data(kept, label)
       end
 

data/lib/recourse/helpers/formats.rb

@@ -79,15 +79,21 @@ module Recourse
         value.is_a?(String) && value.match?(WEB_URL)
       end
 
-      # Bootstrap's icon link, saying the value leads somewhere the way text cannot.
-      # What it reads is the host, and an ellipsis where the address goes further --
-      # a path is how a machine finds the page, and the href is already carrying it.
+      # The words lead where the value points, in this tab, the way any link does; the
+      # arrow after them — Bootstrap's icon link, stepping under the cursor — opens the
+      # same address in a new tab. Either reads as the host, and an ellipsis where the
+      # address goes further: a path is how a machine finds the page, and the href has it.
       def url_link(value)
         host, rest = value.match(WEB_URL).captures
         said = rest.delete_suffix('/').empty? ? host : "#{host}/…"
 
-        tag.a safe_join([said, icon_tag(:point_right)], ' '),
-              href: value, class: 'icon-link icon-link-hover'
+        safe_join [tag.a(said, href: value), new_tab_arrow(value)], ' '
+      end
+
+      def new_tab_arrow(value)
+        tag.a icon_tag(:point_right), href: value, target: '_blank', rel: 'noopener',
+                                      class: 'icon-link icon-link-hover',
+                                      aria: { label: t('recourse.new_tab') }
       end
     end
   end

data/lib/recourse/routes/nested.rb

@@ -18,8 +18,9 @@ module Recourse
       # Whether this resource has rows to address one at a time. A bookmark names one
       # row, which means nothing for a name with no class behind it at all — and one was
       # drawn anyway, at `/placeholders/:placeholder_id/bookmark`, where nothing linked
-      # to it and anything reaching it raised.
-      def addressable_rows? = Recourse.model?(parent_resource.name).present?
+      # to it and anything reaching it raised. Asked of the constant rather than the
+      # class: loading a model while the routes draw is what Rails 8.2 warns about.
+      def addressable_rows? = Object.const_defined? Recourse.model_name(parent_resource.name)
 
       # The row a table's bookmark square writes: one record kept by whoever is looking,
       # at `/places/5/bookmark`. Deliberately not recorded through `Recourse.nest` — it
@@ -28,7 +29,7 @@ module Recourse
       # since the gem drew it: one segment under the resource, always.
       def draw_bookmark
         path = [current_module, 'bookmarks'].compact.join '/'
-        Controllers.define_missing path, ::BookmarksController
+        Controllers.define_missing(path) { ::BookmarksController }
         resource :bookmark, only: %i[create destroy]
       end
     end

data/lib/recourse/version.rb

@@ -1,4 +1,4 @@
 module Recourse
   # Version of the gem, read by the gemspec and by hosts checking compatibility.
-  VERSION = '4.4.4'
+  VERSION = '4.5.0'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: recourse
 version: !ruby/object:Gem::Version
-  version: 4.4.4
+  version: 4.5.0
 platform: ruby
 authors:
 - claudiob