recordselect 3.4.0 → 3.4.1

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: 097b55b2bcf91b9610442b574be4a9359fbd3828
+  data.tar.gz: b98335628b3b439807428a33bdc8d03793738255
+SHA512:
+  metadata.gz: e5b2934d61d0cc0a6dbdce8269d4217f169b3dea3af9227effe4e2bad429d340df960f37109b9fc1a93f39eaf3762abf3620937140d002fb5810c528ce3b16ed
+  data.tar.gz: 3f274babc93311a0a941054be6092910d6d0278e12fbcb5e361149aedc2ca818f29e7a6950a5db8f6784d5a9916aaab7ce7e604b997436c0c90905e2aa420e9a

data/app/assets/javascripts/jquery/record_select.js

@@ -88,7 +88,8 @@ if (typeof(jQuery.fn.delayedObserver) === 'undefined') {
               else {
                 if (el.data('timer')) { clearTimeout(el.data('timer')); }
                 el.data('timer', setTimeout(function(){
-                  el.data('callback').apply(el);
+                  var callback = el.data('callback');
+                  if (callback) callback.apply(el);
                 }, el.data('delay') * 1000));
                 el.data('oldval', el.val());
               }
@@ -183,7 +184,7 @@ RecordSelect.Abstract = Class.extend({
   open: function() {
     if (this.is_open()) return;
     var _this = this;
-    jQuery.rails.fire(_this.obj, 'rs:before');
+    jQuery.rails.fire(_this.obj, 'recordselect:before');
     _this.container.html('');
     _this.container.show();
     var params = _this.obj.data('params');
@@ -200,6 +201,7 @@ RecordSelect.Abstract = Class.extend({
         else {
           _this.container.find('.text-input').val(_this.obj.val());
           RecordSelect.observe(_this.container.find('form').attr('id'));
+          _this.container.hide(); // needed to get right document height to position first time
           _this.show();
           jQuery(document.body).mousedown(jQuery.proxy(_this, "onbodyclick"));
         }
@@ -211,19 +213,25 @@ RecordSelect.Abstract = Class.extend({
    * positions and reveals the recordselect
    */
   show: function() {
-    var offset = this.obj.offset()
-    if (this.fixed) offset.top -= jQuery(window).scrollTop(); // get fixed position
-    var top = this.obj.outerHeight() + offset.top;
+    var offset = this.obj.offset(), scroll = jQuery(window).scrollTop(), window_height = jQuery(window).height();
+    if (this.fixed) offset.top -= scroll; // get fixed position
+    var top = this.obj.outerHeight() + offset.top, document_height = jQuery(document).height();
     
     this.container.show();
+    var height = this.container.outerHeight();
     this.container.css('left', offset.left);
     this.container.css('top', '');
     this.container.css('bottom', '');
-    if (this.fixed && top + this.container.outerHeight() > jQuery(window).height()) {
-      this.container.css('bottom', jQuery(window).height() - offset.top);
+    if (this.fixed && top + height > window_height) {
+      this.container.css('bottom', window_height - offset.top);
     } else {
-      this.container.css('top', top);
-      if (!this.container.visible()) this.container.css('top', top - this.obj.outerHeight() - this.container.outerHeight());
+      var below_space = window_height-(top-scroll), above_space = offset.top - scroll, position;
+      if (below_space < height) {
+        if (above_space >= height) position = 'bottom';
+        else position = above_space < below_space ? 'top' : 'bottom';
+      } else position = 'top';
+      if (position == 'top') this.container.css('top', top);
+      else this.container.css('bottom', document_height - offset.top);
     }
 
     if (this._use_iframe_mask()) {

data/lib/record_select/version.rb

@@ -2,7 +2,7 @@ module RecordSelect
   module Version
     MAJOR = 3
     MINOR = 4
-    PATCH = 0
+    PATCH = 1
 
     STRING = [MAJOR, MINOR, PATCH].compact.join('.')
   end

metadata

@@ -1,79 +1,70 @@
---- !ruby/object:Gem::Specification 
+--- !ruby/object:Gem::Specification
 name: recordselect
-version: !ruby/object:Gem::Version 
-  hash: 23
-  prerelease: 
-  segments: 
-  - 3
-  - 4
-  - 0
-  version: 3.4.0
+version: !ruby/object:Gem::Version
+  version: 3.4.1
 platform: ruby
-authors: 
+authors:
 - Sergio Cambra
 - Volker Hochstein
 - Lance Ivy
 autorequire: 
 bindir: bin
 cert_chain: []
-
-date: 2014-10-31 00:00:00 Z
-dependencies: 
-- !ruby/object:Gem::Dependency 
-  type: :development
-  requirement: &id001 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
-  version_requirements: *id001
+date: 2014-12-26 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
   name: shoulda
-  prerelease: false
-- !ruby/object:Gem::Dependency 
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
-  requirement: &id002 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: bundler
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
     - - ~>
-      - !ruby/object:Gem::Version 
-        hash: 23
-        segments: 
-        - 1
-        - 0
-        - 0
+      - !ruby/object:Gem::Version
         version: 1.0.0
-  version_requirements: *id002
-  name: bundler
+  type: :development
   prerelease: false
-- !ruby/object:Gem::Dependency 
-  type: :runtime
-  requirement: &id003 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 5
-        segments: 
-        - 3
-        - 1
-        - 3
-        version: 3.1.3
-  version_requirements: *id003
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 1.0.0
+- !ruby/object:Gem::Dependency
   name: rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: 3.1.3
+  type: :runtime
   prerelease: false
-description: RecordSelect is a Rails widget to help you pick one record out of many. I designed it as a more usable and performant alternative to generating a massive dropdown list
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: 3.1.3
+description: RecordSelect is a Rails widget to help you pick one record out of many.
+  I designed it as a more usable and performant alternative to generating a massive
+  dropdown list
 email: activescaffold@googlegroups.com
 executables: []
-
 extensions: []
-
-extra_rdoc_files: 
+extra_rdoc_files:
+- README
+files:
+- MIT-LICENSE
 - README
-files: 
 - app/assets/images/record_select/accept.png
 - app/assets/images/record_select/cross.gif
 - app/assets/images/record_select/next.gif
@@ -100,44 +91,31 @@ files:
 - lib/record_select/helpers/record_select_helper.rb
 - lib/record_select/version.rb
 - lib/recordselect.rb
-- vendor/assets/javascripts/jquery.visible.min.js
-- MIT-LICENSE
-- README
 - test/recordselect_test.rb
+- vendor/assets/javascripts/jquery.visible.min.js
 homepage: http://github.com/scambra/recordselect
-licenses: 
+licenses:
 - MIT
+metadata: {}
 post_install_message: 
 rdoc_options: []
-
-require_paths: 
+require_paths:
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement 
-  none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 49
-      segments: 
-      - 1
-      - 9
-      - 1
+required_ruby_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - '>='
+    - !ruby/object:Gem::Version
       version: 1.9.1
-required_rubygems_version: !ruby/object:Gem::Requirement 
-  none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
-      version: "0"
+required_rubygems_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - '>='
+    - !ruby/object:Gem::Version
+      version: '0'
 requirements: []
-
 rubyforge_project: 
-rubygems_version: 1.8.29
+rubygems_version: 2.4.5
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: RecordSelect widget as a replacement for massive drop down lists
-test_files: 
+test_files:
 - test/recordselect_test.rb