recordselect 3.2.9 → 3.2.10

data/app/assets/javascripts/jquery/record_select.js

@@ -160,7 +160,9 @@ RecordSelect.notify = function(item) {
 
 RecordSelect.observe = function(id) {
   var form = jQuery("#" + id);
-  form.find('input.text-input').delayedObserver(0.35, function() { form.trigger("submit"); });
+  form.find('input.text-input').delayedObserver(0.35, function() {
+    if (form.closest('body').length) form.trigger("submit");
+  });
 }
 
 RecordSelect.render_page = function(record_select_id, page) {
@@ -353,13 +355,15 @@ jQuery.extend(RecordSelect.Abstract.prototype, {
         elem = this.container.find('li.pagination.previous');
         if (elem) elem.find('a').click();
         break;
-      case 27: // Event.KEY_ESC
+      case 27, 9: // Event.KEY_ESC, Event.KEY_TAB
         this.close();
         break;
       default:
         return true;
     }
-    ev.preventDefault(); // so "enter" doesn't submit the form, among other things(?)
+    if (ev.keyCode != 9) { // don't prevent tabbing
+      ev.preventDefault(); // so "enter" doesn't submit the form, among other things(?)
+    }
   },
 
   /**
@@ -424,13 +428,6 @@ RecordSelect.Single = RecordSelect.Abstract.extend({
     if (this.obj.prop('focused')) this.open(); // if it was focused before we could attach observers
   },
 
-  close: function() {
-    // if they close the dialog with the text field empty, then delete the id value
-    if (this.obj.val() == '') this.set('', '');
-
-    RecordSelect.Abstract.prototype.close.call(this);
-  },
-
   onselect: function(id, value) {
     this.set(id, value);
     if (this.options.onchange) this.options.onchange.call(this, id, value);

data/app/assets/javascripts/prototype/record_select.js

@@ -236,13 +236,15 @@ Object.extend(RecordSelect.Abstract.prototype, {
         elem = this.container.down('li.pagination.previous');
         if (elem) elem.down('a').onclick();
         break;
-      case Event.KEY_ESC:
+      case Event.KEY_ESC, Event.KEY_TAB:
         this.close();
         break;
       default:
         return;
     }
-    Event.stop(ev); // so "enter" doesn't submit the form, among other things(?)
+    if (ev.keyCode != Event.KEY_TAB) { // don't prevent tabbing
+      Event.stop(ev); // so "enter" doesn't submit the form, among other things(?)
+    }
   },
 
   /**
@@ -309,13 +311,6 @@ RecordSelect.Single.prototype = Object.extend(new RecordSelect.Abstract(), {
     if (this.obj.focused) this.open(); // if it was focused before we could attach observers
   },
 
-  close: function() {
-    // if they close the dialog with the text field empty, then delete the id value
-    if (this.obj.value == '') this.set('', '');
-
-    RecordSelect.Abstract.prototype.close.call(this);
-  },
-
   onselect: function(id, value) {
     this.set(id, value);
     if (this.options.onchange) this.options.onchange.call(this, id, value);

data/lib/record_select/version.rb

@@ -2,7 +2,7 @@ module RecordSelect
   module Version
     MAJOR = 3
     MINOR = 2
-    PATCH = 9
+    PATCH = 10
 
     STRING = [MAJOR, MINOR, PATCH].compact.join('.')
   end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: recordselect
 version: !ruby/object:Gem::Version 
-  hash: 29
+  hash: 27
   prerelease: 
   segments: 
   - 3
   - 2
-  - 9
-  version: 3.2.9
+  - 10
+  version: 3.2.10
 platform: ruby
 authors: 
 - Sergio Cambra
@@ -17,7 +17,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2013-06-24 00:00:00 Z
+date: 2013-07-04 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   type: :development