recordselect 3.1.6 → 3.1.7

data/app/assets/javascripts/jquery/record_select.js

@@ -79,7 +79,7 @@ if (typeof(jQuery.fn.delayedObserver) === 'undefined') {
    
     function delayedObserverCallback(stackPos) {
       observed = delayedObserverStack[stackPos];
-      if (observed.timer) return;
+      if (observed.timer) clearTimeout(observed.timer);
      
       observed.timer = setTimeout(function(){
         observed.timer = null;
@@ -284,7 +284,7 @@ RecordSelect.Abstract = Class.extend({
     if (!this.is_open()) return;
     if (this.container.has($(event.target)).length > 0) {
       return;
-    } else {
+    } else if (!this.obj.is(event.target)) {
       this.close();
     }
   },

data/app/assets/javascripts/jquery/record_select.js~

@@ -79,7 +79,7 @@ if (typeof(jQuery.fn.delayedObserver) === 'undefined') {
    
     function delayedObserverCallback(stackPos) {
       observed = delayedObserverStack[stackPos];
-      if (observed.timer) return;
+      if (observed.timer) clearTimeout(observed.timer);
      
       observed.timer = setTimeout(function(){
         observed.timer = null;
@@ -161,11 +161,8 @@ RecordSelect.notify = function(item) {
   if (onselect)
   {
     try {
-      // .unescapeHTML() not implemented so far
-      var label = $.trim(item.find('label').first().html());
-      if (label.length == 0) {
-        label = item.html();
-      }
+      var label = $.trim(item.find('label').first().text());
+      if (!label) label = item.text();
       onselect(item.parent().attr('id').substr(2), label, e);
     } catch(e) {
       alert(e);
@@ -191,6 +188,9 @@ RecordSelect.Abstract = Class.extend({
     this.url = url;
     this.options = options;
     this.container;
+    if (this.options.onchange && typeof this.options.onchange != 'function') {
+      this.options.onchange = eval(this.options.onchange);
+    }
 
     if (RecordSelect.document_loaded) {
       this.onload();
@@ -284,7 +284,7 @@ RecordSelect.Abstract = Class.extend({
     if (!this.is_open()) return;
     if (this.container.has($(event.target)).length > 0) {
       return;
-    } else {
+    } else if (!this.obj.is(event.target)) {
       this.close();
     }
   },
@@ -438,6 +438,8 @@ RecordSelect.Single = RecordSelect.Abstract.extend({
   onselect: function(id, value) {
     this.set(id, value);
     if (this.options.onchange) this.options.onchange.call(this, id, value);
+    var _this = this;
+    this.obj.trigger("recordselect:change", [id, value]);
     this.close();
   },
 
@@ -471,7 +473,7 @@ RecordSelect.Autocomplete = RecordSelect.Abstract.extend({
 
   close: function() {
     // if they close the dialog with the text field empty, then delete the id value
-    if (this.obj.val() == '') this.set('', '');
+    if (this.obj.val() == '') this.set('');
 
     RecordSelect.Abstract.prototype.close.call(this);
   },
@@ -479,6 +481,7 @@ RecordSelect.Autocomplete = RecordSelect.Abstract.extend({
   onselect: function(id, value) {
     this.set(value);
     if (this.options.onchange) this.options.onchange.call(this, id, value);
+    this.obj.trigger("recordselect:change", [id, value]);
     this.close();
   },
 

data/lib/record_select/version.rb

@@ -2,7 +2,7 @@ module RecordSelect
   module Version
     MAJOR = 3
     MINOR = 1
-    PATCH = 6
+    PATCH = 7
 
     STRING = [MAJOR, MINOR, PATCH].compact.join('.')
   end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: recordselect
 version: !ruby/object:Gem::Version 
-  hash: 15
+  hash: 13
   prerelease: 
   segments: 
   - 3
   - 1
-  - 6
-  version: 3.1.6
+  - 7
+  version: 3.1.7
 platform: ruby
 authors: 
 - Sergio Cambra
@@ -17,10 +17,10 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-11-14 00:00:00 Z
+date: 2011-12-19 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
-  requirement: &id001 !ruby/object:Gem::Requirement 
+  version_requirements: &id001 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
@@ -29,12 +29,12 @@ dependencies:
         segments: 
         - 0
         version: "0"
+  requirement: *id001
+  prerelease: false
   type: :development
   name: shoulda
-  version_requirements: *id001
-  prerelease: false
 - !ruby/object:Gem::Dependency 
-  requirement: &id002 !ruby/object:Gem::Requirement 
+  version_requirements: &id002 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ~>
@@ -45,12 +45,12 @@ dependencies:
         - 0
         - 0
         version: 1.0.0
+  requirement: *id002
+  prerelease: false
   type: :development
   name: bundler
-  version_requirements: *id002
-  prerelease: false
 - !ruby/object:Gem::Dependency 
-  requirement: &id003 !ruby/object:Gem::Requirement 
+  version_requirements: &id003 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
@@ -59,12 +59,12 @@ dependencies:
         segments: 
         - 0
         version: "0"
+  requirement: *id003
+  prerelease: false
   type: :development
   name: rcov
-  version_requirements: *id003
-  prerelease: false
 - !ruby/object:Gem::Dependency 
-  requirement: &id004 !ruby/object:Gem::Requirement 
+  version_requirements: &id004 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ~>
@@ -75,10 +75,10 @@ dependencies:
         - 1
         - 0
         version: 3.1.0
+  requirement: *id004
+  prerelease: false
   type: :runtime
   name: rails
-  version_requirements: *id004
-  prerelease: false
 description: RecordSelect is a Rails widget to help you pick one record out of many. I designed it as a more usable and performant alternative to generating a massive dropdown list
 email: activescaffold@googlegroups.com
 executables: []