record_store 8.0.5 → 8.0.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6c527f647483b3ba25a8795bd1de0eebc8db895263dcaa836b36ba61d6937ede
-  data.tar.gz: 89aa174d951809d032d50defe287e53f348a363c68b0eadb759ee15589915b1c
+  metadata.gz: a6884d926bdd86badb5c898030ca919d28c61ff64fc7b023c5af227cc289a2be
+  data.tar.gz: 6189b564b512cb320b5a69a4027dc4642212ab9dc1aa054e66b899b70c58187b
 SHA512:
-  metadata.gz: a5deb741718100321c6c96bdb789cb73120a1d91a24baeec672da5633805f11cc91c310d32a8bc41aead7f0c5a825bd57544272a0d1a6d1a61041896edd8f265
-  data.tar.gz: c041100480d8f986c5e2c5a3eb4edebc91e30759f3299c12420d9fe263e22fd359912ff3ad88936c3edb3202d5170cecd2adb3defd4213933b65e0e1214250e9
+  metadata.gz: 59b22a7833c745d2416a6c3070f22115305e66a4b5553d3a9e20c7e703ab4c5125f24b5e9d278c81dd755337d015da422c9f32f6ebe7da031a850dce2dd2b7c3
+  data.tar.gz: 3f336051180e9e08ee46b11d4f516d8461f006ad882e28015dcaf4f481e5962c661cc7fea3a619090543987b39b80fcbbcbf182c29d38b60272cbc7177aedfe2

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 # CHANGELOG
 
+## 8.0.7
+- Add retry logic for server errors from providers
+  
+## 8.0.6
+- Fix quotes around Cloudflare TXT records
+
 ## 8.0.5
 - Add IPv6 PTR record validation
 

data/lib/record_store/provider/cloudflare/client.rb

@@ -64,16 +64,13 @@ module Cloudflare
 
         begin
           response = conn.request(request)
-        rescue StandardError => e
-          raise "HTTP error: #{e.message}"
+          response.value
+          response
+        rescue Net::HTTPRetriableError, Net::HTTPFatalError => e
+          raise RecordStore::Provider::RetriableError, e.message
+        rescue Net::HTTPClientException, Net::HTTPError => e
+          raise RecordStore::Provider::Error, e.message
         end
-
-        if response.code.to_i >= 300
-          raise RecordStore::Provider::Error,
-            "HTTP response code: #{response.code} - #{response.message}; #{response.body}"
-        end
-
-        response
       end
     end
 

data/lib/record_store/provider/cloudflare.rb

@@ -128,7 +128,7 @@ module RecordStore
           api_body[:content] = record.exchange
           api_body[:priority] = record.preference
         when Record::TXT, Record::SPF
-          api_body[:content] = record.txtdata.gsub('\;', ';')
+          api_body[:content] = Record.quote(record.txtdata.gsub('\;', ';'))
         when Record::CAA
           api_body[:data] = record.rdata
         when Record::SRV
@@ -166,7 +166,8 @@ module RecordStore
             record.merge!(cname: api_response['content'])
           end
         when 'TXT'
-          record.merge!(txtdata: Record.unescape(api_response['content']).gsub(';', '\;'))
+          content = Record.unquote(api_response['content'])
+          record.merge!(txtdata: content.gsub(';', '\;'))
         when 'MX'
           record.merge!(preference: api_response['priority'], exchange: api_response['content'])
         when 'PTR'

data/lib/record_store/provider.rb

@@ -6,6 +6,8 @@ module RecordStore
 
     class UnparseableBodyError < Error; end
 
+    class RetriableError < Error; end
+
     class << self
       def provider_for(object)
         lookup_error = false
@@ -145,6 +147,7 @@ module RecordStore
         max_timeouts: 5,
         max_conn_resets: 5,
         max_retries: 5,
+        max_server_errors: 3,
         delay: 1,
         backoff_multiplier: 2,
         max_backoff: 10
@@ -158,7 +161,7 @@ module RecordStore
 
         loop do
           return yield
-        rescue UnparseableBodyError
+        rescue RecordStore::Provider::UnparseableBodyError
           raise if max_retries <= 0
 
           max_retries -= 1
@@ -176,6 +179,12 @@ module RecordStore
           max_conn_resets -= 1
 
           waiter.wait
+        rescue RecordStore::Provider::RetriableError
+          raise if max_server_errors <= 0
+
+          max_server_errors -= 1
+
+          waiter.wait(message: 'Waiting to retry after server error')
         end
       end
     end

data/lib/record_store/record/txt.rb

@@ -22,7 +22,7 @@ module RecordStore
 
     def escaped_semicolons
       if txtdata =~ /([^\\]|\A);/
-        errors.add(:txtdata, 'has unescaped semicolons (See RFC 1035).')
+        errors.add(:txtdata, 'has unescaped semicolons, which begins comment portion of record per RFC 1035.')
       end
     end
   end

data/lib/record_store/version.rb

@@ -1,3 +1,3 @@
 module RecordStore
-  VERSION = '8.0.5'.freeze
+  VERSION = '8.0.7'.freeze
 end

data/record_store.gemspec

@@ -46,7 +46,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'mocha'
   spec.add_development_dependency 'pry'
   spec.add_development_dependency 'rake'
-  spec.add_development_dependency 'rubocop', '~> 1.69.0'
+  spec.add_development_dependency 'rubocop', '~> 1.75.2'
   spec.add_development_dependency 'rubocop-shopify', '~> 2.15.1'
   spec.add_development_dependency 'vcr'
   spec.add_development_dependency 'webmock'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: record_store
 version: !ruby/object:Gem::Version
-  version: 8.0.5
+  version: 8.0.7
 platform: ruby
 authors:
 - Willem van Bergen
 - Emil Stolarsky
 bindir: bin
 cert_chain: []
-date: 2025-01-09 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -304,14 +304,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.69.0
+        version: 1.75.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.69.0
+        version: 1.75.2
 - !ruby/object:Gem::Dependency
   name: rubocop-shopify
   requirement: !ruby/object:Gem::Requirement
@@ -453,7 +453,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.2
+rubygems_version: 3.6.8
 specification_version: 4
 summary: Manage DNS using git
 test_files: []