record_store 8.0.3 → 8.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1e8b87ae901142fc4396da4b2e67b9f7b5f7ff70c9bdc2046dbbb4967feeee76
-  data.tar.gz: 9572767d6cfc0b0e5ed3ad9d962fe7e9b37fe057c50d734ed7cc73d74a29b18a
+  metadata.gz: 6c527f647483b3ba25a8795bd1de0eebc8db895263dcaa836b36ba61d6937ede
+  data.tar.gz: 89aa174d951809d032d50defe287e53f348a363c68b0eadb759ee15589915b1c
 SHA512:
-  metadata.gz: 236d61311fa1639e0223e9553b8616da334333d01b328c54e549d543eed2b0abfaeb32b568416e29736c57fcf4a6ad277eec2b7783e3456d0f206749c35a724e
-  data.tar.gz: 624c5bb6dbeebc0cea107cdf4e87d20e228e690f54aacad5a4a3ab31538a5c5e6aa9adb522c63812ac3c6d49c6e52cb44e49adc2470049e87812f6593e894f25
+  metadata.gz: a5deb741718100321c6c96bdb789cb73120a1d91a24baeec672da5633805f11cc91c310d32a8bc41aead7f0c5a825bd57544272a0d1a6d1a61041896edd8f265
+  data.tar.gz: c041100480d8f986c5e2c5a3eb4edebc91e30759f3299c12420d9fe263e22fd359912ff3ad88936c3edb3202d5170cecd2adb3defd4213933b65e0e1214250e9

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 # CHANGELOG
 
+## 8.0.5
+- Add IPv6 PTR record validation
+
+## 8.0.4
+- Normalize (compress) addresses in A and AAAA records
+
 ## 8.0.3
 - Fix SRV records in Cloudflare
 

data/lib/record_store/provider/cloudflare/client.rb

@@ -11,35 +11,30 @@ module Cloudflare
 
     def get(endpoint, params = {})
       uri = build_uri(endpoint, params)
-
       response = request(:get, uri)
       Cloudflare::Response.new(response)
     end
 
     def post(endpoint, body = nil)
       uri = build_uri(endpoint)
-
       response = request(:post, uri, body: body)
       Cloudflare::Response.new(response)
     end
 
     def put(endpoint, body = nil)
       uri = build_uri(endpoint)
-
       response = request(:put, uri, body: body)
       Cloudflare::Response.new(response)
     end
 
     def patch(endpoint, body = nil)
       uri = build_uri(endpoint)
-
       response = request(:patch, uri, body: body)
       Cloudflare::Response.new(response)
     end
 
     def delete(endpoint)
       uri = build_uri(endpoint)
-
       response = request(:delete, uri)
       Cloudflare::Response.new(response)
     end
@@ -72,6 +67,12 @@ module Cloudflare
         rescue StandardError => e
           raise "HTTP error: #{e.message}"
         end
+
+        if response.code.to_i >= 300
+          raise RecordStore::Provider::Error,
+            "HTTP response code: #{response.code} - #{response.message}; #{response.body}"
+        end
+
         response
       end
     end

data/lib/record_store/record/a.rb

@@ -1,13 +1,17 @@
 module RecordStore
   class Record::A < Record
-    attr_accessor :address
+    attr_reader :address
 
     validates_presence_of :address
     validate :valid_address?
 
     def initialize(record)
       super
-      @address = record.fetch(:address)
+      self.address = record.fetch(:address)
+    end
+
+    def address=(value)
+      @address = normalize_address(value)
     end
 
     def rdata
@@ -26,5 +30,11 @@ module RecordStore
     rescue IPAddr::InvalidAddressError
       errors.add(:address, 'is invalid')
     end
+
+    def normalize_address(value)
+      IPAddr.new(value).to_s
+    rescue IPAddr::InvalidAddressError
+      value
+    end
   end
 end

data/lib/record_store/record/aaaa.rb

@@ -1,13 +1,17 @@
 module RecordStore
   class Record::AAAA < Record
-    attr_accessor :address
+    attr_reader :address
 
     validates_presence_of :address
     validate :valid_address?
 
     def initialize(record)
       super
-      @address = record.fetch(:address)
+      self.address = record.fetch(:address)
+    end
+
+    def address=(value)
+      @address = normalize_address(value)
     end
 
     def rdata
@@ -26,5 +30,11 @@ module RecordStore
     rescue IPAddr::InvalidAddressError
       errors.add(:address, 'is invalid')
     end
+
+    def normalize_address(value)
+      IPAddr.new(value).to_s
+    rescue IPAddr::InvalidAddressError
+      value
+    end
   end
 end

data/lib/record_store/record/ptr.rb

@@ -2,11 +2,19 @@ module RecordStore
   class Record::PTR < Record
     attr_accessor :ptrdname
 
-    OCTET_LABEL_SEQUENCE_REGEX = /\A(?:([0-9]|[1-9][0-9]|[1-9][0-9][0-9])\.){1,4}/
-    IN_ADDR_ARPA_SUFFIX_REGEX = /in-addr\.arpa\.\z/
-    FQDN_FORMAT_REGEX = Regexp.new(OCTET_LABEL_SEQUENCE_REGEX.source + IN_ADDR_ARPA_SUFFIX_REGEX.source)
+    # IPv4: 1-3 digits (0-255) followed by dots, 1-4 times
+    IPV4_LABEL_SEQUENCE_REGEX = /\A(?:([0-9]|[1-9][0-9]|[1-9][0-9][0-9])\.){1,4}/
 
-    validates_format_of :fqdn, with: FQDN_FORMAT_REGEX
+    # IPv6: single hex digit followed by dots, exactly 32 times
+    IPV6_LABEL_SEQUENCE_REGEX = /\A(?:[0-9a-f]\.){32}/i
+
+    IN_ADDR_ARPA_SUFFIX_REGEX = /(in-addr|ip6)\.arpa\.\z/
+
+    # Combine with suffix for full validation
+    IPV4_FORMAT_REGEX = Regexp.new(IPV4_LABEL_SEQUENCE_REGEX.source + 'in-addr\.arpa\.\z')
+    IPV6_FORMAT_REGEX = Regexp.new(IPV6_LABEL_SEQUENCE_REGEX.source + 'ip6\.arpa\.\z')
+
+    validates_format_of :fqdn, with: Regexp.union(IPV4_FORMAT_REGEX, IPV6_FORMAT_REGEX)
 
     validate :validate_fqdn_octets_in_range
     validate :validate_fqdn_is_in_addr_arpa_subzone
@@ -26,9 +34,20 @@ module RecordStore
     end
 
     def validate_fqdn_octets_in_range
-      OCTET_LABEL_SEQUENCE_REGEX.match(fqdn) do |m|
-        unless m.captures.all? { |o| o.to_d.between?(0, 255) }
-          errors.add(:fqdn, 'octet labels must be within the range 0-255')
+      if fqdn.end_with?('in-addr.arpa.')
+        # IPv4 validation: each octet must be 0-255
+        IPV4_LABEL_SEQUENCE_REGEX.match(fqdn) do |m|
+          unless m.captures.all? { |o| o.to_i.between?(0, 255) }
+            errors.add(:fqdn, 'IPv4 octet labels must be within the range 0-255')
+          end
+        end
+      elsif fqdn.end_with?('ip6.arpa.')
+        # IPv6 validation: each nibble must be a valid hex digit
+        IPV6_LABEL_SEQUENCE_REGEX.match(fqdn) do |m|
+          nibbles = m[0].split('.').reject(&:empty?)
+          unless nibbles.all? { |n| n.match?(/\A[0-9a-f]\z/i) }
+            errors.add(:fqdn, 'IPv6 labels must be single hexadecimal digits (0-9, a-f)')
+          end
         end
       end
     end

data/lib/record_store/version.rb

@@ -1,3 +1,3 @@
 module RecordStore
-  VERSION = '8.0.3'.freeze
+  VERSION = '8.0.5'.freeze
 end

data/record_store.gemspec

@@ -46,7 +46,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'mocha'
   spec.add_development_dependency 'pry'
   spec.add_development_dependency 'rake'
-  spec.add_development_dependency 'rubocop', '~> 1.67.0'
+  spec.add_development_dependency 'rubocop', '~> 1.69.0'
   spec.add_development_dependency 'rubocop-shopify', '~> 2.15.1'
   spec.add_development_dependency 'vcr'
   spec.add_development_dependency 'webmock'

metadata

@@ -1,15 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: record_store
 version: !ruby/object:Gem::Version
-  version: 8.0.3
+  version: 8.0.5
 platform: ruby
 authors:
 - Willem van Bergen
 - Emil Stolarsky
-autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-11-05 00:00:00.000000000 Z
+date: 2025-01-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -305,14 +304,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.67.0
+        version: 1.69.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.67.0
+        version: 1.69.0
 - !ruby/object:Gem::Dependency
   name: rubocop-shopify
   requirement: !ruby/object:Gem::Requirement
@@ -440,7 +439,6 @@ licenses:
 - MIT
 metadata:
   allowed_push_host: https://rubygems.org
-post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -455,8 +453,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.22
-signing_key:
+rubygems_version: 3.6.2
 specification_version: 4
 summary: Manage DNS using git
 test_files: []