record_store 6.7.1 → 7.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7870ecd8f6c7f112a049ad82c71993773df9cd47ebfec1ece571bac97d209572
-  data.tar.gz: 6c137abf69f115a6fc78e38e800ff3d270d54e6462c2467627f97b8fc524dd4e
+  metadata.gz: 4660a1728cb56ba74b30cb043651657b5c771d09b3c2db4cd490668f03816347
+  data.tar.gz: d2c5a964d0144796cfd527f07c980e9f7ae9d2fc29b4b62270eb44c16433adc0
 SHA512:
-  metadata.gz: 376c0a4183592b115118cabf2d89befa26209d0f02bd85f82bece5e0afc5c2c62db8fc2c1ae6668ccfe57148ccbee922aca7386fcb04e9ec5785fbabfb195744
-  data.tar.gz: 8a42c0c7ed8a121d57c0b2c58f2bbe6f568c809fe53e9908724083415f44643497d6019a1cb712e561901ee4e1258d523f9f36738221090ff321c921fb99037c
+  metadata.gz: 76b79d9ba3bcef04ab34d8f39bc8c29ddcd2d46f819f99d0c51f02ae0184f76dd15bf41cf1ba5db629fa601912bf2a06a314a4053f3f75b0cca11c6052cdda5a
+  data.tar.gz: 46790fdab35c62eb6999dc27f91e71690065344c72c2e09c3e1cb9063d55cc1aa2819846d6d5337f55c4a13f1159ccae6ae16b828b7d6d042dc3e8e787a3eb29

data/.github/workflows/ci.yml

@@ -11,7 +11,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        ruby: [ 2.7.1, 3.2.1 ]
+        ruby: [ 3.0, 3.1, 3.2 ]
     name: Test Ruby ${{ matrix.ruby }}
     steps:
       - uses: actions/checkout@v4

data/.rubocop.yml

@@ -2,7 +2,6 @@ inherit_gem:
   rubocop-shopify: rubocop.yml
 
 AllCops:
-  TargetRubyVersion: 2.6.4
   Exclude:
     - vendor/**/*
   UseCache: true

data/.ruby-version

@@ -0,0 +1 @@
+3.2.1

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 # CHANGELOG
 
+## 7.0.0
+- Validate that there are no A/AAAA record conflicts with ALIAS records
+
+## 6.7.2
+- Fix ActiveModel::Error usage for validate_records (behaviour change in ActiveModel 7)
+
 # 6.7.1
 - Change update_record to update_zone_record for DNSimple
 

data/dev.yml

@@ -2,7 +2,7 @@
 name: recordstore
 
 up:
-  - ruby: 3.2.1
+  - ruby
   - bundler
 
 commands:

data/lib/record_store/cli.rb

@@ -149,7 +149,7 @@ module RecordStore
 
     option :name, desc: 'Zone to download', aliases: '-n', type: :string, required: true
     option :provider, desc: 'Provider in which this zone exists', aliases: '-p', type: :string
-    desc 'download', 'Downloads all records from zone and creates YAML zone definition in zones/ '\
+    desc 'download', 'Downloads all records from zone and creates YAML zone definition in zones/ ' \
       'e.g. record-store download --name=shopify.io'
     def download
       name = options.fetch('name')
@@ -289,8 +289,10 @@ module RecordStore
 
         invalid_records.each do |record|
           puts "    #{record}"
-          record.errors.each do |field, msg|
-            puts "      - #{field}: #{msg}"
+          record.errors.messages.each do |field, errors|
+            errors.each do |msg|
+              puts "      - #{field}: #{msg}"
+            end
           end
         end
       end

data/lib/record_store/version.rb

@@ -1,3 +1,3 @@
 module RecordStore
-  VERSION = '6.7.1'.freeze
+  VERSION = '7.0.0'.freeze
 end

data/lib/record_store/zone.rb

@@ -22,6 +22,7 @@ module RecordStore
     validate :validate_can_handle_alias_records
     validate :validate_no_duplicate_keys
     validate :validate_zone_record_not_shadowed
+    validate :validate_alias_has_no_conflicts
 
     class << self
       def download(name, provider_name, **write_options)
@@ -265,6 +266,27 @@ module RecordStore
       end
     end
 
+    # CNAME conflict is handled by validate_cname_records_for_same_fqdn
+    ALIAS_CONFLICTS = [
+      "A",
+      "AAAA",
+    ]
+
+    def validate_alias_has_no_conflicts
+      alias_records = records.select { |record| record.is_a?(Record::ALIAS) }
+
+      alias_records.each do |alias_record|
+        records.each do |record|
+          next unless ALIAS_CONFLICTS.include?(record.type)
+          next unless record.fqdn == alias_record.fqdn
+
+          errors.add(:records, "#{record.type} record conflicts with ALIAS:\n" \
+            "- #{alias_record}\n" \
+            "- #{record}")
+        end
+      end
+    end
+
     def validate_provider_can_handle_zone_records
       record_types = records.map(&:type).to_set
       return unless config.valid?
@@ -312,8 +334,8 @@ module RecordStore
           .select { |record| record.match?(/^([a-zA-Z0-9\-_]+)#{Regexp.escape(suffix)}$/) }
         terminal_records.each do |terminal_record|
           non_terminal = terminal_record.partition('.').last
-          errors.add(:records, "found empty non-terminal #{non_terminal} "\
-            "(caused by existing records #{wildcard} and #{terminal_record})")\
+          errors.add(:records, "found empty non-terminal #{non_terminal} " \
+            "(caused by existing records #{wildcard} and #{terminal_record})") \
             unless intermediate_records.include?(non_terminal)
         end
       end

data/record_store.gemspec

@@ -9,8 +9,8 @@ Gem::Specification.new do |spec|
   spec.email       = ['willem@railsdoctors.com', 'emil@shopify.com']
 
   spec.summary     = 'Manage DNS using git'
-  spec.description = "Manage DNS through a git-based workflow. If you're looking for the original 'record_store',"\
-    " that has been renamed to 'sequel_record_store'."
+  spec.description = "Manage DNS through a git-based workflow. If you're looking for the original 'record_store', " \
+    "that has been renamed to 'sequel_record_store'."
   spec.homepage    = 'https://github.com/Shopify/record_store'
   spec.license     = 'MIT'
 
@@ -24,20 +24,20 @@ Gem::Specification.new do |spec|
   spec.executables = ['record-store']
   spec.require_paths = ['lib']
 
-  spec.required_ruby_version = '>= 2.0'
+  spec.required_ruby_version = '>= 3.0.0'
 
   spec.add_runtime_dependency 'activemodel', '>= 4.2'
   spec.add_runtime_dependency 'activesupport', '>= 4.2'
   spec.add_runtime_dependency 'ejson'
   spec.add_runtime_dependency 'thor', '>= 0.20.3', '< 1.4.0'
 
-  spec.add_runtime_dependency 'dnsimple', '>= 4.4', '< 8.9'
+  spec.add_runtime_dependency 'dnsimple', '>= 4.4', '< 9.1'
   spec.add_runtime_dependency 'fog-dynect', '>= 0.4', '< 0.6'
   spec.add_runtime_dependency 'fog-json'
   spec.add_runtime_dependency 'fog-xml'
   spec.add_runtime_dependency 'google-cloud-dns', '~> 0.31'
   spec.add_runtime_dependency 'ns1'
-  spec.add_runtime_dependency 'oci', '~> 2.14.0'
+  spec.add_runtime_dependency 'oci', '>= 2.14', '< 2.21'
   spec.add_runtime_dependency 'ruby-limiter', '>= 1.0.1', '< 3'
 
   spec.add_development_dependency 'bundler'
@@ -46,8 +46,8 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'mocha'
   spec.add_development_dependency 'pry'
   spec.add_development_dependency 'rake'
-  spec.add_development_dependency 'rubocop', '~> 1.60.2'
-  spec.add_development_dependency 'rubocop-shopify', '~> 2.14.0'
+  spec.add_development_dependency 'rubocop', '~> 1.62.1'
+  spec.add_development_dependency 'rubocop-shopify', '~> 2.15.1'
   spec.add_development_dependency 'vcr'
   spec.add_development_dependency 'webmock'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: record_store
 version: !ruby/object:Gem::Version
-  version: 6.7.1
+  version: 7.0.0
 platform: ruby
 authors:
 - Willem van Bergen
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2024-02-12 00:00:00.000000000 Z
+date: 2024-04-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -82,7 +82,7 @@ dependencies:
         version: '4.4'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '8.9'
+        version: '9.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -92,7 +92,7 @@ dependencies:
         version: '4.4'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '8.9'
+        version: '9.1'
 - !ruby/object:Gem::Dependency
   name: fog-dynect
   requirement: !ruby/object:Gem::Requirement
@@ -173,16 +173,22 @@ dependencies:
   name: oci
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '2.14'
+    - - "<"
       - !ruby/object:Gem::Version
-        version: 2.14.0
+        version: '2.21'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '2.14'
+    - - "<"
       - !ruby/object:Gem::Version
-        version: 2.14.0
+        version: '2.21'
 - !ruby/object:Gem::Dependency
   name: ruby-limiter
   requirement: !ruby/object:Gem::Requirement
@@ -293,28 +299,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.60.2
+        version: 1.62.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.60.2
+        version: 1.62.1
 - !ruby/object:Gem::Dependency
   name: rubocop-shopify
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.14.0
+        version: 2.15.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.14.0
+        version: 2.15.1
 - !ruby/object:Gem::Dependency
   name: vcr
   requirement: !ruby/object:Gem::Requirement
@@ -360,6 +366,7 @@ files:
 - ".gitignore"
 - ".rubocop-https---shopify-github-io-ruby-style-guide-rubocop-yml"
 - ".rubocop.yml"
+- ".ruby-version"
 - ".travis.yml"
 - CHANGELOG.md
 - Gemfile
@@ -432,14 +439,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.0'
+      version: 3.0.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.6
+rubygems_version: 3.5.7
 signing_key: 
 specification_version: 4
 summary: Manage DNS using git