record_filter 0.9.15 → 0.9.16

data/VERSION.yml

@@ -1,4 +1,4 @@
 --- 
-:patch: 15
+:patch: 16
 :major: 0
 :minor: 9

data/lib/record_filter/restrictions.rb

@@ -90,8 +90,15 @@ module RecordFilter
       end
 
       def to_conditions
-        # Need to put in the value even if it's null in this case.
-        [to_sql, @value]
+        # For NOT IN conditions, passing an empty array as the value will
+        # produce a condition like "WHERE id NOT IN (NULL)", and that will
+        # return an empty set, which is presumably not what the user meant
+        # to get. Doing some babysitting here.
+        if @negated && @value.respond_to?(:empty?) && @value.empty?
+          []
+        else
+          [to_sql, @value]
+        end
       end
     end
 

data/record_filter.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{record_filter}
-  s.version = "0.9.15"
+  s.version = "0.9.16"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Aubrey Holland", "Mat Brown"]
-  s.date = %q{2010-01-04}
+  s.date = %q{2010-02-12}
   s.description = %q{RecordFilter is a Pure-ruby criteria API for building complex queries in ActiveRecord. It supports queries that are built on the fly as well as named filters that can be added to objects and chained to create complex queries. It also gets rid of the nasty hard-coded SQL that shows up in most ActiveRecord code with a clean API that makes queries simple and intuitive to build.}
   s.email = %q{aubreyholland@gmail.com}
   s.extra_rdoc_files = [

data/spec/restrictions_spec.rb

@@ -80,6 +80,13 @@ describe 'RecordFilter restrictions' do
     Post.last_find.should == { :readonly => false, :conditions => [%q("posts".blog_id IN (?)), []] }
   end
 
+  it 'should ignore the condition for NOT IN filters with empty arrays' do
+    Post.filter do
+      with(:blog_id).not_in([])
+    end.inspect
+    Post.last_find.should == { :readonly => false }
+  end
+
   it 'should do the right thing for IN filters with single values' do
     Post.filter do
       with(:blog_id).in(1)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: record_filter
 version: !ruby/object:Gem::Version 
-  version: 0.9.15
+  version: 0.9.16
 platform: ruby
 authors: 
 - Aubrey Holland
@@ -10,7 +10,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-01-04 00:00:00 -05:00
+date: 2010-02-12 00:00:00 -05:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency