record_collection 0.4.4 → 0.4.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ffed31f67a7d2df694b8b0314dc9ae69606d7839
-  data.tar.gz: 00d178e4963eeff61b02443841eb0d1624f0a896
+  metadata.gz: 69468333eb7b36ccfe4e161a27349d8c0c88eb97
+  data.tar.gz: f11c4e74135a921ff668565f2806bd1e21dbd21e
 SHA512:
-  metadata.gz: 8070ced31dfc91c1bbce60dbce564226634f21a33aaac223139fb52d22ab4c2ec5df5473e8e5036c660d15fcae78827afaf5ef62b328f3fa1a547ab9ab742d81
-  data.tar.gz: 7fe040d93fceb173d528f2c3a8e0701404c58417dad7cb8a346917ffbf633e7b221b96511825a0c40339fd15dd16bad864b1eb547a9c8a862eadfe292915b746
+  metadata.gz: 6efdd0029314ff4867e3c894b7bb634fedcdbb23dfc1d8bdcd29531fe429820236ae0d68357074ef6d37770de8ae952f8d7d4266edece99ba9f6a94e4c9e18e6
+  data.tar.gz: a5cff88bcf12c8e0739cac8f94b61981afe9383ff1f5119f519d2d43822041e2c562611b158bea30f8fc43854ae9a0a3d8aa97207e01aac3c49bc3a3228c1397

data/lib/record_collection/rails/form_options_helper.rb

@@ -11,6 +11,7 @@ class ActionView::Helpers::FormBuilder
   # Return inputs for the collection ids
   def collection_ids
     @collection_ids_already_added = true
+    return "".html_safe unless object.respond_to?(:map)
     object.map{|record| @template.hidden_field_tag('ids[]', record.id, id: nil) }.join.html_safe
   end
 

data/lib/record_collection/version.rb

@@ -1,3 +1,3 @@
 module RecordCollection
-  VERSION = "0.4.4"
+  VERSION = "0.4.5"
 end

data/spec/base/delegation_spec.rb

@@ -0,0 +1,85 @@
+require 'spec_helper'
+
+RSpec.describe Employee::Collection do
+  subject { described_class.new }
+
+  describe '#one?' do
+    it 'is false without a collection' do
+      expect( subject.one? ).to be false
+    end
+
+    it 'is true with exactly one record' do
+      expect( described_class.new([Object.new]).one? ).to be true
+    end
+
+    it 'is false with more than one records' do
+      expect( described_class.new([Object.new, Object.new]).one? ).to be false
+    end
+  end
+
+  describe '#first and #last' do
+    it 'returns the first and last object of the collection' do
+      o1 = Object.new
+      o2 = Object.new
+      expect( described_class.new([o1, o2]).first ).to be o1
+      expect( described_class.new([o1, o2]).last ).to   be o2
+    end
+  end
+
+  describe 'form representation' do
+    it 'has prefix collection for all types in forms' do
+      expect( described_class.model_name.param_key ).to eq 'collection'
+    end
+  end
+
+  describe '#uniform_collection_attribute' do
+    let(:collection_class){ described_class }
+    describe 'boolean attribute' do
+      let(:record) { Struct.new(:admin) }
+
+      it 'returns false for mixed falsy boolean values' do
+        expect( collection_class.new([record.new, record.new(false)]).uniform_collection_attribute(:admin)).to be false
+      end
+
+      it 'returns nil for mixes boolean values' do
+        expect( collection_class.new([record.new, record.new(true)]).uniform_collection_attribute(:admin)).to be nil
+      end
+
+      it 'returns true for all truthy values' do
+        expect( collection_class.new([record.new(true), record.new(true)]).uniform_collection_attribute(:admin)).to be true
+      end
+    end
+
+    describe 'untyped attribute' do
+      let(:record) { Struct.new(:section) }
+      it 'returns nil for mixed values truthy and falsy' do
+        collection = collection_class.new([record.new, record.new('NT2')])
+        expect( collection.uniform_collection_attribute :section ).to be nil
+      end
+
+      it 'returns nil for mixed truthy values' do
+        collection = collection_class.new([record.new('NT1'), record.new('NT2')])
+        expect( collection.uniform_collection_attribute :section ).to be nil
+      end
+
+      it 'returns the value for all the same values, but does not set the value' do
+        collection = collection_class.new([record.new('NT2'), record.new('NT2')])
+        expect( collection.uniform_collection_attribute :section ).to eq 'NT2'
+        expect( collection.section ).to be nil
+      end
+
+      it 'returns the value for all the same values, and sets the value if set_if_nil is given' do
+        collection = collection_class.new([record.new('NT2'), record.new('NT2')])
+        expect( collection.uniform_collection_attribute :section, set_if_nil: true ).to eq 'NT2'
+        expect( collection.section ).to eq 'NT2'
+      end
+
+      it 'returns the value for all the same values, and does not set the value if set_if_nil is given, but already set (eg: by invalid form)' do
+        collection = collection_class.new([record.new('NT2'), record.new('NT2')], section: 'Invalid set form value')
+        expect( collection.uniform_collection_attribute :section, set_if_nil: true ).to eq 'NT2'
+        expect( collection.section ).to eq 'Invalid set form value'
+      end
+    end
+  end
+end
+

data/spec/base/validations_spec.rb

@@ -1,9 +1,9 @@
 require 'spec_helper'
 
 RSpec.describe 'Validations' do
+  let(:collection_class)  { Employee::Collection }
   describe 'conditional validations' do
     let(:record_class){ Employee }
-    let(:collection_class)  { Employee::Collection }
     it 'is valid without attribute present' do
       collection_class.new([]).should be_valid
     end
@@ -15,5 +15,12 @@ RSpec.describe 'Validations' do
     it 'is invalid with invalid section attribute' do
       collection_class.new([], section: 'SECTION3').should be_invalid
     end
+    describe '#save' do
+      it 'does not trigger update_collection_attributes! for invalid collection' do
+        collection = collection_class.new [], section: 'INVALID_SECTION_NAME'
+        collection.should_not receive :update_collection_attributes!
+        collection.save
+      end
+    end
   end
 end

data/spec/rails/form_builder_spec.rb

@@ -0,0 +1,24 @@
+require 'spec_helper'
+
+RSpec.describe ActionView::Helpers::FormBuilder do
+  let(:employee){ Employee.create section: 'SE1' }
+  subject{ described_class.new :collection, Employee::Collection.new([employee]), @template, {}}
+  before do
+    # http://pivotallabs.com/testing-custom-form-builder/
+    @template = Object.new
+    @template.extend ActionView::Helpers::FormTagHelper
+    @template.extend ActionView::Helpers::FormOptionsHelper
+    @template.extend ActionView::Helpers::FormHelper
+  end
+
+  describe '.collection_ids' do
+    it 'returns the collection ids as hidden fields' do
+      subject.collection_ids.should eq %{<input type="hidden" name="ids[]" value="#{employee.id}" />}
+    end
+
+    it "does not raise when the object is not a collection object" do
+      form_builder = described_class.new :employee, employee, @template, {}
+      expect{ form_builder.collection_ids }.not_to raise_error
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: record_collection
 version: !ruby/object:Gem::Version
-  version: 0.4.4
+  version: 0.4.5
 platform: ruby
 authors:
 - Benjamin ter Kuile
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-02-06 00:00:00.000000000 Z
+date: 2015-02-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -307,6 +307,7 @@ files:
 - lib/record_collection/rails/routes.rb
 - lib/record_collection/version.rb
 - record_collection.gemspec
+- spec/base/delegation_spec.rb
 - spec/base/finding_records_spec.rb
 - spec/base/validations_spec.rb
 - spec/dummy/README.rdoc
@@ -375,6 +376,7 @@ files:
 - spec/features/multi_select_spec.rb
 - spec/features/translations_spec.rb
 - spec/fixtures/collections.rb
+- spec/rails/form_builder_spec.rb
 - spec/record_selection/base_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/bterkuile/record_collection
@@ -402,6 +404,7 @@ signing_key:
 specification_version: 4
 summary: Manage collections of records in Ruby on Rails
 test_files:
+- spec/base/delegation_spec.rb
 - spec/base/finding_records_spec.rb
 - spec/base/validations_spec.rb
 - spec/dummy/README.rdoc
@@ -470,6 +473,7 @@ test_files:
 - spec/features/multi_select_spec.rb
 - spec/features/translations_spec.rb
 - spec/fixtures/collections.rb
+- spec/rails/form_builder_spec.rb
 - spec/record_selection/base_spec.rb
 - spec/spec_helper.rb
 has_rdoc: