record-cache 0.1.3 → 0.1.4

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    NjcyYzNmZjBjM2VjZGU4MzMzMGI1YjBkNDdiNmQ5NWZiODNiZjE3OA==
+    YzM5MTA3YWI2MTRjMDIwMGFmN2FhYzQxZmNlMWU2ZTNiNTkzODkyMQ==
   data.tar.gz: !binary |-
-    MzU0ZDM3ZjE1YzhmNTY2MTM3M2MwZmU4ZjZhZTI5ZGQ1NWMwNTMwZg==
+    MGYzNGU3NzVlZTI4YTMwZTM5NDhkZDVjZGVjY2UyODJlMWU1YzIzMQ==
 SHA512:
   metadata.gz: !binary |-
-    NDE4MTQxYjA2ZDQ2ZTE1ZWVlOTk1MjY5OGU3ZDJjNThjZGQ4MjIxZTE1MWQy
-    MjMyZmViZmUzZWY2MGU5NDUzOWNhOWFiYWY0MTlmYTAzMTJlOTVjZTA2N2Yz
-    ODgyNDFiMWY5YzU1MzRhYzNjZWM5M2UyMjU1OGFmNzJlMjliMGI=
+    MzQxNDM1ZWQxMmUzYmQyNzZhZjZmNDA2MmQzZWViMWYwZDhlMzI0YTczYjY4
+    ZmE4ZDZkNjBkMjc3YjUxNGM1YjJhMDlkNzkwZDRlNGM0MTBlMTUzMTBmZThm
+    MDg1NWNjMzZhOGE3OWIxMjc0ODg5YzZmYjY1MmY5MWRkNWFhMDc=
   data.tar.gz: !binary |-
-    NDBiNGYyZjIwNDlkMzg5MDU0YjhhNjBjNThiMDhjMzk1YzE1YjgxODUwYTJj
-    ZTk5YzAzNzY1ZmU4MWI2ZjYyYTU1MjQ4NjNkOTEwZmIxMWMzNzAyYWY5NGJj
-    YTc2ZDVlN2UyOTZhMzBhY2NjMmUwMWQ0NDI5MjliYjY5MGZjM2Y=
+    ZDA2OTRjOTZkODFhMTdiNGU3M2IzZDZiYTljNTViZTdjZGQ2ZjRjODNmY2Ew
+    MzA4OTgwYmMyNTE2YzRlZDI4Yjg1MjhiMGFlNTdmYzFmNWZlYWZiYmJlZDc0
+    YzMzODM2Y2UyNDIzYjQyNzAwMWY0NWIxZWI0ZjBkNDJlNDVkMTQ=

data/lib/record_cache/base.rb

@@ -9,7 +9,7 @@ module RecordCache
   module Base
     class << self
       def included(klass)
-        klass.class_eval do 
+        klass.class_eval do
           extend ClassMethods
           include InstanceMethods
         end
@@ -113,7 +113,7 @@ module RecordCache
       #   :store => the cache store for the instances, e.g. :memory_store, :dalli_store* (default: Rails.cache)
       #             or one of the store ids defined using +RecordCache::Base.register_store+
       #   :key   => provide a unique shorter key to limit the cache key length (default: model.name)
-      # 
+      #
       # cache strategy specific options:
       #   :index => one or more attributes (Symbols) for which the ids are cached for the value of the attribute
       #
@@ -124,7 +124,7 @@ module RecordCache
       #   - use :index => :person_id for aggregated has_many associations
       def cache_records(options = {})
         unless @rc_dispatcher
-          @rc_dispatcher = RecordCache::Dispatcher.new(self) 
+          @rc_dispatcher = RecordCache::Dispatcher.new(self)
           # Callback for Data Store specific initialization
           record_cache_init
 
@@ -174,4 +174,4 @@ module RecordCache
     end
 
   end
-end
+end

data/lib/record_cache/datastore/active_record_30.rb

@@ -173,7 +173,7 @@ module RecordCache
         @cacheable = false unless o.groups.empty?
         visit o.froms  if @cacheable
         visit o.wheres if @cacheable
-        # skip o.projections
+        @cacheable = o.projections.none?{ |projection| projection.to_s =~ /distinct/i } unless o.projections.empty? if @cacheable
       end
 
       def visit_Arel_Nodes_SelectStatement o

data/lib/record_cache/datastore/active_record_31.rb

@@ -199,7 +199,7 @@ module RecordCache
         visit o.froms  if @cacheable
         visit o.wheres if @cacheable
         visit o.source if @cacheable
-        # skip o.projections
+        @cacheable = o.projections.none?{ |projection| projection.to_s =~ /distinct/i } unless o.projections.empty? if @cacheable
       end
 
       def visit_Arel_Nodes_SelectStatement o

data/lib/record_cache/datastore/active_record_32.rb

@@ -33,7 +33,7 @@ module RecordCache
           arel = sql.is_a?(String) ? sql.instance_variable_get(:@arel) : sql
 
           sanitized_sql = sanitize_sql(sql)
-          sanitized_sql = connection.to_sql(sanitized_sql, binds) if sanitized_sql.respond_to?(:ast)
+          sanitized_sql = connection.to_sql(sanitized_sql, binds.dup) if sanitized_sql.respond_to?(:ast)
 
           records = if connection.query_cache_enabled
                       query_cache = connection.instance_variable_get(:@query_cache)
@@ -210,7 +210,7 @@ module RecordCache
         visit o.froms  if @cacheable
         visit o.wheres if @cacheable
         visit o.source if @cacheable
-        # skip o.projections
+        @cacheable = o.projections.none?{ |projection| projection.to_s =~ /distinct/i } unless o.projections.empty? if @cacheable
       end
 
       def visit_Arel_Nodes_SelectStatement o

data/lib/record_cache/datastore/active_record_40.rb

@@ -0,0 +1,445 @@
+module RecordCache
+  module ActiveRecord
+
+    module Base
+      class << self
+        def included(klass)
+          klass.extend ClassMethods
+          klass.class_eval do
+            class << self
+              alias_method_chain :find_by_sql, :record_cache
+            end
+          end
+        end
+      end
+
+      module ClassMethods
+        # the tests are always run within a transaction, so the threshold is one higher
+        RC_TRANSACTIONS_THRESHOLD = ENV['RAILS_ENV'] == 'test' ? 1 : 0
+
+        # add cache invalidation hooks on initialization
+        def record_cache_init
+          after_commit :record_cache_create,  :on => :create,  :prepend => true
+          after_commit :record_cache_update,  :on => :update,  :prepend => true
+          after_commit :record_cache_destroy, :on => :destroy, :prepend => true
+        end
+
+        # Retrieve the records, possibly from cache
+        def find_by_sql_with_record_cache(sql, binds = [])
+          # Shortcut, no caching please
+          return find_by_sql_without_record_cache(sql, binds) unless record_cache?
+
+          # check the piggy-back'd ActiveRelation record to see if the query can be retrieved from cache
+          arel = sql.is_a?(String) ? sql.instance_variable_get(:@arel) : sql
+
+          sanitized_sql = sanitize_sql(sql)
+          sanitized_sql = connection.to_sql(sanitized_sql, binds) if sanitized_sql.respond_to?(:ast)
+
+          records = if connection.query_cache_enabled
+                      query_cache = connection.instance_variable_get(:@query_cache)
+                      query_cache["rc/#{sanitized_sql}"][binds] ||= try_record_cache(arel, sql, binds)
+
+                    elsif connection.open_transactions > RC_TRANSACTIONS_THRESHOLD
+                      find_by_sql_without_record_cache(sql, binds)
+
+                    else
+                      try_record_cache(arel, sql, binds)
+                    end
+          records
+        end
+
+        def try_record_cache(arel, sql, binds)
+          query = arel && arel.respond_to?(:ast) ? RecordCache::Arel::QueryVisitor.new(binds).accept(arel.ast) : nil
+          record_cache.fetch(query) do
+            find_by_sql_without_record_cache(sql, binds)
+          end
+        end
+
+      end
+
+    end
+  end
+
+  module Arel
+
+    # The method <ActiveRecord::Base>.find_by_sql is used to actually
+    # retrieve the data from the DB.
+    # Unfortunately the ActiveRelation record is not accessible from
+    # there, so it is piggy-back'd in the SQL string.
+    module TreeManager
+      def self.included(klass)
+        klass.extend ClassMethods
+        klass.send(:include, InstanceMethods)
+        klass.class_eval do
+          alias_method_chain :to_sql, :record_cache
+        end
+      end
+
+      module ClassMethods
+      end
+
+      module InstanceMethods
+        def to_sql_with_record_cache
+          sql = to_sql_without_record_cache
+          sql.instance_variable_set(:@arel, self)
+          sql
+        end
+      end
+    end
+
+    # Visitor for the ActiveRelation to extract a simple cache query
+    # Only accepts single select queries with equality where statements
+    # Rejects queries with grouping / having / offset / etc.
+    class QueryVisitor < ::Arel::Visitors::Visitor
+      DESC = "DESC".freeze
+      COMMA = ",".freeze
+
+      def initialize(bindings)
+        super()
+        @bindings = (bindings || []).inject({}){ |h, cv| column, value = cv; h[column.name] = value; h}
+        @cacheable  = true
+        @query = ::RecordCache::Query.new
+      end
+
+      def accept ast
+        super
+        @cacheable && !ast.lock ? @query : nil
+      end
+
+      private
+
+      def not_cacheable o, attribute
+        @cacheable = false
+      end
+
+      def skip o, attribute
+      end
+
+      alias :visit_Arel_Nodes_TableAlias :not_cacheable
+
+      alias :visit_Arel_Nodes_Lock :not_cacheable
+
+      alias :visit_Arel_Nodes_Sum            :not_cacheable
+      alias :visit_Arel_Nodes_Max            :not_cacheable
+      alias :visit_Arel_Nodes_Min            :not_cacheable
+      alias :visit_Arel_Nodes_Avg            :not_cacheable
+      alias :visit_Arel_Nodes_Count          :not_cacheable
+      alias :visit_Arel_Nodes_Addition       :not_cacheable
+      alias :visit_Arel_Nodes_Subtraction    :not_cacheable
+      alias :visit_Arel_Nodes_Multiplication :not_cacheable
+      alias :visit_Arel_Nodes_NamedFunction  :not_cacheable
+
+      alias :visit_Arel_Nodes_Bin :not_cacheable
+      alias :visit_Arel_Nodes_Distinct :not_cacheable
+      alias :visit_Arel_Nodes_DistinctOn :not_cacheable
+      alias :visit_Arel_Nodes_Division :not_cacheable
+      alias :visit_Arel_Nodes_Except :not_cacheable
+      alias :visit_Arel_Nodes_Exists :not_cacheable
+      alias :visit_Arel_Nodes_InfixOperation :not_cacheable
+      alias :visit_Arel_Nodes_Intersect :not_cacheable
+      alias :visit_Arel_Nodes_Union :not_cacheable
+      alias :visit_Arel_Nodes_UnionAll :not_cacheable
+      alias :visit_Arel_Nodes_With :not_cacheable
+      alias :visit_Arel_Nodes_WithRecursive :not_cacheable
+
+      def visit_Arel_Nodes_JoinSource o, attribute
+        # left and right are array, but using blank as it also works for nil
+        @cacheable = o.left.blank? || o.right.blank?
+      end
+
+      alias :visit_Arel_Nodes_CurrentRow :not_cacheable
+      alias :visit_Arel_Nodes_Extract :not_cacheable
+      alias :visit_Arel_Nodes_Following :not_cacheable
+      alias :visit_Arel_Nodes_NamedWindow :not_cacheable
+      alias :visit_Arel_Nodes_Over :not_cacheable
+      alias :visit_Arel_Nodes_Preceding :not_cacheable
+      alias :visit_Arel_Nodes_Range :not_cacheable
+      alias :visit_Arel_Nodes_Rows :not_cacheable
+      alias :visit_Arel_Nodes_Window :not_cacheable
+
+      alias :visit_Arel_Nodes_As :skip
+      alias :visit_Arel_SelectManager :not_cacheable
+      alias :visit_Arel_Nodes_Ascending :skip
+      alias :visit_Arel_Nodes_Descending :skip
+      alias :visit_Arel_Nodes_False :skip
+      alias :visit_Arel_Nodes_True :skip
+
+      alias :visit_Arel_Nodes_StringJoin :not_cacheable
+      alias :visit_Arel_Nodes_InnerJoin  :not_cacheable
+      alias :visit_Arel_Nodes_OuterJoin  :not_cacheable
+
+      alias :visit_Arel_Nodes_DeleteStatement  :not_cacheable
+      alias :visit_Arel_Nodes_InsertStatement  :not_cacheable
+      alias :visit_Arel_Nodes_UpdateStatement  :not_cacheable
+
+
+      alias :unary                              :not_cacheable
+      alias :visit_Arel_Nodes_Group             :unary
+      alias :visit_Arel_Nodes_Having            :unary
+      alias :visit_Arel_Nodes_Not               :unary
+      alias :visit_Arel_Nodes_On                :unary
+      alias :visit_Arel_Nodes_UnqualifiedColumn :unary
+
+      def visit_Arel_Nodes_Offset o, attribute
+        @cacheable = false unless o.expr == 0
+      end
+
+      def visit_Arel_Nodes_Values o, attribute
+        visit o.expressions if @cacheable
+      end
+
+      def visit_Arel_Nodes_Limit o, attribute
+        @query.limit = o.expr
+      end
+      alias :visit_Arel_Nodes_Top :visit_Arel_Nodes_Limit
+
+      GROUPING_EQUALS_REGEXP = /^\W?(\w*)\W?\.\W?(\w*)\W?\s*=\s*(\d+)$/        # `calendars`.account_id = 5
+      GROUPING_IN_REGEXP = /^^\W?(\w*)\W?\.\W?(\w*)\W?\s*IN\s*\(([\d\s,]+)\)$/ # `service_instances`.`id` IN (118,80,120,82)
+      def visit_Arel_Nodes_Grouping o, attribute
+        return unless @cacheable
+        if @table_name && o.expr =~ GROUPING_EQUALS_REGEXP && $1 == @table_name
+          @cacheable = @query.where($2, $3.to_i)
+        elsif @table_name && o.expr =~ GROUPING_IN_REGEXP && $1 == @table_name
+          @cacheable = @query.where($2, $3.split(',').map(&:to_i))
+        else
+          @cacheable = false
+        end
+      end
+
+      def visit_Arel_Nodes_SelectCore o, attribute
+        @cacheable = false unless o.groups.empty?
+        visit o.froms  if @cacheable
+        visit o.wheres if @cacheable
+        visit o.source if @cacheable
+        @cacheable = o.projections.none?{ |projection| projection.to_s =~ /distinct/i } unless o.projections.empty? if @cacheable
+      end
+
+      def visit_Arel_Nodes_SelectStatement o, attribute
+        @cacheable = false if o.cores.size > 1
+        if @cacheable
+          visit o.offset
+          o.orders.map { |x| handle_order_by(visit x) } if @cacheable && o.orders.size > 0
+          visit o.limit
+          visit o.cores
+        end
+      end
+
+      ORDER_BY_REGEXP = /^\s*([\w\.]*)\s*(|ASC|asc|DESC|desc)\s*$/ # people.id DESC
+      def handle_order_by(order)
+        order.to_s.split(COMMA).each do |o|
+          # simple sort order (+people.id+ can be replaced by +id+, as joins are not allowed anyways)
+          if o.match(ORDER_BY_REGEXP)
+            asc = $2.upcase == DESC ? false : true
+            @query.order_by($1.split('.').last, asc)
+          else
+            @cacheable = false
+          end
+        end
+      end
+
+      def visit_Arel_Table o, attribute
+        @table_name = o.name
+      end
+
+      def visit_Arel_Attributes_Attribute o, attribute
+        o.name.to_sym
+      end
+      alias :visit_Arel_Attributes_Integer   :visit_Arel_Attributes_Attribute
+      alias :visit_Arel_Attributes_Float     :visit_Arel_Attributes_Attribute
+      alias :visit_Arel_Attributes_String    :visit_Arel_Attributes_Attribute
+      alias :visit_Arel_Attributes_Time      :visit_Arel_Attributes_Attribute
+      alias :visit_Arel_Attributes_Boolean   :visit_Arel_Attributes_Attribute
+      alias :visit_Arel_Attributes_Decimal   :visit_Arel_Attributes_Attribute
+
+      def visit_Arel_Nodes_Equality o, attribute
+        key, value = visit(o.left), visit(o.right)
+        # several different binding markers exist depending on the db driver used (MySQL, Postgress supported)
+        if value.to_s =~ /^(\?|\u0000|\$\d+)$/
+          # puts "bindings: #{@bindings.inspect}, key = #{key.to_s}"
+          value = @bindings[key.to_s] || value
+        end
+        # puts "  =====> equality found: #{key.inspect}@#{key.class.name} => #{value.inspect}@#{value.class.name}"
+        @query.where(key, value)
+      end
+      alias :visit_Arel_Nodes_In                 :visit_Arel_Nodes_Equality
+
+      def visit_Arel_Nodes_And o, attribute
+        visit(o.children)
+      end
+
+      alias :visit_Arel_Nodes_Or                 :not_cacheable
+      alias :visit_Arel_Nodes_NotEqual           :not_cacheable
+      alias :visit_Arel_Nodes_GreaterThan        :not_cacheable
+      alias :visit_Arel_Nodes_GreaterThanOrEqual :not_cacheable
+      alias :visit_Arel_Nodes_Assignment         :not_cacheable
+      alias :visit_Arel_Nodes_LessThan           :not_cacheable
+      alias :visit_Arel_Nodes_LessThanOrEqual    :not_cacheable
+      alias :visit_Arel_Nodes_Between            :not_cacheable
+      alias :visit_Arel_Nodes_NotIn              :not_cacheable
+      alias :visit_Arel_Nodes_DoesNotMatch       :not_cacheable
+      alias :visit_Arel_Nodes_Matches            :not_cacheable
+
+      def visit_Fixnum o, attribute
+        o.to_i
+      end
+      alias :visit_Bignum :visit_Fixnum
+
+      def visit_Symbol o, attribute
+        o.to_sym
+      end
+
+      def visit_Object o, attribute
+        o
+      end
+      alias :visit_Arel_Nodes_SqlLiteral :visit_Object
+      alias :visit_Arel_Nodes_BindParam :visit_Object
+      alias :visit_Arel_SqlLiteral :visit_Object # This is deprecated
+      alias :visit_String :visit_Object
+      alias :visit_NilClass :visit_Object
+      alias :visit_TrueClass :visit_Object
+      alias :visit_FalseClass :visit_Object
+      alias :visit_Arel_SqlLiteral :visit_Object
+      alias :visit_BigDecimal :visit_Object
+      alias :visit_Float :visit_Object
+      alias :visit_Time :visit_Object
+      alias :visit_Date :visit_Object
+      alias :visit_DateTime :visit_Object
+      alias :visit_Hash :visit_Object
+
+      def visit_Array o, attribute
+        o.map{ |x| visit x }
+      end
+    end
+  end
+
+end
+
+module RecordCache
+
+  # Patch ActiveRecord::Relation to make sure update_all will invalidate all referenced records
+  module ActiveRecord
+    module UpdateAll
+      class << self
+        def included(klass)
+          klass.extend ClassMethods
+          klass.send(:include, InstanceMethods)
+          klass.class_eval do
+            alias_method_chain :update_all, :record_cache
+          end
+        end
+      end
+
+      module ClassMethods
+      end
+
+      module InstanceMethods
+        def __find_in_clause(sub_select)
+          return nil unless sub_select.arel.constraints.count == 1
+          constraint = sub_select.arel.constraints.first
+          return constraint if constraint.is_a?(::Arel::Nodes::In) # directly an IN clause
+          return nil unless constraint.respond_to?(:children) && constraint.children.count == 1
+          constraint = constraint.children.first
+          return constraint if constraint.is_a?(::Arel::Nodes::In) # AND with IN clause
+          nil
+        end
+
+        def update_all_with_record_cache(updates, conditions = nil, options = {})
+          result = update_all_without_record_cache(updates, conditions, options)
+
+          if record_cache?
+            # when this condition is met, the arel.update method will be called on the current scope, see ActiveRecord::Relation#update_all
+            unless conditions || options.present? || @limit_value.present? != @order_values.present?
+              # get all attributes that contain a unique index for this model
+              unique_index_attributes = RecordCache::Strategy::UniqueIndexCache.attributes(self)
+              # go straight to SQL result (without instantiating records) for optimal performance
+              RecordCache::Base.version_store.multi do
+                sub_select = select(unique_index_attributes.map(&:to_s).join(','))
+                in_clause = __find_in_clause(sub_select)
+                if unique_index_attributes.size == 1 && in_clause &&
+                  in_clause.left.try(:name).to_s == unique_index_attributes.first.to_s
+                  # common case where the unique index is the (only) constraint on the query: SELECT id FROM people WHERE id in (...)
+                  attribute = unique_index_attributes.first
+                  in_clause.right.each do |value|
+                    record_cache.invalidate(attribute, value)
+                  end
+                else
+                  connection.execute(sub_select.to_sql).each do |row|
+                    # invalidate the unique index for all attributes
+                    unique_index_attributes.each_with_index do |attribute, index|
+                      record_cache.invalidate(attribute, (row.is_a?(Hash) ? row[attribute.to_s] : row[index]))
+                    end
+                  end
+                end
+              end
+            end
+          end
+
+          result
+        end
+      end
+    end
+  end
+
+  # Patch ActiveRecord::Associations::HasManyAssociation to make sure the index_cache is updated when records are
+  # deleted from the collection
+  module ActiveRecord
+    module HasMany
+      class << self
+        def included(klass)
+          klass.extend ClassMethods
+          klass.send(:include, InstanceMethods)
+          klass.class_eval do
+            alias_method_chain :delete_records, :record_cache
+          end
+        end
+      end
+
+      module ClassMethods
+      end
+
+      module InstanceMethods
+        def delete_records_with_record_cache(records, method)
+          # invalidate :id cache for all records
+          records.each{ |record| record.class.record_cache.invalidate(record.id) if record.class.record_cache? unless record.new_record? }
+          # invalidate the referenced class for the attribute/value pair on the index cache
+          @reflection.klass.record_cache.invalidate(@reflection.foreign_key.to_sym, @owner.id) if @reflection.klass.record_cache?
+          delete_records_without_record_cache(records, method)
+        end
+      end
+    end
+
+    module HasOne
+      class << self
+        def included(klass)
+          klass.extend ClassMethods
+          klass.send(:include, InstanceMethods)
+          klass.class_eval do
+            alias_method_chain :delete, :record_cache
+          end
+        end
+      end
+
+      module ClassMethods
+      end
+
+      module InstanceMethods
+        def delete_with_record_cache(method = options[:dependent])
+          # invalidate :id cache for all record
+          if load_target
+            target.class.record_cache.invalidate(target.id) if target.class.record_cache? unless target.new_record?
+          end
+          # invalidate the referenced class for the attribute/value pair on the index cache
+          @reflection.klass.record_cache.invalidate(@reflection.foreign_key.to_sym, @owner.id) if @reflection.klass.record_cache?
+          delete_without_record_cache(method)
+        end
+      end
+    end
+  end
+
+end
+
+ActiveRecord::Base.send(:include, RecordCache::ActiveRecord::Base)
+Arel::TreeManager.send(:include, RecordCache::Arel::TreeManager)
+ActiveRecord::Relation.send(:include, RecordCache::ActiveRecord::UpdateAll)
+ActiveRecord::Associations::HasManyAssociation.send(:include, RecordCache::ActiveRecord::HasMany)
+ActiveRecord::Associations::HasOneAssociation.send(:include, RecordCache::ActiveRecord::HasOne)