recommendify 0.3.2 → 0.3.3

data/ext/recommendify.c

@@ -57,6 +57,7 @@ int main(int argc, char **argv){
   redisPrefix = argv[2];
   itemID = argv[3];
   redis_addr.host[0] = 0;
+  redis_addr.port = 0;
 
   /* configure redis location */
   if(argc > 4){
@@ -86,13 +87,20 @@ int main(int argc, char **argv){
     return 1;
   }
 
+
   /* get item count */
   reply = redisCommand(c,"HGET %s:items %s", redisPrefix, itemID);    
-  itemCount = atoi(reply->str);    
+
+  if(reply->str){
+    itemCount = atoi(reply->str);
+  } else {
+    itemCount = 0;
+  }
+
   freeReplyObject(reply);
 
   if(itemCount == 0){
-    printf("item count is zero\n");
+    printf("exit: item count is zero\n");
     return 0;
   }
   

data/lib/recommendify/cc_matrix.rb

@@ -19,11 +19,10 @@ module Recommendify::CCMatrix
   end
 
   def add_single(set_id, item_id, other_item_ids)
-  # todo: add single item to set after set was added (incrementally)
-  #   item_count_incr(item_id)
-  #   other_item_ids.each do |other_item|
-  #     @ccmatrix.incr(item_id, other_idem)
-  #   end
+    item_count_incr(item_id)
+    other_item_ids.each do |other_item|
+      @ccmatrix.incr(item_id, other_item)
+    end
   end
 
   def all_items

data/recommendify.gemspec

@@ -3,7 +3,7 @@ $:.push File.expand_path("../lib", __FILE__)
 
 Gem::Specification.new do |s|
   s.name        = "recommendify"
-  s.version     = "0.3.2"
+  s.version     = "0.3.3"
   s.date        = Date.today.to_s
   s.platform    = Gem::Platform::RUBY
   s.authors     = ["Paul Asmuth"]

data/spec/base_spec.rb

@@ -161,6 +161,11 @@ describe Recommendify::Base do
       sm.for("fnorditem").should == []
     end
 
+    it "should not call split on nil when retrieving a non-existent item (return an empty array)" do
+      sm = Recommendify::Base.new
+      sm.for("NONEXISTENT").should == []
+    end
+
   end
 
   describe "delete_item!" do

data/spec/cc_matrix_shared.rb

@@ -19,8 +19,22 @@ share_examples_for Recommendify::CCMatrix do
     @matrix.ccmatrix["foo", "fnord"].should == 1    
   end
 
-  it "should increment all item<->item paris on single item addition"
-  it "should increment the item count on single item addition"
+  it "should increment all item<->item paris on single item addition" do
+    @matrix.ccmatrix["bar", "fnord"] = 2
+    @matrix.add_single("user123", "fnord", ["foo", "bar"])
+    @matrix.ccmatrix["bar", "fnord"].should == 3
+    @matrix.ccmatrix["foo", "fnord"].should == 1   
+  end
+
+  it "should increment the item count on single item addition" do
+    @matrix.send(:item_count_incr, "fnordfnord")
+    @matrix.send(:item_count_incr, "fnordfnord")
+    @matrix.send(:item_count_incr, "foofnord")
+    @matrix.add_single("user123", "fnordfnord", ["foofnord", "barfnord"])
+    @matrix.send(:item_count, "foofnord").should == 1
+    @matrix.send(:item_count, "barfnord").should == 0
+    @matrix.send(:item_count, "fnordfnord").should == 3
+  end
 
   it "should calculate all item<->item pairs (3)" do
     res = @matrix.send(:all_pairs, ["foo", "bar", "fnord"])

data/spec/similarity_matrix_spec.rb

@@ -88,8 +88,6 @@ describe Recommendify::SimilarityMatrix do
       @matrix["item_fnord"].should == {"item_blubb" => 0.6, "item_foo" => 0.4}
     end
 
-    it "should not call split on nil when retrieving a non-existent item (return an empty array)"
-
   end
 
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: recommendify
 version: !ruby/object:Gem::Version
-  version: 0.3.2
+  version: 0.3.3
   prerelease: 
 platform: ruby
 authors:
@@ -13,7 +13,7 @@ date: 2012-03-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: redis
-  requirement: &11718500 !ruby/object:Gem::Requirement
+  requirement: &83607540 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: 2.2.2
   type: :runtime
   prerelease: false
-  version_requirements: *11718500
+  version_requirements: *83607540
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &11717900 !ruby/object:Gem::Requirement
+  requirement: &83607300 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -32,7 +32,7 @@ dependencies:
         version: 2.8.0
   type: :development
   prerelease: false
-  version_requirements: *11717900
+  version_requirements: *83607300
 description: Recommendify is a distributed, incremental item-based recommendation
   engine for binary input ratings. It's based on ruby and redis and uses an approach
   called "Collaborative Filtering"
@@ -100,7 +100,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.17
+rubygems_version: 1.8.6
 signing_key: 
 specification_version: 3
 summary: ruby/redis based recommendation engine (collaborative filtering)
@@ -115,3 +115,4 @@ test_files:
 - spec/similarity_matrix_spec.rb
 - spec/sparse_matrix_spec.rb
 - spec/spec_helper.rb
+has_rdoc: