recheck 0.7.0 → 0.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 50764d09b7fd317140ed5a0145f1420404044fc5a6c169b87871206fcdf80dec
-  data.tar.gz: 05b29309e6f67ae7feabe036fc4f0362e9515c12b4abb7e4cd09b83a0d2d39bd
+  metadata.gz: 486a238104811d7c0c89f9139bce5a9d484f4394e3c23645e1329635a2d462c2
+  data.tar.gz: af3d9af6493d3b684c1047635ad2481f638ad89166d01f1f11fd99c3e57e615b
 SHA512:
-  metadata.gz: d38baf414985cfd55e79d2159c55bd99b982031c11a04222d5d1178288dbd065013bfd422e5694a004585c430d6420452419c27e58c5b6d96653dafc842155c6
-  data.tar.gz: f47fd053650743480c2cbdec6c12982464d0bdb3875ffd3fc445cdb009c3c2dbfb1c274d2bae75d43dead5d65913d2946da98caa3b8e53df09e2d36eaabb27d5
+  metadata.gz: '059a3fd50bc81f4788297e9c767094ea6fda175c4328ca6922778929c41612da1cec31e419a751e8705daf1b6a8409dd16185156947d5321a0f6976f109d113c'
+  data.tar.gz: c0237b5b87bcee83242f5c8a753eb89a61936519b9a2eedb1e39b071a832726b2c5a50e4bd036a1f126d892d399aecccd3e7c158f9c66793b913aca996774957

data/changelog.md

@@ -1,4 +1,8 @@
-## ## [Unreleased]
+## [Unreleased]
+
+## 0.8.0 - 2025-09-05
+
+* Fixed generated check for ActiveRecord length validation
 
 ## 0.7.0 - 2025-09-05
 

data/lib/recheck/rails/setup.rb

@@ -94,25 +94,26 @@ module Recheck
               FunctionPlaceholder.new inspect:, name:, comment: "Coming soon to Recheck beta"
             when ActiveRecord::Validations::LengthValidator
               or_clauses = []
-              if type == :stirng || type == :integer
+              if type == :string || type == :text || type == :integer
                 if validator.options[:is]
                   or_clauses << %{"LENGTH(`#{column.name}`) = '')"}
                 end
                 if validator.options[:minimum] && validator.options[:maximum]
-                  or_clauses << %{"LENGTH(`#{column.name}`) >= #{validator.options[:minimum]} and "LENGTH(`#{column.name}`) <= #{validator.options[:maximum]}}
+                  or_clauses << %{"LENGTH(`#{column.name}`) <= #{validator.options[:minimum]} and LENGTH(`#{column.name}`) >= #{validator.options[:maximum]}"}
                 elsif validator.options[:minimum]
-                  or_clauses << %{"LENGTH(`#{column.name}`) >= #{validator.options[:minimum]}}
+                  or_clauses << %{"LENGTH(`#{column.name}`) <= #{validator.options[:minimum]}"}
                 elsif validator.options[:maximum]
-                  or_clauses << %{"LENGTH(`#{column.name}`) <= #{validator.options[:maximum]}}
+                  or_clauses << %{"LENGTH(`#{column.name}`) >= #{validator.options[:maximum]}"}
                 end
               elsif type == :boolean
-                comment = "Validating length of a boolean is backend-dependednt and a strange idea."
+                comment = "Validating length of a boolean is backend-dependent and a strange idea."
               else
-                comment = "Recheck doesn't know how to handle presence on a #{type}, please report."
+                comment = "Recheck doesn't know how to handle length on a #{type}, please report."
               end
               if !validator.options[:allow_nil] && !validator.options[:allow_blank]
                 or_clauses << "#{column.name}: nil"
               end
+              Query.new inspect:, name:, warning:, comment:, or_clauses:
             when ActiveRecord::Validations::NumericalityValidator
               FunctionPlaceholder.new inspect:, name:, comment: "Coming soon to Recheck beta"
             when ActiveRecord::Validations::PresenceValidator

data/lib/recheck/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Recheck
-  VERSION = '0.7.0'
+  VERSION = '0.8.0'
 end

data/template/validation_checker.rb.erb

@@ -8,7 +8,7 @@ class <%= class_name %>ValidationChecker < Recheck::Checker::Base
     <%
     case query
     when Placeholder %>
-      # <%= query.comment %>
+      # <%= query.comment -%>
       <%
     when FunctionPlaceholder
       %>
@@ -20,7 +20,7 @@ class <%= class_name %>ValidationChecker < Recheck::Checker::Base
       %><%= query.warning ? "# #{query.warning}" : "" %>
       def <%= query.name %>
         <%= query.comment ? "# #{query.comment}" : "" %>
-        <%= class_name %>.where(<%= query.or_clauses.first %>)<%= (query.or_clauses[1..].map {".or(#{class_name}.where(#{it}))"}).join("") %>.find_each
+        <%= class_name %>.where(<%= query.or_clauses.first %>)<%= (query.or_clauses.drop(1).map {".or(#{class_name}.where(#{it}))"}).join("") %>.find_each
       end
       <%
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: recheck
 version: !ruby/object:Gem::Version
-  version: 0.7.0
+  version: 0.8.0
 platform: ruby
 authors:
 - Peter Bhat Harkins