rebase_attr 1.0.0 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6c5ca1579c9b6c0d4b53dbf284b9a907e78e0672
-  data.tar.gz: 59a8675533ba8782afac72c77b4abc5f3e864793
+  metadata.gz: 1c989126e78f373d7608f11824429b65974311bc
+  data.tar.gz: 2859dd7b67c93645a72d0ad8f38ee128b9d72d29
 SHA512:
-  metadata.gz: 11f4460a87351f5440b6a99ad40b5f5365acaa957192c4478b715b44f870cdc1be575192a89ea56561f97a9948697aa61eb8463ad0b2d677e49ba9201b761b59
-  data.tar.gz: 83d57eb45a652d7ea51d7621d83d15ec962db0e1762db238fcfa4fcba38f99a9ebb58ac0e5aa05f9ace9bb80bf2bb0336f5cefe4270d956bfb47268ddf83e545
+  metadata.gz: e812eced8377afca51ce32ee032411782b1aba3395df1b7480603011a2c6a3e988406d0d12eb6d3fad162afdab3c0353ab7c67e5256e1add033e540b8991afc3
+  data.tar.gz: bc4df6f016698c5a4ec2c89c48eda5f243beb5c709a29f10d65331b80f344076c5e4bd7b523adf335bc44b40b39cb8a40a6d8834524a2adba2a4a537cbf383b4

data/.gitignore

@@ -1,12 +1,20 @@
-/.bundle/
-/.yardoc
-/Gemfile.lock
-/_yardoc/
-/coverage/
-/doc/
-/pkg/
-/spec/reports/
-/tmp/
+*.gem
+*.rbc
+.bundle
+.config
+.yardoc
+Gemfile.lock
+InstalledFiles
+_yardoc
+coverage
+doc/
+lib/bundler/man
+pkg
+rdoc
+spec/reports
+test/tmp
+test/version_tmp
+tmp
 *.bundle
 *.so
 *.o

data/README.md

@@ -1,4 +1,4 @@
-# rebase_attr [![Gem Version](https://badge.fury.io/rb/attr_rebase.svg)](http://badge.fury.io/rb/attr_rebase)
+# rebase_attr [![Gem Version](https://badge.fury.io/rb/rebase_attr.svg)](http://badge.fury.io/rb/rebase_attr)
 
 Convert an attribute to a specified base.
 
@@ -59,13 +59,13 @@ Other functions you get when using rebase_attr:
 bill.id_without_rebase = 3151957185711
 bill.id
 => "2rnfkjw5f"
-Bill.find(Bill.decode("2rnfkjw5f"))
+Bill.find(Bill.decode_id("2rnfkjw5f"))
 => #<Bill id: 3151957185711>
-bill.decode("2rnfkjw5f")
+bill.decode_id("2rnfkjw5f")
 => 3151957185711
-Bill.encode(3151957185711)
+Bill.encode_id(3151957185711)
 => "2rnfkjw5f"
-bill.encode(3151957185711)
+bill.encode_id(3151957185711)
 => "2rnfkjw5f"
 ```
 

data/lib/rebase_attr/version.rb

@@ -1,3 +1,3 @@
 module RebaseAttr
-  VERSION = "1.0.0"
+  VERSION = "1.1.0"
 end

data/lib/rebase_attr.rb

@@ -12,6 +12,8 @@ module RebaseAttr
       attributes.each do |attr|
         # encoders & decoders
         define_singleton_method :"encode_#{attr}" do |decoded|
+          break nil if decoded.nil?
+
           result = decoded
           raise TypeError, "decoded value must implement #to_i, #{result.inspect} given" unless result.respond_to?(:to_i)
           result = result.to_i(from || 10) if result.is_a?(String)
@@ -25,6 +27,8 @@ module RebaseAttr
         end
 
         define_singleton_method :"decode_#{attr}" do |encoded|
+          break nil if encoded.nil?
+
           result = encoded
           if deconvert
             begin

data/spec/rebase_attr_spec.rb

@@ -17,31 +17,62 @@ describe RebaseAttr::Generator do
     describe "#encode" do
       specify { expect(klass.encode_x(decoded)).to eq(encoded) }
       specify { expect(instance.encode_x(decoded)).to eq(encoded) }
+      specify { expect(instance.encode_x(nil)).to be_nil }
     end
 
     describe "#decode" do
       specify { expect(klass.decode_x(encoded)).to eq(decoded) }
+      specify { expect(klass.decode_x(nil)).to be_nil }
       specify { expect(instance.decode_x(encoded)).to eq(decoded) }
+      specify { expect(instance.decode_x(nil)).to be_nil }
     end
 
     describe "reader" do
-      before { d = decoded; instance.instance_eval { @x = d } } # converting decoded to local variable so I can use it inside instance_eval
-      its(:x) { should == encoded }
+      context "when not nil" do
+        before { d = decoded; instance.instance_eval { @x = d } } # converting decoded to local variable so I can use it inside instance_eval
+        its(:x) { should == encoded }
+      end
+
+      context "when nil" do
+        before { instance.instance_eval { @x = nil } } # converting decoded to local variable so I can use it inside instance_eval
+        its(:x) { should be_nil }
+      end
     end
 
     describe "#without_rebase" do
-      before { d = decoded; instance.instance_eval { @x = d } } # converting decoded to local variable so I can use it inside instance_eval
-      its(:x_without_rebase) { should == decoded }
+      context "when not nil" do
+        before { d = decoded; instance.instance_eval { @x = d } } # converting decoded to local variable so I can use it inside instance_eval
+        its(:x_without_rebase) { should == decoded }
+      end
+
+      context "when nil" do
+        before { instance.instance_eval { @x = nil } } # converting decoded to local variable so I can use it inside instance_eval
+        its(:x_without_rebase) { should be_nil }
+      end
     end
 
     describe "writer" do
-      before { instance.x = encoded }
-      specify { expect(instance.instance_eval { @x }).to eq(decoded) }
+      context "when not nil" do
+        before { instance.x = encoded }
+        specify { expect(instance.instance_eval { @x }).to eq(decoded) }
+      end
+
+      context "when nil" do
+        before { instance.x = nil }
+        specify { expect(instance.instance_eval { @x }).to be_nil }
+      end
     end
 
     describe "#without_rebase=" do
-      before { instance.x_without_rebase = decoded }
-      specify { expect(instance.instance_eval { @x }).to eq(decoded) }
+      context "when not nil" do
+        before { instance.x_without_rebase = decoded }
+        specify { expect(instance.instance_eval { @x }).to eq(decoded) }
+      end
+
+      context "when nil" do
+        before { instance.x_without_rebase = nil }
+        specify { expect(instance.instance_eval { @x }).to be_nil }
+      end
     end
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rebase_attr
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.0
 platform: ruby
 authors:
 - Oded Niv
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-09-17 00:00:00.000000000 Z
+date: 2014-09-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler