rearview 1.0.3.rc.2-jruby → 1.0.3.rc.3-jruby

data/spec/lib/rearview/stats_service_spec.rb

@@ -6,6 +6,20 @@ describe Rearview::StatsService do
     Celluloid.boot
     @service = Rearview::StatsService.new
   end
+  context '#statsd' do
+    it "will yield to the block if stats are enabled" do
+      Rearview.config.stubs(:stats_enabled?).returns(true)
+      block_yielded = false
+      @service.statsd { |stats| block_yielded = true }
+      expect(block_yielded).to be_true
+    end
+    it "will not yield to the block if stats are disabled" do
+      Rearview.config.stubs(:stats_enabled?).returns(false)
+      block_yielded = false
+      @service.statsd { |stats| block_yielded = true }
+      expect(block_yielded).to be_false
+    end
+  end
   context '#startup' do
     it "can only be started if stopped" do
       Rearview::StatsTask.stubs(:supervise).returns(mock)

data/spec/lib/rearview/stats_task_spec.rb

@@ -12,7 +12,7 @@ describe Rearview::StatsTask do
     it "sets the batch size correctly" do
       Rearview::StatsTask.any_instance.stubs(:schedule)
       statsd = mock
-      statsd.expects(:batch_size=).with(11)
+      statsd.expects(:batch_size=).with(12)
       Rearview::Statsd.stubs(:new).returns(statsd)
       stats_task = Rearview::StatsTask.new
     end

data/spec/lib/rearview/statsd_spec.rb

@@ -1,11 +1,11 @@
 require 'spec_helper'
 
 describe Rearview::Statsd do
+  before(:all) do
+    Rearview.config.statsd_connection = { host: 'myhost', port: 123, namespace: 'mynamespace' }
+  end
+  let(:statsd) { Rearview::Statsd.new }
   context '.initialize' do
-    before(:all) do
-      Rearview.config.statsd_connection = { host: 'myhost', port: 123, namespace: 'mynamespace' }
-    end
-    let(:statsd) { Rearview::Statsd.new }
     it "sets the port from Rearview::Configuration" do
       expect(statsd.port).to eq(123)
     end
@@ -16,5 +16,24 @@ describe Rearview::Statsd do
       expect(statsd.namespace).to eq('mynamespace')
     end
   end
-
+  context '.statsd' do
+    it "returns a shared instance" do
+      expect(Rearview::Statsd.statsd).to eq(Rearview::Statsd.statsd)
+      expect(Rearview::Statsd.statsd).not_to be_nil
+    end
+  end
+  context '.report' do
+    it "will yield to the block if stats are enabled" do
+      Rearview.config.stubs(:stats_enabled?).returns(true)
+      block_yielded = false
+      Rearview::Statsd.report { |stats| block_yielded = true }
+      expect(block_yielded).to be_true
+    end
+    it "will not yield to the block if stats are disabled" do
+      Rearview.config.stubs(:stats_enabled?).returns(false)
+      block_yielded = false
+      Rearview::Statsd.report { |stats| block_yielded = true }
+      expect(block_yielded).to be_false
+    end
+  end
 end

data/spec/models/job_spec.rb

@@ -56,7 +56,7 @@ describe Rearview::Job do
       end
     end
   end
-  describe 'reset' do
+  describe '#reset' do
     it "should reset the job" do
       job = create(:job,:status=>Rearview::Job::Status::SUCCESS)
       job_data = create(:job_data,:job=>job)
@@ -82,7 +82,7 @@ describe Rearview::Job do
       expect(job.job_errors.size).to eq(0)
     end
   end
-  describe 'destroy' do
+  describe '#destroy' do
     it "should unschedule the job" do
       job = create(:job)
       monitor_service = mock
@@ -91,7 +91,7 @@ describe Rearview::Job do
       job.destroy
     end
   end
-  describe 'schedulable' do
+  describe '.schedulable' do
     it "should only return jobs eligible for scheduling" do
       j1 = create(:job,:active=>false)
       j2 = create(:job,:active=>true)
@@ -100,7 +100,7 @@ describe Rearview::Job do
       expect(schedulable.first).to eq(j2)
     end
   end
-  describe 'schedule' do
+  describe '#schedule' do
     let(:monitor_service) { mock }
     let(:job) { create(:job) }
     it "should invoke the monitoring service to schedule the job" do
@@ -109,7 +109,7 @@ describe Rearview::Job do
       job.schedule
     end
   end
-  describe 'unschedule' do
+  describe '#unschedule' do
     let(:monitor_service) { mock }
     let(:job) { create(:job) }
     it "should invoke the monitoring service to unschedule the job" do
@@ -118,7 +118,7 @@ describe Rearview::Job do
       job.unschedule
     end
   end
-  describe 'sync_monitor_service' do
+  describe '#sync_monitor_service' do
     let(:monitor_service) { mock }
     it "should schedule an active job" do
       Rearview.stubs(:monitor_service).returns(monitor_service)
@@ -133,6 +133,16 @@ describe Rearview::Job do
       inactive_job.sync_monitor_service
     end
   end
+  describe '#report_transition' do
+    context 'success event' do
+      it "should increment monitor.success" do
+      end
+    end
+    context 'failure event' do
+      it "should increment monitor.failure" do
+      end
+    end
+  end
   context 'event' do
     def mock_creation_event(job,event)
       event_data = {:job_error=>{:message=>"foo"},:monitor_results=>{:x=>:y}}

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rearview
 version: !ruby/object:Gem::Version
-  version: 1.0.3.rc.2
+  version: 1.0.3.rc.3
 platform: jruby
 authors:
 - Trent Albright
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2014-01-10 00:00:00.000000000 Z
+date: 2014-01-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails