rearview 1.0.2.rc.4-jruby → 1.0.3.rc.1-jruby

data/spec/lib/rearview/configuration_spec.rb

@@ -59,6 +59,14 @@ describe Rearview::Configuration do
       config.valid?
       expect(config.errors[:graphite_url]).to be_empty
     end
+    it "should require statsd_connection to be present if stats are enabled" do
+      config.enable_stats = false
+      config.valid?
+      expect(config.errors[:statsd_connection]).to be_empty
+      config.enable_stats = true
+      config.valid?
+      expect(config.errors[:statsd_connection]).to include("can't be blank")
+    end
     pending "should require sanbox_exec to be executable"
   end
 
@@ -70,8 +78,10 @@ describe Rearview::Configuration do
       expect(config.enable_alerts).to be_true
       expect(config.preload_jobs).to be_true
       expect(config.enable_monitor).to be_true
+      expect(config.enable_stats).to be_false
       expect(config.verify).to be_false
       expect(config.authentication).to eq({strategy: :database})
+      expect(config.default_url_options).to eq({:host=>"localhost", :port=>"3000"})
     end
   end
 

data/spec/lib/rearview/stats_service_spec.rb

@@ -0,0 +1,43 @@
+require 'spec_helper'
+
+describe Rearview::StatsService do
+  before do
+    Celluloid.shutdown
+    Celluloid.boot
+    @service = Rearview::StatsService.new
+  end
+  context '#startup' do
+    it "can only be started if stopped" do
+      Rearview::StatsTask.stubs(:supervise).returns(mock)
+      @service.startup
+      expect { @service.startup }.to raise_error(Rearview::StatsService::StatsServiceError,"service already started")
+    end
+    it "should create the supervised task" do
+      Rearview::StatsTask.expects(:supervise)
+      @service.startup
+    end
+  end
+  context '#shutdown' do
+    it "can only be shutdown if started" do
+      expect { @service.shutdown }.to raise_error(Rearview::StatsService::StatsServiceError,"service not started")
+    end
+    it "should terminate the supervised task" do
+      mock_task = mock
+      mock_task.expects(:terminate).once
+      Rearview::StatsTask.stubs(:supervise).returns(stub(:actors => stub(:first => mock_task)))
+      @service.startup
+      @service.shutdown
+    end
+  end
+  context '#started?' do
+    it "should be true if the service is started" do
+      Rearview::StatsTask.stubs(:supervise).returns(mock)
+      @service.startup
+      expect(@service.started?).to be_true
+    end
+    it "should be false if the service is not started" do
+      expect(@service.started?).to be_false
+    end
+  end
+end
+

data/spec/lib/rearview/stats_task_spec.rb

@@ -0,0 +1,45 @@
+require 'spec_helper'
+
+describe Rearview::StatsTask do
+
+  context '.initialize' do
+    it "sets the default delay to 120s" do
+      Rearview::StatsTask.any_instance.stubs(:schedule)
+      stats_task = Rearview::StatsTask.new
+      Rearview::Statsd.stubs(:new).returns(mock)
+      expect(stats_task.delay).to eq(120)
+    end
+    it "sets the batch size correctly" do
+      Rearview::StatsTask.any_instance.stubs(:schedule)
+      statsd = mock
+      statsd.expects(:batch_size=).with(11)
+      Rearview::Statsd.stubs(:new).returns(statsd)
+      stats_task = Rearview::StatsTask.new
+    end
+    it "schedules itself by default" do
+      statsd = mock
+      statsd.expects(:batch_size=).with(anything)
+      Rearview::Statsd.stubs(:new).returns(statsd)
+      Rearview::StatsTask.any_instance.expects(:schedule)
+      stats_task = Rearview::StatsTask.new
+    end
+  end
+
+  context '#schedule' do
+    it "sets the timer delay" do
+      stats_task = Rearview::StatsTask.new(120,false)
+      stats_task.expects(:after).with(120)
+      stats_task.schedule
+    end
+  end
+
+  context '#run' do
+    it "sends a batch request to statsd" do
+      stats_task = Rearview::StatsTask.new(120,false)
+      stats_task.statsd.expects(:batch)
+      stats_task.run
+    end
+  end
+
+end
+

data/spec/lib/rearview/statsd_spec.rb

@@ -0,0 +1,20 @@
+require 'spec_helper'
+
+describe Rearview::Statsd do
+  context '.initialize' do
+    before(:all) do
+      Rearview.config.statsd_connection = { host: 'myhost', port: 123, namespace: 'mynamespace' }
+    end
+    let(:statsd) { Rearview::Statsd.new }
+    it "sets the port from Rearview::Configuration" do
+      expect(statsd.port).to eq(123)
+    end
+    it "sets the host from Rearview::Configuration" do
+      expect(statsd.host).to eq('myhost')
+    end
+    it "sets the namespace from Rearview::Configuration" do
+      expect(statsd.namespace).to eq('mynamespace')
+    end
+  end
+
+end

data/spec/lib/rearview/templates/utilities_spec.rb

@@ -66,14 +66,13 @@ describe "utility method" do
       monitor_expr = <<-'eos'
         puts @a
       eos
-      result = collect_aberrations(all_created, 1)
-      expect(result[0]).to eq("All Purchases Created in the last hour experienced a standard deviation shift of 1.03, which is greater than the threshold of 1.")
+      result = collect_aberrations(all_created, 0)
+      expect(result).to eq({"All Purchases Created in the last hour"=>0.3505384991636653})
     end
   
     it "returns correct errors for multiple metrics" do
-      result = collect_aberrations(all_created, local_created, 1)
-      expect(result[0]).to eq("All Purchases Created in the last hour experienced a standard deviation shift of 1.03, which is greater than the threshold of 1.")
-      expect(result[1]).to be_empty
+      result = collect_aberrations(all_created, local_created, 0.36)
+      expect(result).to eq({"Local Purchases Created in the last hour"=>0.40808960944909956})
     end
   end
 end

data/spec/lib/rearview/vm_spec.rb

@@ -0,0 +1,79 @@
+require 'spec_helper'
+
+describe Rearview::Vm do
+
+  let(:vm) { Rearview::Vm.new }
+
+  context '#heap' do
+    it "should be present" do
+      expect(vm.heap.present?).to be_true
+    end
+  end
+
+  context '#non_heap' do
+    it "should be present" do
+      expect(vm.non_heap.present?).to be_true
+    end
+  end
+
+  context '#total_memory' do
+    it "should be non-zero" do
+      expect(vm.total_memory>0).to be_true
+    end
+  end
+
+  context '#free_memory' do
+    it "should be non-zero" do
+      expect(vm.free_memory>0).to be_true
+    end
+  end
+
+  context '#max_memory' do
+    it "should be non-zero" do
+      expect(vm.max_memory>0).to be_true
+    end
+  end
+
+  describe Rearview::Vm::Memory do
+    let(:heap) { Rearview::Vm::Heap.new }
+    let(:non_heap) { Rearview::Vm::Heap.new }
+
+    context '#committed' do
+      it "heap should be non-zero" do
+        expect(heap.committed>0).to be_true
+      end
+      it "non_heap should be non-zero" do
+        expect(non_heap.committed>0).to be_true
+      end
+    end
+
+    context '#init' do
+      it "heap should be non-zero" do
+        expect(heap.init>0).to be_true
+      end
+      it "non_heap should be non-zero" do
+        expect(non_heap.init>0).to be_true
+      end
+    end
+
+    context '#max' do
+      it "heap should be non-zero" do
+        expect(heap.max>0).to be_true
+      end
+      it "non_heap should be non-zero" do
+        expect(non_heap.max>0).to be_true
+      end
+    end
+
+    context '#used' do
+      it "heap should be non-zero" do
+        expect(heap.used>0).to be_true
+      end
+      it "non_heap should be non-zero" do
+        expect(non_heap.used>0).to be_true
+      end
+    end
+
+  end
+
+end

data/spec/spec_helper.rb

@@ -18,7 +18,8 @@ Rearview.configure do |config|
   config.sandbox_timeout = 10
   config.preload_jobs = false
   config.enable_monitor = false
-  config.default_url_options = {:host=>'localhost', :port=>'3000'}
+  config.default_url_options = { host: 'localhost', port: '3000' }
+  config.statsd_connection = { host: '127.0.0.1', port: 8125, namespace: 'rearview' }
 end
 
 Rearview.boot!

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rearview
 version: !ruby/object:Gem::Version
-  version: 1.0.2.rc.4
+  version: 1.0.3.rc.1
 platform: jruby
 authors:
 - Trent Albright
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2014-01-06 00:00:00.000000000 Z
+date: 2014-01-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -136,6 +136,20 @@ dependencies:
         version: 1.5.2
   prerelease: false
   type: :runtime
+- !ruby/object:Gem::Dependency
+  name: statsd-ruby
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 1.2.1
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 1.2.1
+  prerelease: false
+  type: :runtime
 - !ruby/object:Gem::Dependency
   name: activerecord-jdbcmysql-adapter
   version_requirements: !ruby/object:Gem::Requirement
@@ -321,14 +335,19 @@ files:
 - lib/rearview/monitor_supervisor.rb
 - lib/rearview/monitor_task.rb
 - lib/rearview/results_handler.rb
+- lib/rearview/stats_service.rb
+- lib/rearview/stats_task.rb
+- lib/rearview/statsd.rb
 - lib/rearview/url_helper.rb
 - lib/rearview/version.rb
+- lib/rearview/vm.rb
 - lib/rearview/alerts/base.rb
 - lib/rearview/alerts/campfire_alert.rb
 - lib/rearview/alerts/email_alert.rb
 - lib/rearview/alerts/pagerduty_alert.rb
 - lib/rearview/concerns/models.rb
 - lib/rearview/concerns/models/user.rb
+- lib/rearview/ext/numeric.rb
 - lib/rearview/ext/state_machine.rb
 - lib/rearview/templates/monitor.rb
 - lib/rearview/templates/utilities.rb
@@ -2212,7 +2231,11 @@ files:
 - spec/lib/rearview/monitor_task_spec.rb
 - spec/lib/rearview/rearview_spec.rb
 - spec/lib/rearview/results_handler_spec.rb
+- spec/lib/rearview/stats_service_spec.rb
+- spec/lib/rearview/stats_task_spec.rb
+- spec/lib/rearview/statsd_spec.rb
 - spec/lib/rearview/url_helper_spec.rb
+- spec/lib/rearview/vm_spec.rb
 - spec/lib/rearview/alerts/campfire_alert_spec.rb
 - spec/lib/rearview/alerts/email_alert_spec.rb
 - spec/lib/rearview/alerts/pagerduty_alert_spec.rb
@@ -2330,7 +2353,11 @@ test_files:
 - spec/lib/rearview/monitor_task_spec.rb
 - spec/lib/rearview/rearview_spec.rb
 - spec/lib/rearview/results_handler_spec.rb
+- spec/lib/rearview/stats_service_spec.rb
+- spec/lib/rearview/stats_task_spec.rb
+- spec/lib/rearview/statsd_spec.rb
 - spec/lib/rearview/url_helper_spec.rb
+- spec/lib/rearview/vm_spec.rb
 - spec/lib/rearview/alerts/campfire_alert_spec.rb
 - spec/lib/rearview/alerts/email_alert_spec.rb
 - spec/lib/rearview/alerts/pagerduty_alert_spec.rb