rearview 1.0.1-jruby → 1.0.2-jruby

data/spec/lib/rearview/alerts/campfire_alert_spec.rb

@@ -19,7 +19,7 @@ describe Rearview::Alerts::CampfireAlert do
         let(:result) { { message: "alert alert!"} }
 
         it "notifies campfire" do
-          Broach.expects(:speak).with("nyan", "alert alert! #{Rearview::UriHelper.rearview_uri(job)}")
+          Broach.expects(:speak).with("nyan", "alert alert! #{Rearview::UrlHelper.job_url(job)}")
           campfire_alert.alert(job, result)
         end
       end
@@ -28,7 +28,7 @@ describe Rearview::Alerts::CampfireAlert do
         let(:result) { { } }
 
         it "notifies campfire" do
-          Broach.expects(:speak).with("nyan", "Job did not provide an error description #{Rearview::UriHelper.rearview_uri(job)}")
+          Broach.expects(:speak).with("nyan", "Job did not provide an error description #{Rearview::UrlHelper.job_url(job)}")
           campfire_alert.alert(job, result)
         end
       end

data/spec/lib/rearview/configuration_spec.rb

@@ -2,22 +2,81 @@ require 'spec_helper'
 
 describe Rearview::Configuration do
 
-  context 'initialize' do
-    it 'sets defaults' do
-      config = Rearview::Configuration.new
-      expect(config.default_from.present?).to be_true
-      expect(config.graphite_url.present?).to be_true
-      expect(config.pagerduty_url.present?).to be_true
-      expect(config.sandbox_timeout.present?).to be_true
-      expect(config.enable_alerts.present?).to be_true
-      expect(config.preload_jobs.present?).to be_true
-      expect(config.enable_monitor.present?).to be_true
+  before do
+    Rearview::Configuration.any_instance.stubs(:validate_sandbox_execution).returns(true)
+  end
+
+  let(:config) { Rearview::Configuration.new }
+
+  context 'validation' do
+    it { should validate_presence_of(:graphite_url) }
+    it { should validate_presence_of(:pagerduty_url) }
+    it { should validate_presence_of(:default_from) }
+    it { should validate_presence_of(:sandbox_dir) }
+    it { should validate_presence_of(:sandbox_exec) }
+    it { should validate_presence_of(:sandbox_timeout) }
+    it { should validate_presence_of(:default_url_options) }
+    it { should validate_presence_of(:authentication) }
+    it { should validate_numericality_of(:sandbox_timeout).is_greater_than(4) }
+    it "should requre sandbox_dir to be a directory" do
+      config.sandbox_dir="/__not_likely__"
+      config.valid?
+      expect(config.errors[:sandbox_dir]).to include("is not a directory")
+      config.sandbox_dir = File.dirname(__FILE__)
+      config.valid?
+      expect(config.errors[:sandbox_dir]).to be_empty
+    end
+    it "should require graphite_url to be a url" do
+      response = stub(code: 200)
+      HTTParty.stubs(:get).returns(response)
+      config.graphite_url="ssh://fooblah"
+      config.valid?
+      expect(config.errors[:graphite_url]).to include("is not a valid URL")
+      config.graphite_url="fooblah"
+      config.valid?
+      expect(config.errors[:graphite_url]).to include("is not a valid URL")
+      config.graphite_url="http://fooblah.com"
+      config.valid?
+      expect(config.errors[:graphite_url]).to be_empty
+    end
+    it "should require pagerduty_url to be a url" do
+      config.pagerduty_url="ftp://fooblah"
+      config.valid?
+      expect(config.errors[:pagerduty_url]).to include("is not a valid URL")
+      config.pagerduty_url="HTTPS://fooblah"
+      config.valid?
+      expect(config.errors[:pagerduty_url]).to be_empty
+    end
+    it "should require graphite_url to be reachable" do
+      response = stub(code: 400)
+      HTTParty.expects(:get).with("http://graphite.mycompany-unreachable.com").returns(response)
+      config.graphite_url="http://graphite.mycompany-unreachable.com"
+      config.valid?
+      expect(config.errors[:graphite_url]).to include("is not a reachable URL")
+      response = stub(code: 200)
+      HTTParty.expects(:get).with("http://graphite.mycompany.com").returns(response)
+      config.graphite_url="http://graphite.mycompany.com"
+      config.valid?
+      expect(config.errors[:graphite_url]).to be_empty
     end
+    pending "should require sanbox_exec to be executable"
   end
 
-  context 'with_argv' do
+  context '.new' do
+    it 'sets sensible defaults' do
+      expect(config.default_from).to eq("rearview@localhost")
+      expect(config.pagerduty_url).to eq("https://events.pagerduty.com/generic/2010-04-15/create_event.json")
+      expect(config.sandbox_timeout).to eq(5)
+      expect(config.enable_alerts).to be_true
+      expect(config.preload_jobs).to be_true
+      expect(config.enable_monitor).to be_true
+      expect(config.verify).to be_false
+      expect(config.authentication).to eq({strategy: :database})
+    end
+  end
+
+  context '#with_argv' do
     it 'processes args as command line options' do
-      config = Rearview::Configuration.new
       expect { config.with_argv(["--no-preload","--no-alerts","--no-monitor"]) }.not_to raise_error
       expect(config.preload_jobs?).to be_false
       expect(config.monitor_enabled?).to be_false
@@ -25,5 +84,11 @@ describe Rearview::Configuration do
     end
   end
 
+  context '#dump' do
+    it 'dumps a stringy version of the configuration' do
+      expect(config.dump).not_to be_empty
+    end
+  end
+
 end
 

data/spec/lib/rearview/url_helper_spec.rb

@@ -0,0 +1,12 @@
+require 'spec_helper'
+
+describe Rearview::UrlHelper do
+  let(:job) { stub(app_id: 1234, id: 42) }
+  subject { Rearview::UrlHelper }
+  context ".rearview_uri" do
+    it "returns rearview uri" do
+      subject.job_url(job).should eq("http://#{Rearview.config.default_url_options[:host]}:#{Rearview.config.default_url_options[:port]}/rearview/#dash/1234/expand/42")
+    end
+  end
+end
+

data/spec/mailers/alert_mailer_spec.rb

@@ -29,7 +29,7 @@ describe Rearview::AlertMailer do
       expect(mail.body.encoded).to match(/Alerted On: .*/)
     end
     it 'has a direct link' do
-      expect(mail.body.encoded).to match(%r{Direct Link: https://rearview.livingsocial.net/#dash/#{job.app_id}/expand/#{job.id}})
+      expect(mail.body.encoded).to match(%r{Direct Link: http://localhost:3000/rearview/#dash/#{job.app_id}/expand/#{job.id}})
     end
   end
 

data/spec/models/user_spec.rb

@@ -8,11 +8,22 @@ describe Rearview::User do
     end
   end
   describe 'validations' do
-    # let!(:first_user) { FactoryGirl.build(:user) }
-    # pending { should validate_presence_of(:email) }
-    # pending { should validate_uniqueness_of(:email) }
-    # pending { should_not allow_value("this is not an email address").for(:email) }
-    # pending("requires a hungrymachine.com email address") { should_not allow_value("user@example.com").for(:email) }
-    # pending { should allow_value("example@hungrymachine.com").for(:email) }
+    let!(:first_user) { FactoryGirl.build(:user) }
+    it { should validate_presence_of(:email) }
+    it { should validate_uniqueness_of(:email) }
+  end
+  describe '.valid_google_oauth2_email?' do
+    it "should not be valid unless an email is present" do
+      expect(Rearview::User.valid_google_oauth2_email?(nil)).to be_false
+    end
+    it "should not be valid unless :matching_emails is present" do
+      Rearview.config.authentication.delete(:matching_emails)
+      expect(Rearview::User.valid_google_oauth2_email?("foo@foo.com")).to be_false
+    end
+    it "should not be valid unless it matches the :matching_emails regexp" do
+      Rearview.config.authentication[:matching_emails] = /@mycompany\.com$/
+      expect(Rearview::User.valid_google_oauth2_email?("foo@foo.com")).to be_false
+      expect(Rearview::User.valid_google_oauth2_email?("foo@mycompany.com")).to be_true
+    end
   end
 end

data/spec/spec_helper.rb

@@ -18,6 +18,7 @@ Rearview.configure do |config|
   config.sandbox_timeout = 10
   config.preload_jobs = false
   config.enable_monitor = false
+  config.default_url_options = {:host=>'localhost', :port=>'3000'}
 end
 
 Rearview.boot!

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rearview
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
 platform: jruby
 authors:
 - Trent Albright
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2013-12-27 00:00:00.000000000 Z
+date: 2014-01-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -271,6 +271,8 @@ files:
 - app/models/rearview/job_data.rb
 - app/models/rearview/job_error.rb
 - app/models/rearview/user.rb
+- app/views/devise/sessions/_database_auth.html.erb
+- app/views/devise/sessions/_google_oauth2_auth.html.erb
 - app/views/devise/sessions/new.html.erb
 - app/views/devise/shared/_links.erb
 - app/views/layouts/devise/sessions.html.erb
@@ -297,6 +299,7 @@ files:
 - config/initializers/unlimited_strength_cryptography.rb
 - config/locales/devise.en.yml
 - db/migrate/20131106162900_base_schema.rb
+- db/migrate/20140106161202_add_indexes.rb
 - lib/rearview.rb
 - lib/generators/rearview/install_generator.rb
 - lib/generators/templates/README.md
@@ -318,8 +321,7 @@ files:
 - lib/rearview/monitor_supervisor.rb
 - lib/rearview/monitor_task.rb
 - lib/rearview/results_handler.rb
-- lib/rearview/sandbox.rb
-- lib/rearview/uri_helper.rb
+- lib/rearview/url_helper.rb
 - lib/rearview/version.rb
 - lib/rearview/alerts/base.rb
 - lib/rearview/alerts/campfire_alert.rb
@@ -2210,7 +2212,7 @@ files:
 - spec/lib/rearview/monitor_task_spec.rb
 - spec/lib/rearview/rearview_spec.rb
 - spec/lib/rearview/results_handler_spec.rb
-- spec/lib/rearview/uri_helper_spec.rb
+- spec/lib/rearview/url_helper_spec.rb
 - spec/lib/rearview/alerts/campfire_alert_spec.rb
 - spec/lib/rearview/alerts/email_alert_spec.rb
 - spec/lib/rearview/alerts/pagerduty_alert_spec.rb
@@ -2328,7 +2330,7 @@ test_files:
 - spec/lib/rearview/monitor_task_spec.rb
 - spec/lib/rearview/rearview_spec.rb
 - spec/lib/rearview/results_handler_spec.rb
-- spec/lib/rearview/uri_helper_spec.rb
+- spec/lib/rearview/url_helper_spec.rb
 - spec/lib/rearview/alerts/campfire_alert_spec.rb
 - spec/lib/rearview/alerts/email_alert_spec.rb
 - spec/lib/rearview/alerts/pagerduty_alert_spec.rb

data/lib/rearview/sandbox.rb

@@ -1,47 +0,0 @@
-
-module Rearview
-  module Sandbox
-    class << self
-
-      include Rearview::Logger
-
-      def valid?
-        valid_exec = self.valid_exec?
-        valid_graphite_connection = self.valid_graphite_connection?
-        valid_exec && valid_graphite_connection
-      end
-
-      def valid_exec?
-        script_file = File.join(Rearview.config.sandbox_dir,"verify_sandbox.rb")
-        cmd = Rearview.config.sandbox_exec.clone << script_file
-        logger.info "#{self} checking sandbox with #{cmd}"
-        process_builder = ProcessBuilder.new(cmd).redirectErrorStream(true)
-        process_builder.directory(java.io.File.new(Rearview.config.sandbox_dir.to_s))
-        process_builder.environment.delete("GEM_HOME")
-        process_builder.environment.delete("GEM_PATH")
-        process = process_builder.start
-        exit_code = process.waitFor
-        output = process.get_input_stream.to_io.read
-        logger.info "#{self} sandbox execution: \n#{output}"
-        unless exit_code == 0
-          logger.error "#{self} unable to execute in sandbox"
-        end
-        exit_code == 0
-      end
-
-      def valid_graphite_connection?
-        url = "#{Rearview.config.graphite_url}/dashboard"
-        logger.info "#{self} checking graphite connection to #{url}"
-        response = HTTParty.get(url)
-        unless response.code == 200
-          logger.error "#{self} unable to communicate with graphite"
-        end
-        response.code == 200
-      rescue
-        logger.error "#{self} unable to communicate with graphite #{$!}"
-        false
-      end
-
-    end
-  end
-end

data/lib/rearview/uri_helper.rb

@@ -1,7 +0,0 @@
-module Rearview
-  class UriHelper
-    def self.rearview_uri(job)
-      "https://rearview.livingsocial.net/#dash/#{job.app_id}/expand/#{job.id}"
-    end
-  end
-end

data/spec/lib/rearview/uri_helper_spec.rb

@@ -1,12 +0,0 @@
-require 'spec_helper'
-
-describe Rearview::UriHelper do
-  let(:job) { stub(app_id: 1234, id: 42) }
-  subject { Rearview::UriHelper }
-
-  context ".rearview_uri" do
-    it "returns rearview uri" do
-      subject.rearview_uri(job).should eq("https://rearview.livingsocial.net/#dash/1234/expand/42")
-    end
-  end
-end