reapack-index 1.0beta3 → 1.0beta4

data/test/test_metadata.rb

@@ -132,7 +132,7 @@ class TestMetadata < MiniTest::Test
       md.push_link :website, 'hello'
     end
 
-    assert_equal 'invalid link: hello', error.message
+    assert_equal "invalid link 'hello'", error.message
     assert_equal after.chomp, before.to_s
   end
 
@@ -172,7 +172,7 @@ class TestMetadata < MiniTest::Test
       md.remove_link :website, 'hello'
     end
 
-    assert_equal 'no such website link: hello', error.message
+    assert_equal "no such website link 'hello'", error.message
   end
 
   def test_replace_link_url

data/test/test_named_node.rb

@@ -3,87 +3,96 @@ require File.expand_path '../helper', __FILE__
 class TestNamedNode < MiniTest::Test
   include XMLHelper
 
+  def setup
+    @mock = Class.new(ReaPack::Index::NamedNode) { @tag = 'node' }
+  end
+
   def test_no_tag_set
-    mock = Class.new ReaPack::Index::NamedNode
+    @ock = Class.new ReaPack::Index::NamedNode
     assert_raises { mock.tag }
   end
 
-  def test_find_in
-    node = make_node '<root><node name="hello"/><node name="world"/></root>'
-    mock = Class.new(ReaPack::Index::NamedNode) { @tag = 'node' }
+  def test_create_node
+    before = make_node '<parent />'
 
-    instance = mock.find_in node, 'hello'
-    assert_nil mock.find_in node, 'bacon'
+    after = <<-XML
+<parent>
+  <node name="name here"/>
+</parent>
+    XML
 
-    assert_kind_of mock, instance
-    assert_equal 'hello', instance.name
+    instance = @mock.create 'name here', before
+    assert instance.is_new?, 'instance is not new'
+    assert instance.modified?, 'instance is not modified'
+
+    assert_equal after.chomp, before.to_s
+  end
+
+  def test_from_existing_node
+    before = make_node '<node name="1.0"/>'
+
+    instance = @mock.new before
     refute instance.is_new?, 'instance is new'
     refute instance.modified?, 'instance is modified'
   end
 
+  def test_find_one
+    node = make_node '<root><node name="hello"/><node name="world"/></root>'
+
+    instance = @mock.find_one 'hello', node
+    assert_kind_of @mock, instance
+    assert_equal 'hello', instance.name
+
+    assert_nil @mock.find_one 'bacon', node
+  end
+
   def test_find_all
     node = make_node '<root><node name="hello"/><node name="world"/></root>'
-    mock = Class.new(ReaPack::Index::NamedNode) { @tag = 'node' }
 
-    instances = mock.find_all node
+    instances = @mock.find_all node
     assert_equal 2, instances.size
 
-    assert_kind_of mock, instances.first
+    assert_kind_of @mock, instances.first
     assert_equal 'hello', instances.first.name
-    refute instances.first.is_new?, 'instance is new'
 
+    assert_kind_of @mock, instances.last
     assert_equal 'world', instances.last.name
   end
 
-  def test_get_readonly
+  def test_fetch_existing
     node = make_node '<root><node name="hello"/></root>'
-    mock = Class.new(ReaPack::Index::NamedNode) { @tag = 'node' }
 
-    instance = mock.get 'hello', node, false
-    assert_kind_of mock, instance
+    instance = @mock.fetch 'hello', node, false
+    assert_kind_of @mock, instance
 
-    assert_nil mock.get 'world', node, false
+    assert_nil @mock.fetch 'world', node, false
   end
 
-  def test_get_create
+  def test_fetch_create
     node = make_node '<root></root>'
-    mock = Class.new(ReaPack::Index::NamedNode) { @tag = 'node' }
 
-    instance = mock.get 'hello', node, true
+    instance = @mock.fetch 'hello', node, true
 
-    assert_kind_of mock, instance
+    assert_kind_of @mock, instance
     assert instance.is_new?, 'instance is not new'
     assert instance.modified?, 'instance is not modified'
   end
 
   def test_get_null_parent
-    mock = Class.new(ReaPack::Index::NamedNode) { @tag = 'node' }
-
-    assert_nil mock.get 'hello', nil, false
+    assert_nil @mock.fetch 'hello', nil, false
   end
 
   def test_empty
-    node = make_node <<-XML
-    <root>
-      <node name="first"/>
-      <node name="second"><something/></node>
-    </root>
-    XML
-
-    mock = Class.new(ReaPack::Index::NamedNode) { @tag = 'node' }
-
-    first = mock.find_in node, 'first'
+    first = @mock.new make_node('<node/>')
     assert first.empty?, 'first is not empty'
 
-    second = mock.find_in node, 'second'
+    second = @mock.new make_node('<node><something/></node>')
     refute second.empty?, 'second is empty'
   end
 
   def test_remove
     node = make_node '<root><node name="test"/></root>'
-    mock = Class.new(ReaPack::Index::NamedNode) { @tag = 'node' }
-
-    instance = mock.find_in node, 'test'
+    instance = @mock.find_one 'test', node
 
     assert_equal 1, node.children.size
     instance.remove
@@ -91,10 +100,9 @@ class TestNamedNode < MiniTest::Test
   end
 
   def test_children
-    node = make_node '<root><node name="test"><a/><b/></root>'
-    mock = Class.new(ReaPack::Index::NamedNode) { @tag = 'node' }
+    node = make_node '<node name="test"><a/><b><a/></b></node>'
 
-    instance = mock.find_in node, 'test'
-    assert_equal node.css('a').inspect, instance.children('a').inspect
+    instance = @mock.new node
+    assert_equal node.css('> a').inspect, instance.children('a').inspect
   end
 end

data/test/test_package.rb

@@ -3,39 +3,16 @@ require File.expand_path '../helper', __FILE__
 class TestPackage < MiniTest::Test
   include XMLHelper
 
-  def test_create
-    before = make_node '<category />'
-    after = <<-XML
-<category>
-  <reapack name="1.0"/>
-</category>
-    XML
-
-    pkg = ReaPack::Index::Package.new '1.0', before
-    assert pkg.is_new?, 'package is not new'
-    assert pkg.modified?, 'package is not modified'
-
-    assert_equal after.chomp, before.to_s
-  end
-
-  def test_use
-    before = make_node '<reapack name="1.0"/>'
-
-    pkg = ReaPack::Index::Package.new before
-    refute pkg.is_new?, 'package is new'
-    refute pkg.modified?, 'package is modified'
-  end
-
   def test_change_type
     before = make_node '<reapack name="1.0"/>'
     after = '<reapack name="1.0" type="script"/>'
 
     pkg = ReaPack::Index::Package.new before
-    assert_empty pkg.type
+    assert_nil pkg.type
 
     pkg.type = 'script'
     assert pkg.modified?, 'package is not modified'
-    assert_equal 'script', pkg.type
+    assert_equal :script, pkg.type
 
     assert_equal after, before.to_s
   end
@@ -45,7 +22,7 @@ class TestPackage < MiniTest::Test
 
     pkg = ReaPack::Index::Package.new before
 
-    assert_equal 'script', pkg.type
+    assert_equal :script, pkg.type
     pkg.type = pkg.type
 
     refute pkg.modified?, 'package is modified'
@@ -92,4 +69,16 @@ class TestPackage < MiniTest::Test
 
     assert pkg.has_version?('1.1'), 'version 1.1 not found'
   end
+
+  def test_category_and_path
+    pkg1 = ReaPack::Index::Package.new make_node('<reapack/>')
+    assert_nil pkg1.category
+    assert_nil pkg1.path
+
+    pkg2 = ReaPack::Index::Package.create 'test',
+      make_node('<category name="Hello/World"/>')
+
+    assert_equal 'Hello/World', pkg2.category
+    assert_equal 'Hello/World/test', pkg2.path
+  end
 end

data/test/test_provides.rb

@@ -0,0 +1,68 @@
+require File.expand_path '../helper', __FILE__
+
+class TestProvides < MiniTest::Test
+  def test_parse_all
+    enum = ReaPack::Index::Provides.parse_each "file1\nfile2"
+    assert_equal 2, enum.to_a.size
+  end
+
+  def test_filename
+    names = [
+      'file.txt',
+      'hello world.lua',
+      '[file]',
+    ]
+
+    assert_equal names,
+      names.map {|l| ReaPack::Index::Provides.parse(l).file_pattern }
+  end
+
+  def test_url_template
+    bucket = [
+      'file http://hello/world',
+      'file   https://chunky/bacon',
+      'file file:///foo',
+      'file scp://bar',
+    ].map {|l| ReaPack::Index::Provides.parse l }
+
+    assert_equal ['http://hello/world', 'https://chunky/bacon', 'file:///foo', nil],
+      bucket.map {|line| line.url_template }
+
+    assert_equal ['file', 'file', 'file', 'file scp://bar'],
+      bucket.map {|line| line.file_pattern }
+  end
+
+  def test_platforms
+    assert_equal [:windows, :win32, :win64, :darwin, :darwin32, :darwin64],
+      [
+        '[windows] file',
+        '[win32] file',
+        '[win64] file',
+        '[Darwin]file',
+        ' [ darwin32 ] file',
+        '[win32, darwin64] file',
+      ].map {|l| ReaPack::Index::Provides.parse(l).platform }
+
+    error = assert_raises ReaPack::Index::Error do
+      ReaPack::Index::Provides.parse '[HeLlO] file'
+    end
+
+    assert_equal "unknown option (platform or type) 'HeLlO'", error.message
+  end
+
+  def test_types
+    assert_equal [:script, :data, nil, nil],
+      vals = [
+        '[script] file',
+        '[windows,Data] file',
+        '[windows] file',
+        '[,windows,,] file',
+      ].map {|l| ReaPack::Index::Provides.parse(l).type }
+
+    error = assert_raises ReaPack::Index::Error do
+      ReaPack::Index::Provides.parse '[, Test] file'
+    end
+
+    assert_equal "unknown option (platform or type) 'Test'", error.message
+  end
+end

data/test/test_source.rb

@@ -0,0 +1,115 @@
+require File.expand_path '../helper', __FILE__
+
+class TestSource < MiniTest::Test
+  include XMLHelper
+
+  def test_escape_url
+    before = make_node '<version name="1.0"/>'
+    after = <<-XML
+<version name="1.0">
+  <source platform="all">http://files.cfillion.tk/hello%20world.lua</source>
+</version>
+    XML
+
+    src = ReaPack::Index::Source.new 'http://files.cfillion.tk/hello world.lua'
+    assert_equal 'http://files.cfillion.tk/hello world.lua', src.url
+
+    src.make_node before
+
+    assert_equal after.chomp, before.to_s
+  end
+
+  def test_invalid_url
+    after = '<version name="1.0"/>'
+    before = make_node after
+
+    src = ReaPack::Index::Source.new 'http://hello world/'
+    assert_equal 'http://hello world/', src.url
+
+    error = assert_raises ReaPack::Index::Error do
+      src.make_node before
+    end
+
+    refute_empty error.message
+    assert_equal after.chomp, before.to_s
+  end
+
+  def test_file
+    before = make_node '<version name="1.0"/>'
+    after = <<-XML
+<version name="1.0">
+  <source platform="all" file="test.png">http://hello/world</source>
+</version>
+    XML
+
+    src = ReaPack::Index::Source.new 'http://hello/world'
+    assert_nil src.file
+
+    src.file = 'test.png'
+    assert_equal 'test.png', src.file
+
+    src.make_node before
+
+    assert_equal after.chomp, before.to_s
+  end
+
+  def test_platform
+    src = ReaPack::Index::Source.new
+    assert_equal :all, src.platform
+
+    src.platform = 'windows'
+    assert_equal :windows, src.platform
+
+    src.platform = nil
+    assert_equal :all, src.platform
+
+    src.platform = :darwin
+    assert_equal :darwin, src.platform
+
+    error = assert_raises ReaPack::Index::Error do
+      src.platform = :hello
+    end
+
+    assert_equal "invalid platform 'hello'", error.message
+    assert_equal :darwin, src.platform
+  end
+
+  def test_type
+    before = make_node '<version name="1.0"/>'
+    after = <<-XML
+<version name="1.0">
+  <source platform="all" type="effect">http://hello/world</source>
+</version>
+    XML
+
+    src = ReaPack::Index::Source.new 'http://hello/world'
+    assert_nil src.type
+
+    src.type = 'script'
+    assert_equal :script, src.type
+
+    src.type = nil
+    assert_nil src.type
+
+    src.type = :effect
+    assert_equal :effect, src.type
+
+    error = assert_raises ReaPack::Index::Error do
+      src.type = 'jsfx'
+    end
+
+    assert_equal "invalid type 'jsfx'", error.message
+    assert_equal :effect, src.type
+
+    src.make_node before
+
+    assert_equal after.chomp, before.to_s
+  end
+
+  def test_is_platform
+    assert_equal [false, true, true, false],
+      [nil, :windows, 'windows', :atari].map {|p|
+        ReaPack::Index::Source.is_platform? p
+      }
+  end
+end

data/test/test_version.rb

@@ -3,29 +3,6 @@ require File.expand_path '../helper', __FILE__
 class TestVersion < MiniTest::Test
   include XMLHelper
 
-  def test_create
-    before = make_node '<reapack />'
-    after = <<-XML
-<reapack>
-  <version name="1.0"/>
-</reapack>
-    XML
-
-    ver = ReaPack::Index::Version.new '1.0', before
-    assert ver.is_new?, 'version is not new'
-    assert ver.modified?, 'version is not modified'
-
-    assert_equal after.chomp, before.to_s
-  end
-
-  def test_use
-    before = make_node '<version name="1.0"/>'
-
-    ver = ReaPack::Index::Version.new before
-    refute ver.is_new?, 'version is new'
-    refute ver.modified?, 'version is modified'
-  end
-
   def test_set_author
     before = make_node '<version name="1.0"/>'
     after = '<version name="1.0" author="cfillion"/>'
@@ -108,12 +85,11 @@ class TestVersion < MiniTest::Test
     before = make_node '<version name="1.0"/>'
     after = <<-XML
 <version name="1.0">
-  <source platform="all" file="test.lua">http://files.cfillion.tk/test.lua</source>
+  <source platform="all">http://files.cfillion.tk/test.lua</source>
 </version>
     XML
 
-    src = ReaPack::Index::Source.new nil, 'test.lua',
-      'http://files.cfillion.tk/test.lua'
+    src = ReaPack::Index::Source.new 'http://files.cfillion.tk/test.lua'
 
     ver = ReaPack::Index::Version.new before
     ver.add_source src
@@ -123,37 +99,24 @@ class TestVersion < MiniTest::Test
     assert_equal after.chomp, before.to_s
   end
 
-  def test_escape_source_url
-    before = make_node '<version name="1.0"/>'
-    after = <<-XML
-<version name="1.0">
-  <source platform="all" file="test.lua">http://files.cfillion.tk/hello%20world.lua</source>
-</version>
-    XML
-
-    ver = ReaPack::Index::Version.new before
-    ver.add_source :all, 'test.lua', 'http://files.cfillion.tk/hello world.lua'
-
-    assert_equal after.chomp, before.to_s
-  end
-
   def test_replace_sources
     before = make_node <<-XML
 <version name="1.0">
-  <source platform="all" file="old.lua">http://files.cfillion.tk/old.lua</source>
+  <source platform="all">http://files.cfillion.tk/old.lua</source>
 </version>
     XML
 
     after = <<-XML
 <version name="1.0">
-  <source platform="all" file="new.lua">http://files.cfillion.tk/new.lua</source>
+  <source platform="all">http://files.cfillion.tk/new.lua</source>
 </version>
 XML
 
     ver = ReaPack::Index::Version.new before
 
     ver.replace_sources do
-      ver.add_source :all, 'new.lua', 'http://files.cfillion.tk/new.lua'
+      src = ReaPack::Index::Source.new 'http://files.cfillion.tk/new.lua'
+      ver.add_source src
     end
 
     assert ver.modified?, 'version is not modified'
@@ -164,14 +127,15 @@ XML
   def test_replace_sources_to_identical
     before = make_node <<-XML
 <version name="1.0">
-  <source platform="all" file="test.lua">http://files.cfillion.tk/test.lua</source>
+  <source platform="all">http://files.cfillion.tk/test.lua</source>
 </version>
     XML
 
     ver = ReaPack::Index::Version.new before
 
     ver.replace_sources do
-      ver.add_source :all, 'test.lua', 'http://files.cfillion.tk/test.lua'
+      src = ReaPack::Index::Source.new 'http://files.cfillion.tk/test.lua'
+      ver.add_source src
     end
 
     refute ver.modified?, 'version is modified'
@@ -186,23 +150,6 @@ XML
     assert ver.modified?, 'version is not modified'
   end
 
-  def test_source_platform
-    src = ReaPack::Index::Source.new
-    assert_equal :all, src.platform
-
-    src.platform = :windows
-    assert_equal :windows, src.platform
-
-    error = assert_raises ReaPack::Index::Error do
-      src.platform = :hello
-    end
-
-    assert_equal 'invalid platform hello', error.message
-
-    src.platform = nil
-    assert_equal :all, src.platform
-  end
-
   def test_version_without_sources
     ver = ReaPack::Index::Version.new make_node('<version name="1.0"/>')
 
@@ -210,6 +157,6 @@ XML
       ver.replace_sources do; end
     end
 
-    assert_equal 'no sources found. @provides tag missing?', error.message
+    assert_equal 'no files provided', error.message
   end
 end