reapack-index 1.0beta2 → 1.0beta3

data/test/test_cli.rb

@@ -21,24 +21,28 @@ module CLIUtils
   end
 
   def wrapper(args = [], options = {})
-    Dir.mktmpdir('test-repository') do |path|
-      @git = Git.init path
-      @git.config('user.name', 'John Doe')
-      @git.config('user.email', 'john@doe.com')
+    path = Dir.mktmpdir 'test-repository'
+    old_pwd = Dir.pwd
 
-      if options[:remote] != false
-        @git.add_remote 'origin', 'git@github.com:cfillion/test-repository.git'
-      end
+    @git = Git.init path
+    @git.config('user.name', 'John Doe')
+    @git.config('user.email', 'john@doe.com')
 
-      options[:setup].call if options.has_key? :setup
+    if options[:remote] != false
+      options[:remote] ||= 'git@github.com:cfillion/test-repository.git'
+      @git.add_remote 'origin', options[:remote]
+    end
 
-      @indexer = ReaPack::Index::CLI.new \
-        ['--no-progress', '--no-commit'] + args + ['--', path]
+    options[:setup].call if options.has_key? :setup
 
-      yield if block_given?
-    end
+    @indexer = ReaPack::Index::CLI.new \
+      ['--no-progress', '--no-commit'] + args + ['--', path]
+
+    yield if block_given?
   ensure
     @git = @indexer = nil
+    Dir.chdir old_pwd
+    FileUtils.rm_r path
   end
 
   def mkfile(file, content = String.new)
@@ -56,11 +60,6 @@ end
 class TestCLI < MiniTest::Test
   include CLIUtils
 
-  def teardown
-    # who is changing the working directory without restoring it?!
-    Dir.chdir File.dirname(__FILE__)
-  end
-
   def test_help
     assert_output /--help/, '' do
       i = ReaPack::Index::CLI.new ['--help']
@@ -75,10 +74,26 @@ class TestCLI < MiniTest::Test
     end
   end
 
+  def test_help_version
+    stdout, _ = capture_io do
+      i = ReaPack::Index::CLI.new ['--help', '--version']
+      assert_equal true, i.run # does nothing
+    end
+
+    refute_match ReaPack::Index::VERSION.to_s, stdout
+  end
+
   def test_invalid_option
-    assert_output '', /reapack-indexer: invalid option: --hello-world/i do
+    assert_output '', /reapack-index: invalid option: --hello-world/i do
       i = ReaPack::Index::CLI.new ['--hello-world']
-      assert_equal false, i.run # does nothing
+      assert_equal false, i.run
+    end
+  end
+
+  def test_ambiguous_option
+    assert_output '', /reapack-index: ambiguous option: --c/i do
+      i = ReaPack::Index::CLI.new ['--c']
+      assert_equal false, i.run
     end
   end
 
@@ -90,25 +105,26 @@ class TestCLI < MiniTest::Test
     end
   end
 
-  def test_initial_commit
+  def test_scan_initial_commit
     wrapper do
       @git.add mkfile('test1.lua', '@version 1.0')
       @git.add mkfile('Category/test2.lua', '@version 1.0')
       @git.add mkfile('Category/Sub/test3.lua', '@version 1.0')
       @git.commit 'initial commit'
 
-      assert_output /3 new packages/, '' do
+      assert_output /3 new packages/ do
         assert_equal true, @indexer.run
       end
 
       assert_match 'Category/test2.lua', read_index
       assert_match "raw/#{@git.log(1).last.sha}/test1.lua", read_index
+      assert_match 'https://github.com/cfillion/test-repository/raw', read_index
 
       assert_match @git.log(1).last.date.utc.iso8601, read_index
     end
   end
 
-  def test_normal_commit
+  def test_scan_normal_commit
     wrapper do
       @git.add mkfile('README.md', '# Hello World')
       @git.commit 'initial commit'
@@ -118,7 +134,7 @@ class TestCLI < MiniTest::Test
       @git.add mkfile('Category/Sub/test3.lua', '@version 1.0')
       @git.commit 'second commit'
 
-      assert_output "3 new categories, 3 new packages, 3 new versions\n", '' do
+      assert_output "3 new categories, 3 new packages, 3 new versions\n" do
         assert_equal true, @indexer.run
       end
 
@@ -135,7 +151,7 @@ class TestCLI < MiniTest::Test
       Dir.mkdir pwd
       Dir.chdir pwd
 
-      assert_output /1 new package/, '' do
+      assert_output /1 new package/ do
         assert_equal true, @indexer.run
       end
 
@@ -191,7 +207,7 @@ class TestCLI < MiniTest::Test
       @git.add mkfile('test.lua', 'no version tag in this script!')
       @git.commit 'initial commit'
 
-      stdout, stderr = capture_io do
+      _, stderr = capture_io do
         assert_equal true, @indexer.run
       end
 
@@ -217,7 +233,7 @@ class TestCLI < MiniTest::Test
 
       mkfile 'index.xml', <<-XML
 <?xml version="1.0" encoding="utf-8"?>
-<index version="1" commit="#{@git.log(1).last.sha}"/>
+<index version="1" name="hello" commit="#{@git.log(1).last.sha}"/>
       XML
     }
 
@@ -241,31 +257,7 @@ class TestCLI < MiniTest::Test
 
       mkfile 'index.xml', <<-XML
 <?xml version="1.0" encoding="utf-8"?>
-<index version="1" commit="hello world"/>
-      XML
-    }
-
-    wrapper [], setup: setup do
-      @git.add mkfile('test2.lua', '@version 1.0')
-      @git.commit 'second commit'
-
-      assert_output nil, '' do
-        assert_equal true, @indexer.run
-      end
-
-      assert_match 'test1.lua', read_index
-      assert_match 'test2.lua', read_index
-    end
-  end
-
-  def test_index_from_invalid
-    setup = proc {
-      @git.add mkfile('test1.lua', '@version 1.0')
-      @git.commit 'initial commit'
-
-      mkfile 'index.xml', <<-XML
-<?xml version="1.0" encoding="utf-8"?>
-<index version="1" commit="hello world"/>
+<index version="1" name="hello" commit="hello world"/>
       XML
     }
 
@@ -354,7 +346,7 @@ class TestCLI < MiniTest::Test
       
       mkfile 'index.xml', <<-XML
 <?xml version="1.0" encoding="utf-8"?>
-<index version="1" commit="#{@git.log(1).last.sha}">
+<index version="1" name="hello" commit="#{@git.log(1).last.sha}">
   <category name="Test">
     <reapack name="test.lua" type="script">
       <version name="1.0"/>
@@ -386,7 +378,7 @@ class TestCLI < MiniTest::Test
       @git.remove script
       @git.commit 'second commit'
 
-      assert_output /1 removed package/i, '' do
+      assert_output /1 removed package/i do
         assert_equal true, @indexer.run
       end
 
@@ -399,7 +391,7 @@ class TestCLI < MiniTest::Test
       @git.add mkfile('test.lua', '@version 1.0')
       @git.commit 'initial commit'
 
-      assert_output nil, '' do
+      capture_io do
         assert_equal true, @indexer.run
       end
 
@@ -445,7 +437,10 @@ class TestCLI < MiniTest::Test
       @git.add mkfile('.gitkeep')
       @git.commit 'initial commit'
 
-      assert_output("empty index\n", "commit created\n") { @indexer.run }
+      mkfile 'ignored1'
+      @git.add mkfile('ignored2')
+
+      assert_output("empty index\n", /commit created\n/) { @indexer.run }
       
       commit = @git.log(1).last
       assert_equal 'index: empty index', commit.message
@@ -453,6 +448,19 @@ class TestCLI < MiniTest::Test
     end
   end
 
+  def test_create_initial_commit
+    wrapper ['--commit'] do
+      mkfile 'ignored1'
+      @git.add mkfile('ignored2')
+
+      assert_output("empty index\n", /commit created\n/) { @indexer.run }
+
+      commit = @git.log(1).last
+      assert_equal 'index: empty index', commit.message
+      assert_equal ['index.xml'], commit.gtree.files.keys
+    end
+  end
+
   def test_create_commit_accept
     wrapper ['--prompt-commit'] do
       @git.add mkfile('.gitkeep')
@@ -460,7 +468,7 @@ class TestCLI < MiniTest::Test
 
       fake_input do |fio|
         fio.getch = 'y'
-        stdin, stderr = capture_io { @indexer.run }
+        _, stderr = capture_io { @indexer.run }
         assert_match /commit created/i, stderr
       end
 
@@ -477,7 +485,7 @@ class TestCLI < MiniTest::Test
 
       fake_input do |fio|
         fio.getch = 'n'
-        stdin, stderr = capture_io { @indexer.run }
+        _, stderr = capture_io { @indexer.run }
         refute_match /commit created/i, stderr
       end
 
@@ -496,7 +504,7 @@ class TestCLI < MiniTest::Test
   end
 
   def test_no_config
-    stdout, stderr = capture_io do
+    stdout, _ = capture_io do
       wrapper ['--no-config'], setup: proc {
         mkfile '.reapack-index.conf', '--help'
       }
@@ -510,7 +518,7 @@ class TestCLI < MiniTest::Test
       mkfile '.reapack-index.conf', "--verbose\n--no-warnings"
     }
 
-    stdout, stderr = capture_io do
+    _, stderr = capture_io do
       wrapper ['--warnings'], setup: setup do
         @git.add mkfile('test.lua', 'no version tag in this script!')
         @git.commit 'initial commit'
@@ -524,8 +532,6 @@ class TestCLI < MiniTest::Test
   end
 
   def test_config_subdirectory
-    pwd = Dir.pwd
-
     wrapper do
       mkfile '.reapack-index.conf', '--help'
       mkfile 'Category/.gitkeep'
@@ -536,8 +542,6 @@ class TestCLI < MiniTest::Test
         ReaPack::Index::CLI.new
       end
     end
-  ensure
-    Dir.chdir pwd
   end
 
   def test_working_directory_with_options
@@ -545,22 +549,23 @@ class TestCLI < MiniTest::Test
       @git.add mkfile('README.md', '# Hello World')
       @git.commit 'initial commit'
 
-      begin
-        pwd = Dir.pwd
-        Dir.chdir @git.dir.to_s
+      Dir.chdir @git.dir.to_s
 
-        assert_output '', '' do
-          i2 = ReaPack::Index::CLI.new ['--no-commit', '--quiet']
-          i2.run
-        end
-      ensure
-        Dir.chdir pwd
+      assert_output '', '' do
+        i2 = ReaPack::Index::CLI.new ['--no-commit', '--quiet']
+        i2.run
       end
     end
   end
 
   def test_no_such_repository
-    assert_output '', /no such file or directory/i do
+    no_such_file = if RUBY_PLATFORM =~ /mingw32/
+      /cannot find the path specified/i
+    else
+      /no such file or directory/i
+    end
+
+    assert_output '', no_such_file do
       i = ReaPack::Index::CLI.new ['/hello/world']
       assert_equal false, i.run
     end
@@ -598,7 +603,7 @@ class TestCLI < MiniTest::Test
     }
 
     wrapper ['--progress'], setup: setup do
-      assert_output '', "Nothing to do!\n" do
+      assert_output '', /Nothing to do!\n/ do
         @indexer.run
       end
     end
@@ -628,7 +633,7 @@ class TestCLI < MiniTest::Test
 
   def test_website_link
     wrapper ['-l http://cfillion.tk'] do
-      assert_output "1 new website link, empty index\n", '' do
+      assert_output "1 new website link, empty index\n" do
         assert_equal true, @indexer.run
       end
 
@@ -636,7 +641,7 @@ class TestCLI < MiniTest::Test
     end
   end
 
-  def test_website_link
+  def test_donation_link
     wrapper ['--donation-link', 'Link Label=http://cfillion.tk'] do
       assert_output "1 new donation link, empty index\n" do
         assert_equal true, @indexer.run
@@ -648,12 +653,15 @@ class TestCLI < MiniTest::Test
   end
 
   def test_invalid_link
-    wrapper ['--link', 'shinsekai yori', '--link', 'http://cfillion.tk'] do
-      assert_output "1 new website link, empty index\n",
-          /warning: invalid url: shinsekai yori/i do
+    wrapper ['--link', 'shinsekai yori', '--donation-link', 'hello world',
+             '--link', 'http://cfillion.tk'] do
+      stdout, stderr = capture_io do
         assert_equal true, @indexer.run
       end
 
+      assert_equal "1 new website link, empty index\n", stdout
+      assert_match /warning: --link: invalid link: shinsekai yori/i, stderr
+      assert_match /warning: --donation-link: invalid link: hello world/i, stderr
       assert_match 'rel="website">http://cfillion.tk</link>', read_index
     end
   end
@@ -697,17 +705,73 @@ class TestCLI < MiniTest::Test
   end
 
   def test_no_git_remote
-    wrapper [], remote: false do
+    wrapper [], remote: '*' do
+      # no crash :)
       assert_output { @indexer.run }
     end
   end
 
+  def test_weird_git_remote_url
+    wrapper [], remote: 'scp://hello.world/$path' do
+      _, stderr = capture_io { @indexer.run }
+      refute_match /invalid url/i, stderr
+      refute_match '$path', stderr
+    end
+  end
+
+  def test_auto_url_template_ssh
+    wrapper [], remote: 'git@github.com:User/Repo.git' do
+      @git.add mkfile('hello.lua', '@version 1.0')
+      @git.commit 'initial commit'
+
+      assert_output { @indexer.run }
+      assert_match "https://github.com/User/Repo/raw/#{@git.log(1).last.sha}/hello.lua", read_index
+    end
+  end
+
+  def test_auto_url_template_https
+    wrapper [], remote: 'https://github.com/User/Repo.git' do
+      @git.add mkfile('hello.lua', '@version 1.0')
+      @git.commit 'initial commit'
+
+      assert_output { @indexer.run }
+      assert_match "https://github.com/User/Repo/raw/#{@git.log(1).last.sha}/hello.lua", read_index
+    end
+  end
+
+  def test_url_template
+    wrapper ['--url-template=http://host/$path'], remote: false do
+      @git.add mkfile('hello.lua', '@version 1.0')
+      @git.commit 'initial commit'
+
+      assert_output { @indexer.run }
+      assert_match 'http://host/hello.lua', read_index
+    end
+  end
+
+  def test_url_template_override_git
+    wrapper ['--url-template=http://host/$path'] do
+      @git.add mkfile('hello.lua', '@version 1.0')
+      @git.commit 'initial commit'
+
+      assert_output { @indexer.run }
+      assert_match 'http://host/hello.lua', read_index
+    end
+  end
+
+  def test_url_template_invalid
+    wrapper ['--url-template=minoshiro'] do
+      @git.add mkfile('hello.lua', '@version 1.0')
+      @git.commit 'initial commit'
+
+      _, stderr = capture_io { @indexer.run }
+      assert_match /--url-template: \$path placeholder is missing/i, stderr
+    end
+  end
+
   def test_about
     opts = ['--about']
-
-    setup = proc {
-      opts << mkfile('README.md', '# Hello World')
-    }
+    setup = proc { opts << mkfile('README.md', '# Hello World') }
 
     wrapper opts, setup: setup do
       assert_output "1 modified metadata, empty index\n" do
@@ -843,4 +907,106 @@ test2.lua contains invalid metadata:
       end
     end
   end
+
+  def test_check_ignore
+    setup = proc { Dir.chdir @git.dir.to_s }
+
+    expected = <<-STDERR
+.
+
+Finished checks for 1 package with 0 failures
+    STDERR
+
+    wrapper ['--check', '--ignore=Hello',
+             '--ignore=Chunky/Bacon.lua', '--ignore=test2.lua'], setup: setup do
+      mkfile 'Hello/World.lua', 'konnichiwa'
+      mkfile 'Chunky/Bacon.lua', 'konnichiwa'
+      mkfile 'Directory/test2.lua', '@version 1.0'
+
+      assert_output nil, expected do
+        @indexer.run
+      end
+    end
+  end
+
+  def test_ignore_config
+    expected = <<-STDERR
+.
+
+Finished checks for 1 package with 0 failures
+    STDERR
+
+    setup = proc {
+      mkfile '.reapack-index.conf', <<-CONFIG
+--ignore=Hello
+--ignore=Chunky/Bacon.lua
+--ignore=test2.lua
+      CONFIG
+    }
+
+    wrapper ['--check'], setup: setup do
+      mkfile 'Hello/World.lua', 'konnichiwa'
+      mkfile 'Chunky/Bacon.lua', 'konnichiwa'
+      mkfile 'Directory/test2.lua', '@version 1.0'
+
+      assert_output nil, expected do
+        @indexer.run
+      end
+    end
+  end
+
+  def test_scan_ignore
+    setup = proc { Dir.chdir @git.dir.to_s }
+
+    wrapper ['--ignore=Hello', '--ignore=Chunky/Bacon.lua',
+             '--ignore=test2.lua'], setup: setup do
+      @git.add mkfile('README.md', '# Hello World')
+      @git.commit 'initial commit'
+
+      @git.add mkfile('Hello/World.lua', 'konnichiwa')
+      @git.add mkfile('Chunky/Bacon.lua', 'konnichiwa')
+      @git.add mkfile('Directory/test2.lua', '@version 1.0')
+      @git.commit 'second commit'
+
+      assert_output "1 new category, 1 new package, 1 new version\n" do
+        assert_equal true, @indexer.run
+      end
+
+      refute_match 'Hello/World.lua', read_index
+      refute_match 'Chunky/Bacon.lua', read_index
+      assert_match 'Directory/test2.lua', read_index
+    end
+  end
+
+  def test_noname
+    wrapper do
+      assert_output nil, /The name of this index is unset/i do
+        assert_equal true, @indexer.run
+      end
+
+      refute_match 'name', read_index
+    end
+  end
+
+  def test_set_name
+    wrapper ['--name=Hello World'] do
+      _, stderr = capture_io do
+        assert_equal true, @indexer.run
+      end
+
+      refute_match /The name of this index is unset/i, stderr
+      assert_match 'name="Hello World"', read_index
+    end
+  end
+
+  def test_set_name_invalid
+    wrapper ['--name=Hello/World'] do
+      _, stderr = capture_io do
+        assert_equal true, @indexer.run
+      end
+
+      refute_match /The name of this index is unset/i, stderr
+      assert_match /invalid name: 'Hello\/World'/i, stderr
+    end
+  end
 end